[INFO] crate newegg 0.1.0 is already in cache [INFO] extracting crate newegg 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/newegg/0.1.0 [INFO] extracting crate newegg 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/newegg/0.1.0 [INFO] validating manifest of newegg-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of newegg-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing newegg-0.1.0 [INFO] finished frobbing newegg-0.1.0 [INFO] frobbed toml for newegg-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/newegg/0.1.0/Cargo.toml [INFO] started frobbing newegg-0.1.0 [INFO] finished frobbing newegg-0.1.0 [INFO] frobbed toml for newegg-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/newegg/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting newegg-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/newegg/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bfa9b4e6e531a4a32f720b98fe8a5d32286035ad25f0802126a7b7697ee67e8c [INFO] running `"docker" "start" "-a" "bfa9b4e6e531a4a32f720b98fe8a5d32286035ad25f0802126a7b7697ee67e8c"` [INFO] [stderr] Compiling parse-zoneinfo v0.1.1 [INFO] [stderr] Compiling chrono-tz v0.4.1 [INFO] [stderr] Checking newegg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/helpers.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | const FORMAT: &'static str = "%m/%d/%Y %H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | Err(err) => return Err(ErrorKind::Deserialize(err.to_string(), body_str.to_string()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::Deserialize(err.to_string(), body_str.to_string()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/helpers.rs:13:16 [INFO] [stderr] | [INFO] [stderr] 13 | const FORMAT: &'static str = "%m/%d/%Y %H:%M:%S"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/client.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | Err(err) => return Err(ErrorKind::Deserialize(err.to_string(), body_str.to_string()).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ErrorKind::Deserialize(err.to_string(), body_str.to_string()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:347:3 [INFO] [stderr] | [INFO] [stderr] 347 | / pub fn new() -> GetOrderInfoRequestBuilder { [INFO] [stderr] 348 | | GetOrderInfoRequestBuilder { [INFO] [stderr] 349 | | inner: GetOrderInfoRequest::default(), [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:347:3 [INFO] [stderr] | [INFO] [stderr] 347 | / pub fn new() -> GetOrderInfoRequestBuilder { [INFO] [stderr] 348 | | GetOrderInfoRequestBuilder { [INFO] [stderr] 349 | | inner: GetOrderInfoRequest::default(), [INFO] [stderr] 350 | | } [INFO] [stderr] 351 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:435:3 [INFO] [stderr] | [INFO] [stderr] 435 | / pub fn new(seller_id: &str, order_number: i64) -> ShipOrderActionBuilder { [INFO] [stderr] 436 | | ShipOrderActionBuilder::new(seller_id, order_number) [INFO] [stderr] 437 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:435:3 [INFO] [stderr] | [INFO] [stderr] 435 | / pub fn new(seller_id: &str, order_number: i64) -> ShipOrderActionBuilder { [INFO] [stderr] 436 | | ShipOrderActionBuilder::new(seller_id, order_number) [INFO] [stderr] 437 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:547:3 [INFO] [stderr] | [INFO] [stderr] 547 | / pub fn new(carrier: ShipCarrier, service: &str, tracking: &str) -> PackageBuilder { [INFO] [stderr] 548 | | PackageBuilder::new(carrier, service, tracking) [INFO] [stderr] 549 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/order/types.rs:547:3 [INFO] [stderr] | [INFO] [stderr] 547 | / pub fn new(carrier: ShipCarrier, service: &str, tracking: &str) -> PackageBuilder { [INFO] [stderr] 548 | | PackageBuilder::new(carrier, service, tracking) [INFO] [stderr] 549 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/service_status.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn from_str(v: &str) -> Option { [INFO] [stderr] 30 | | match v { [INFO] [stderr] 31 | | "contentmgmt" => Some(ServiceStatusDomain::Content), [INFO] [stderr] 32 | | "ordermgmt" => Some(ServiceStatusDomain::Order), [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/service_status.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn from_str(v: &str) -> Option { [INFO] [stderr] 30 | | match v { [INFO] [stderr] 31 | | "contentmgmt" => Some(ServiceStatusDomain::Content), [INFO] [stderr] 32 | | "ordermgmt" => Some(ServiceStatusDomain::Order), [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.51s [INFO] running `"docker" "inspect" "bfa9b4e6e531a4a32f720b98fe8a5d32286035ad25f0802126a7b7697ee67e8c"` [INFO] running `"docker" "rm" "-f" "bfa9b4e6e531a4a32f720b98fe8a5d32286035ad25f0802126a7b7697ee67e8c"` [INFO] [stdout] bfa9b4e6e531a4a32f720b98fe8a5d32286035ad25f0802126a7b7697ee67e8c