[INFO] crate newbee 0.1.7 is already in cache [INFO] extracting crate newbee 0.1.7 into work/ex/clippy-test-run/sources/stable/reg/newbee/0.1.7 [INFO] extracting crate newbee 0.1.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/newbee/0.1.7 [INFO] validating manifest of newbee-0.1.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of newbee-0.1.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing newbee-0.1.7 [INFO] finished frobbing newbee-0.1.7 [INFO] frobbed toml for newbee-0.1.7 written to work/ex/clippy-test-run/sources/stable/reg/newbee/0.1.7/Cargo.toml [INFO] started frobbing newbee-0.1.7 [INFO] finished frobbing newbee-0.1.7 [INFO] frobbed toml for newbee-0.1.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/newbee/0.1.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting newbee-0.1.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/newbee/0.1.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37db53324043235bccbfeaf1b6d7e8d40ab0872954c285203fceb234729ba4ba [INFO] running `"docker" "start" "-a" "37db53324043235bccbfeaf1b6d7e8d40ab0872954c285203fceb234729ba4ba"` [INFO] [stderr] Checking lzf v0.3.1 [INFO] [stderr] Checking newbee v0.1.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | compressed_len: compressed_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressed_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | original_len: original_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | member: member, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `member` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | sp: sp, [INFO] [stderr] | ^^^^^^ help: replace it with: `sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | zlbytes: zlbytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zlbytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | zltails: zltails, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zltails` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | zllen: zllen, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `zllen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | zlend: zlend, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `zlend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:662:13 [INFO] [stderr] | [INFO] [stderr] 662 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:664:13 [INFO] [stderr] | [INFO] [stderr] 664 | ints: ints, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | compressed_len: compressed_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressed_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | original_len: original_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | member: member, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `member` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | score: score, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:507:13 [INFO] [stderr] | [INFO] [stderr] 507 | sp: sp, [INFO] [stderr] | ^^^^^^ help: replace it with: `sp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | zlbytes: zlbytes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zlbytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | zltails: zltails, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `zltails` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | zllen: zllen, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `zllen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | zlend: zlend, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `zlend` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:662:13 [INFO] [stderr] | [INFO] [stderr] 662 | encoding: encoding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `encoding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/codec/mod.rs:664:13 [INFO] [stderr] | [INFO] [stderr] 664 | ints: ints, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/consts.rs:37:57 [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 001; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 1; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 0o1; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/consts.rs:37:57 [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 001; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 1; [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 37 | pub const REDIS_RDB_FLAG_ZIPLIST_ENTRY_NORMAL_STR: u8 = 0o1; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `shift` which has no body [INFO] [stderr] --> src/com.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 12 | | fn shift(&self) -> usize; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/com.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | more!(src.len() < 1); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(src[0] as i32)` [INFO] [stderr] --> src/com.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vi32 |= (src[0] as i32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vi32 |= (src[0] as i32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | vi32 |= (src[1] as i32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | vi32 |= (src[2] as i32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &Length::Small(val) => val as usize, [INFO] [stderr] 38 | | &Length::Normal(val) => val as usize, [INFO] [stderr] 39 | | &Length::Large(val) => val as usize, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Length::Small(val) => val as usize, [INFO] [stderr] 38 | Length::Normal(val) => val as usize, [INFO] [stderr] 39 | Length::Large(val) => val as usize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &Length::Small(_) => 1, [INFO] [stderr] 49 | | &Length::Normal(_) => 2, [INFO] [stderr] 50 | | &Length::Large(_) => 5, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | Length::Small(_) => 1, [INFO] [stderr] 49 | Length::Normal(_) => 2, [INFO] [stderr] 50 | Length::Large(_) => 5, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &RedisString::LengthPrefix { ref len, ref data } => len.shift() + data.len(), [INFO] [stderr] 67 | | &RedisString::StrInt(ref ival) => ival.shift(), [INFO] [stderr] 68 | | &RedisString::LZF(ref lzf) => lzf.shift(), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | RedisString::LengthPrefix { ref len, ref data } => len.shift() + data.len(), [INFO] [stderr] 67 | RedisString::StrInt(ref ival) => ival.shift(), [INFO] [stderr] 68 | RedisString::LZF(ref lzf) => lzf.shift(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self { [INFO] [stderr] 160 | | &StrInt::Small(_) => 1 + 1, [INFO] [stderr] 161 | | &StrInt::Normal(_) => 1 + 2, [INFO] [stderr] 162 | | &StrInt::Large(_) => 1 + 4, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *self { [INFO] [stderr] 160 | StrInt::Small(_) => 1 + 1, [INFO] [stderr] 161 | StrInt::Normal(_) => 1 + 2, [INFO] [stderr] 162 | StrInt::Large(_) => 1 + 4, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/mod.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn value(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / match self { [INFO] [stderr] 192 | | &StrInt::Small(value) => value as i32, [INFO] [stderr] 193 | | &StrInt::Normal(value) => value as i32, [INFO] [stderr] 194 | | &StrInt::Large(value) => value as i32, [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *self { [INFO] [stderr] 192 | StrInt::Small(value) => value as i32, [INFO] [stderr] 193 | StrInt::Normal(value) => value as i32, [INFO] [stderr] 194 | StrInt::Large(value) => value as i32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | &StrInt::Small(value) => value as i32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | &StrInt::Normal(value) => value as i32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec/mod.rs:234:67 [INFO] [stderr] | [INFO] [stderr] 234 | self.length.shift() + self.items.iter().map(|x| x.shift()).fold(0, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | / match self { [INFO] [stderr] 349 | | &ZLELen::Small(_) => 1, [INFO] [stderr] 350 | | &ZLELen::Large(_) => 5, [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 348 | match *self { [INFO] [stderr] 349 | ZLELen::Small(_) => 1, [INFO] [stderr] 350 | ZLELen::Large(_) => 5, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/codec/mod.rs:357:15 [INFO] [stderr] | [INFO] [stderr] 357 | more!(src.len() < 1); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | / match self { [INFO] [stderr] 400 | | &ZLESpData::SmallStr(ref v) => 1 + v.len(), [INFO] [stderr] 401 | | &ZLESpData::NormalStr(ref v) => 2 + v.len(), [INFO] [stderr] 402 | | &ZLESpData::LargeStr(ref v) => 1 + 4 + v.len(), [INFO] [stderr] ... | [INFO] [stderr] 408 | | &ZLESpData::ExLargeInt(_) => 1 + 8, [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 399 | match *self { [INFO] [stderr] 400 | ZLESpData::SmallStr(ref v) => 1 + v.len(), [INFO] [stderr] 401 | ZLESpData::NormalStr(ref v) => 2 + v.len(), [INFO] [stderr] 402 | ZLESpData::LargeStr(ref v) => 1 + 4 + v.len(), [INFO] [stderr] 403 | ZLESpData::ExSmallInt(_) => 1, [INFO] [stderr] 404 | ZLESpData::SmallInt(_) => 1 + 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:414:23 [INFO] [stderr] | [INFO] [stderr] 414 | fn to_special_int(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:430:21 [INFO] [stderr] | [INFO] [stderr] 430 | fn to_usual_int(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:451:15 [INFO] [stderr] | [INFO] [stderr] 451 | fn to_str(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec/mod.rs:481:15 [INFO] [stderr] | [INFO] [stderr] 481 | more!(src.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec/mod.rs:524:47 [INFO] [stderr] | [INFO] [stderr] 524 | self.entries.iter().map(|x| x.shift()).fold(0, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | / match self { [INFO] [stderr] 599 | | &IntSetEncoding::Normal => 2, [INFO] [stderr] 600 | | &IntSetEncoding::Large => 4, [INFO] [stderr] 601 | | &IntSetEncoding::ExLarge => 8, [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 598 | match *self { [INFO] [stderr] 599 | IntSetEncoding::Normal => 2, [INFO] [stderr] 600 | IntSetEncoding::Large => 4, [INFO] [stderr] 601 | IntSetEncoding::ExLarge => 8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:648:17 [INFO] [stderr] | [INFO] [stderr] 648 | (uv as i32) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from((uv as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:651:17 [INFO] [stderr] | [INFO] [stderr] 651 | (uv as i16) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from((uv as i16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &RedisData::String(ref key, _) => key.clone(), [INFO] [stderr] 37 | | &RedisData::List(ref key, _) => key.clone(), [INFO] [stderr] 38 | | &RedisData::Set(ref key, _) => key.clone(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | &RedisData::SetIntSet(ref key, _) => key.clone(), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | RedisData::String(ref key, _) => key.clone(), [INFO] [stderr] 37 | RedisData::List(ref key, _) => key.clone(), [INFO] [stderr] 38 | RedisData::Set(ref key, _) => key.clone(), [INFO] [stderr] 39 | RedisData::ZSet(ref key, _) => key.clone(), [INFO] [stderr] 40 | RedisData::Hash(ref key, _) => key.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | let suffix_len = match self { [INFO] [stderr] | __________________________^ [INFO] [stderr] 207 | | &RedisData::String(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 208 | | &RedisData::List(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 209 | | &RedisData::Set(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] ... | [INFO] [stderr] 215 | | &RedisData::ZSetZipList(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 216 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | let suffix_len = match *self { [INFO] [stderr] 207 | RedisData::String(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 208 | RedisData::List(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 209 | RedisData::Set(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 210 | RedisData::ZSet(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 211 | RedisData::Hash(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / match self { [INFO] [stderr] 234 | | &ExpireTime::Ms(_) => 8 + 1, [INFO] [stderr] 235 | | &ExpireTime::Sec(_) => 4 + 1, [INFO] [stderr] 236 | | _ => 0, [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | match *self { [INFO] [stderr] 234 | ExpireTime::Ms(_) => 8 + 1, [INFO] [stderr] 235 | ExpireTime::Sec(_) => 4 + 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:267:27 [INFO] [stderr] | [INFO] [stderr] 267 | let sec = sec as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(sec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &RedisFmt::CRLF => true, [INFO] [stderr] 14 | | _ => false, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | RedisFmt::CRLF => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / match self { [INFO] [stderr] 208 | | // len('REDIS') + version_number [INFO] [stderr] 209 | | &RdbEntry::Version(_) => 5 + 4, [INFO] [stderr] 210 | | // 0xFE + u8 [INFO] [stderr] 211 | | &RdbEntry::Sector(_) => 2, [INFO] [stderr] 212 | | &RdbEntry::Data { ref expire, ref data } => expire.shift() + data.shift(), [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | match *self { [INFO] [stderr] 208 | // len('REDIS') + version_number [INFO] [stderr] 209 | RdbEntry::Version(_) => 5 + 4, [INFO] [stderr] 210 | // 0xFE + u8 [INFO] [stderr] 211 | RdbEntry::Sector(_) => 2, [INFO] [stderr] 212 | RdbEntry::Data { ref expire, ref data } => expire.shift() + data.shift(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `newbee`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `#[inline]` on trait method `shift` which has no body [INFO] [stderr] --> src/com.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 12 | | fn shift(&self) -> usize; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/com.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | more!(src.len() < 1); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(src[0] as i32)` [INFO] [stderr] --> src/com.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vi32 |= (src[0] as i32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | vi32 |= (src[0] as i32) << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | vi32 |= (src[1] as i32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/com.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | vi32 |= (src[2] as i32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / match self { [INFO] [stderr] 37 | | &Length::Small(val) => val as usize, [INFO] [stderr] 38 | | &Length::Normal(val) => val as usize, [INFO] [stderr] 39 | | &Length::Large(val) => val as usize, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 36 | match *self { [INFO] [stderr] 37 | Length::Small(val) => val as usize, [INFO] [stderr] 38 | Length::Normal(val) => val as usize, [INFO] [stderr] 39 | Length::Large(val) => val as usize, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &Length::Small(_) => 1, [INFO] [stderr] 49 | | &Length::Normal(_) => 2, [INFO] [stderr] 50 | | &Length::Large(_) => 5, [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | Length::Small(_) => 1, [INFO] [stderr] 49 | Length::Normal(_) => 2, [INFO] [stderr] 50 | Length::Large(_) => 5, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &RedisString::LengthPrefix { ref len, ref data } => len.shift() + data.len(), [INFO] [stderr] 67 | | &RedisString::StrInt(ref ival) => ival.shift(), [INFO] [stderr] 68 | | &RedisString::LZF(ref lzf) => lzf.shift(), [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | RedisString::LengthPrefix { ref len, ref data } => len.shift() + data.len(), [INFO] [stderr] 67 | RedisString::StrInt(ref ival) => ival.shift(), [INFO] [stderr] 68 | RedisString::LZF(ref lzf) => lzf.shift(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self { [INFO] [stderr] 160 | | &StrInt::Small(_) => 1 + 1, [INFO] [stderr] 161 | | &StrInt::Normal(_) => 1 + 2, [INFO] [stderr] 162 | | &StrInt::Large(_) => 1 + 4, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *self { [INFO] [stderr] 160 | StrInt::Small(_) => 1 + 1, [INFO] [stderr] 161 | StrInt::Normal(_) => 1 + 2, [INFO] [stderr] 162 | StrInt::Large(_) => 1 + 4, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codec/mod.rs:190:18 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn value(&self) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | / match self { [INFO] [stderr] 192 | | &StrInt::Small(value) => value as i32, [INFO] [stderr] 193 | | &StrInt::Normal(value) => value as i32, [INFO] [stderr] 194 | | &StrInt::Large(value) => value as i32, [INFO] [stderr] 195 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 191 | match *self { [INFO] [stderr] 192 | StrInt::Small(value) => value as i32, [INFO] [stderr] 193 | StrInt::Normal(value) => value as i32, [INFO] [stderr] 194 | StrInt::Large(value) => value as i32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | &StrInt::Small(value) => value as i32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:193:39 [INFO] [stderr] | [INFO] [stderr] 193 | &StrInt::Normal(value) => value as i32, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec/mod.rs:234:67 [INFO] [stderr] | [INFO] [stderr] 234 | self.length.shift() + self.items.iter().map(|x| x.shift()).fold(0, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:348:9 [INFO] [stderr] | [INFO] [stderr] 348 | / match self { [INFO] [stderr] 349 | | &ZLELen::Small(_) => 1, [INFO] [stderr] 350 | | &ZLELen::Large(_) => 5, [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 348 | match *self { [INFO] [stderr] 349 | ZLELen::Small(_) => 1, [INFO] [stderr] 350 | ZLELen::Large(_) => 5, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/codec/mod.rs:357:15 [INFO] [stderr] | [INFO] [stderr] 357 | more!(src.len() < 1); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | / match self { [INFO] [stderr] 400 | | &ZLESpData::SmallStr(ref v) => 1 + v.len(), [INFO] [stderr] 401 | | &ZLESpData::NormalStr(ref v) => 2 + v.len(), [INFO] [stderr] 402 | | &ZLESpData::LargeStr(ref v) => 1 + 4 + v.len(), [INFO] [stderr] ... | [INFO] [stderr] 408 | | &ZLESpData::ExLargeInt(_) => 1 + 8, [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 399 | match *self { [INFO] [stderr] 400 | ZLESpData::SmallStr(ref v) => 1 + v.len(), [INFO] [stderr] 401 | ZLESpData::NormalStr(ref v) => 2 + v.len(), [INFO] [stderr] 402 | ZLESpData::LargeStr(ref v) => 1 + 4 + v.len(), [INFO] [stderr] 403 | ZLESpData::ExSmallInt(_) => 1, [INFO] [stderr] 404 | ZLESpData::SmallInt(_) => 1 + 1, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:414:23 [INFO] [stderr] | [INFO] [stderr] 414 | fn to_special_int(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:430:21 [INFO] [stderr] | [INFO] [stderr] 430 | fn to_usual_int(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codec/mod.rs:451:15 [INFO] [stderr] | [INFO] [stderr] 451 | fn to_str(src: &[u8]) -> Result { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/codec/mod.rs:481:15 [INFO] [stderr] | [INFO] [stderr] 481 | more!(src.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/codec/mod.rs:524:47 [INFO] [stderr] | [INFO] [stderr] 524 | self.entries.iter().map(|x| x.shift()).fold(0, |acc, x| acc + x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/codec/mod.rs:598:9 [INFO] [stderr] | [INFO] [stderr] 598 | / match self { [INFO] [stderr] 599 | | &IntSetEncoding::Normal => 2, [INFO] [stderr] 600 | | &IntSetEncoding::Large => 4, [INFO] [stderr] 601 | | &IntSetEncoding::ExLarge => 8, [INFO] [stderr] 602 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 598 | match *self { [INFO] [stderr] 599 | IntSetEncoding::Normal => 2, [INFO] [stderr] 600 | IntSetEncoding::Large => 4, [INFO] [stderr] 601 | IntSetEncoding::ExLarge => 8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:648:17 [INFO] [stderr] | [INFO] [stderr] 648 | (uv as i32) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from((uv as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/codec/mod.rs:651:17 [INFO] [stderr] | [INFO] [stderr] 651 | (uv as i16) as i64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from((uv as i16))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &RedisData::String(ref key, _) => key.clone(), [INFO] [stderr] 37 | | &RedisData::List(ref key, _) => key.clone(), [INFO] [stderr] 38 | | &RedisData::Set(ref key, _) => key.clone(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | &RedisData::SetIntSet(ref key, _) => key.clone(), [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | RedisData::String(ref key, _) => key.clone(), [INFO] [stderr] 37 | RedisData::List(ref key, _) => key.clone(), [INFO] [stderr] 38 | RedisData::Set(ref key, _) => key.clone(), [INFO] [stderr] 39 | RedisData::ZSet(ref key, _) => key.clone(), [INFO] [stderr] 40 | RedisData::Hash(ref key, _) => key.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | let suffix_len = match self { [INFO] [stderr] | __________________________^ [INFO] [stderr] 207 | | &RedisData::String(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 208 | | &RedisData::List(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 209 | | &RedisData::Set(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] ... | [INFO] [stderr] 215 | | &RedisData::ZSetZipList(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 216 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 206 | let suffix_len = match *self { [INFO] [stderr] 207 | RedisData::String(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 208 | RedisData::List(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 209 | RedisData::Set(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 210 | RedisData::ZSet(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] 211 | RedisData::Hash(ref key, ref v) => key.shift() + v.shift(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types/mod.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | / match self { [INFO] [stderr] 234 | | &ExpireTime::Ms(_) => 8 + 1, [INFO] [stderr] 235 | | &ExpireTime::Sec(_) => 4 + 1, [INFO] [stderr] 236 | | _ => 0, [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 233 | match *self { [INFO] [stderr] 234 | ExpireTime::Ms(_) => 8 + 1, [INFO] [stderr] 235 | ExpireTime::Sec(_) => 4 + 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types/mod.rs:267:27 [INFO] [stderr] | [INFO] [stderr] 267 | let sec = sec as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(sec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/fmt.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | &RedisFmt::CRLF => true, [INFO] [stderr] 14 | | _ => false, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *self { [INFO] [stderr] 13 | RedisFmt::CRLF => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / match self { [INFO] [stderr] 208 | | // len('REDIS') + version_number [INFO] [stderr] 209 | | &RdbEntry::Version(_) => 5 + 4, [INFO] [stderr] 210 | | // 0xFE + u8 [INFO] [stderr] 211 | | &RdbEntry::Sector(_) => 2, [INFO] [stderr] 212 | | &RdbEntry::Data { ref expire, ref data } => expire.shift() + data.shift(), [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | match *self { [INFO] [stderr] 208 | // len('REDIS') + version_number [INFO] [stderr] 209 | RdbEntry::Version(_) => 5 + 4, [INFO] [stderr] 210 | // 0xFE + u8 [INFO] [stderr] 211 | RdbEntry::Sector(_) => 2, [INFO] [stderr] 212 | RdbEntry::Data { ref expire, ref data } => expire.shift() + data.shift(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `newbee`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "37db53324043235bccbfeaf1b6d7e8d40ab0872954c285203fceb234729ba4ba"` [INFO] running `"docker" "rm" "-f" "37db53324043235bccbfeaf1b6d7e8d40ab0872954c285203fceb234729ba4ba"` [INFO] [stdout] 37db53324043235bccbfeaf1b6d7e8d40ab0872954c285203fceb234729ba4ba