[INFO] crate new-ordered-float 1.0.2 is already in cache [INFO] extracting crate new-ordered-float 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/new-ordered-float/1.0.2 [INFO] extracting crate new-ordered-float 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/new-ordered-float/1.0.2 [INFO] validating manifest of new-ordered-float-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of new-ordered-float-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing new-ordered-float-1.0.2 [INFO] finished frobbing new-ordered-float-1.0.2 [INFO] frobbed toml for new-ordered-float-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/new-ordered-float/1.0.2/Cargo.toml [INFO] started frobbing new-ordered-float-1.0.2 [INFO] finished frobbing new-ordered-float-1.0.2 [INFO] frobbed toml for new-ordered-float-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/new-ordered-float/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting new-ordered-float-1.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/new-ordered-float/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5c60a1f64a5601d009dc52a3e0f1259cd43a97ac9ed79bc2cfb99a7a173194c [INFO] running `"docker" "start" "-a" "e5c60a1f64a5601d009dc52a3e0f1259cd43a97ac9ed79bc2cfb99a7a173194c"` [INFO] [stderr] Checking new-ordered-float v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | const SIGN_MASK: u64 = 0x8000000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | const EXP_MASK: u64 = 0x7ff0000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7ff0_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | const MAN_MASK: u64 = 0x000fffffffffffffu64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x000f_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | const CANONICAL_NAN_BITS: u64 = 0x7ff8000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7ff8_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | return "Error parsing a not-NaN floating point value"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Error parsing a not-NaN floating point value"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/lib.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | const SIGN_MASK: u64 = 0x8000000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/lib.rs:33:23 [INFO] [stderr] | [INFO] [stderr] 33 | const EXP_MASK: u64 = 0x7ff0000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7ff0_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/lib.rs:34:23 [INFO] [stderr] | [INFO] [stderr] 34 | const MAN_MASK: u64 = 0x000fffffffffffffu64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x000f_ffff_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/lib.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | const CANONICAL_NAN_BITS: u64 = 0x7ff8000000000000u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7ff8_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/lib.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | return "Error parsing a not-NaN floating point value"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"Error parsing a not-NaN floating point value"` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: you are implementing `Hash` explicitly but have derived `PartialEq` [INFO] [stderr] --> src/lib.rs:207:1 [INFO] [stderr] | [INFO] [stderr] 207 | / impl Hash for NotNan { [INFO] [stderr] 208 | | fn hash(&self, state: &mut H) { [INFO] [stderr] 209 | | hash_float(self.as_ref(), state) [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | #[derive(PartialOrd, PartialEq, Debug, Default, Clone, Copy)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:576:19 [INFO] [stderr] | [INFO] [stderr] 576 | let exp_u64 = unsafe { mem::transmute::(exp) } as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unsafe { mem::transmute::(exp) })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:659:22 [INFO] [stderr] | [INFO] [stderr] 659 | .map_err(|err| ParseNotNanError::ParseFloatError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseNotNanError::ParseFloatError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `new-ordered-float`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `new-ordered-float`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e5c60a1f64a5601d009dc52a3e0f1259cd43a97ac9ed79bc2cfb99a7a173194c"` [INFO] running `"docker" "rm" "-f" "e5c60a1f64a5601d009dc52a3e0f1259cd43a97ac9ed79bc2cfb99a7a173194c"` [INFO] [stdout] e5c60a1f64a5601d009dc52a3e0f1259cd43a97ac9ed79bc2cfb99a7a173194c