[INFO] crate neuroflow 0.1.3 is already in cache [INFO] extracting crate neuroflow 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/neuroflow/0.1.3 [INFO] extracting crate neuroflow 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/neuroflow/0.1.3 [INFO] validating manifest of neuroflow-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neuroflow-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neuroflow-0.1.3 [INFO] finished frobbing neuroflow-0.1.3 [INFO] frobbed toml for neuroflow-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/neuroflow/0.1.3/Cargo.toml [INFO] started frobbing neuroflow-0.1.3 [INFO] finished frobbing neuroflow-0.1.3 [INFO] frobbed toml for neuroflow-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/neuroflow/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neuroflow-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/neuroflow/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ddce67ada2ec59d3030f14a5b025116840bb0f5a75e64dffaa32fa48babd4d6 [INFO] running `"docker" "start" "-a" "2ddce67ada2ec59d3030f14a5b025116840bb0f5a75e64dffaa32fa48babd4d6"` [INFO] [stderr] Checking neuroflow v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return DataSet { [INFO] [stderr] 83 | | x: vec![], [INFO] [stderr] 84 | | y: vec![], [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | DataSet { [INFO] [stderr] 83 | x: vec![], [INFO] [stderr] 84 | y: vec![], [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | return nl; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `nl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return nn; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `nn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:377:30 [INFO] [stderr] | [INFO] [stderr] 377 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 378 | | if k == 0{ [INFO] [stderr] 379 | | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]; [INFO] [stderr] 380 | | } else { [INFO] [stderr] 381 | | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]*self.layers[j - 1].y[k - 1]; [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 377 | else if k == 0{ [INFO] [stderr] 378 | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]; [INFO] [stderr] 379 | } else { [INFO] [stderr] 380 | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]*self.layers[j - 1].y[k - 1]; [INFO] [stderr] 381 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/data/mod.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return DataSet { [INFO] [stderr] 83 | | x: vec![], [INFO] [stderr] 84 | | y: vec![], [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | DataSet { [INFO] [stderr] 83 | x: vec![], [INFO] [stderr] 84 | y: vec![], [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | return nl; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `nl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:310:9 [INFO] [stderr] | [INFO] [stderr] 310 | return nn; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `nn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:377:30 [INFO] [stderr] | [INFO] [stderr] 377 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 378 | | if k == 0{ [INFO] [stderr] 379 | | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]; [INFO] [stderr] 380 | | } else { [INFO] [stderr] 381 | | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]*self.layers[j - 1].y[k - 1]; [INFO] [stderr] 382 | | } [INFO] [stderr] 383 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 377 | else if k == 0{ [INFO] [stderr] 378 | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]; [INFO] [stderr] 379 | } else { [INFO] [stderr] 380 | self.layers[j].w[i][k] += self.learn_rate * self.layers[j].delta[i]*self.layers[j - 1].y[k - 1]; [INFO] [stderr] 381 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nn` [INFO] [stderr] --> src/estimators/mod.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn OBS(nn: &super::FeedForward) { [INFO] [stderr] | ^^ help: consider using `_nn` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `obj` [INFO] [stderr] --> src/io/mod.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn to_json(obj: T) { [INFO] [stderr] | ^^^ help: consider using `_obj` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/io/mod.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn from_json(s: &str){ [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/estimators/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | (s as f64) / allowed_error [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trait `Extractable` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/data/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / pub trait Extractable { [INFO] [stderr] 26 | | /// Get random element from set [INFO] [stderr] 27 | | /// [INFO] [stderr] 28 | | /// * `return` - tuple of two links on vectors. [INFO] [stderr] ... | [INFO] [stderr] 40 | | fn len(&self) -> usize; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::DataSet` [INFO] [stderr] --> src/data/mod.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> DataSet{ [INFO] [stderr] 82 | | return DataSet { [INFO] [stderr] 83 | | x: vec![], [INFO] [stderr] 84 | | y: vec![], [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sum_x` [INFO] [stderr] --> src/data/mod.rs:168:22 [INFO] [stderr] | [INFO] [stderr] 168 | for j in 0..self.x[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for (j, ) in sum_x.iter_mut().enumerate().take(self.x[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sum_y` [INFO] [stderr] --> src/data/mod.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | for j in 0..self.y[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 174 | for (j, ) in sum_y.iter_mut().enumerate().take(self.y[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mean_x`. [INFO] [stderr] --> src/data/mod.rs:204:18 [INFO] [stderr] | [INFO] [stderr] 204 | for i in 0..self.x[0].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 204 | for in mean_x.iter_mut().take(self.x[0].len()){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mean_y`. [INFO] [stderr] --> src/data/mod.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | for i in 0..self.y[0].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 209 | for in mean_y.iter_mut().take(self.y[0].len()){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/io/mod.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn load<'b, T>(file_path: &'b str) -> Result where for<'de> T: serde::Deserialize<'de>{ [INFO] [stderr] 75 | | let file = File::open(file_path).map_err(ErrorKind::IO)?; [INFO] [stderr] 76 | | let mut buf = BufReader::new(file); [INFO] [stderr] 77 | | [INFO] [stderr] ... | [INFO] [stderr] 80 | | Ok(nn) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:251:22 [INFO] [stderr] | [INFO] [stderr] 251 | for _ in 0..input + 1{ [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:313:30 [INFO] [stderr] | [INFO] [stderr] 313 | fn forward(&mut self, x: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `x` [INFO] [stderr] --> src/lib.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | for k in 0..x.len(){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 320 | for (k, ) in x.iter().enumerate(){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | fn backward(&mut self, d: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d` [INFO] [stderr] --> src/lib.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | for i in 0..self.layers[j].y.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 355 | for (i, ) in d.iter().enumerate().take(self.layers[j].y.len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | fn update(&mut self, x: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `x` [INFO] [stderr] --> src/lib.rs:373:26 [INFO] [stderr] | [INFO] [stderr] 373 | for k in 0..self.layers[j].w[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 373 | for (k, ) in x.iter().enumerate().take(self.layers[j].w[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `nn` [INFO] [stderr] --> src/estimators/mod.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn OBS(nn: &super::FeedForward) { [INFO] [stderr] | ^^ help: consider using `_nn` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `obj` [INFO] [stderr] --> src/io/mod.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn to_json(obj: T) { [INFO] [stderr] | ^^^ help: consider using `_obj` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/io/mod.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn from_json(s: &str){ [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:551:31 [INFO] [stderr] | [INFO] [stderr] 551 | let mut buf: String = format!("**Induced field**\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"**Induced field**\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/estimators/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | (s as f64) / allowed_error [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trait `Extractable` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/data/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / pub trait Extractable { [INFO] [stderr] 26 | | /// Get random element from set [INFO] [stderr] 27 | | /// [INFO] [stderr] 28 | | /// * `return` - tuple of two links on vectors. [INFO] [stderr] ... | [INFO] [stderr] 40 | | fn len(&self) -> usize; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `data::DataSet` [INFO] [stderr] --> src/data/mod.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn new() -> DataSet{ [INFO] [stderr] 82 | | return DataSet { [INFO] [stderr] 83 | | x: vec![], [INFO] [stderr] 84 | | y: vec![], [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sum_x` [INFO] [stderr] --> src/data/mod.rs:168:22 [INFO] [stderr] | [INFO] [stderr] 168 | for j in 0..self.x[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 168 | for (j, ) in sum_x.iter_mut().enumerate().take(self.x[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `sum_y` [INFO] [stderr] --> src/data/mod.rs:174:22 [INFO] [stderr] | [INFO] [stderr] 174 | for j in 0..self.y[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 174 | for (j, ) in sum_y.iter_mut().enumerate().take(self.y[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mean_x`. [INFO] [stderr] --> src/data/mod.rs:204:18 [INFO] [stderr] | [INFO] [stderr] 204 | for i in 0..self.x[0].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 204 | for in mean_x.iter_mut().take(self.x[0].len()){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mean_y`. [INFO] [stderr] --> src/data/mod.rs:209:18 [INFO] [stderr] | [INFO] [stderr] 209 | for i in 0..self.y[0].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 209 | for in mean_y.iter_mut().take(self.y[0].len()){ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/io/mod.rs:74:1 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn load<'b, T>(file_path: &'b str) -> Result where for<'de> T: serde::Deserialize<'de>{ [INFO] [stderr] 75 | | let file = File::open(file_path).map_err(ErrorKind::IO)?; [INFO] [stderr] 76 | | let mut buf = BufReader::new(file); [INFO] [stderr] 77 | | [INFO] [stderr] ... | [INFO] [stderr] 80 | | Ok(nn) [INFO] [stderr] 81 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:251:22 [INFO] [stderr] | [INFO] [stderr] 251 | for _ in 0..input + 1{ [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:313:30 [INFO] [stderr] | [INFO] [stderr] 313 | fn forward(&mut self, x: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `x` [INFO] [stderr] --> src/lib.rs:320:30 [INFO] [stderr] | [INFO] [stderr] 320 | for k in 0..x.len(){ [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 320 | for (k, ) in x.iter().enumerate(){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | fn backward(&mut self, d: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `d` [INFO] [stderr] --> src/lib.rs:355:26 [INFO] [stderr] | [INFO] [stderr] 355 | for i in 0..self.layers[j].y.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 355 | for (i, ) in d.iter().enumerate().take(self.layers[j].y.len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:370:29 [INFO] [stderr] | [INFO] [stderr] 370 | fn update(&mut self, x: &Vec){ [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `x` [INFO] [stderr] --> src/lib.rs:373:26 [INFO] [stderr] | [INFO] [stderr] 373 | for k in 0..self.layers[j].w[i].len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 373 | for (k, ) in x.iter().enumerate().take(self.layers[j].w[i].len()){ [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:551:31 [INFO] [stderr] | [INFO] [stderr] 551 | let mut buf: String = format!("**Induced field**\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"**Induced field**\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "2ddce67ada2ec59d3030f14a5b025116840bb0f5a75e64dffaa32fa48babd4d6"` [INFO] running `"docker" "rm" "-f" "2ddce67ada2ec59d3030f14a5b025116840bb0f5a75e64dffaa32fa48babd4d6"` [INFO] [stdout] 2ddce67ada2ec59d3030f14a5b025116840bb0f5a75e64dffaa32fa48babd4d6