[INFO] crate network-communicator 0.1.1 is already in cache [INFO] extracting crate network-communicator 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/network-communicator/0.1.1 [INFO] extracting crate network-communicator 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/network-communicator/0.1.1 [INFO] validating manifest of network-communicator-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of network-communicator-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing network-communicator-0.1.1 [INFO] finished frobbing network-communicator-0.1.1 [INFO] frobbed toml for network-communicator-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/network-communicator/0.1.1/Cargo.toml [INFO] started frobbing network-communicator-0.1.1 [INFO] finished frobbing network-communicator-0.1.1 [INFO] frobbed toml for network-communicator-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/network-communicator/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting network-communicator-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/network-communicator/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d55c813e6bde24124c0711837795710f2ab88e7f4bb853525de0a24927e1ba2b [INFO] running `"docker" "start" "-a" "d55c813e6bde24124c0711837795710f2ab88e7f4bb853525de0a24927e1ba2b"` [INFO] [stderr] Checking tokio-curl v0.1.11 [INFO] [stderr] Checking network-communicator v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | thread_handle: thread_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | is_terminating: is_terminating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_terminating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | remotes: remotes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `remotes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | thread_count: thread_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | error: error [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | remote: remote, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:55:4 [INFO] [stderr] | [INFO] [stderr] 55 | session: session, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `session` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:56:4 [INFO] [stderr] | [INFO] [stderr] 56 | thread_handle: thread_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:57:4 [INFO] [stderr] | [INFO] [stderr] 57 | is_terminating: is_terminating, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_terminating` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/manager.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | remotes: remotes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `remotes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:26:4 [INFO] [stderr] | [INFO] [stderr] 26 | thread_count: thread_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:92:4 [INFO] [stderr] | [INFO] [stderr] 92 | error: error [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return Ok(downloader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(downloader)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | return result.poll().map( [INFO] [stderr] | _________________^ [INFO] [stderr] 27 | | |result|{ [INFO] [stderr] 28 | | return result.map(|item|{ [INFO] [stderr] 29 | | RequestFutureItem::Process(item) [INFO] [stderr] 30 | | }) [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | result.poll().map( [INFO] [stderr] 27 | |result|{ [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] 30 | }) [INFO] [stderr] 31 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Async::Ready(RequestFutureItem::Ready)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(RequestFutureItem::Ready))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 29 | | RequestFutureItem::Process(item) [INFO] [stderr] 30 | | }) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] 30 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return Worker { [INFO] [stderr] | _________^ [INFO] [stderr] 54 | | remote: remote, [INFO] [stderr] 55 | | session: session, [INFO] [stderr] 56 | | thread_handle: thread_handle, [INFO] [stderr] 57 | | is_terminating: is_terminating, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Worker { [INFO] [stderr] 54 | remote: remote, [INFO] [stderr] 55 | session: session, [INFO] [stderr] 56 | thread_handle: thread_handle, [INFO] [stderr] 57 | is_terminating: is_terminating, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | return self.task_rx.send(task); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.task_rx.send(task)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | return self.task_rx.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.task_rx.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return self.result_tx.recv(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.result_tx.recv()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(NetworkManagerHandle { [INFO] [stderr] | _________________^ [INFO] [stderr] 173 | | task_rx: tx, [INFO] [stderr] 174 | | result_tx: result_rx, [INFO] [stderr] 175 | | manager_handle: Some(thread_handle), [INFO] [stderr] 176 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | Ok(NetworkManagerHandle { [INFO] [stderr] 173 | task_rx: tx, [INFO] [stderr] 174 | result_tx: result_rx, [INFO] [stderr] 175 | manager_handle: Some(thread_handle), [INFO] [stderr] 176 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return Err(Error::ThreadStartError { error: thread_error }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::ThreadStartError { error: thread_error })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:164:7 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.map(|_|{()}).map_err(|_|{()})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/manager.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/manager.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | return task; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `task` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | return (data, configurator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(data, configurator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return self.thread_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return self.limit_result_channel_buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.limit_result_channel_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return self.limit_task_channel_buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.limit_task_channel_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request_future.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 25 | | &mut RequestFuture::Process(ref mut result) => { [INFO] [stderr] 26 | | return result.poll().map( [INFO] [stderr] 27 | | |result|{ [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | RequestFuture::Process(ref mut result) => { [INFO] [stderr] 26 | return result.poll().map( [INFO] [stderr] 27 | |result|{ [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:43:6 [INFO] [stderr] | [INFO] [stderr] 43 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request.rs:63:3 [INFO] [stderr] | [INFO] [stderr] 63 | return Ok(downloader); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(downloader)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | return result.poll().map( [INFO] [stderr] | _________________^ [INFO] [stderr] 27 | | |result|{ [INFO] [stderr] 28 | | return result.map(|item|{ [INFO] [stderr] 29 | | RequestFutureItem::Process(item) [INFO] [stderr] 30 | | }) [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 26 | result.poll().map( [INFO] [stderr] 27 | |result|{ [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] 30 | }) [INFO] [stderr] 31 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(Async::Ready(RequestFutureItem::Ready)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(RequestFutureItem::Ready))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/request_future.rs:28:10 [INFO] [stderr] | [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 29 | | RequestFutureItem::Process(item) [INFO] [stderr] 30 | | }) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] 30 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:53:3 [INFO] [stderr] | [INFO] [stderr] 53 | return Worker { [INFO] [stderr] | _________^ [INFO] [stderr] 54 | | remote: remote, [INFO] [stderr] 55 | | session: session, [INFO] [stderr] 56 | | thread_handle: thread_handle, [INFO] [stderr] 57 | | is_terminating: is_terminating, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Worker { [INFO] [stderr] 54 | remote: remote, [INFO] [stderr] 55 | session: session, [INFO] [stderr] 56 | thread_handle: thread_handle, [INFO] [stderr] 57 | is_terminating: is_terminating, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:85:3 [INFO] [stderr] | [INFO] [stderr] 85 | return self.task_rx.send(task); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.task_rx.send(task)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | return self.task_rx.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.task_rx.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return self.result_tx.recv(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.result_tx.recv()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | return Ok(NetworkManagerHandle { [INFO] [stderr] | _________________^ [INFO] [stderr] 173 | | task_rx: tx, [INFO] [stderr] 174 | | result_tx: result_rx, [INFO] [stderr] 175 | | manager_handle: Some(thread_handle), [INFO] [stderr] 176 | | }); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 172 | Ok(NetworkManagerHandle { [INFO] [stderr] 173 | task_rx: tx, [INFO] [stderr] 174 | result_tx: result_rx, [INFO] [stderr] 175 | manager_handle: Some(thread_handle), [INFO] [stderr] 176 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return Err(Error::ThreadStartError { error: thread_error }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::ThreadStartError { error: thread_error })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/manager.rs:164:7 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.map(|_|{()}).map_err(|_|{()})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/manager.rs:164:29 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/manager.rs:164:46 [INFO] [stderr] | [INFO] [stderr] 164 | return result.map(|_|{()}).map_err(|_|{()}); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | return task; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `task` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:28:4 [INFO] [stderr] | [INFO] [stderr] 28 | return (data, configurator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(data, configurator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | return self.thread_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.thread_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | return self.limit_result_channel_buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.limit_result_channel_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | return self.limit_task_channel_buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.limit_task_channel_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/task.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | configurator: Box Result<(),Error> + Send + 'static>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/task.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn disassemble_task(task: Task) -> (T,Box Result<(),Error> + Send + 'static>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | match task { [INFO] [stderr] | _____^ [INFO] [stderr] 41 | | &Task::Terminate => true, [INFO] [stderr] 42 | | _ => false, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *task { [INFO] [stderr] 41 | Task::Terminate => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/config.rs:35:6 [INFO] [stderr] | [INFO] [stderr] 35 | if self.thread_count <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.thread_count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 29 | | &Error::ThreadStartError {ref error} => { [INFO] [stderr] 30 | | write!(f, "Unable to start thread: {:?}", error) [INFO] [stderr] 31 | | }, [INFO] [stderr] ... | [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | Error::ThreadStartError {ref error} => { [INFO] [stderr] 30 | write!(f, "Unable to start thread: {:?}", error) [INFO] [stderr] 31 | }, [INFO] [stderr] 32 | Error::Curl {ref error} => { [INFO] [stderr] 33 | write!(f, "Curl error: {:?}", error) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 55 | | &Error::ThreadStartError {..} => { [INFO] [stderr] 56 | | "Unable to start thread" [INFO] [stderr] 57 | | }, [INFO] [stderr] ... | [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | Error::ThreadStartError {..} => { [INFO] [stderr] 56 | "Unable to start thread" [INFO] [stderr] 57 | }, [INFO] [stderr] 58 | Error::Curl {..} => { [INFO] [stderr] 59 | "Curl error" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 72 | | &Error::ThreadStartError {ref error} => { [INFO] [stderr] 73 | | Some(error) [INFO] [stderr] 74 | | }, [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *self { [INFO] [stderr] 72 | Error::ThreadStartError {ref error} => { [INFO] [stderr] 73 | Some(error) [INFO] [stderr] 74 | }, [INFO] [stderr] 75 | Error::Curl {ref error} => { [INFO] [stderr] 76 | Some(error) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `network-communicator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/request_future.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 25 | | &mut RequestFuture::Process(ref mut result) => { [INFO] [stderr] 26 | | return result.poll().map( [INFO] [stderr] 27 | | |result|{ [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | RequestFuture::Process(ref mut result) => { [INFO] [stderr] 26 | return result.poll().map( [INFO] [stderr] 27 | |result|{ [INFO] [stderr] 28 | return result.map(|item|{ [INFO] [stderr] 29 | RequestFutureItem::Process(item) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/task.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | configurator: Box Result<(),Error> + Send + 'static>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/task.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn disassemble_task(task: Task) -> (T,Box Result<(),Error> + Send + 'static>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | match task { [INFO] [stderr] | _____^ [INFO] [stderr] 41 | | &Task::Terminate => true, [INFO] [stderr] 42 | | _ => false, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *task { [INFO] [stderr] 41 | Task::Terminate => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/config.rs:35:6 [INFO] [stderr] | [INFO] [stderr] 35 | if self.thread_count <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.thread_count == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 29 | | &Error::ThreadStartError {ref error} => { [INFO] [stderr] 30 | | write!(f, "Unable to start thread: {:?}", error) [INFO] [stderr] 31 | | }, [INFO] [stderr] ... | [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | Error::ThreadStartError {ref error} => { [INFO] [stderr] 30 | write!(f, "Unable to start thread: {:?}", error) [INFO] [stderr] 31 | }, [INFO] [stderr] 32 | Error::Curl {ref error} => { [INFO] [stderr] 33 | write!(f, "Curl error: {:?}", error) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 55 | | &Error::ThreadStartError {..} => { [INFO] [stderr] 56 | | "Unable to start thread" [INFO] [stderr] 57 | | }, [INFO] [stderr] ... | [INFO] [stderr] 66 | | }, [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | Error::ThreadStartError {..} => { [INFO] [stderr] 56 | "Unable to start thread" [INFO] [stderr] 57 | }, [INFO] [stderr] 58 | Error::Curl {..} => { [INFO] [stderr] 59 | "Curl error" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 72 | | &Error::ThreadStartError {ref error} => { [INFO] [stderr] 73 | | Some(error) [INFO] [stderr] 74 | | }, [INFO] [stderr] ... | [INFO] [stderr] 83 | | }, [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | match *self { [INFO] [stderr] 72 | Error::ThreadStartError {ref error} => { [INFO] [stderr] 73 | Some(error) [INFO] [stderr] 74 | }, [INFO] [stderr] 75 | Error::Curl {ref error} => { [INFO] [stderr] 76 | Some(error) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `network-communicator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d55c813e6bde24124c0711837795710f2ab88e7f4bb853525de0a24927e1ba2b"` [INFO] running `"docker" "rm" "-f" "d55c813e6bde24124c0711837795710f2ab88e7f4bb853525de0a24927e1ba2b"` [INFO] [stdout] d55c813e6bde24124c0711837795710f2ab88e7f4bb853525de0a24927e1ba2b