[INFO] crate netstring 0.4.1 is already in cache [INFO] extracting crate netstring 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/netstring/0.4.1 [INFO] extracting crate netstring 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netstring/0.4.1 [INFO] validating manifest of netstring-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netstring-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netstring-0.4.1 [INFO] finished frobbing netstring-0.4.1 [INFO] frobbed toml for netstring-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/netstring/0.4.1/Cargo.toml [INFO] started frobbing netstring-0.4.1 [INFO] finished frobbing netstring-0.4.1 [INFO] frobbed toml for netstring-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netstring/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netstring-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netstring/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe629750e2921bcb399d2e92838fe19825de6fbce733fb64c0186a3a3eb43e6f [INFO] running `"docker" "start" "-a" "fe629750e2921bcb399d2e92838fe19825de6fbce733fb64c0186a3a3eb43e6f"` [INFO] [stderr] Checking netstring v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/channel.rs:116:37 [INFO] [stderr] | [INFO] [stderr] 116 | Channel { outgoing: out_tx, stop: stop } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/channel.rs:116:37 [INFO] [stderr] | [INFO] [stderr] 116 | Channel { outgoing: out_tx, stop: stop } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/channel.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | if let Err(_) = incoming.send(x) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 54 | | // This can happen when *incoming* is dropped [INFO] [stderr] 55 | | debug!("Received message but nobody is listening"); [INFO] [stderr] 56 | | reader.shutdown(Shutdown::Both).ok(); [INFO] [stderr] 57 | | break; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________________________- help: try this: `if incoming.send(x).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/channel.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(_) = writer.flush() { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 90 | | c.send(()).ok(); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________________- help: try this: `if writer.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/channel.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | if let Ok(_) = writer.flush() { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 100 | | c.send(()).ok(); [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________________________- help: try this: `if writer.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/channel.rs:123:67 [INFO] [stderr] | [INFO] [stderr] 123 | Channel::map(reader, writer, incoming, outgoing_capacity, |x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | offset = offset + r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | try!(self.read(t[..].as_mut())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:117:31 [INFO] [stderr] | [INFO] [stderr] 117 | let r = try!(r.read(t[current..current + 1].as_mut())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `current..=current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `netstring`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/channel.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | if let Err(_) = incoming.send(x) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 54 | | // This can happen when *incoming* is dropped [INFO] [stderr] 55 | | debug!("Received message but nobody is listening"); [INFO] [stderr] 56 | | reader.shutdown(Shutdown::Both).ok(); [INFO] [stderr] 57 | | break; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________________________________- help: try this: `if incoming.send(x).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/channel.rs:89:36 [INFO] [stderr] | [INFO] [stderr] 89 | if let Ok(_) = writer.flush() { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 90 | | c.send(()).ok(); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________________- help: try this: `if writer.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/channel.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | if let Ok(_) = writer.flush() { [INFO] [stderr] | _____________________________- ^^^^^ [INFO] [stderr] 100 | | c.send(()).ok(); [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____________________________- help: try this: `if writer.flush().is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/channel.rs:123:67 [INFO] [stderr] | [INFO] [stderr] 123 | Channel::map(reader, writer, incoming, outgoing_capacity, |x| Some(x)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/channel.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | let reader = "5:hello,".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"5:hello,"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/channel.rs:232:22 [INFO] [stderr] | [INFO] [stderr] 232 | let reader = "".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/channel.rs:245:22 [INFO] [stderr] | [INFO] [stderr] 245 | let reader = "".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | offset = offset + r; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset += r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | try!(self.read(t[..].as_mut())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:117:31 [INFO] [stderr] | [INFO] [stderr] 117 | let r = try!(r.read(t[current..current + 1].as_mut())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `current..=current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | let mut raw = "5:hello,".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"5:hello,"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | let _ = raw.write_netstring("hello").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | let mut raw = "5:hello?".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"5:hello?"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let mut raw = "10:hello,".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"10:hello,"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:178:23 [INFO] [stderr] | [INFO] [stderr] 178 | let mut raw = "2:hello,".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"2:hello,"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:184:23 [INFO] [stderr] | [INFO] [stderr] 184 | let mut raw = "5:hello,5:world,10:xxxxxxxxxx,".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"5:hello,5:world,10:xxxxxxxxxx,"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `netstring`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fe629750e2921bcb399d2e92838fe19825de6fbce733fb64c0186a3a3eb43e6f"` [INFO] running `"docker" "rm" "-f" "fe629750e2921bcb399d2e92838fe19825de6fbce733fb64c0186a3a3eb43e6f"` [INFO] [stdout] fe629750e2921bcb399d2e92838fe19825de6fbce733fb64c0186a3a3eb43e6f