[INFO] crate netlink-sys 0.0.1 is already in cache [INFO] extracting crate netlink-sys 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/netlink-sys/0.0.1 [INFO] extracting crate netlink-sys 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netlink-sys/0.0.1 [INFO] validating manifest of netlink-sys-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netlink-sys-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netlink-sys-0.0.1 [INFO] removed 2 missing examples [INFO] finished frobbing netlink-sys-0.0.1 [INFO] frobbed toml for netlink-sys-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/netlink-sys/0.0.1/Cargo.toml [INFO] started frobbing netlink-sys-0.0.1 [INFO] removed 2 missing examples [INFO] finished frobbing netlink-sys-0.0.1 [INFO] frobbed toml for netlink-sys-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netlink-sys/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netlink-sys-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netlink-sys/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fac08a50e85d1c79d7eb55f99eef3b0c9739bbb0a8fbbc9164966bd749e15e97 [INFO] running `"docker" "start" "-a" "fac08a50e85d1c79d7eb55f99eef3b0c9739bbb0a8fbbc9164966bd749e15e97"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/dump_links_tokio.rs [INFO] [stderr] * /opt/crater/workdir/examples/dump_links.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling netlink-sys v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `BufMut` [INFO] [stderr] --> src/codecs.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use bytes::{BufMut, BytesMut}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Emitable` [INFO] [stderr] --> src/codecs.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | use {Emitable, Error, NetlinkBuffer}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet/buffer.rs:339:46 [INFO] [stderr] | [INFO] [stderr] 339 | assert_eq!(packet.sequence_number(), 1526271540); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_526_271_540` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet/buffer.rs:360:40 [INFO] [stderr] | [INFO] [stderr] 360 | packet.set_sequence_number(1526271540); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_526_271_540` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet/rtnl/link/nlas/tests.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | LinkAfInet6Nla::Flags(2147483648), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet/rtnl/link/nlas/tests.rs:199:29 [INFO] [stderr] | [INFO] [stderr] 199 | temp_valid_lft: 604800, [INFO] [stderr] | ^^^^^^ help: consider: `604_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packet/rtnl/link/nlas/tests.rs:231:39 [INFO] [stderr] | [INFO] [stderr] 231 | rtr_solicit_max_interval: 3600000, [INFO] [stderr] | ^^^^^^^ help: consider: `3_600_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufMut` [INFO] [stderr] --> src/codecs.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | use bytes::{BufMut, BytesMut}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Emitable` [INFO] [stderr] --> src/codecs.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | use {Emitable, Error, NetlinkBuffer}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packet::rtnl::link::message::LinkMessage` [INFO] [stderr] --> src/packet/rtnl/link/message.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | LinkMessage::from_parts(LinkHeader::new(), vec![]) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/packet/utils.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | for (i, byte) in payload.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/packet/utils.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | for (i, byte) in payload.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `packet::rtnl::link::message::LinkMessage` [INFO] [stderr] --> src/packet/rtnl/link/message.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | LinkMessage::from_parts(LinkHeader::new(), vec![]) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/packet/rtnl/link/message.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | / fn packet_nlas_read() { [INFO] [stderr] 151 | | let packet = LinkBuffer::new(&HEADER[..]); [INFO] [stderr] 152 | | assert_eq!(packet.nlas().count(), 10); [INFO] [stderr] 153 | | let mut nlas = packet.nlas(); [INFO] [stderr] ... | [INFO] [stderr] 227 | | assert_eq!(parsed, LinkNla::NumTxQueues(1)); [INFO] [stderr] 228 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/packet/utils.rs:10:30 [INFO] [stderr] | [INFO] [stderr] 10 | for (i, byte) in payload.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/packet/utils.rs:21:30 [INFO] [stderr] | [INFO] [stderr] 21 | for (i, byte) in payload.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_nl`) [INFO] [stderr] --> src/socket/sys.rs:434:40 [INFO] [stderr] | [INFO] [stderr] 434 | let inner_addr = unsafe { *(addr_ptr as *const libc::sockaddr_nl) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut libc::sockaddr` to a more-strictly-aligned pointer (`*mut libc::sockaddr_nl`) [INFO] [stderr] --> src/socket/sys.rs:441:31 [INFO] [stderr] | [INFO] [stderr] 441 | let sockaddr_nl = addr_ptr as *mut libc::sockaddr_nl; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netlink-sys`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fac08a50e85d1c79d7eb55f99eef3b0c9739bbb0a8fbbc9164966bd749e15e97"` [INFO] running `"docker" "rm" "-f" "fac08a50e85d1c79d7eb55f99eef3b0c9739bbb0a8fbbc9164966bd749e15e97"` [INFO] [stdout] fac08a50e85d1c79d7eb55f99eef3b0c9739bbb0a8fbbc9164966bd749e15e97