[INFO] crate netlink-rust 0.1.0 is already in cache [INFO] extracting crate netlink-rust 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/netlink-rust/0.1.0 [INFO] extracting crate netlink-rust 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netlink-rust/0.1.0 [INFO] validating manifest of netlink-rust-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netlink-rust-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netlink-rust-0.1.0 [INFO] finished frobbing netlink-rust-0.1.0 [INFO] frobbed toml for netlink-rust-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/netlink-rust/0.1.0/Cargo.toml [INFO] started frobbing netlink-rust-0.1.0 [INFO] finished frobbing netlink-rust-0.1.0 [INFO] frobbed toml for netlink-rust-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netlink-rust/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netlink-rust-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netlink-rust/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d34a7df2843e9763f1bc0576e7ddf06fa9fdf55cf8e6c8be8322ecb524e89df [INFO] running `"docker" "start" "-a" "4d34a7df2843e9763f1bc0576e7ddf06fa9fdf55cf8e6c8be8322ecb524e89df"` [INFO] [stderr] Checking netlink-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(DataMessage { header: header, data: data }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(DataMessage { header: header, data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(ErrorMessage { header: header, code: code, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:212:43 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(ErrorMessage { header: header, code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | original_header: original_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:239:24 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Attribute { identifier: identifier, data: data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:239:48 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Attribute { identifier: identifier, data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | groups: groups, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | groups: groups, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | change: change, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | sequence: sequence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | pid: pid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:198:26 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(DataMessage { header: header, data: data }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(DataMessage { header: header, data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(ErrorMessage { header: header, code: code, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:212:43 [INFO] [stderr] | [INFO] [stderr] 212 | Ok(ErrorMessage { header: header, code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | original_header: original_header }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:239:24 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Attribute { identifier: identifier, data: data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:239:48 [INFO] [stderr] | [INFO] [stderr] 239 | Ok(Attribute { identifier: identifier, data: data }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:339:13 [INFO] [stderr] | [INFO] [stderr] 339 | groups: groups, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | groups: groups, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `groups` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/mod.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | page_size: page_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `page_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | change: change, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `change` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/route.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/mod.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | return Ok(more_messages); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(more_messages)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/route.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Message { family: family.into(), attributes: vec!(), }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Message { family: family.into(), attributes: vec!(), }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Message { [INFO] [stderr] 67 | | family: family.into(), [INFO] [stderr] 68 | | command: command.into(), [INFO] [stderr] 69 | | version: 1u8, [INFO] [stderr] 70 | | flags: mode.into(), [INFO] [stderr] 71 | | attributes: vec!(), [INFO] [stderr] 72 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Message { [INFO] [stderr] 67 | family: family.into(), [INFO] [stderr] 68 | command: command.into(), [INFO] [stderr] 69 | version: 1u8, [INFO] [stderr] 70 | flags: mode.into(), [INFO] [stderr] 71 | attributes: vec!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return Ok(families) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(families)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:314:52 [INFO] [stderr] | [INFO] [stderr] 314 | read_write_test(&[0x44, 0x33, 0x22, 0x11], 0x11223344u32.to_le()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x1122_3344u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | 0x1122334455667788u64.to_le()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x1122_3344_5566_7788u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:330:54 [INFO] [stderr] | [INFO] [stderr] 330 | read_write_test(&[0x11, 0x22, 0x33, 0xa4], (-1540152815i32).to_le()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_540_152_815i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:336:15 [INFO] [stderr] | [INFO] [stderr] 336 | (-8637284766759618799i64).to_le()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `8_637_284_766_759_618_799i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:405:54 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(f64::read(&mut reader).unwrap(), -2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_459_045` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/variant.rs:418:11 [INFO] [stderr] | [INFO] [stderr] 418 | (-2.718281828459045f64).write(&mut writer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_459_045f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/core/mod.rs:523:9 [INFO] [stderr] | [INFO] [stderr] 523 | return Ok(more_messages); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(more_messages)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/route.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Message { family: family.into(), attributes: vec!(), }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Message { family: family.into(), attributes: vec!(), }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / return Message { [INFO] [stderr] 67 | | family: family.into(), [INFO] [stderr] 68 | | command: command.into(), [INFO] [stderr] 69 | | version: 1u8, [INFO] [stderr] 70 | | flags: mode.into(), [INFO] [stderr] 71 | | attributes: vec!(), [INFO] [stderr] 72 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 66 | Message { [INFO] [stderr] 67 | family: family.into(), [INFO] [stderr] 68 | command: command.into(), [INFO] [stderr] 69 | version: 1u8, [INFO] [stderr] 70 | flags: mode.into(), [INFO] [stderr] 71 | attributes: vec!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return Ok(families) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(families)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/hardware_address.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bytes(&self) -> [u8; 6] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/hardware_address.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core/variant.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | writer.write(&self.bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core/variant.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | writer.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/core/mod.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / extended_enum!(Protocol, i32, [INFO] [stderr] 30 | | Route => 0, [INFO] [stderr] 31 | | Unused => 1, [INFO] [stderr] 32 | | Usersock => 2, [INFO] [stderr] ... | [INFO] [stderr] 51 | | SMC => 21 [INFO] [stderr] 52 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: item `core::Attribute` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/core/mod.rs:228:1 [INFO] [stderr] | [INFO] [stderr] 228 | / impl Attribute { [INFO] [stderr] 229 | | const HEADER_SIZE: u16 = 4; [INFO] [stderr] 230 | | [INFO] [stderr] 231 | | pub fn parse(reader: &mut R) -> Result { [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The function/method `system::bind` doesn't need a mutable reference [INFO] [stderr] --> src/core/mod.rs:341:30 [INFO] [stderr] | [INFO] [stderr] 341 | system::bind(socket, &mut local_addr)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/core/mod.rs:382:26 [INFO] [stderr] | [INFO] [stderr] 382 | msg_control: 0 as *mut libc::c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | pos = pos + header.aligned_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos += header.aligned_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core/mod.rs:516:67 [INFO] [stderr] | [INFO] [stderr] 516 | let flags = MessageFlags::from_bits(header.flags).unwrap_or(MessageFlags::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(MessageFlags::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/route.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / extended_enum!(FamilyId, u16, [INFO] [stderr] 11 | | NewLink => 16, [INFO] [stderr] 12 | | DeleteLink => 17, [INFO] [stderr] 13 | | GetLink => 18, [INFO] [stderr] 14 | | SetLink => 19, [INFO] [stderr] 15 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/route.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / extended_enum_default!(AddressFamilyAttribute, u16, [INFO] [stderr] 18 | | Unspecified => 0, [INFO] [stderr] 19 | | Address => 1, [INFO] [stderr] 20 | | Broadcast => 2, [INFO] [stderr] ... | [INFO] [stderr] 64 | | InterfaceNetworkNameSpaceId => 46, [INFO] [stderr] 65 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / extended_enum!(FamilyId, u16, [INFO] [stderr] 14 | | Control => 16, [INFO] [stderr] 15 | | VirtualFileSystemDiskQuota => 17, [INFO] [stderr] 16 | | Raid => 18, [INFO] [stderr] 17 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / extended_enum_default!(Command, u8, [INFO] [stderr] 20 | | Unspecified => 0, [INFO] [stderr] 21 | | NewFamily => 1, [INFO] [stderr] 22 | | DelFamily => 2, [INFO] [stderr] ... | [INFO] [stderr] 29 | | GetMulticastGroup => 9, [INFO] [stderr] 30 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / extended_enum_default!(AttributeId, u16, [INFO] [stderr] 33 | | Unspecified => 0, [INFO] [stderr] 34 | | FamilyId => 1, [INFO] [stderr] 35 | | FamilyName => 2, [INFO] [stderr] ... | [INFO] [stderr] 40 | | MulticastGroups => 7, [INFO] [stderr] 41 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / extended_enum_default!(OperationAttributeId, u16, [INFO] [stderr] 44 | | Unspecified => 0, [INFO] [stderr] 45 | | Id => 1, [INFO] [stderr] 46 | | Flags => 2, [INFO] [stderr] 47 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / extended_enum_default!(MulticastAttributeId, u16, [INFO] [stderr] 50 | | Unspecified => 0, [INFO] [stderr] 51 | | Name => 1, [INFO] [stderr] 52 | | Id => 2, [INFO] [stderr] 53 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generic.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn family(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.family.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generic.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn family(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generic.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | fn message_type(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.family.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generic.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | fn message_type(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generic.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | / match message { [INFO] [stderr] 247 | | core::Message::Data(m) => { [INFO] [stderr] 248 | | if FamilyId::convert_from(m.header.identifier) == Some(FamilyId::Control) { [INFO] [stderr] 249 | | let msg = Message::parse(&mut io::Cursor::new(m.data))?; [INFO] [stderr] ... | [INFO] [stderr] 256 | | _ => (), [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | if let core::Message::Data(m) = message { [INFO] [stderr] 247 | if FamilyId::convert_from(m.header.identifier) == Some(FamilyId::Control) { [INFO] [stderr] 248 | let msg = Message::parse(&mut io::Cursor::new(m.data))?; [INFO] [stderr] 249 | let family = Family::from_message(msg)?; [INFO] [stderr] 250 | if family.name == name { [INFO] [stderr] 251 | return Ok(family); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netlink-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/hardware_address.rs:11:15 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bytes(&self) -> [u8; 6] { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/hardware_address.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core/variant.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | writer.write(&self.bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/core/variant.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | writer.write(&bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/variant.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | assert_eq!(f32::read(&mut reader).unwrap(), -3.14156); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/variant.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | assert_eq!(f32::read(&mut reader).unwrap(), -3.14156); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::E` found. Consider using it directly [INFO] [stderr] --> src/core/variant.rs:405:54 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(f64::read(&mut reader).unwrap(), -2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/core/variant.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(f64::read(&mut reader).unwrap(), -2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/core/variant.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | assert_eq!(f64::read(&mut reader).unwrap(), -2.718281828459045); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::E` found. Consider using it directly [INFO] [stderr] --> src/core/variant.rs:418:11 [INFO] [stderr] | [INFO] [stderr] 418 | (-2.718281828459045f64).write(&mut writer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/core/mod.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | / extended_enum!(Protocol, i32, [INFO] [stderr] 30 | | Route => 0, [INFO] [stderr] 31 | | Unused => 1, [INFO] [stderr] 32 | | Usersock => 2, [INFO] [stderr] ... | [INFO] [stderr] 51 | | SMC => 21 [INFO] [stderr] 52 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: item `core::Attribute` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/core/mod.rs:228:1 [INFO] [stderr] | [INFO] [stderr] 228 | / impl Attribute { [INFO] [stderr] 229 | | const HEADER_SIZE: u16 = 4; [INFO] [stderr] 230 | | [INFO] [stderr] 231 | | pub fn parse(reader: &mut R) -> Result { [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: The function/method `system::bind` doesn't need a mutable reference [INFO] [stderr] --> src/core/mod.rs:341:30 [INFO] [stderr] | [INFO] [stderr] 341 | system::bind(socket, &mut local_addr)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/core/mod.rs:382:26 [INFO] [stderr] | [INFO] [stderr] 382 | msg_control: 0 as *mut libc::c_void, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/core/mod.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | pos = pos + header.aligned_length(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos += header.aligned_length()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/core/mod.rs:516:67 [INFO] [stderr] | [INFO] [stderr] 516 | let flags = MessageFlags::from_bits(header.flags).unwrap_or(MessageFlags::empty()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(MessageFlags::empty)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/route.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / extended_enum!(FamilyId, u16, [INFO] [stderr] 11 | | NewLink => 16, [INFO] [stderr] 12 | | DeleteLink => 17, [INFO] [stderr] 13 | | GetLink => 18, [INFO] [stderr] 14 | | SetLink => 19, [INFO] [stderr] 15 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/route.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / extended_enum_default!(AddressFamilyAttribute, u16, [INFO] [stderr] 18 | | Unspecified => 0, [INFO] [stderr] 19 | | Address => 1, [INFO] [stderr] 20 | | Broadcast => 2, [INFO] [stderr] ... | [INFO] [stderr] 64 | | InterfaceNetworkNameSpaceId => 46, [INFO] [stderr] 65 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 107 | | match *other { [INFO] [stderr] 108 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / extended_enum!(FamilyId, u16, [INFO] [stderr] 14 | | Control => 16, [INFO] [stderr] 15 | | VirtualFileSystemDiskQuota => 17, [INFO] [stderr] 16 | | Raid => 18, [INFO] [stderr] 17 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / extended_enum_default!(Command, u8, [INFO] [stderr] 20 | | Unspecified => 0, [INFO] [stderr] 21 | | NewFamily => 1, [INFO] [stderr] 22 | | DelFamily => 2, [INFO] [stderr] ... | [INFO] [stderr] 29 | | GetMulticastGroup => 9, [INFO] [stderr] 30 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / extended_enum_default!(AttributeId, u16, [INFO] [stderr] 33 | | Unspecified => 0, [INFO] [stderr] 34 | | FamilyId => 1, [INFO] [stderr] 35 | | FamilyName => 2, [INFO] [stderr] ... | [INFO] [stderr] 40 | | MulticastGroups => 7, [INFO] [stderr] 41 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / extended_enum_default!(OperationAttributeId, u16, [INFO] [stderr] 44 | | Unspecified => 0, [INFO] [stderr] 45 | | Id => 1, [INFO] [stderr] 46 | | Flags => 2, [INFO] [stderr] 47 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/core/helpers.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | / fn ne(&self, other: &$name) -> bool { [INFO] [stderr] 53 | | match *other { [INFO] [stderr] 54 | | $name::$var_def => *self != $val_def, [INFO] [stderr] 55 | | $( $name::$var => *self != $val, )* [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/generic.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / extended_enum_default!(MulticastAttributeId, u16, [INFO] [stderr] 50 | | Unspecified => 0, [INFO] [stderr] 51 | | Name => 1, [INFO] [stderr] 52 | | Id => 2, [INFO] [stderr] 53 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generic.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn family(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.family.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generic.rs:89:35 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn family(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generic.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | fn message_type(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.family.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/generic.rs:109:37 [INFO] [stderr] | [INFO] [stderr] 109 | fn message_type(&self) -> u16 { self.family.clone().into() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/generic.rs:246:13 [INFO] [stderr] | [INFO] [stderr] 246 | / match message { [INFO] [stderr] 247 | | core::Message::Data(m) => { [INFO] [stderr] 248 | | if FamilyId::convert_from(m.header.identifier) == Some(FamilyId::Control) { [INFO] [stderr] 249 | | let msg = Message::parse(&mut io::Cursor::new(m.data))?; [INFO] [stderr] ... | [INFO] [stderr] 256 | | _ => (), [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 246 | if let core::Message::Data(m) = message { [INFO] [stderr] 247 | if FamilyId::convert_from(m.header.identifier) == Some(FamilyId::Control) { [INFO] [stderr] 248 | let msg = Message::parse(&mut io::Cursor::new(m.data))?; [INFO] [stderr] 249 | let family = Family::from_message(msg)?; [INFO] [stderr] 250 | if family.name == name { [INFO] [stderr] 251 | return Ok(family); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netlink-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4d34a7df2843e9763f1bc0576e7ddf06fa9fdf55cf8e6c8be8322ecb524e89df"` [INFO] running `"docker" "rm" "-f" "4d34a7df2843e9763f1bc0576e7ddf06fa9fdf55cf8e6c8be8322ecb524e89df"` [INFO] [stdout] 4d34a7df2843e9763f1bc0576e7ddf06fa9fdf55cf8e6c8be8322ecb524e89df