[INFO] crate netinfo-ffi 0.5.0 is already in cache [INFO] extracting crate netinfo-ffi 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/netinfo-ffi/0.5.0 [INFO] extracting crate netinfo-ffi 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netinfo-ffi/0.5.0 [INFO] validating manifest of netinfo-ffi-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netinfo-ffi-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netinfo-ffi-0.5.0 [INFO] finished frobbing netinfo-ffi-0.5.0 [INFO] frobbed toml for netinfo-ffi-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/netinfo-ffi/0.5.0/Cargo.toml [INFO] started frobbing netinfo-ffi-0.5.0 [INFO] finished frobbing netinfo-ffi-0.5.0 [INFO] frobbed toml for netinfo-ffi-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netinfo-ffi/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netinfo-ffi-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netinfo-ffi/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 702ce903150a837a8ab8f17d726654e58d6ec91ebf66e92a0d55b8cbe6f9d920 [INFO] running `"docker" "start" "-a" "702ce903150a837a8ab8f17d726654e58d6ec91ebf66e92a0d55b8cbe6f9d920"` [INFO] [stderr] Checking netinfo v0.5.1 [INFO] [stderr] Checking netinfo-ffi v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:179:79 [INFO] [stderr] | [INFO] [stderr] 179 | fn from(f: MacAddr) -> ni_mac_addr { let m = ni_mac_addr { d: f.into() }; m } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:179:50 [INFO] [stderr] | [INFO] [stderr] 179 | fn from(f: MacAddr) -> ni_mac_addr { let m = ni_mac_addr { d: f.into() }; m } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:179:79 [INFO] [stderr] | [INFO] [stderr] 179 | fn from(f: MacAddr) -> ni_mac_addr { let m = ni_mac_addr { d: f.into() }; m } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:179:50 [INFO] [stderr] | [INFO] [stderr] 179 | fn from(f: MacAddr) -> ni_mac_addr { let m = ni_mac_addr { d: f.into() }; m } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:90:58 [INFO] [stderr] | [INFO] [stderr] 90 | temp_box(ptr_elem as *mut c_void, |elem_box: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | fn to_netinfo_type(&self) -> netinfo::TransportType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | fn to_netinfo_type(&self) -> netinfo::InoutType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 271 | check_ptr!(net_interfaces_array_out, num_net_interfaces_out); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 271 | check_ptr!(net_interfaces_array_out, num_net_interfaces_out); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | check_ptr!(name_out, name_len_out); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:286:25 [INFO] [stderr] | [INFO] [stderr] 286 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 296 | check_ptr!(s); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 306 | check_ptr!(index_out); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:308:25 [INFO] [stderr] | [INFO] [stderr] 308 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 317 | check_ptr!(has_mac_out, mac_out); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 340 | check_ptr!(ip4_array_out, num_ip4_out, ip6_array_out, num_ip6_out); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:342:25 [INFO] [stderr] | [INFO] [stderr] 342 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 372 | check_ptr!(flags_out); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 397 | check_ptr!(interfaces, n_out); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 408 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:410:31 [INFO] [stderr] | [INFO] [stderr] 410 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 420 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:422:31 [INFO] [stderr] | [INFO] [stderr] 422 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 431 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 442 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:444:31 [INFO] [stderr] | [INFO] [stderr] 444 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 454 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:456:31 [INFO] [stderr] | [INFO] [stderr] 456 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:458:77 [INFO] [stderr] | [INFO] [stderr] 458 | netinfo.set_min_refresh_interval(Some(Duration::from_millis(milliseconds as u64)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(milliseconds)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 469 | check_ptr!(n, worker_thread_errors, num_errors); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:471:31 [INFO] [stderr] | [INFO] [stderr] 471 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 490 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:501:28 [INFO] [stderr] | [INFO] [stderr] 501 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:512:28 [INFO] [stderr] | [INFO] [stderr] 512 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:523:28 [INFO] [stderr] | [INFO] [stderr] 523 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:534:28 [INFO] [stderr] | [INFO] [stderr] 534 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 543 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:545:28 [INFO] [stderr] | [INFO] [stderr] 545 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 554 | check_ptr!(s, pid_array_out, num_pids_out); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:556:28 [INFO] [stderr] | [INFO] [stderr] 556 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 574 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:576:28 [INFO] [stderr] | [INFO] [stderr] 576 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:577:44 [INFO] [stderr] | [INFO] [stderr] 577 | let pid_opt2: Option = if pid_opt == null_mut() { None } else { Some(*pid_opt) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:578:52 [INFO] [stderr] | [INFO] [stderr] 578 | let inout_opt2: Option = if inout_opt == null_mut() { None } else { Some(ni_inout_enum::import(*inout_opt)?.to_netinfo_type()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:579:53 [INFO] [stderr] | [INFO] [stderr] 579 | let tt_opt2: Option = if tt_opt == null_mut() { None } else { Some(ni_transport_type_enum::import(*tt_opt)?.to_netinfo_type()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 588 | check_ptr!(s); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:601:16 [INFO] [stderr] | [INFO] [stderr] 601 | }).unwrap_or("unknown error code".as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown error code".as_ptr())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:90:58 [INFO] [stderr] | [INFO] [stderr] 90 | temp_box(ptr_elem as *mut c_void, |elem_box: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `&mut T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:156:24 [INFO] [stderr] | [INFO] [stderr] 156 | fn to_netinfo_type(&self) -> netinfo::TransportType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | fn to_netinfo_type(&self) -> netinfo::InoutType { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 271 | check_ptr!(net_interfaces_array_out, num_net_interfaces_out); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 271 | check_ptr!(net_interfaces_array_out, num_net_interfaces_out); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | check_ptr!(name_out, name_len_out); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:286:25 [INFO] [stderr] | [INFO] [stderr] 286 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 296 | check_ptr!(s); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 306 | check_ptr!(index_out); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:308:25 [INFO] [stderr] | [INFO] [stderr] 308 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 317 | check_ptr!(has_mac_out, mac_out); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 340 | check_ptr!(ip4_array_out, num_ip4_out, ip6_array_out, num_ip6_out); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:342:25 [INFO] [stderr] | [INFO] [stderr] 342 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 372 | check_ptr!(flags_out); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:374:25 [INFO] [stderr] | [INFO] [stderr] 374 | temp_box(i, |i: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetworkInterface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 397 | check_ptr!(interfaces, n_out); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 408 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:410:31 [INFO] [stderr] | [INFO] [stderr] 410 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 420 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:422:31 [INFO] [stderr] | [INFO] [stderr] 422 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 431 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 442 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:444:31 [INFO] [stderr] | [INFO] [stderr] 444 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 454 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:456:31 [INFO] [stderr] | [INFO] [stderr] 456 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:458:77 [INFO] [stderr] | [INFO] [stderr] 458 | netinfo.set_min_refresh_interval(Some(Duration::from_millis(milliseconds as u64)))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(milliseconds)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 469 | check_ptr!(n, worker_thread_errors, num_errors); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:471:31 [INFO] [stderr] | [INFO] [stderr] 471 | temp_box(n, |netinfo: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Netinfo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 490 | check_ptr!(n); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:501:28 [INFO] [stderr] | [INFO] [stderr] 501 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:512:28 [INFO] [stderr] | [INFO] [stderr] 512 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:523:28 [INFO] [stderr] | [INFO] [stderr] 523 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:534:28 [INFO] [stderr] | [INFO] [stderr] 534 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 543 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:545:28 [INFO] [stderr] | [INFO] [stderr] 545 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 554 | check_ptr!(s, pid_array_out, num_pids_out); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:556:28 [INFO] [stderr] | [INFO] [stderr] 556 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 574 | check_ptr!(s, bytes_out); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/lib.rs:576:28 [INFO] [stderr] | [INFO] [stderr] 576 | temp_box(s, |stat: &mut Box| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut NetStatistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:577:44 [INFO] [stderr] | [INFO] [stderr] 577 | let pid_opt2: Option = if pid_opt == null_mut() { None } else { Some(*pid_opt) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:578:52 [INFO] [stderr] | [INFO] [stderr] 578 | let inout_opt2: Option = if inout_opt == null_mut() { None } else { Some(ni_inout_enum::import(*inout_opt)?.to_netinfo_type()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:579:53 [INFO] [stderr] | [INFO] [stderr] 579 | let tt_opt2: Option = if tt_opt == null_mut() { None } else { Some(ni_transport_type_enum::import(*tt_opt)?.to_netinfo_type()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/lib.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if $i == null_mut() { return From::from(ReturnCodes::NullPointerArgument); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 588 | check_ptr!(s); [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:601:16 [INFO] [stderr] | [INFO] [stderr] 601 | }).unwrap_or("unknown error code".as_ptr()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "unknown error code".as_ptr())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.87s [INFO] running `"docker" "inspect" "702ce903150a837a8ab8f17d726654e58d6ec91ebf66e92a0d55b8cbe6f9d920"` [INFO] running `"docker" "rm" "-f" "702ce903150a837a8ab8f17d726654e58d6ec91ebf66e92a0d55b8cbe6f9d920"` [INFO] [stdout] 702ce903150a837a8ab8f17d726654e58d6ec91ebf66e92a0d55b8cbe6f9d920