[INFO] crate netinfo 0.5.1 is already in cache [INFO] extracting crate netinfo 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/netinfo/0.5.1 [INFO] extracting crate netinfo 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netinfo/0.5.1 [INFO] validating manifest of netinfo-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netinfo-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netinfo-0.5.1 [INFO] finished frobbing netinfo-0.5.1 [INFO] frobbed toml for netinfo-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/netinfo/0.5.1/Cargo.toml [INFO] started frobbing netinfo-0.5.1 [INFO] finished frobbing netinfo-0.5.1 [INFO] frobbed toml for netinfo-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netinfo/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netinfo-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netinfo/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b69e0817c1cd15a24ebc987f1247f0a10bb491f83716ef7d34161721f4fc09b [INFO] running `"docker" "start" "-a" "5b69e0817c1cd15a24ebc987f1247f0a10bb491f83716ef7d34161721f4fc09b"` [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking netinfo v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/packet_capture.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | CaptureParser { packet_info_handler: packet_info_handler, local_net_ips: local_net_ips_hashset } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_info_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:35:66 [INFO] [stderr] | [INFO] [stderr] 35 | fn from(d: MacAddr) -> PnetMacAddr { let MacAddr(a, b, c, d, e, f) = d; PnetMacAddr::new(a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:35:69 [INFO] [stderr] | [INFO] [stderr] 35 | fn from(d: MacAddr) -> PnetMacAddr { let MacAddr(a, b, c, d, e, f) = d; PnetMacAddr::new(a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:38:79 [INFO] [stderr] | [INFO] [stderr] 38 | fn from(d: MacAddr) -> (u8, u8, u8, u8, u8, u8) { let MacAddr(a, b, c, d, e, f) = d; (a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:38:82 [INFO] [stderr] | [INFO] [stderr] 38 | fn from(d: MacAddr) -> (u8, u8, u8, u8, u8, u8) { let MacAddr(a, b, c, d, e, f) = d; (a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:32 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `datalen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:69 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:101 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inout_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | Connection { local: local, remote: remote } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:154:36 [INFO] [stderr] | [INFO] [stderr] 154 | Connection { local: local, remote: remote } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | capture_handle: capture_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capture_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | statistics: statistics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | stop_request: stop_request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/packet_capture.rs:86:25 [INFO] [stderr] | [INFO] [stderr] 86 | CaptureParser { packet_info_handler: packet_info_handler, local_net_ips: local_net_ips_hashset } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `packet_info_handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:35:66 [INFO] [stderr] | [INFO] [stderr] 35 | fn from(d: MacAddr) -> PnetMacAddr { let MacAddr(a, b, c, d, e, f) = d; PnetMacAddr::new(a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:35:69 [INFO] [stderr] | [INFO] [stderr] 35 | fn from(d: MacAddr) -> PnetMacAddr { let MacAddr(a, b, c, d, e, f) = d; PnetMacAddr::new(a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:38:79 [INFO] [stderr] | [INFO] [stderr] 38 | fn from(d: MacAddr) -> (u8, u8, u8, u8, u8, u8) { let MacAddr(a, b, c, d, e, f) = d; (a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/netinfo/types.rs:38:82 [INFO] [stderr] | [INFO] [stderr] 38 | fn from(d: MacAddr) -> (u8, u8, u8, u8, u8, u8) { let MacAddr(a, b, c, d, e, f) = d; (a, b, c, d, e, f) } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:22 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:32 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `datalen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:69 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:118:101 [INFO] [stderr] | [INFO] [stderr] 118 | PacketInfo { sip: sip, dip: dip, time: 0, datalen: datalen, transport_type: transport_type, inout_type: inout_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inout_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:154:22 [INFO] [stderr] | [INFO] [stderr] 154 | Connection { local: local, remote: remote } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `local` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/types.rs:154:36 [INFO] [stderr] | [INFO] [stderr] 154 | Connection { local: local, remote: remote } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `remote` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | capture_handle: capture_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `capture_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | statistics: statistics, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `statistics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/netinfo/netinfo.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | stop_request: stop_request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stop_request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/netinfo/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod netinfo; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/netinfo/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | mod netinfo; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/netinfo/packet_capture.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | !(flags & IFF_LOOPBACK as u32 != 0) && (flags & IFF_UP as u32 != 0) && (flags & IFF_RUNNING as u32 != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flags & IFF_LOOPBACK as u32 == 0 && (flags & IFF_UP as u32 != 0) && (flags & IFF_RUNNING as u32 != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/netinfo/packet_capture.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | match channel { [INFO] [stderr] | _________^ [INFO] [stderr] 91 | | &mut Channel::Ethernet(_ /* ref tx */, ref mut rx) => { [INFO] [stderr] 92 | | loop { [INFO] [stderr] 93 | | let packet = rx.next().chain_err(|| ErrorKind::EthernetReceiveError)?; [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *channel { [INFO] [stderr] 91 | Channel::Ethernet(_ /* ref tx */, ref mut rx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/netinfo/inode_to_pid.rs:42:85 [INFO] [stderr] | [INFO] [stderr] 42 | if link_target_str.starts_with("socket:[") && link_target_str.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/inode_to_pid.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.inode_to_pid_map.get(&inode).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inode_to_pid_map.get(&inode).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/conn_to_inode.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | self.conn_to_inode_map.get(&(tt, c)).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.conn_to_inode_map.get(&(tt, c)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/conn_to_inode.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | self.conn_to_inode_map.get(&(tt, c)).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.conn_to_inode_map.get(&(tt, c)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/netinfo/netinfo.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | map: HashMap<(Option, Option, Option), u64>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/netinfo/netinfo.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | .map(|(_, &b)| b) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 43 | | .fold(0, |b, acc| b + acc) [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/netinfo/netinfo.rs:75:86 [INFO] [stderr] | [INFO] [stderr] 75 | for &io_attr in [None, Some(InoutType::Incoming), Some(InoutType::Outgoing)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/netinfo/netinfo.rs:77:88 [INFO] [stderr] | [INFO] [stderr] 77 | for &tt_attr in [None, Some(TransportType::Tcp), Some(TransportType::Udp)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/netinfo.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | b += self.map.get(&(pid, io_attr, tt_attr)).map(|&x| x).unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.map.get(&(pid, io_attr, tt_attr)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/netinfo/netinfo.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | self.map.values().fold(0, |acc, bytes| acc + bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/netinfo/netinfo.rs:236:65 [INFO] [stderr] | [INFO] [stderr] 236 | Ok(CaptureHandle::list_net_interfaces().into_iter().map(|i| NetworkInterface::from(i)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkInterface::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/netinfo/packet_capture.rs:58:3 [INFO] [stderr] | [INFO] [stderr] 58 | !(flags & IFF_LOOPBACK as u32 != 0) && (flags & IFF_UP as u32 != 0) && (flags & IFF_RUNNING as u32 != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flags & IFF_LOOPBACK as u32 == 0 && (flags & IFF_UP as u32 != 0) && (flags & IFF_RUNNING as u32 != 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/netinfo/packet_capture.rs:90:3 [INFO] [stderr] | [INFO] [stderr] 90 | match channel { [INFO] [stderr] | _________^ [INFO] [stderr] 91 | | &mut Channel::Ethernet(_ /* ref tx */, ref mut rx) => { [INFO] [stderr] 92 | | loop { [INFO] [stderr] 93 | | let packet = rx.next().chain_err(|| ErrorKind::EthernetReceiveError)?; [INFO] [stderr] ... | [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | match *channel { [INFO] [stderr] 91 | Channel::Ethernet(_ /* ref tx */, ref mut rx) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netinfo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/netinfo/inode_to_pid.rs:42:85 [INFO] [stderr] | [INFO] [stderr] 42 | if link_target_str.starts_with("socket:[") && link_target_str.ends_with("]") { [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/inode_to_pid.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | self.inode_to_pid_map.get(&inode).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.inode_to_pid_map.get(&inode).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/conn_to_inode.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | self.conn_to_inode_map.get(&(tt, c)).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.conn_to_inode_map.get(&(tt, c)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/conn_to_inode.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | self.conn_to_inode_map.get(&(tt, c)).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.conn_to_inode_map.get(&(tt, c)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/netinfo/netinfo.rs:16:10 [INFO] [stderr] | [INFO] [stderr] 16 | map: HashMap<(Option, Option, Option), u64>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/netinfo/netinfo.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | .map(|(_, &b)| b) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 43 | | .fold(0, |b, acc| b + acc) [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/netinfo/netinfo.rs:75:86 [INFO] [stderr] | [INFO] [stderr] 75 | for &io_attr in [None, Some(InoutType::Incoming), Some(InoutType::Outgoing)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/netinfo/netinfo.rs:77:88 [INFO] [stderr] | [INFO] [stderr] 77 | for &tt_attr in [None, Some(TransportType::Tcp), Some(TransportType::Udp)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/netinfo/netinfo.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | b += self.map.get(&(pid, io_attr, tt_attr)).map(|&x| x).unwrap_or(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.map.get(&(pid, io_attr, tt_attr)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/netinfo/netinfo.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | self.map.values().fold(0, |acc, bytes| acc + bytes) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/netinfo/netinfo.rs:236:65 [INFO] [stderr] | [INFO] [stderr] 236 | Ok(CaptureHandle::list_net_interfaces().into_iter().map(|i| NetworkInterface::from(i)).collect()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkInterface::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netinfo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5b69e0817c1cd15a24ebc987f1247f0a10bb491f83716ef7d34161721f4fc09b"` [INFO] running `"docker" "rm" "-f" "5b69e0817c1cd15a24ebc987f1247f0a10bb491f83716ef7d34161721f4fc09b"` [INFO] [stdout] 5b69e0817c1cd15a24ebc987f1247f0a10bb491f83716ef7d34161721f4fc09b