[INFO] crate netdevice 0.1.1 is already in cache
[INFO] extracting crate netdevice 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/netdevice/0.1.1
[INFO] extracting crate netdevice 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netdevice/0.1.1
[INFO] validating manifest of netdevice-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of netdevice-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing netdevice-0.1.1
[INFO] finished frobbing netdevice-0.1.1
[INFO] frobbed toml for netdevice-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/netdevice/0.1.1/Cargo.toml
[INFO] started frobbing netdevice-0.1.1
[INFO] finished frobbing netdevice-0.1.1
[INFO] frobbed toml for netdevice-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netdevice/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting netdevice-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netdevice/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 32da62a2807fc25e2ce3d0678f51d51389e7df7575d07367ab94ea7e909e674d
[INFO] running `"docker" "start" "-a" "32da62a2807fc25e2ce3d0678f51d51389e7df7575d07367ab94ea7e909e674d"`
[INFO] [stderr]     Checking netdevice v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         value: value,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         value: value,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 |         value: value,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         value: value,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:81:49
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn set_flags(sock: c_int, dev: &str, flags: &IfFlags) -> Result<(), Error> {
[INFO] [stderr]    |                                                 ^^^^^^^^ help: consider passing by value instead: `IfFlags`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |         flags: flags.clone(),
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: try dereferencing it: `*flags`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/lib.rs:264:5
[INFO] [stderr]     |
[INFO] [stderr] 264 |     name.as_ref().read_until(0, &mut vec_name).unwrap();
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: try this: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:294:81
[INFO] [stderr]     |
[INFO] [stderr] 294 |     Ok(ifaces.into_iter().map(|mut iface| (cstr_from_name(iface.name.as_mut()), iface.value.clone())).collect())
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `iface.value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/lib.rs:81:49
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn set_flags(sock: c_int, dev: &str, flags: &IfFlags) -> Result<(), Error> {
[INFO] [stderr]    |                                                 ^^^^^^^^ help: consider passing by value instead: `IfFlags`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |         flags: flags.clone(),
[INFO] [stderr]    |                ^^^^^^^^^^^^^ help: try dereferencing it: `*flags`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/lib.rs:264:5
[INFO] [stderr]     |
[INFO] [stderr] 264 |     name.as_ref().read_until(0, &mut vec_name).unwrap();
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: try this: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:294:81
[INFO] [stderr]     |
[INFO] [stderr] 294 |     Ok(ifaces.into_iter().map(|mut iface| (cstr_from_name(iface.name.as_mut()), iface.value.clone())).collect())
[INFO] [stderr]     |                                                                                 ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `iface.value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> examples/list_ifaces.rs:15:58
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let res = unsafe { libc::socket(PF_SOCKET, SOCK_RAW, htons(ETH_P_ALL) as c_int) };
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(htons(ETH_P_ALL))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> examples/dump_raw.rs:52:58
[INFO] [stderr]    |
[INFO] [stderr] 52 |     let res = unsafe { libc::socket(PF_SOCKET, SOCK_RAW, htons(ETH_P_ALL) as c_int) };
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(htons(ETH_P_ALL))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.61s
[INFO] running `"docker" "inspect" "32da62a2807fc25e2ce3d0678f51d51389e7df7575d07367ab94ea7e909e674d"`
[INFO] running `"docker" "rm" "-f" "32da62a2807fc25e2ce3d0678f51d51389e7df7575d07367ab94ea7e909e674d"`
[INFO] [stdout] 32da62a2807fc25e2ce3d0678f51d51389e7df7575d07367ab94ea7e909e674d