[INFO] crate netbuf 0.4.1 is already in cache [INFO] extracting crate netbuf 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/netbuf/0.4.1 [INFO] extracting crate netbuf 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netbuf/0.4.1 [INFO] validating manifest of netbuf-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of netbuf-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing netbuf-0.4.1 [INFO] finished frobbing netbuf-0.4.1 [INFO] frobbed toml for netbuf-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/netbuf/0.4.1/Cargo.toml [INFO] started frobbing netbuf-0.4.1 [INFO] finished frobbing netbuf-0.4.1 [INFO] frobbed toml for netbuf-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/netbuf/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting netbuf-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/netbuf/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d495646197267754a3635820c0e74b2ae4608c766eb1ed7effdad786100f7179 [INFO] running `"docker" "start" "-a" "d495646197267754a3635820c0e74b2ae4608c766eb1ed7effdad786100f7179"` [INFO] [stderr] Checking mockstream v0.0.2 [INFO] [stderr] Checking netbuf v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / fn future_slice<'x>(&'x mut self) -> &'x mut [u8] { [INFO] [stderr] 235 | | let rem = self.remaining(); [INFO] [stderr] 236 | | self.data.as_mut() [INFO] [stderr] 237 | | .map(|x| { [INFO] [stderr] ... | [INFO] [stderr] 241 | | .unwrap() [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/buf.rs:249:12 [INFO] [stderr] | [INFO] [stderr] 249 | if buf.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | / fn index<'x>(&'x self, index: usize) -> &'x u8 { [INFO] [stderr] 460 | | if let Some(ref data) = self.data { [INFO] [stderr] 461 | | return &data[self.consumed() + index] [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | panic!("cannot index empty buffer"); [INFO] [stderr] 464 | | [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / fn index<'x>(&'x self, _idx: RangeFull) -> &'x[u8] { [INFO] [stderr] 471 | | self.data.as_ref() [INFO] [stderr] 472 | | .map(|x| &x[self.consumed()..x.len() - self.remaining()]) [INFO] [stderr] 473 | | .unwrap_or(b"") [INFO] [stderr] 474 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:518:5 [INFO] [stderr] | [INFO] [stderr] 518 | / fn index_mut<'x>(&'x mut self, index: usize) -> &'x mut u8 { [INFO] [stderr] 519 | | let consumed = self.consumed(); [INFO] [stderr] 520 | | if let Some(ref mut data) = self.data { [INFO] [stderr] 521 | | return &mut data[consumed + index] [INFO] [stderr] 522 | | } [INFO] [stderr] 523 | | panic!("cannot index empty buffer"); [INFO] [stderr] 524 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:528:5 [INFO] [stderr] | [INFO] [stderr] 528 | / fn index_mut<'x>(&'x mut self, _idx: RangeFull) -> &'x mut[u8] { [INFO] [stderr] 529 | | let consumed = self.consumed(); [INFO] [stderr] 530 | | let remaining = self.remaining(); [INFO] [stderr] 531 | | self.data.as_mut() [INFO] [stderr] ... | [INFO] [stderr] 536 | | .unwrap_or(&mut []) [INFO] [stderr] 537 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/buf.rs:584:12 [INFO] [stderr] | [INFO] [stderr] 584 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/buf.rs:747:31 [INFO] [stderr] | [INFO] [stderr] 747 | assert_eq!(buf.len(), 1048576 + 5); [INFO] [stderr] | ^^^^^^^ help: consider: `1_048_576` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/buf.rs:749:35 [INFO] [stderr] | [INFO] [stderr] 749 | assert!(buf.capacity() <= 2100000); [INFO] [stderr] | ^^^^^^^ help: consider: `2_100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / fn future_slice<'x>(&'x mut self) -> &'x mut [u8] { [INFO] [stderr] 235 | | let rem = self.remaining(); [INFO] [stderr] 236 | | self.data.as_mut() [INFO] [stderr] 237 | | .map(|x| { [INFO] [stderr] ... | [INFO] [stderr] 241 | | .unwrap() [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/buf.rs:249:12 [INFO] [stderr] | [INFO] [stderr] 249 | if buf.len() == 0 { return; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:459:5 [INFO] [stderr] | [INFO] [stderr] 459 | / fn index<'x>(&'x self, index: usize) -> &'x u8 { [INFO] [stderr] 460 | | if let Some(ref data) = self.data { [INFO] [stderr] 461 | | return &data[self.consumed() + index] [INFO] [stderr] 462 | | } [INFO] [stderr] 463 | | panic!("cannot index empty buffer"); [INFO] [stderr] 464 | | [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:470:5 [INFO] [stderr] | [INFO] [stderr] 470 | / fn index<'x>(&'x self, _idx: RangeFull) -> &'x[u8] { [INFO] [stderr] 471 | | self.data.as_ref() [INFO] [stderr] 472 | | .map(|x| &x[self.consumed()..x.len() - self.remaining()]) [INFO] [stderr] 473 | | .unwrap_or(b"") [INFO] [stderr] 474 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:518:5 [INFO] [stderr] | [INFO] [stderr] 518 | / fn index_mut<'x>(&'x mut self, index: usize) -> &'x mut u8 { [INFO] [stderr] 519 | | let consumed = self.consumed(); [INFO] [stderr] 520 | | if let Some(ref mut data) = self.data { [INFO] [stderr] 521 | | return &mut data[consumed + index] [INFO] [stderr] 522 | | } [INFO] [stderr] 523 | | panic!("cannot index empty buffer"); [INFO] [stderr] 524 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/buf.rs:528:5 [INFO] [stderr] | [INFO] [stderr] 528 | / fn index_mut<'x>(&'x mut self, _idx: RangeFull) -> &'x mut[u8] { [INFO] [stderr] 529 | | let consumed = self.consumed(); [INFO] [stderr] 530 | | let remaining = self.remaining(); [INFO] [stderr] 531 | | self.data.as_mut() [INFO] [stderr] ... | [INFO] [stderr] 536 | | .unwrap_or(&mut []) [INFO] [stderr] 537 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/buf.rs:584:12 [INFO] [stderr] | [INFO] [stderr] 584 | if buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:774:9 [INFO] [stderr] | [INFO] [stderr] 774 | buf.write(b"hello").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:784:9 [INFO] [stderr] | [INFO] [stderr] 784 | buf.write(b" world").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:806:9 [INFO] [stderr] | [INFO] [stderr] 806 | buf.write(b" world").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:820:9 [INFO] [stderr] | [INFO] [stderr] 820 | buf.write(b" world").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:857:9 [INFO] [stderr] | [INFO] [stderr] 857 | buf.write(b"Some larger string for you").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/buf.rs:866:9 [INFO] [stderr] | [INFO] [stderr] 866 | buf.write(b" world").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `netbuf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d495646197267754a3635820c0e74b2ae4608c766eb1ed7effdad786100f7179"` [INFO] running `"docker" "rm" "-f" "d495646197267754a3635820c0e74b2ae4608c766eb1ed7effdad786100f7179"` [INFO] [stdout] d495646197267754a3635820c0e74b2ae4608c766eb1ed7effdad786100f7179