[INFO] crate net-utils 0.0.5 is already in cache [INFO] extracting crate net-utils 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/net-utils/0.0.5 [INFO] extracting crate net-utils 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/net-utils/0.0.5 [INFO] validating manifest of net-utils-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of net-utils-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing net-utils-0.0.5 [INFO] finished frobbing net-utils-0.0.5 [INFO] frobbed toml for net-utils-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/net-utils/0.0.5/Cargo.toml [INFO] started frobbing net-utils-0.0.5 [INFO] finished frobbing net-utils-0.0.5 [INFO] frobbed toml for net-utils-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/net-utils/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting net-utils-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/net-utils/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e33da7ac54f2ac2b625b72f58289e5450d0c70f1b60056867b66c82a75ea7b3 [INFO] running `"docker" "start" "-a" "1e33da7ac54f2ac2b625b72f58289e5450d0c70f1b60056867b66c82a75ea7b3"` [INFO] [stderr] Checking net-utils v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | local_address: local_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | peer_address: peer_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/conn.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | local_address: local_address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/net/config.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/net/conn.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/conn.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Err(Error::new(ErrorKind::Other, err_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, err_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(c); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/net/conn.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let err_str = format!("Failed to parse {}:{}. ", host, port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server` [INFO] [stderr] --> src/net/conn.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let server = match (host, port).to_socket_addrs() { [INFO] [stderr] | ^^^^^^ help: consider using `_server` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/net/conn.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let mut stream_socket; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_file` [INFO] [stderr] --> src/net/config.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | fn from_file(file: &str) -> Config { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/net/conn.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn get_peer_address(&self) -> &String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a method [INFO] [stderr] --> src/net/conn.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn get_local_address(&self) -> &String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self.reader.get_ref() { [INFO] [stderr] 102 | | &NetStream::UnsecuredTcpStream(ref tcp) => { [INFO] [stderr] 103 | | debug!("TCP FD:{}", tcp.as_raw_fd()); [INFO] [stderr] 104 | | if tcp.as_raw_fd() < 0 { false } else { true } [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self.reader.get_ref() { [INFO] [stderr] 102 | NetStream::UnsecuredTcpStream(ref tcp) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/net/conn.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | if tcp.as_raw_fd() < 0 { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(tcp.as_raw_fd() < 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let server =` [INFO] [stderr] --> src/net/conn.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / let server = match (host, port).to_socket_addrs() { [INFO] [stderr] 121 | | Ok(mut host_iter) => { [INFO] [stderr] 122 | | match host_iter.next() { [INFO] [stderr] 123 | | Some(mut host_addr) => return Ok(host_addr), [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | / match self { [INFO] [stderr] 343 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.read(buf), [INFO] [stderr] 344 | | #[cfg(feature = "ssl")] [INFO] [stderr] 345 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().read(buf), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 342 | match *self { [INFO] [stderr] 343 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.read(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | / match self { [INFO] [stderr] 350 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.read_exact(buf), [INFO] [stderr] 351 | | #[cfg(feature = "ssl")] [INFO] [stderr] 352 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().read_exact(buf), [INFO] [stderr] 353 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | match *self { [INFO] [stderr] 350 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.read_exact(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | / match self { [INFO] [stderr] 363 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.write(buf), [INFO] [stderr] 364 | | #[cfg(feature = "ssl")] [INFO] [stderr] 365 | | &mut NetStream::SslTcpStream(ref mut stream) => { [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 362 | match *self { [INFO] [stderr] 363 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | / match self { [INFO] [stderr] 374 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.write_all(buf), [INFO] [stderr] 375 | | #[cfg(feature = "ssl")] [INFO] [stderr] 376 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().write_all(buf), [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 373 | match *self { [INFO] [stderr] 374 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.write_all(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | / match self { [INFO] [stderr] 381 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.flush(), [INFO] [stderr] 382 | | #[cfg(feature = "ssl")] [INFO] [stderr] 383 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().flush(), [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 380 | match *self { [INFO] [stderr] 381 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/net/poolmgr.rs:186:49 [INFO] [stderr] | [INFO] [stderr] 186 | if total_count >= self.max_conns && self.tmp_conn_allowed == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.tmp_conn_allowed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/net/config.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/net/config.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::str::FromStr` [INFO] [stderr] --> src/net/conn.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::str::FromStr; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/conn.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return Err(Error::new(ErrorKind::Other, err_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Error::new(ErrorKind::Other, err_str))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | return Ok(c); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/net/poolmgr.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | return Err(e); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/net/poolmgr.rs:269:45 [INFO] [stderr] | [INFO] [stderr] 269 | fn handle_client(mut stream: TcpStream) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unreachable statement [INFO] [stderr] --> src/net/conn.rs:137:9 [INFO] [stderr] | [INFO] [stderr] 137 | let err_str = format!("Failed to parse {}:{}. ", host, port); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `server` [INFO] [stderr] --> src/net/conn.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let server = match (host, port).to_socket_addrs() { [INFO] [stderr] | ^^^^^^ help: consider using `_server` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/net/conn.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let mut stream_socket; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_file` [INFO] [stderr] --> src/net/config.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | fn from_file(file: &str) -> Config { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self.reader.get_ref() { [INFO] [stderr] 102 | | &NetStream::UnsecuredTcpStream(ref tcp) => { [INFO] [stderr] 103 | | debug!("TCP FD:{}", tcp.as_raw_fd()); [INFO] [stderr] 104 | | if tcp.as_raw_fd() < 0 { false } else { true } [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self.reader.get_ref() { [INFO] [stderr] 102 | NetStream::UnsecuredTcpStream(ref tcp) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/net/conn.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | if tcp.as_raw_fd() < 0 { false } else { true } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(tcp.as_raw_fd() < 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let server =` [INFO] [stderr] --> src/net/conn.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / let server = match (host, port).to_socket_addrs() { [INFO] [stderr] 121 | | Ok(mut host_iter) => { [INFO] [stderr] 122 | | match host_iter.next() { [INFO] [stderr] 123 | | Some(mut host_addr) => return Ok(host_addr), [INFO] [stderr] ... | [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:342:9 [INFO] [stderr] | [INFO] [stderr] 342 | / match self { [INFO] [stderr] 343 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.read(buf), [INFO] [stderr] 344 | | #[cfg(feature = "ssl")] [INFO] [stderr] 345 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().read(buf), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 342 | match *self { [INFO] [stderr] 343 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.read(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:349:9 [INFO] [stderr] | [INFO] [stderr] 349 | / match self { [INFO] [stderr] 350 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.read_exact(buf), [INFO] [stderr] 351 | | #[cfg(feature = "ssl")] [INFO] [stderr] 352 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().read_exact(buf), [INFO] [stderr] 353 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | match *self { [INFO] [stderr] 350 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.read_exact(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:362:9 [INFO] [stderr] | [INFO] [stderr] 362 | / match self { [INFO] [stderr] 363 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.write(buf), [INFO] [stderr] 364 | | #[cfg(feature = "ssl")] [INFO] [stderr] 365 | | &mut NetStream::SslTcpStream(ref mut stream) => { [INFO] [stderr] ... | [INFO] [stderr] 368 | | } [INFO] [stderr] 369 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 362 | match *self { [INFO] [stderr] 363 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:373:9 [INFO] [stderr] | [INFO] [stderr] 373 | / match self { [INFO] [stderr] 374 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.write_all(buf), [INFO] [stderr] 375 | | #[cfg(feature = "ssl")] [INFO] [stderr] 376 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().write_all(buf), [INFO] [stderr] 377 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 373 | match *self { [INFO] [stderr] 374 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.write_all(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | / match self { [INFO] [stderr] 381 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => stream.flush(), [INFO] [stderr] 382 | | #[cfg(feature = "ssl")] [INFO] [stderr] 383 | | &mut NetStream::SslTcpStream(ref mut stream) => stream.lock().unwrap().flush(), [INFO] [stderr] 384 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 380 | match *self { [INFO] [stderr] 381 | NetStream::UnsecuredTcpStream(ref mut stream) => stream.flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/net/conn.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | / match self.reader.get_mut() { [INFO] [stderr] 399 | | &mut NetStream::UnsecuredTcpStream(ref mut stream) => { [INFO] [stderr] 400 | | stream.shutdown(Shutdown::Read); [INFO] [stderr] 401 | | stream.shutdown(Shutdown::Write); [INFO] [stderr] ... | [INFO] [stderr] 406 | | } [INFO] [stderr] 407 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 398 | match *self.reader.get_mut() { [INFO] [stderr] 399 | NetStream::UnsecuredTcpStream(ref mut stream) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/net/poolmgr.rs:186:49 [INFO] [stderr] | [INFO] [stderr] 186 | if total_count >= self.max_conns && self.tmp_conn_allowed == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.tmp_conn_allowed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/net/poolmgr.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | let result = handle_client(stream); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/net/poolmgr.rs:333:9 [INFO] [stderr] | [INFO] [stderr] 333 | conn.writer.write("GET google.com\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/net/poolmgr.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | c1.writer.write("GET google.com\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `net-utils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/net_utils_example.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | conn.writer.write("GET google.com\r\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `net-utils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1e33da7ac54f2ac2b625b72f58289e5450d0c70f1b60056867b66c82a75ea7b3"` [INFO] running `"docker" "rm" "-f" "1e33da7ac54f2ac2b625b72f58289e5450d0c70f1b60056867b66c82a75ea7b3"` [INFO] [stdout] 1e33da7ac54f2ac2b625b72f58289e5450d0c70f1b60056867b66c82a75ea7b3