[INFO] crate nestools 1.3.1 is already in cache
[INFO] extracting crate nestools 1.3.1 into work/ex/clippy-test-run/sources/stable/reg/nestools/1.3.1
[INFO] extracting crate nestools 1.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nestools/1.3.1
[INFO] validating manifest of nestools-1.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nestools-1.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nestools-1.3.1
[INFO] finished frobbing nestools-1.3.1
[INFO] frobbed toml for nestools-1.3.1 written to work/ex/clippy-test-run/sources/stable/reg/nestools/1.3.1/Cargo.toml
[INFO] started frobbing nestools-1.3.1
[INFO] finished frobbing nestools-1.3.1
[INFO] frobbed toml for nestools-1.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nestools/1.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nestools-1.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nestools/1.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1906bbc2fb3ec880db7914267215da922b7279d83dbad9c31b968522b1f1b598
[INFO] running `"docker" "start" "-a" "1906bbc2fb3ec880db7914267215da922b7279d83dbad9c31b968522b1f1b598"`
[INFO] [stderr]     Checking rgb v0.8.12
[INFO] [stderr]     Checking lodepng v2.4.2
[INFO] [stderr]     Checking nestools v1.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:221:5
[INFO] [stderr]     |
[INFO] [stderr] 221 |     fn image_path<'a>(&'a self) -> &'a str;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:224:5
[INFO] [stderr]     |
[INFO] [stderr] 224 |     fn name<'a>(&'a self) -> &'a str;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:289:5
[INFO] [stderr]     |
[INFO] [stderr] 289 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 290 | |         &self.file
[INFO] [stderr] 291 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:292:5
[INFO] [stderr]     |
[INFO] [stderr] 292 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 293 | |         &self.name
[INFO] [stderr] 294 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:304:5
[INFO] [stderr]     |
[INFO] [stderr] 304 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 305 | |         &self.file
[INFO] [stderr] 306 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 308 | |         &self.name
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:319:5
[INFO] [stderr]     |
[INFO] [stderr] 319 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 320 | |         &self.file
[INFO] [stderr] 321 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 323 | |         &self.name
[INFO] [stderr] 324 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sprites/mod.rs:33:28
[INFO] [stderr]    |
[INFO] [stderr] 33 |           let output: &str = match self {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 34 | |             &Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 35 | |             &Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 36 | |             &Error::PaletteError(ref err) => &err,
[INFO] [stderr] 37 | |             &Error::FormatError(ref err) => &err,
[INFO] [stderr] 38 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |         let output: &str = match *self {
[INFO] [stderr] 34 |             Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 35 |             Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 36 |             Error::PaletteError(ref err) => &err,
[INFO] [stderr] 37 |             Error::FormatError(ref err) => &err,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sprites/mod.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         match self {
[INFO] [stderr] 46 | |             &Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 47 | |             &Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 48 | |             &Error::PaletteError(ref err) => &err,
[INFO] [stderr] 49 | |             &Error::FormatError(ref err) => &err,
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         match *self {
[INFO] [stderr] 46 |             Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 47 |             Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 48 |             Error::PaletteError(ref err) => &err,
[INFO] [stderr] 49 |             Error::FormatError(ref err) => &err,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/sprites/mod.rs:321:13
[INFO] [stderr]     |
[INFO] [stderr] 321 |         for ref tile in &self.left {
[INFO] [stderr]     |             ^^^^^^^^    ---------- help: try: `let tile = &&self.left;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/sprites/mod.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 |             writer.write(&tile.data)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/sprites/mod.rs:324:13
[INFO] [stderr]     |
[INFO] [stderr] 324 |         for ref tile in &self.right {
[INFO] [stderr]     |             ^^^^^^^^    ----------- help: try: `let tile = &&self.right;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/sprites/mod.rs:325:13
[INFO] [stderr]     |
[INFO] [stderr] 325 |             writer.write(&tile.data)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/binaries/spritesheetc.rs:223:33
[INFO] [stderr]     |
[INFO] [stderr] 223 | pub fn write_c_header(filename: &String, prefix: &str, pattern_table: &PatternTable) -> Result<(), io::Error> {
[INFO] [stderr]     |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/binaries/spritesheetc.rs:253:35
[INFO] [stderr]     |
[INFO] [stderr] 253 | pub fn write_asm_header(filename: &String, prefix: &str, pattern_table: &PatternTable) -> Result<(), io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `nestools`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:221:5
[INFO] [stderr]     |
[INFO] [stderr] 221 |     fn image_path<'a>(&'a self) -> &'a str;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:224:5
[INFO] [stderr]     |
[INFO] [stderr] 224 |     fn name<'a>(&'a self) -> &'a str;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:289:5
[INFO] [stderr]     |
[INFO] [stderr] 289 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 290 | |         &self.file
[INFO] [stderr] 291 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:292:5
[INFO] [stderr]     |
[INFO] [stderr] 292 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 293 | |         &self.name
[INFO] [stderr] 294 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:304:5
[INFO] [stderr]     |
[INFO] [stderr] 304 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 305 | |         &self.file
[INFO] [stderr] 306 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:307:5
[INFO] [stderr]     |
[INFO] [stderr] 307 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 308 | |         &self.name
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:319:5
[INFO] [stderr]     |
[INFO] [stderr] 319 | /     fn image_path<'a>(&'a self) -> &'a str {
[INFO] [stderr] 320 | |         &self.file
[INFO] [stderr] 321 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/sprites/sheet.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     fn name<'a>(&'a self) -> &'a str {
[INFO] [stderr] 323 | |         &self.name
[INFO] [stderr] 324 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sprites/mod.rs:33:28
[INFO] [stderr]    |
[INFO] [stderr] 33 |           let output: &str = match self {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 34 | |             &Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 35 | |             &Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 36 | |             &Error::PaletteError(ref err) => &err,
[INFO] [stderr] 37 | |             &Error::FormatError(ref err) => &err,
[INFO] [stderr] 38 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |         let output: &str = match *self {
[INFO] [stderr] 34 |             Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 35 |             Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 36 |             Error::PaletteError(ref err) => &err,
[INFO] [stderr] 37 |             Error::FormatError(ref err) => &err,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/sprites/mod.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         match self {
[INFO] [stderr] 46 | |             &Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 47 | |             &Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 48 | |             &Error::PaletteError(ref err) => &err,
[INFO] [stderr] 49 | |             &Error::FormatError(ref err) => &err,
[INFO] [stderr] 50 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 45 |         match *self {
[INFO] [stderr] 46 |             Error::PNGError(ref err) => err.as_str(),
[INFO] [stderr] 47 |             Error::DimensionsError(ref err) => &err,
[INFO] [stderr] 48 |             Error::PaletteError(ref err) => &err,
[INFO] [stderr] 49 |             Error::FormatError(ref err) => &err,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/sprites/mod.rs:321:13
[INFO] [stderr]     |
[INFO] [stderr] 321 |         for ref tile in &self.left {
[INFO] [stderr]     |             ^^^^^^^^    ---------- help: try: `let tile = &&self.left;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/sprites/mod.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 |             writer.write(&tile.data)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/sprites/mod.rs:324:13
[INFO] [stderr]     |
[INFO] [stderr] 324 |         for ref tile in &self.right {
[INFO] [stderr]     |             ^^^^^^^^    ----------- help: try: `let tile = &&self.right;`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/sprites/mod.rs:325:13
[INFO] [stderr]     |
[INFO] [stderr] 325 |             writer.write(&tile.data)?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/binaries/spritesheetc.rs:223:33
[INFO] [stderr]     |
[INFO] [stderr] 223 | pub fn write_c_header(filename: &String, prefix: &str, pattern_table: &PatternTable) -> Result<(), io::Error> {
[INFO] [stderr]     |                                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/binaries/spritesheetc.rs:253:35
[INFO] [stderr]     |
[INFO] [stderr] 253 | pub fn write_asm_header(filename: &String, prefix: &str, pattern_table: &PatternTable) -> Result<(), io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `nestools`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "1906bbc2fb3ec880db7914267215da922b7279d83dbad9c31b968522b1f1b598"`
[INFO] running `"docker" "rm" "-f" "1906bbc2fb3ec880db7914267215da922b7279d83dbad9c31b968522b1f1b598"`
[INFO] [stdout] 1906bbc2fb3ec880db7914267215da922b7279d83dbad9c31b968522b1f1b598