[INFO] crate nell 0.0.3 is already in cache [INFO] extracting crate nell 0.0.3 into work/ex/clippy-test-run/sources/stable/reg/nell/0.0.3 [INFO] extracting crate nell 0.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nell/0.0.3 [INFO] validating manifest of nell-0.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nell-0.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nell-0.0.3 [INFO] finished frobbing nell-0.0.3 [INFO] frobbed toml for nell-0.0.3 written to work/ex/clippy-test-run/sources/stable/reg/nell/0.0.3/Cargo.toml [INFO] started frobbing nell-0.0.3 [INFO] finished frobbing nell-0.0.3 [INFO] frobbed toml for nell-0.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nell/0.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nell-0.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nell/0.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c61dcc4704975ea0455640652e827e7f2758c244be086d07221e506a261fe98 [INFO] running `"docker" "start" "-a" "5c61dcc4704975ea0455640652e827e7f2758c244be086d07221e506a261fe98"` [INFO] [stderr] Checking eui48 v0.3.2 [INFO] [stderr] Checking nell v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/diag.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | src: src, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/diag.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | dst: dst, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/diag.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | src: src, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/diag.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | dst: dst, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api/addr.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / match head.rta_type { [INFO] [stderr] 54 | | IFLA_ADDRESS => addr.addr = ip(&data), [INFO] [stderr] 55 | | _ => (), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________^ help: try this: `if let IFLA_ADDRESS = head.rta_type { addr.addr = ip(&data) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/api/xdp.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | req.hdr.nlmsg_len += nlmsg_align(req.nla.nla_len as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(req.nla.nla_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/xdp.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | fn skip(_: &(), _: Attrs) -> Result<(), Error> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:225:40 [INFO] [stderr] | [INFO] [stderr] 225 | pub const IFF_UP: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sys.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn next(&mut self) -> Option<(&nlmsghdr, &T, Attrs)> { [INFO] [stderr] 111 | | unsafe { [INFO] [stderr] 112 | | if self.ptr < self.end { [INFO] [stderr] 113 | | let len = (*self.ptr).nlmsg_len; [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | let head = &*(head as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | self.ptr = next as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:138:22 [INFO] [stderr] | [INFO] [stderr] 138 | ptr: ptr as *const nlmsghdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | end: ptr.offset(len) as *const nlmsghdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sys.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn next(&mut self) -> Option<(&T, Data)> { [INFO] [stderr] 158 | | unsafe { [INFO] [stderr] 159 | | if self.ptr < self.end { [INFO] [stderr] 160 | | let len = Attr::len(&*(self.ptr as *const T)); [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: trait `Attr` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/sys.rs:219:1 [INFO] [stderr] | [INFO] [stderr] 219 | / pub trait Attr { [INFO] [stderr] 220 | | fn len(&self) -> usize; [INFO] [stderr] 221 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nell`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/api/addr.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / match head.rta_type { [INFO] [stderr] 54 | | IFLA_ADDRESS => addr.addr = ip(&data), [INFO] [stderr] 55 | | _ => (), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____________^ help: try this: `if let IFLA_ADDRESS = head.rta_type { addr.addr = ip(&data) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/api/xdp.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | req.hdr.nlmsg_len += nlmsg_align(req.nla.nla_len as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(req.nla.nla_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/api/xdp.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | fn skip(_: &(), _: Attrs) -> Result<(), Error> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/ffi.rs:225:40 [INFO] [stderr] | [INFO] [stderr] 225 | pub const IFF_UP: c_int = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sys.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn next(&mut self) -> Option<(&nlmsghdr, &T, Attrs)> { [INFO] [stderr] 111 | | unsafe { [INFO] [stderr] 112 | | if self.ptr < self.end { [INFO] [stderr] 113 | | let len = (*self.ptr).nlmsg_len; [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:120:30 [INFO] [stderr] | [INFO] [stderr] 120 | let head = &*(head as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:124:28 [INFO] [stderr] | [INFO] [stderr] 124 | self.ptr = next as *const _; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:138:22 [INFO] [stderr] | [INFO] [stderr] 138 | ptr: ptr as *const nlmsghdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*const ffi::nlmsghdr`) [INFO] [stderr] --> src/sys.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | end: ptr.offset(len) as *const nlmsghdr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/sys.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | / pub fn next(&mut self) -> Option<(&T, Data)> { [INFO] [stderr] 158 | | unsafe { [INFO] [stderr] 159 | | if self.ptr < self.end { [INFO] [stderr] 160 | | let len = Attr::len(&*(self.ptr as *const T)); [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: trait `Attr` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/sys.rs:219:1 [INFO] [stderr] | [INFO] [stderr] 219 | / pub trait Attr { [INFO] [stderr] 220 | | fn len(&self) -> usize; [INFO] [stderr] 221 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nell`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5c61dcc4704975ea0455640652e827e7f2758c244be086d07221e506a261fe98"` [INFO] running `"docker" "rm" "-f" "5c61dcc4704975ea0455640652e827e7f2758c244be086d07221e506a261fe98"` [INFO] [stdout] 5c61dcc4704975ea0455640652e827e7f2758c244be086d07221e506a261fe98