[INFO] crate neli 0.3.1 is already in cache [INFO] extracting crate neli 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/neli/0.3.1 [INFO] extracting crate neli 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/neli/0.3.1 [INFO] validating manifest of neli-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neli-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neli-0.3.1 [INFO] finished frobbing neli-0.3.1 [INFO] frobbed toml for neli-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/neli/0.3.1/Cargo.toml [INFO] started frobbing neli-0.3.1 [INFO] finished frobbing neli-0.3.1 [INFO] frobbed toml for neli-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/neli/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neli-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/neli/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 968d958a1ff1521ae3c9c4a7ff5db3b310a18c9046513bd706fdf983b6a16c7b [INFO] running `"docker" "start" "-a" "968d958a1ff1521ae3c9c4a7ff5db3b310a18c9046513bd706fdf983b6a16c7b"` [INFO] [stderr] Checking buffering v0.1.0 [INFO] [stderr] Checking neli v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | i if i < 0 => return Err(io::Error::last_os_error()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::last_os_error())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | i if i < 0 => return Err(io::Error::last_os_error()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::last_os_error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | i if i < 0 => return Err(io::Error::last_os_error()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::last_os_error())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/socket.rs:88:27 [INFO] [stderr] | [INFO] [stderr] 88 | i if i < 0 => return Err(io::Error::last_os_error()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(io::Error::last_os_error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | let v: u32 = 600000; [INFO] [stderr] | ^^^^^^ help: consider: `600_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:348:41 [INFO] [stderr] | [INFO] [stderr] 348 | c.write_u32::(600000).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `600_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:360:41 [INFO] [stderr] | [INFO] [stderr] 360 | c.write_u32::(600000).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `600_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:366:23 [INFO] [stderr] | [INFO] [stderr] 366 | assert_eq!(v, 600000) [INFO] [stderr] | ^^^^^^ help: consider: `600_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/socket.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | id.ok_or(NlError::new("Failed to resolve multicast group ID")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| NlError::new("Failed to resolve multicast group ID"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/nlattr.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn get_attr_handle<'a, P>(&'a self) -> AttrHandle<'a, P> { [INFO] [stderr] 126 | | AttrHandle::Bin(self.payload.as_slice()) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `nlattr::AttrHandle<'a, P>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/nlattr.rs:167:1 [INFO] [stderr] | [INFO] [stderr] 167 | / impl<'a, P> AttrHandle<'a, P> where P: PartialEq + Nl + Into + From { [INFO] [stderr] 168 | | /// Get length if attribute handle has been parsed [INFO] [stderr] 169 | | pub fn len(&self) -> Option { [INFO] [stderr] 170 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nlattr.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match opt_v { [INFO] [stderr] 201 | | Some(v) => { *self = AttrHandle::Parsed(v); }, [INFO] [stderr] 202 | | None => (), [INFO] [stderr] 203 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(v) = opt_v { *self = AttrHandle::Parsed(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | mem.write(&padding)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | let bytes: Vec = self.iter().take(input).map(|u| *u).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter().take(input).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | mem.write(&vec![0; input - num_bytes])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | mem.write(&vec![0; input - num_bytes])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `neli`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/socket.rs:235:12 [INFO] [stderr] | [INFO] [stderr] 235 | id.ok_or(NlError::new("Failed to resolve multicast group ID")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| NlError::new("Failed to resolve multicast group ID"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/nlattr.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn get_attr_handle<'a, P>(&'a self) -> AttrHandle<'a, P> { [INFO] [stderr] 126 | | AttrHandle::Bin(self.payload.as_slice()) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: item `nlattr::AttrHandle<'a, P>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/nlattr.rs:167:1 [INFO] [stderr] | [INFO] [stderr] 167 | / impl<'a, P> AttrHandle<'a, P> where P: PartialEq + Nl + Into + From { [INFO] [stderr] 168 | | /// Get length if attribute handle has been parsed [INFO] [stderr] 169 | | pub fn len(&self) -> Option { [INFO] [stderr] 170 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/nlattr.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match opt_v { [INFO] [stderr] 201 | | Some(v) => { *self = AttrHandle::Parsed(v); }, [INFO] [stderr] 202 | | None => (), [INFO] [stderr] 203 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(v) = opt_v { *self = AttrHandle::Parsed(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/genlhdr.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | c.write_all(&vec![0, 1, 2, 3, 4, 5, 0, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 1, 2, 3, 4, 5, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/genlhdr.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | c.write(&vec![65, 65, 65, 65, 65, 65, 65, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/genlhdr.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | c.write(&vec![65, 65, 65, 65, 65, 65, 65, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[65, 65, 65, 65, 65, 65, 65, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | mem.write(&padding)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | let bytes: Vec = self.iter().take(input).map(|u| *u).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.iter().take(input).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | mem.write(&vec![0; input - num_bytes])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | mem.write(&vec![0; input - num_bytes])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `neli`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "968d958a1ff1521ae3c9c4a7ff5db3b310a18c9046513bd706fdf983b6a16c7b"` [INFO] running `"docker" "rm" "-f" "968d958a1ff1521ae3c9c4a7ff5db3b310a18c9046513bd706fdf983b6a16c7b"` [INFO] [stdout] 968d958a1ff1521ae3c9c4a7ff5db3b310a18c9046513bd706fdf983b6a16c7b