[INFO] crate ndarray-npy 0.3.0 is already in cache [INFO] extracting crate ndarray-npy 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/ndarray-npy/0.3.0 [INFO] extracting crate ndarray-npy 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ndarray-npy/0.3.0 [INFO] validating manifest of ndarray-npy-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ndarray-npy-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ndarray-npy-0.3.0 [INFO] finished frobbing ndarray-npy-0.3.0 [INFO] frobbed toml for ndarray-npy-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/ndarray-npy/0.3.0/Cargo.toml [INFO] started frobbing ndarray-npy-0.3.0 [INFO] finished frobbing ndarray-npy-0.3.0 [INFO] frobbed toml for ndarray-npy-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ndarray-npy/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ndarray-npy-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ndarray-npy/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b2c21024eb58ad96a19cbf6799c83804f4650521ea96f258c112d00d8d77639 [INFO] running `"docker" "start" "-a" "0b2c21024eb58ad96a19cbf6799c83804f4650521ea96f258c112d00d8d77639"` [INFO] [stderr] Checking num-bigint v0.2.2 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking py_literal v0.2.0 [INFO] [stderr] Checking ndarray-npy v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | type_descriptor: type_descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_descriptor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | fortran_order: fortran_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fortran_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | type_descriptor: type_descriptor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_descriptor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | fortran_order: fortran_order, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fortran_order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/npy/header.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'byteorder::ByteOrder::read_f32_into_unchecked': please use `read_f32_into` instead [INFO] [stderr] --> src/npy/mod.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | $other_read_into(&bytes, &mut out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 398 | impl_primitive_multibyte!(f32, "f4", 0., read_f32_into_unchecked); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'byteorder::ByteOrder::read_f64_into_unchecked': please use `read_f64_into` instead [INFO] [stderr] --> src/npy/mod.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | $other_read_into(&bytes, &mut out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 399 | impl_primitive_multibyte!(f64, "f8", 0., read_f64_into_unchecked); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'byteorder::ByteOrder::read_f32_into_unchecked': please use `read_f32_into` instead [INFO] [stderr] --> src/npy/mod.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | $other_read_into(&bytes, &mut out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 398 | impl_primitive_multibyte!(f32, "f4", 0., read_f32_into_unchecked); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'byteorder::ByteOrder::read_f64_into_unchecked': please use `read_f64_into` instead [INFO] [stderr] --> src/npy/mod.rs:319:25 [INFO] [stderr] | [INFO] [stderr] 319 | $other_read_into(&bytes, &mut out); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 399 | impl_primitive_multibyte!(f64, "f8", 0., read_f64_into_unchecked); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/npy/header.rs:196:33 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &PyValue::Integer(ref int) = elem { [INFO] [stderr] 197 | | out.push(int.to_usize().ok_or_else(|| { [INFO] [stderr] 198 | | HeaderParseError::IllegalValue( [INFO] [stderr] 199 | | "shape".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 207 | | )); [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | if let PyValue::Integer(ref int) = *elem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/npy/header.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | .map_err(|err| HeaderParseError::from(err))?)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HeaderParseError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: item `npz::NpzReader` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/npz.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / impl NpzReader { [INFO] [stderr] 162 | | /// Creates a new `.npz` file reader. [INFO] [stderr] 163 | | pub fn new(reader: R) -> Result, ReadNpzError> { [INFO] [stderr] 164 | | Ok(NpzReader { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/npy/header.rs:196:33 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &PyValue::Integer(ref int) = elem { [INFO] [stderr] 197 | | out.push(int.to_usize().ok_or_else(|| { [INFO] [stderr] 198 | | HeaderParseError::IllegalValue( [INFO] [stderr] 199 | | "shape".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 207 | | )); [INFO] [stderr] 208 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | if let PyValue::Integer(ref int) = *elem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/npy/header.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | .map_err(|err| HeaderParseError::from(err))?)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HeaderParseError::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: item `npz::NpzReader` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/npz.rs:161:1 [INFO] [stderr] | [INFO] [stderr] 161 | / impl NpzReader { [INFO] [stderr] 162 | | /// Creates a new `.npz` file reader. [INFO] [stderr] 163 | | pub fn new(reader: R) -> Result, ReadNpzError> { [INFO] [stderr] 164 | | Ok(NpzReader { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.79s [INFO] running `"docker" "inspect" "0b2c21024eb58ad96a19cbf6799c83804f4650521ea96f258c112d00d8d77639"` [INFO] running `"docker" "rm" "-f" "0b2c21024eb58ad96a19cbf6799c83804f4650521ea96f258c112d00d8d77639"` [INFO] [stdout] 0b2c21024eb58ad96a19cbf6799c83804f4650521ea96f258c112d00d8d77639