[INFO] crate nd_lib 0.1.0 is already in cache [INFO] extracting crate nd_lib 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nd_lib/0.1.0 [INFO] extracting crate nd_lib 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nd_lib/0.1.0 [INFO] validating manifest of nd_lib-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nd_lib-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nd_lib-0.1.0 [INFO] finished frobbing nd_lib-0.1.0 [INFO] frobbed toml for nd_lib-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nd_lib/0.1.0/Cargo.toml [INFO] started frobbing nd_lib-0.1.0 [INFO] finished frobbing nd_lib-0.1.0 [INFO] frobbed toml for nd_lib-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nd_lib/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nd_lib-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nd_lib/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8946600498796b63524a84ba7712a131da45b2b60fa2e3e27780f05e7017853 [INFO] running `"docker" "start" "-a" "c8946600498796b63524a84ba7712a131da45b2b60fa2e3e27780f05e7017853"` [INFO] [stderr] Checking nd_lib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/package.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | / fs::read_dir(d) [INFO] [stderr] 215 | | .unwrap() [INFO] [stderr] 216 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 214 | fs::read_dir(d) [INFO] [stderr] 215 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/package.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | / fs::read_dir(d) [INFO] [stderr] 215 | | .unwrap() [INFO] [stderr] 216 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 214 | fs::read_dir(d) [INFO] [stderr] 215 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/package.rs:241:20 [INFO] [stderr] | [INFO] [stderr] 241 | assert_eq!(p.dependencies.unwrap().get("edon-test-a").unwrap(), "0.0.1"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.dependencies.unwrap()["edon-test-a"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/package.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | p.dependencies.unwrap().get("edon-test-a").unwrap().version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.dependencies.unwrap()["edon-test-a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/package.rs:284:13 [INFO] [stderr] | [INFO] [stderr] 284 | tree.children.get("edon-test-a").unwrap().package.name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree.children["edon-test-a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/package.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | tree.children.get("edon-test-a").unwrap().package.version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tree.children["edon-test-a"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.04s [INFO] running `"docker" "inspect" "c8946600498796b63524a84ba7712a131da45b2b60fa2e3e27780f05e7017853"` [INFO] running `"docker" "rm" "-f" "c8946600498796b63524a84ba7712a131da45b2b60fa2e3e27780f05e7017853"` [INFO] [stdout] c8946600498796b63524a84ba7712a131da45b2b60fa2e3e27780f05e7017853