[INFO] crate ncollide_testbed3d 0.5.0 is already in cache [INFO] extracting crate ncollide_testbed3d 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/ncollide_testbed3d/0.5.0 [INFO] extracting crate ncollide_testbed3d 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_testbed3d/0.5.0 [INFO] validating manifest of ncollide_testbed3d-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ncollide_testbed3d-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ncollide_testbed3d-0.5.0 [INFO] finished frobbing ncollide_testbed3d-0.5.0 [INFO] frobbed toml for ncollide_testbed3d-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/ncollide_testbed3d/0.5.0/Cargo.toml [INFO] started frobbing ncollide_testbed3d-0.5.0 [INFO] finished frobbing ncollide_testbed3d-0.5.0 [INFO] frobbed toml for ncollide_testbed3d-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_testbed3d/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ncollide_testbed3d-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ncollide_testbed3d/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc9244b2b14c38a69731696a7418bb7ec308c16176dd4b93fde2a676dfd950df [INFO] running `"docker" "start" "-a" "bc9244b2b14c38a69731696a7418bb7ec308c16176dd4b93fde2a676dfd950df"` [INFO] [stderr] Compiling freetype-sys v0.4.0 [INFO] [stderr] Checking gif v0.7.0 [INFO] [stderr] Checking png v0.4.3 [INFO] [stderr] Checking ncollide_math v0.8.0 [INFO] [stderr] Checking glfw v0.8.0 [INFO] [stderr] Checking ncollide_utils v0.8.0 [INFO] [stderr] Checking image v0.6.1 [INFO] [stderr] Checking freetype-rs v0.9.0 [INFO] [stderr] Checking ncollide_procedural v0.8.0 [INFO] [stderr] Checking ncollide_geometry v0.5.1 [INFO] [stderr] Checking kiss3d v0.10.1 [INFO] [stderr] Checking ncollide_pipeline v0.12.1 [INFO] [stderr] Checking ncollide_transformation v0.8.0 [INFO] [stderr] Checking ncollide v0.13.0 [INFO] [stderr] Checking ncollide_testbed3d v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/testbed.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics_manager.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | arc_ball: arc_ball, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_ball` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics_manager.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | first_person: first_person, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_person` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/box_node.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/box_node.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cylinder.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cylinder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cone.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cone.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/mesh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/mesh.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/convex.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/convex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/testbed.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics_manager.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | arc_ball: arc_ball, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arc_ball` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graphics_manager.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | first_person: first_person, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_person` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/box_node.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/box_node.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cylinder.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cylinder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cone.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/cone.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/mesh.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/mesh.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/convex.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/convex.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testbed.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `testbed::Testbed` [INFO] [stderr] --> src/testbed.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Testbed { [INFO] [stderr] 49 | | let graphics = GraphicsManager::new(); [INFO] [stderr] 50 | | let mut window = Window::new("nphysics: 3d demo"); [INFO] [stderr] 51 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for testbed::Testbed { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/testbed.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | let objects = obj::parse_file(&path, &empty, "").ok().expect("Unable to open the obj file."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/testbed.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | / match ray_internal::plane_toi_with_ray(ppos, pdir, &Ray::new(pos, dir)) { [INFO] [stderr] 279 | | Some(inter) => { [INFO] [stderr] 280 | | let new_pos = Isometry3::new((pos + dir * inter).coords, na::zero()); [INFO] [stderr] 281 | | world.deferred_set_position(uid, new_pos); [INFO] [stderr] 282 | | }, [INFO] [stderr] 283 | | None => { } [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 278 | if let Some(inter) = ray_internal::plane_toi_with_ray(ppos, pdir, &Ray::new(pos, dir)) { [INFO] [stderr] 279 | let new_pos = Isometry3::new((pos + dir * inter).coords, na::zero()); [INFO] [stderr] 280 | world.deferred_set_position(uid, new_pos); [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics_manager::GraphicsManager` [INFO] [stderr] --> src/graphics_manager.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> GraphicsManager { [INFO] [stderr] 37 | | let arc_ball = ArcBall::new(Point3::new(10.0, 10.0, 10.0), Point3::new(0.0, 0.0, 0.0)); [INFO] [stderr] 38 | | let first_person = FirstPerson::new(Point3::new(10.0, 10.0, 10.0), Point3::new(0.0, 0.0, 0.0)); [INFO] [stderr] 39 | | [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for graphics_manager::GraphicsManager { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics_manager.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.uid2sn.get(&uid) { [INFO] [stderr] 76 | | Some(sns) => { [INFO] [stderr] 77 | | for sn in sns.iter() { [INFO] [stderr] 78 | | window.remove(&mut sn.scene_node().clone()); [INFO] [stderr] ... | [INFO] [stderr] 81 | | None => { } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(sns) = self.uid2sn.get(&uid) { [INFO] [stderr] 76 | for sn in sns.iter() { [INFO] [stderr] 77 | window.remove(&mut sn.scene_node().clone()); [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/graphics_manager.rs:174:40 [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, object.clone(), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, &(*object).clone(), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, &ncollide::world::CollisionObject, na::Isometry>>, T>::clone(object), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/objects/plane.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / let up; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if world_normal.z.is_zero() && world_normal.y.is_zero() { [INFO] [stderr] 31 | | up = Vector3::z(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | up = Vector3::x(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let up = if world_normal.z.is_zero() && world_normal.y.is_zero() { Vector3::z() } else { Vector3::x() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/testbed.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_testbed3d`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `testbed::Testbed` [INFO] [stderr] --> src/testbed.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Testbed { [INFO] [stderr] 49 | | let graphics = GraphicsManager::new(); [INFO] [stderr] 50 | | let mut window = Window::new("nphysics: 3d demo"); [INFO] [stderr] 51 | | [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for testbed::Testbed { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/testbed.rs:86:23 [INFO] [stderr] | [INFO] [stderr] 86 | let objects = obj::parse_file(&path, &empty, "").ok().expect("Unable to open the obj file."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/testbed.rs:278:25 [INFO] [stderr] | [INFO] [stderr] 278 | / match ray_internal::plane_toi_with_ray(ppos, pdir, &Ray::new(pos, dir)) { [INFO] [stderr] 279 | | Some(inter) => { [INFO] [stderr] 280 | | let new_pos = Isometry3::new((pos + dir * inter).coords, na::zero()); [INFO] [stderr] 281 | | world.deferred_set_position(uid, new_pos); [INFO] [stderr] 282 | | }, [INFO] [stderr] 283 | | None => { } [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 278 | if let Some(inter) = ray_internal::plane_toi_with_ray(ppos, pdir, &Ray::new(pos, dir)) { [INFO] [stderr] 279 | let new_pos = Isometry3::new((pos + dir * inter).coords, na::zero()); [INFO] [stderr] 280 | world.deferred_set_position(uid, new_pos); [INFO] [stderr] 281 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `graphics_manager::GraphicsManager` [INFO] [stderr] --> src/graphics_manager.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> GraphicsManager { [INFO] [stderr] 37 | | let arc_ball = ArcBall::new(Point3::new(10.0, 10.0, 10.0), Point3::new(0.0, 0.0, 0.0)); [INFO] [stderr] 38 | | let first_person = FirstPerson::new(Point3::new(10.0, 10.0, 10.0), Point3::new(0.0, 0.0, 0.0)); [INFO] [stderr] 39 | | [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | impl Default for graphics_manager::GraphicsManager { [INFO] [stderr] 36 | fn default() -> Self { [INFO] [stderr] 37 | Self::new() [INFO] [stderr] 38 | } [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/graphics_manager.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.uid2sn.get(&uid) { [INFO] [stderr] 76 | | Some(sns) => { [INFO] [stderr] 77 | | for sn in sns.iter() { [INFO] [stderr] 78 | | window.remove(&mut sn.scene_node().clone()); [INFO] [stderr] ... | [INFO] [stderr] 81 | | None => { } [INFO] [stderr] 82 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(sns) = self.uid2sn.get(&uid) { [INFO] [stderr] 76 | for sn in sns.iter() { [INFO] [stderr] 77 | window.remove(&mut sn.scene_node().clone()); [INFO] [stderr] 78 | } [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/graphics_manager.rs:174:40 [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, object.clone(), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, &(*object).clone(), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 174 | self.add_shape(window, &ncollide::world::CollisionObject, na::Isometry>>, T>::clone(object), delta * t, s.as_ref(), color, out) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/objects/plane.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / let up; [INFO] [stderr] 29 | | [INFO] [stderr] 30 | | if world_normal.z.is_zero() && world_normal.y.is_zero() { [INFO] [stderr] 31 | | up = Vector3::z(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | up = Vector3::x(); [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let up = if world_normal.z.is_zero() && world_normal.y.is_zero() { Vector3::z() } else { Vector3::x() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_testbed3d`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bc9244b2b14c38a69731696a7418bb7ec308c16176dd4b93fde2a676dfd950df"` [INFO] running `"docker" "rm" "-f" "bc9244b2b14c38a69731696a7418bb7ec308c16176dd4b93fde2a676dfd950df"` [INFO] [stdout] bc9244b2b14c38a69731696a7418bb7ec308c16176dd4b93fde2a676dfd950df