[INFO] crate ncollide_geometry 0.6.3 is already in cache [INFO] extracting crate ncollide_geometry 0.6.3 into work/ex/clippy-test-run/sources/stable/reg/ncollide_geometry/0.6.3 [INFO] extracting crate ncollide_geometry 0.6.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_geometry/0.6.3 [INFO] validating manifest of ncollide_geometry-0.6.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ncollide_geometry-0.6.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ncollide_geometry-0.6.3 [INFO] finished frobbing ncollide_geometry-0.6.3 [INFO] frobbed toml for ncollide_geometry-0.6.3 written to work/ex/clippy-test-run/sources/stable/reg/ncollide_geometry/0.6.3/Cargo.toml [INFO] started frobbing ncollide_geometry-0.6.3 [INFO] finished frobbing ncollide_geometry-0.6.3 [INFO] frobbed toml for ncollide_geometry-0.6.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_geometry/0.6.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ncollide_geometry-0.6.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ncollide_geometry/0.6.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 124912d674dbf8014d7951f7f69a8d60edb217ab2107f4cac333b3fd4cd4104d [INFO] running `"docker" "start" "-a" "124912d674dbf8014d7951f7f69a8d60edb217ab2107f4cac333b3fd4cd4104d"` [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking ncollide_math v0.9.0 [INFO] [stderr] Checking ncollide_utils v0.9.0 [INFO] [stderr] Checking ncollide_geometry v0.6.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/plane.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | Plane { normal: normal } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cuboid.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | half_extents: half_extents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | orig1: orig1, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | orig2: orig2, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let _0_5: P::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | let _0_5: P::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/ball.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | Ball { radius: radius } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/reflection.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | Reflection { shape: shape } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | major_radius: major_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | minor_radius: minor_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | shapes: shapes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shapes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/convex.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | ConvexHull { points: points } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_volume_bvt.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | bv: bv, [INFO] [stderr] | ^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | maxs: maxs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/bvt_visitor.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bv: bv, [INFO] [stderr] | ^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | sub_determinants: sub_determinants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_determinants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | num_leaves: num_leaves, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_leaves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> query/algorithms/epa3.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/algorithms/epa2.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | world1: world1, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `world1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | world2: world2, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `world2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | margin: margin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vel1: vel1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vel1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | vel2: vel2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vel2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | toi: toi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | toi: toi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_ball.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let _0_5: V::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let d = na::dot(&n, &ray.dir); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let t = na::dot(&ap, &n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let e = -utils::cross3(&ray.dir, &ap); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | let mut v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_compound.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_compound.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_query.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | is_inside: is_inside, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_inside` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_query.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_segment.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let p = m.inverse_transform_point(pt); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_triangle.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | let v = ab_ap / na::norm_squared(&ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let w = ac_ap / na::norm_squared(&ac); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:240:21 [INFO] [stderr] | [INFO] [stderr] 240 | let w = na::dot(&bc, &bp) / na::norm_squared(&bc); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | let v = vb * denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | let w = vc * denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let v = ab_ap / (ab_ap - ab_bp); // proj on ab = a + ab * v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:282:17 [INFO] [stderr] | [INFO] [stderr] 282 | let w = ac_ap / (ac_ap - ac_cp); // proj on ac = a + ac * w [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | let u = (ac_bp - ab_bp) / (ac_bp - ab_bp + ab_cp - ac_cp); // proj on bc = b + bc * u [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | let u = ap_ab / ab_ab; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | m: &M, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:446:17 [INFO] [stderr] | [INFO] [stderr] 446 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:449:21 [INFO] [stderr] | [INFO] [stderr] 449 | let n = utils::cross3(ab, ac); // FIXME: is is possible to avoid this cross product? [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_compound.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_bvt.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/plane.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | Plane { normal: normal } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cuboid.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | half_extents: half_extents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | orig1: orig1, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:157:13 [INFO] [stderr] | [INFO] [stderr] 157 | orig2: orig2, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let _0_5: P::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | let _0_5: P::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/ball.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | Ball { radius: radius } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/reflection.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | Reflection { shape: shape } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | major_radius: major_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | minor_radius: minor_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | shapes: shapes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shapes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/convex.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | ConvexHull { points: points } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_volume_bvt.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | bv: bv, [INFO] [stderr] | ^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | maxs: maxs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/bvt_visitor.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | bv: bv, [INFO] [stderr] | ^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | sub_determinants: sub_determinants, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_determinants` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | num_leaves: num_leaves, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_leaves` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> query/algorithms/epa3.rs:401:9 [INFO] [stderr] | [INFO] [stderr] 401 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/algorithms/epa2.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | world1: world1, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `world1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | world2: world2, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `world2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/contacts_internal/contact.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | depth: depth, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/distance_internal/composite_shape_against_shape.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/proximity_internal/composite_shape_against_shape.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | margin: margin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | m1: m1, [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vel1: vel1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vel1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | g1: g1, [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | m2: m2, [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | vel2: vel2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vel2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/time_of_impact_internal/composite_shape_against_shape.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | g2: g2, [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | toi: toi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | toi: toi, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `toi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_ball.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let _0_5: V::Real = na::convert(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | let d = na::dot(&n, &ray.dir); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | let t = na::dot(&ap, &n); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | let e = -utils::cross3(&ray.dir, &ap); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | let mut v; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut w; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_compound.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_compound.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/ray_internal/ray_bvt.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ray: ray, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_query.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | is_inside: is_inside, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_inside` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_query.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_segment.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | let p = m.inverse_transform_point(pt); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_triangle.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | let _1 = na::one::(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | let v = ab_ap / na::norm_squared(&ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let w = ac_ap / na::norm_squared(&ac); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:240:21 [INFO] [stderr] | [INFO] [stderr] 240 | let w = na::dot(&bc, &bp) / na::norm_squared(&bc); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:254:25 [INFO] [stderr] | [INFO] [stderr] 254 | let v = vb * denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:255:25 [INFO] [stderr] | [INFO] [stderr] 255 | let w = vc * denom; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let v = ab_ap / (ab_ap - ab_bp); // proj on ab = a + ab * v [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:282:17 [INFO] [stderr] | [INFO] [stderr] 282 | let w = ac_ap / (ac_ap - ac_cp); // proj on ac = a + ac * w [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_triangle.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | let u = (ac_bp - ab_bp) / (ac_bp - ab_bp + ab_cp - ac_cp); // proj on bc = b + bc * u [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | let u = ap_ab / ab_ab; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:428:13 [INFO] [stderr] | [INFO] [stderr] 428 | m: &M, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | let _0: P::Real = na::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:446:17 [INFO] [stderr] | [INFO] [stderr] 446 | let _1: P::Real = na::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:449:21 [INFO] [stderr] | [INFO] [stderr] 449 | let n = utils::cross3(ab, ac); // FIXME: is is possible to avoid this cross product? [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_compound.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | solid: solid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `solid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> query/point_internal/point_bvt.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> shape/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | pub mod shape; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> shape/plane.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | use na::{self, Unit}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> lib.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> shape/triangle.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | if d2 > d3 { [INFO] [stderr] 97 | | self.b() [INFO] [stderr] 98 | | } else { [INFO] [stderr] 99 | | self.c() [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if d2 > d3 { [INFO] [stderr] 96 | self.b() [INFO] [stderr] 97 | } else { [INFO] [stderr] 98 | self.c() [INFO] [stderr] 99 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> bounding_volume/mod.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub mod bounding_volume; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/epa3.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return self.faces[best_face_id.id].proj; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.faces[best_face_id.id].proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `query::algorithms::gjk` [INFO] [stderr] --> query/algorithms/epa2.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use query::algorithms::gjk; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/epa2.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return self.faces[best_face_id.id].proj; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.faces[best_face_id.id].proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `NormedSpace` [INFO] [stderr] --> query/contacts_internal/support_map_against_support_map.rs:3:20 [INFO] [stderr] | [INFO] [stderr] 3 | use alga::linear::{NormedSpace, Translation}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 196 | | if near_diag { [INFO] [stderr] 197 | | Some((tmin, -na::normalize(&ray.dir), near_side)) [INFO] [stderr] 198 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | } else if near_diag { [INFO] [stderr] 196 | Some((tmin, -na::normalize(&ray.dir), near_side)) [INFO] [stderr] 197 | } else { [INFO] [stderr] 198 | let mut normal = na::zero::(); [INFO] [stderr] 199 | [INFO] [stderr] 200 | if near_side < 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 181 | | if far_diag { [INFO] [stderr] 182 | | Some((tmax, -na::normalize(&ray.dir), far_side)) [INFO] [stderr] 183 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 180 | } else if far_diag { [INFO] [stderr] 181 | Some((tmax, -na::normalize(&ray.dir), far_side)) [INFO] [stderr] 182 | } else { [INFO] [stderr] 183 | let mut normal = na::zero::(); [INFO] [stderr] 184 | [INFO] [stderr] 185 | if far_side < 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_mesh.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 113 | | if na::dot(&n123, &ls_ray.dir) > na::zero() { [INFO] [stderr] 114 | | Some(RayIntersection::new_with_uvs( [INFO] [stderr] 115 | | toi, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if na::dot(&n123, &ls_ray.dir) > na::zero() { [INFO] [stderr] 113 | Some(RayIntersection::new_with_uvs( [INFO] [stderr] 114 | toi, [INFO] [stderr] 115 | -m.rotate_vector(&n123), [INFO] [stderr] 116 | Some(Point2::new(uvx, uvy)), [INFO] [stderr] 117 | )) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `On` [INFO] [stderr] --> query/point_internal/point_triangle.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / enum ProjectionInfo { [INFO] [stderr] 111 | | OnAB, [INFO] [stderr] 112 | | OnAC, [INFO] [stderr] 113 | | OnBC, [INFO] [stderr] 114 | | OnFace(N, N, N), [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/point_internal/point_triangle.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 310 | | if d_ac < d_bc { [INFO] [stderr] 311 | | // ac [INFO] [stderr] 312 | | let bcoords = [_1 - w, w]; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 309 | } else if d_ac < d_bc { [INFO] [stderr] 310 | // ac [INFO] [stderr] 311 | let bcoords = [_1 - w, w]; [INFO] [stderr] 312 | proj = a; [INFO] [stderr] 313 | proj.axpy(bcoords[1], &c, bcoords[0]); [INFO] [stderr] 314 | proj = m.transform_point(&proj); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:573:9 [INFO] [stderr] | [INFO] [stderr] 573 | return (proj, TetrahedronPointLocation::OnSolid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(proj, TetrahedronPointLocation::OnSolid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> shape/mod.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | pub mod shape; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> shape/plane.rs:3:10 [INFO] [stderr] | [INFO] [stderr] 3 | use na::{self, Unit}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> lib.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> shape/triangle.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | if d2 > d3 { [INFO] [stderr] 97 | | self.b() [INFO] [stderr] 98 | | } else { [INFO] [stderr] 99 | | self.c() [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if d2 > d3 { [INFO] [stderr] 96 | self.b() [INFO] [stderr] 97 | } else { [INFO] [stderr] 98 | self.c() [INFO] [stderr] 99 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> bounding_volume/mod.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | pub mod bounding_volume; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:408:9 [INFO] [stderr] | [INFO] [stderr] 408 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/epa3.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | return self.faces[best_face_id.id].proj; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.faces[best_face_id.id].proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `query::algorithms::gjk` [INFO] [stderr] --> query/algorithms/epa2.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use query::algorithms::gjk; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/algorithms/epa2.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return self.faces[best_face_id.id].proj; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.faces[best_face_id.id].proj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `NormedSpace` [INFO] [stderr] --> query/contacts_internal/support_map_against_support_map.rs:3:20 [INFO] [stderr] | [INFO] [stderr] 3 | use alga::linear::{NormedSpace, Translation}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 196 | | if near_diag { [INFO] [stderr] 197 | | Some((tmin, -na::normalize(&ray.dir), near_side)) [INFO] [stderr] 198 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 207 | | } [INFO] [stderr] 208 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 195 | } else if near_diag { [INFO] [stderr] 196 | Some((tmin, -na::normalize(&ray.dir), near_side)) [INFO] [stderr] 197 | } else { [INFO] [stderr] 198 | let mut normal = na::zero::(); [INFO] [stderr] 199 | [INFO] [stderr] 200 | if near_side < 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_aabb.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 181 | | if far_diag { [INFO] [stderr] 182 | | Some((tmax, -na::normalize(&ray.dir), far_side)) [INFO] [stderr] 183 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 180 | } else if far_diag { [INFO] [stderr] 181 | Some((tmax, -na::normalize(&ray.dir), far_side)) [INFO] [stderr] 182 | } else { [INFO] [stderr] 183 | let mut normal = na::zero::(); [INFO] [stderr] 184 | [INFO] [stderr] 185 | if far_side < 0 { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/ray_internal/ray_mesh.rs:112:32 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 113 | | if na::dot(&n123, &ls_ray.dir) > na::zero() { [INFO] [stderr] 114 | | Some(RayIntersection::new_with_uvs( [INFO] [stderr] 115 | | toi, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if na::dot(&n123, &ls_ray.dir) > na::zero() { [INFO] [stderr] 113 | Some(RayIntersection::new_with_uvs( [INFO] [stderr] 114 | toi, [INFO] [stderr] 115 | -m.rotate_vector(&n123), [INFO] [stderr] 116 | Some(Point2::new(uvx, uvy)), [INFO] [stderr] 117 | )) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `On` [INFO] [stderr] --> query/point_internal/point_triangle.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / enum ProjectionInfo { [INFO] [stderr] 111 | | OnAB, [INFO] [stderr] 112 | | OnAC, [INFO] [stderr] 113 | | OnBC, [INFO] [stderr] 114 | | OnFace(N, N, N), [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_triangle.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | return ProjectionInfo::OnFace(va, vb, vc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProjectionInfo::OnFace(va, vb, vc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> query/point_internal/point_triangle.rs:309:20 [INFO] [stderr] | [INFO] [stderr] 309 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 310 | | if d_ac < d_bc { [INFO] [stderr] 311 | | // ac [INFO] [stderr] 312 | | let bcoords = [_1 - w, w]; [INFO] [stderr] ... | [INFO] [stderr] 324 | | } [INFO] [stderr] 325 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 309 | } else if d_ac < d_bc { [INFO] [stderr] 310 | // ac [INFO] [stderr] 311 | let bcoords = [_1 - w, w]; [INFO] [stderr] 312 | proj = a; [INFO] [stderr] 313 | proj.axpy(bcoords[1], &c, bcoords[0]); [INFO] [stderr] 314 | proj = m.transform_point(&proj); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:573:9 [INFO] [stderr] | [INFO] [stderr] 573 | return (proj, TetrahedronPointLocation::OnSolid); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(proj, TetrahedronPointLocation::OnSolid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:479:13 [INFO] [stderr] | [INFO] [stderr] 479 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `aabb` which has no body [INFO] [stderr] --> shape/shape.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `type_id` which has no body [INFO] [stderr] --> shape/shape.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `half_extents`. [INFO] [stderr] --> shape/cuboid.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..na::dimension::() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for in half_extents.iter().take(na::dimension::()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / pub fn point<'r>(&'r self) -> &'r P { [INFO] [stderr] 165 | | &self.point [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:279:29 [INFO] [stderr] | [INFO] [stderr] 279 | self.orig1 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | self.orig2 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> shape/minkowski_sum.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | / fn ne(&self, other: &AnnotatedPoint

) -> bool { [INFO] [stderr] 354 | | self.point != other.point [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 2] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 3] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/triangle.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 3] as *const shape::triangle::Triangle

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/triangle.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::triangle::Triangle

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/tetrahedron.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::tetrahedron::Tetrahedron

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: item `shape::base_mesh::BaseMesh` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> shape/base_mesh.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / impl BaseMesh [INFO] [stderr] 94 | | where [INFO] [stderr] 95 | | P: Point, [INFO] [stderr] 96 | | { [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> shape/cone.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> shape/cylinder.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | self.mins = self.mins + utils::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += utils::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | self.maxs = self.maxs + utils::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += utils::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | self.mins = self.mins + utils::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += utils::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | self.maxs = self.maxs + utils::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += utils::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.radius = self.radius + amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius += amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | self.radius = self.radius - amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius -= amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> partitioning/dbvt.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `partitioning::dbvt::DBVT` [INFO] [stderr] --> partitioning/dbvt.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn new() -> DBVT { [INFO] [stderr] 126 | | DBVT { [INFO] [stderr] 127 | | root: DBVTNodeId::Leaf(0), [INFO] [stderr] 128 | | leaves: SparseVec::new(), [INFO] [stderr] 129 | | internals: SparseVec::new(), [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for partitioning::dbvt::DBVT { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self.tree { [INFO] [stderr] 59 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 60 | | None => {} [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match (&self.tree, &other.tree) { [INFO] [stderr] 67 | | (&Some(ref ta), &Some(ref tb)) => ta.visit_bvtt(tb, visitor), [INFO] [stderr] 68 | | _ => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let (&Some(ref ta), &Some(ref tb)) = (&self.tree, &other.tree) { ta.visit_bvtt(tb, visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn root_bounding_volume<'r>(&'r self) -> Option<&'r BV> { [INFO] [stderr] 93 | | match self.tree { [INFO] [stderr] 94 | | Some(ref n) => match *n { [INFO] [stderr] 95 | | BVTNode::Internal(ref bv, _, _) => Some(bv), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:171:16 [INFO] [stderr] | [INFO] [stderr] 171 | if left.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | } else if right.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / pub fn bounding_volume<'a>(&'a self) -> &'a BV { [INFO] [stderr] 215 | | match *self { [INFO] [stderr] 216 | | BVTNode::Internal(ref bv, _, _) => bv, [INFO] [stderr] 217 | | BVTNode::Leaf(ref bv, _) => bv, [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> partitioning/bvt.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / loop { [INFO] [stderr] 284 | | match queue.pop() { [INFO] [stderr] 285 | | Some(node) => { [INFO] [stderr] 286 | | if -node.cost >= best_cost { [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(node) = queue.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:292:29 [INFO] [stderr] | [INFO] [stderr] 292 | / match algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 293 | | Some(lcost) => { [INFO] [stderr] 294 | | if lcost < best_cost { [INFO] [stderr] 295 | | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] ... | [INFO] [stderr] 298 | | None => {} [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 292 | if let Some(lcost) = algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 293 | if lcost < best_cost { [INFO] [stderr] 294 | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] 295 | } [INFO] [stderr] 296 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:301:29 [INFO] [stderr] | [INFO] [stderr] 301 | / match algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 302 | | Some(rcost) => { [INFO] [stderr] 303 | | if rcost < best_cost { [INFO] [stderr] 304 | | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] ... | [INFO] [stderr] 307 | | None => {} [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 301 | if let Some(rcost) = algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 302 | if rcost < best_cost { [INFO] [stderr] 303 | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] 304 | } [INFO] [stderr] 305 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:310:52 [INFO] [stderr] | [INFO] [stderr] 310 | BVTNode::Leaf(_, ref b) => match algorithm.compute_b_cost(b) { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 311 | | Some((candidate_cost, candidate_result)) => { [INFO] [stderr] 312 | | if candidate_cost < best_cost { [INFO] [stderr] 313 | | best_cost = candidate_cost; [INFO] [stderr] ... | [INFO] [stderr] 317 | | None => {} [INFO] [stderr] 318 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | BVTNode::Leaf(_, ref b) => if let Some((candidate_cost, candidate_result)) = algorithm.compute_b_cost(b) { [INFO] [stderr] 311 | if candidate_cost < best_cost { [INFO] [stderr] 312 | best_cost = candidate_cost; [INFO] [stderr] 313 | result = Some((b, candidate_result)); [INFO] [stderr] 314 | } [INFO] [stderr] 315 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for dimension in 0usize..dimension + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=dimension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0usize..dimension + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | num_added = num_added + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_added += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | determinant_index = determinant_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | for k in 0usize..last_num_points + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=last_num_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | determinant_index = determinant_index + if i == 0 { 0 } else { 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant_index += if i == 0 { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | last_dim_end = last_dim_end + num_added; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_dim_end += num_added` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | last_num_points = last_num_points - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_num_points -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | sub_determinants.push(*map.get(&vec![max_num_points - 1 - i]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&vec![max_num_points - 1 - i]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:265:25 [INFO] [stderr] | [INFO] [stderr] 265 | determinant = determinant + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant += delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | *self.determinants [INFO] [stderr] | ______________________^ [INFO] [stderr] 269 | | .as_mut_ptr() [INFO] [stderr] 270 | | .offset(*recursion.sub_determinants[..].get_unchecked(curr) as isize) = [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 268 | *self.determinants [INFO] [stderr] 269 | .as_mut_ptr().add(*recursion.sub_determinants[..].get_unchecked(curr)) = [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | curr_num_pts = curr_num_pts + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr_num_pts += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | *self.determinants.as_mut_ptr().offset(subdetid as isize) = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.determinants.as_mut_ptr().add(subdetid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:336:29 [INFO] [stderr] | [INFO] [stderr] 336 | total_det = total_det + det; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_det += det` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | curr = curr - curr_num_pts * curr_num_pts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr -= curr_num_pts * curr_num_pts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | curr_num_pts = curr_num_pts - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr_num_pts -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `query::algorithms::voronoi_simplex2::VoronoiSimplex2

` [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> VoronoiSimplex2

{ [INFO] [stderr] 16 | | VoronoiSimplex2 { [INFO] [stderr] 17 | | vertices: [P::origin(); 3], [INFO] [stderr] 18 | | dim: 0, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for query::algorithms::voronoi_simplex2::VoronoiSimplex2

{ [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `query::algorithms::voronoi_simplex3::VoronoiSimplex3

` [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> VoronoiSimplex3

{ [INFO] [stderr] 20 | | VoronoiSimplex3 { [INFO] [stderr] 21 | | vertices: [P::origin(); 4], [INFO] [stderr] 22 | | dim: 0, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for query::algorithms::voronoi_simplex3::VoronoiSimplex3

{ [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:208:18 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:224:18 [INFO] [stderr] | [INFO] [stderr] 224 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> query/algorithms/gjk.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | assert!(min_bound == min_bound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/gjk.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | niter = niter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `niter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/gjk.rs:390:21 [INFO] [stderr] | [INFO] [stderr] 390 | ltoi = ltoi + t; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `ltoi += t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> query/algorithms/gjk.rs:417:64 [INFO] [stderr] | [INFO] [stderr] 417 | } else if max_bound <= _eps_tol * simplex.max_sq_len() { [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 418 | | // Return ldir: the last projection plane is tangeant to the intersected surface. [INFO] [stderr] 419 | | return Some((ltoi, ldir)); [INFO] [stderr] 420 | | } else if max_bound >= old_max_bound { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> query/algorithms/gjk.rs:415:46 [INFO] [stderr] | [INFO] [stderr] 415 | if simplex.dimension() == _dimension { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 416 | | return Some((ltoi, ldir)); [INFO] [stderr] 417 | | } else if max_bound <= _eps_tol * simplex.max_sq_len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `aabb` which has no body [INFO] [stderr] --> shape/shape.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::algorithms::epa3::EPA3

` [INFO] [stderr] --> query/algorithms/epa3.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn new() -> Self { [INFO] [stderr] 148 | | EPA3 { [INFO] [stderr] 149 | | vertices: Vec::new(), [INFO] [stderr] 150 | | faces: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `type_id` which has no body [INFO] [stderr] --> shape/shape.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/epa3.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..simplex.dimension() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=simplex.dimension()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `half_extents`. [INFO] [stderr] --> shape/cuboid.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | for i in 0..na::dimension::() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 20 | for in half_extents.iter().take(na::dimension::()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | / pub fn point<'r>(&'r self) -> &'r P { [INFO] [stderr] 165 | | &self.point [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:279:29 [INFO] [stderr] | [INFO] [stderr] 279 | self.orig1 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:280:29 [INFO] [stderr] | [INFO] [stderr] 280 | self.orig2 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> shape/minkowski_sum.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | / fn ne(&self, other: &AnnotatedPoint

) -> bool { [INFO] [stderr] 354 | | self.point != other.point [INFO] [stderr] 355 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::algorithms::epa2::EPA2

` [INFO] [stderr] --> query/algorithms/epa2.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Self { [INFO] [stderr] 104 | | EPA2 { [INFO] [stderr] 105 | | vertices: Vec::new(), [INFO] [stderr] 106 | | faces: Vec::new(), [INFO] [stderr] 107 | | heap: BinaryHeap::new(), [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/epa2.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | for i in 0..simplex.dimension() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=simplex.dimension()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> query/algorithms/epa2.rs:244:37 [INFO] [stderr] | [INFO] [stderr] 244 | for (i, f) in new_faces.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 2] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:29:18 [INFO] [stderr] | [INFO] [stderr] 29 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 3] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/segment.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::segment::Segment

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/triangle.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 3] as *const shape::triangle::Triangle

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/triangle.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::triangle::Triangle

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/minkowski_sampling.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | simplex.modify_pnts(&|pt| *pt = *pt + (-shift)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pt += (-shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> query/contacts_internal/ball_against_ball.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / let mut normal = Unit::new_normalize(delta_pos); [INFO] [stderr] 31 | | [INFO] [stderr] 32 | | if distance_squared.is_zero() { [INFO] [stderr] 33 | | normal = Unit::new_unchecked(P::Vector::canonical_basis_element(0)); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let normal = if distance_squared.is_zero() { Unit::new_unchecked(P::Vector::canonical_basis_element(0)) } else { Unit::new_normalize(delta_pos) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> shape/tetrahedron.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | unsafe { mem::transmute(arr) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `&*(arr as *const [P; 4] as *const shape::tetrahedron::Tetrahedron

)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> query/contacts_internal/composite_shape_against_shape.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | g1.map_part_at(i, &mut |_, part| match contacts_internal::contact_internal( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 93 | | m1, [INFO] [stderr] 94 | | part, [INFO] [stderr] 95 | | m2, [INFO] [stderr] ... | [INFO] [stderr] 109 | | None => {} [INFO] [stderr] 110 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | g1.map_part_at(i, &mut |_, part| if let Some(c) = contacts_internal::contact_internal( [INFO] [stderr] 93 | m1, [INFO] [stderr] 94 | part, [INFO] [stderr] 95 | m2, [INFO] [stderr] 96 | g2, [INFO] [stderr] 97 | prediction, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: item `shape::base_mesh::BaseMesh` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> shape/base_mesh.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / impl BaseMesh [INFO] [stderr] 94 | | where [INFO] [stderr] 95 | | P: Point, [INFO] [stderr] 96 | | { [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `toi_and_normal_with_ray` which has no body [INFO] [stderr] --> query/ray_internal/ray.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> shape/cone.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> shape/cylinder.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | self.mins = self.mins + utils::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += utils::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | self.maxs = self.maxs + utils::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += utils::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | self.mins = self.mins + utils::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += utils::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | self.maxs = self.maxs + utils::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += utils::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.radius = self.radius + amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius += amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | self.radius = self.radius - amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius -= amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> partitioning/dbvt.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn is_invalid(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `partitioning::dbvt::DBVT` [INFO] [stderr] --> partitioning/dbvt.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn new() -> DBVT { [INFO] [stderr] 126 | | DBVT { [INFO] [stderr] 127 | | root: DBVTNodeId::Leaf(0), [INFO] [stderr] 128 | | leaves: SparseVec::new(), [INFO] [stderr] 129 | | internals: SparseVec::new(), [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 123 | impl Default for partitioning::dbvt::DBVT { [INFO] [stderr] 124 | fn default() -> Self { [INFO] [stderr] 125 | Self::new() [INFO] [stderr] 126 | } [INFO] [stderr] 127 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self.tree { [INFO] [stderr] 59 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 60 | | None => {} [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ) -> Option<(RayIntersection, Vector3)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match (&self.tree, &other.tree) { [INFO] [stderr] 67 | | (&Some(ref ta), &Some(ref tb)) => ta.visit_bvtt(tb, visitor), [INFO] [stderr] 68 | | _ => {} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ help: try this: `if let (&Some(ref ta), &Some(ref tb)) = (&self.tree, &other.tree) { ta.visit_bvtt(tb, visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / pub fn root_bounding_volume<'r>(&'r self) -> Option<&'r BV> { [INFO] [stderr] 93 | | match self.tree { [INFO] [stderr] 94 | | Some(ref n) => match *n { [INFO] [stderr] 95 | | BVTNode::Internal(ref bv, _, _) => Some(bv), [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | v = v * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | w = w * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `w *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | v = v * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | w = w * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `w *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:171:16 [INFO] [stderr] | [INFO] [stderr] 171 | if left.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:173:23 [INFO] [stderr] | [INFO] [stderr] 173 | } else if right.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:214:5 [INFO] [stderr] | [INFO] [stderr] 214 | / pub fn bounding_volume<'a>(&'a self) -> &'a BV { [INFO] [stderr] 215 | | match *self { [INFO] [stderr] 216 | | BVTNode::Internal(ref bv, _, _) => bv, [INFO] [stderr] 217 | | BVTNode::Leaf(ref bv, _) => bv, [INFO] [stderr] 218 | | } [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> partitioning/bvt.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | / loop { [INFO] [stderr] 284 | | match queue.pop() { [INFO] [stderr] 285 | | Some(node) => { [INFO] [stderr] 286 | | if -node.cost >= best_cost { [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(node) = queue.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:292:29 [INFO] [stderr] | [INFO] [stderr] 292 | / match algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 293 | | Some(lcost) => { [INFO] [stderr] 294 | | if lcost < best_cost { [INFO] [stderr] 295 | | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] ... | [INFO] [stderr] 298 | | None => {} [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 292 | if let Some(lcost) = algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 293 | if lcost < best_cost { [INFO] [stderr] 294 | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] 295 | } [INFO] [stderr] 296 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:301:29 [INFO] [stderr] | [INFO] [stderr] 301 | / match algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 302 | | Some(rcost) => { [INFO] [stderr] 303 | | if rcost < best_cost { [INFO] [stderr] 304 | | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] ... | [INFO] [stderr] 307 | | None => {} [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 301 | if let Some(rcost) = algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 302 | if rcost < best_cost { [INFO] [stderr] 303 | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] 304 | } [INFO] [stderr] 305 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:310:52 [INFO] [stderr] | [INFO] [stderr] 310 | BVTNode::Leaf(_, ref b) => match algorithm.compute_b_cost(b) { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 311 | | Some((candidate_cost, candidate_result)) => { [INFO] [stderr] 312 | | if candidate_cost < best_cost { [INFO] [stderr] 313 | | best_cost = candidate_cost; [INFO] [stderr] ... | [INFO] [stderr] 317 | | None => {} [INFO] [stderr] 318 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | BVTNode::Leaf(_, ref b) => if let Some((candidate_cost, candidate_result)) = algorithm.compute_b_cost(b) { [INFO] [stderr] 311 | if candidate_cost < best_cost { [INFO] [stderr] 312 | best_cost = candidate_cost; [INFO] [stderr] 313 | result = Some((b, candidate_result)); [INFO] [stderr] 314 | } [INFO] [stderr] 315 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for dimension in 0usize..dimension + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=dimension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for i in 0usize..dimension + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=dimension` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | num_added = num_added + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_added += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:124:29 [INFO] [stderr] | [INFO] [stderr] 124 | determinant_index = determinant_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant_index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:130:26 [INFO] [stderr] | [INFO] [stderr] 130 | for k in 0usize..last_num_points + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=last_num_points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | determinant_index = determinant_index + if i == 0 { 0 } else { 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant_index += if i == 0 { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | last_dim_end = last_dim_end + num_added; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_dim_end += num_added` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | last_num_points = last_num_points - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_num_points -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:157:36 [INFO] [stderr] | [INFO] [stderr] 157 | sub_determinants.push(*map.get(&vec![max_num_points - 1 - i]).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&vec![max_num_points - 1 - i]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:265:25 [INFO] [stderr] | [INFO] [stderr] 265 | determinant = determinant + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `determinant += delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:268:22 [INFO] [stderr] | [INFO] [stderr] 268 | *self.determinants [INFO] [stderr] | ______________________^ [INFO] [stderr] 269 | | .as_mut_ptr() [INFO] [stderr] 270 | | .offset(*recursion.sub_determinants[..].get_unchecked(curr) as isize) = [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 268 | *self.determinants [INFO] [stderr] 269 | .as_mut_ptr().add(*recursion.sub_determinants[..].get_unchecked(curr)) = [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:277:13 [INFO] [stderr] | [INFO] [stderr] 277 | curr_num_pts = curr_num_pts + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr_num_pts += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:305:38 [INFO] [stderr] | [INFO] [stderr] 305 | *self.determinants.as_mut_ptr().offset(subdetid as isize) = [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.determinants.as_mut_ptr().add(subdetid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:336:29 [INFO] [stderr] | [INFO] [stderr] 336 | total_det = total_det + det; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_det += det` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | curr = curr - curr_num_pts * curr_num_pts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr -= curr_num_pts * curr_num_pts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/johnson_simplex.rs:365:13 [INFO] [stderr] | [INFO] [stderr] 365 | curr_num_pts = curr_num_pts - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curr_num_pts -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `query::algorithms::voronoi_simplex2::VoronoiSimplex2

` [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> VoronoiSimplex2

{ [INFO] [stderr] 16 | | VoronoiSimplex2 { [INFO] [stderr] 17 | | vertices: [P::origin(); 3], [INFO] [stderr] 18 | | dim: 0, [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for query::algorithms::voronoi_simplex2::VoronoiSimplex2

{ [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/ray_internal/ray_mesh.rs:212:10 [INFO] [stderr] | [INFO] [stderr] 212 | ) -> Option<(P::Real, (RayIntersection, Vector3))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `project_point` which has no body [INFO] [stderr] --> query/point_internal/point_query.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `project_point_with_location` which has no body [INFO] [stderr] --> query/point_internal/point_query.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ls_pt` [INFO] [stderr] --> query/point_internal/point_aabb.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 0..na::dimension::() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (i, ) in ls_pt.iter().enumerate().take(na::dimension::()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:130:18 [INFO] [stderr] | [INFO] [stderr] 130 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex2.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `query::algorithms::voronoi_simplex3::VoronoiSimplex3

` [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> VoronoiSimplex3

{ [INFO] [stderr] 20 | | VoronoiSimplex3 { [INFO] [stderr] 21 | | vertices: [P::origin(); 4], [INFO] [stderr] 22 | | dim: 0, [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | impl Default for query::algorithms::voronoi_simplex3::VoronoiSimplex3

{ [INFO] [stderr] 18 | fn default() -> Self { [INFO] [stderr] 19 | Self::new() [INFO] [stderr] 20 | } [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> query/point_internal/point_triangle.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / fn stable_check_edges_voronoi( [INFO] [stderr] 121 | | ab: &P::Vector, [INFO] [stderr] 122 | | ac: &P::Vector, [INFO] [stderr] 123 | | bc: &P::Vector, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:208:18 [INFO] [stderr] | [INFO] [stderr] 208 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:224:18 [INFO] [stderr] | [INFO] [stderr] 224 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/voronoi_simplex3.rs:236:18 [INFO] [stderr] | [INFO] [stderr] 236 | for i in 0..self.dim + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=self.dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `projs` [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (i, ) in projs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:236:14 [INFO] [stderr] | [INFO] [stderr] 236 | ) -> ( [INFO] [stderr] | ______________^ [INFO] [stderr] 237 | | P::Real, [INFO] [stderr] 238 | | P::Real, [INFO] [stderr] 239 | | Option<(PointProjection

, TetrahedronPointLocation)>, [INFO] [stderr] 240 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | / fn check_edge( [INFO] [stderr] 226 | | i: usize, [INFO] [stderr] 227 | | m: &M, [INFO] [stderr] 228 | | a: &P, [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | / fn check_face( [INFO] [stderr] 424 | | i: usize, [INFO] [stderr] 425 | | a: &P, [INFO] [stderr] 426 | | b: &P, [INFO] [stderr] ... | [INFO] [stderr] 479 | | return None; [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> query/algorithms/gjk.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | assert!(min_bound == min_bound); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/gjk.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | niter = niter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `niter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/gjk.rs:390:21 [INFO] [stderr] | [INFO] [stderr] 390 | ltoi = ltoi + t; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `ltoi += t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> query/algorithms/gjk.rs:417:64 [INFO] [stderr] | [INFO] [stderr] 417 | } else if max_bound <= _eps_tol * simplex.max_sq_len() { [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 418 | | // Return ldir: the last projection plane is tangeant to the intersected surface. [INFO] [stderr] 419 | | return Some((ltoi, ldir)); [INFO] [stderr] 420 | | } else if max_bound >= old_max_bound { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> query/algorithms/gjk.rs:415:46 [INFO] [stderr] | [INFO] [stderr] 415 | if simplex.dimension() == _dimension { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 416 | | return Some((ltoi, ldir)); [INFO] [stderr] 417 | | } else if max_bound <= _eps_tol * simplex.max_sq_len() { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::algorithms::epa3::EPA3

` [INFO] [stderr] --> query/algorithms/epa3.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / pub fn new() -> Self { [INFO] [stderr] 148 | | EPA3 { [INFO] [stderr] 149 | | vertices: Vec::new(), [INFO] [stderr] 150 | | faces: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 138 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_geometry`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/epa3.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | for i in 0..simplex.dimension() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=simplex.dimension()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::algorithms::epa2::EPA2

` [INFO] [stderr] --> query/algorithms/epa2.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Self { [INFO] [stderr] 104 | | EPA2 { [INFO] [stderr] 105 | | vertices: Vec::new(), [INFO] [stderr] 106 | | faces: Vec::new(), [INFO] [stderr] 107 | | heap: BinaryHeap::new(), [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> query/algorithms/epa2.rs:133:18 [INFO] [stderr] | [INFO] [stderr] 133 | for i in 0..simplex.dimension() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=simplex.dimension()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> query/algorithms/epa2.rs:244:37 [INFO] [stderr] | [INFO] [stderr] 244 | for (i, f) in new_faces.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/algorithms/minkowski_sampling.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | simplex.modify_pnts(&|pt| *pt = *pt + (-shift)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pt += (-shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> query/contacts_internal/ball_against_ball.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / let mut normal = Unit::new_normalize(delta_pos); [INFO] [stderr] 31 | | [INFO] [stderr] 32 | | if distance_squared.is_zero() { [INFO] [stderr] 33 | | normal = Unit::new_unchecked(P::Vector::canonical_basis_element(0)); [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let normal = if distance_squared.is_zero() { Unit::new_unchecked(P::Vector::canonical_basis_element(0)) } else { Unit::new_normalize(delta_pos) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> query/contacts_internal/composite_shape_against_shape.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | g1.map_part_at(i, &mut |_, part| match contacts_internal::contact_internal( [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 93 | | m1, [INFO] [stderr] 94 | | part, [INFO] [stderr] 95 | | m2, [INFO] [stderr] ... | [INFO] [stderr] 109 | | None => {} [INFO] [stderr] 110 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | g1.map_part_at(i, &mut |_, part| if let Some(c) = contacts_internal::contact_internal( [INFO] [stderr] 93 | m1, [INFO] [stderr] 94 | part, [INFO] [stderr] 95 | m2, [INFO] [stderr] 96 | g2, [INFO] [stderr] 97 | prediction, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `toi_and_normal_with_ray` which has no body [INFO] [stderr] --> query/ray_internal/ray.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ) -> Option<(RayIntersection, Vector3)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | v = v * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | w = w * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `w *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | v = v * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `v *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> query/ray_internal/ray_triangle.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | w = w * invd; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `w *= invd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/ray_internal/ray_mesh.rs:212:10 [INFO] [stderr] | [INFO] [stderr] 212 | ) -> Option<(P::Real, (RayIntersection, Vector3))> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `project_point` which has no body [INFO] [stderr] --> query/point_internal/point_query.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `project_point_with_location` which has no body [INFO] [stderr] --> query/point_internal/point_query.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | #[inline] [INFO] [stderr] | ^^^^^^^^^ help: remove [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ls_pt` [INFO] [stderr] --> query/point_internal/point_aabb.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | for i in 0..na::dimension::() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for (i, ) in ls_pt.iter().enumerate().take(na::dimension::()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> query/point_internal/point_triangle.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | / fn stable_check_edges_voronoi( [INFO] [stderr] 121 | | ab: &P::Vector, [INFO] [stderr] 122 | | ac: &P::Vector, [INFO] [stderr] 123 | | bc: &P::Vector, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `projs` [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 100 | for (i, ) in projs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:236:14 [INFO] [stderr] | [INFO] [stderr] 236 | ) -> ( [INFO] [stderr] | ______________^ [INFO] [stderr] 237 | | P::Real, [INFO] [stderr] 238 | | P::Real, [INFO] [stderr] 239 | | Option<(PointProjection

, TetrahedronPointLocation)>, [INFO] [stderr] 240 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | / fn check_edge( [INFO] [stderr] 226 | | i: usize, [INFO] [stderr] 227 | | m: &M, [INFO] [stderr] 228 | | a: &P, [INFO] [stderr] ... | [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> query/point_internal/point_tetrahedron.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | / fn check_face( [INFO] [stderr] 424 | | i: usize, [INFO] [stderr] 425 | | a: &P, [INFO] [stderr] 426 | | b: &P, [INFO] [stderr] ... | [INFO] [stderr] 479 | | return None; [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_geometry`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "124912d674dbf8014d7951f7f69a8d60edb217ab2107f4cac333b3fd4cd4104d"` [INFO] running `"docker" "rm" "-f" "124912d674dbf8014d7951f7f69a8d60edb217ab2107f4cac333b3fd4cd4104d"` [INFO] [stdout] 124912d674dbf8014d7951f7f69a8d60edb217ab2107f4cac333b3fd4cd4104d