[INFO] crate ncollide_entities 0.5.0 is already in cache [INFO] extracting crate ncollide_entities 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/ncollide_entities/0.5.0 [INFO] extracting crate ncollide_entities 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_entities/0.5.0 [INFO] validating manifest of ncollide_entities-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ncollide_entities-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ncollide_entities-0.5.0 [INFO] removed path dependency ncollide_math from ncollide_entities-0.5.0 [INFO] removed path dependency ncollide_utils from ncollide_entities-0.5.0 [INFO] finished frobbing ncollide_entities-0.5.0 [INFO] frobbed toml for ncollide_entities-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/ncollide_entities/0.5.0/Cargo.toml [INFO] started frobbing ncollide_entities-0.5.0 [INFO] removed path dependency ncollide_math from ncollide_entities-0.5.0 [INFO] removed path dependency ncollide_utils from ncollide_entities-0.5.0 [INFO] finished frobbing ncollide_entities-0.5.0 [INFO] frobbed toml for ncollide_entities-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ncollide_entities/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ncollide_entities-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ncollide_entities/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e897ced71a47316d7d2c2eb939bc14211b95df6bd7957f9bab412a07b89283b9 [INFO] running `"docker" "start" "-a" "e897ced71a47316d7d2c2eb939bc14211b95df6bd7957f9bab412a07b89283b9"` [INFO] [stderr] Checking nalgebra v0.8.2 [INFO] [stderr] Checking ncollide_math v0.3.0 [INFO] [stderr] Checking ncollide_utils v0.3.0 [INFO] [stderr] Checking ncollide_entities v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/plane.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | normal: normal [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cuboid.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | half_extents: half_extents [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:48 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:57 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | orig1: orig1, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | orig2: orig2, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | let _0_5: ::Scalar = na::cast(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | let _0_5: ::Scalar = na::cast(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/segment.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/segment.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | b: b [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/ball.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/reflection.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | Reflection { shape: shape } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major_radius: major_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor_radius: minor_radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | shapes: shapes, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `shapes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | bvs: bvs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/convex.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | points: points [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_volume_bvt.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | bv: bv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | maxs: maxs [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | left: left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/bvt_visitor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bv: bv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | repr_id: repr_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repr_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | repr: repr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `repr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/plane.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | normal: normal [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cuboid.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | half_extents: half_extents [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:32 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:40:48 [INFO] [stderr] | [INFO] [stderr] 40 | MinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:33 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:41 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:49 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `m2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:90:57 [INFO] [stderr] | [INFO] [stderr] 90 | AnnotatedMinkowskiSum { m1: m1, g1: g1, m2: m2, g2: g2 } [INFO] [stderr] | ^^^^^^ help: replace it with: `g2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | orig1: orig1, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | orig2: orig2, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `orig2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/minkowski_sum.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | point: point [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | let _0_5: ::Scalar = na::cast(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> shape/minkowski_sum.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | let _0_5: ::Scalar = na::cast(0.5f64); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/segment.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/segment.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | b: b [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/triangle.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | c: c [INFO] [stderr] | ^^^^ help: replace it with: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | bvs: bvs, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | uvs: uvs, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `uvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/base_mesh.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | normals: normals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `normals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/ball.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/capsule.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cone.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | half_height: half_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/cylinder.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/reflection.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | Reflection { shape: shape } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | major_radius: major_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `major_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/torus.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | minor_radius: minor_radius [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `minor_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | shapes: shapes, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `shapes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | bvt: bvt, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bvt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/compound.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | bvs: bvs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bvs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> shape/convex.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | points: points [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_volume_bvt.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | bv: bv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | mins: mins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/aabb.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | maxs: maxs [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `maxs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | radius: radius [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | left: left, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | bounding_volume: bounding_volume, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bounding_volume` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/dbvt.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | object: object, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> partitioning/bvt_visitor.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bv: bv, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `bv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | type_id: type_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | repr_id: repr_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `repr_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> inspection/repr.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | repr: repr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `repr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> shape/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | mod shape; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> support_map/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub mod support_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> support_map/triangle_support_map.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 29 | | if d2 > d3 { [INFO] [stderr] 30 | | self.b() [INFO] [stderr] 31 | | } [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | else if d2 > d3 { [INFO] [stderr] 29 | self.b() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | else { [INFO] [stderr] 32 | self.c() [INFO] [stderr] 33 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> bounding_volume/mod.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub mod bounding_volume; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> shape/mod.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | mod shape; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> support_map/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub mod support_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> support_map/triangle_support_map.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 29 | | if d2 > d3 { [INFO] [stderr] 30 | | self.b() [INFO] [stderr] 31 | | } [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | else if d2 > d3 { [INFO] [stderr] 29 | self.b() [INFO] [stderr] 30 | } [INFO] [stderr] 31 | else { [INFO] [stderr] 32 | self.c() [INFO] [stderr] 33 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> bounding_volume/mod.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | pub mod bounding_volume; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `na::Iterable` [INFO] [stderr] --> shape/cuboid.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use na::Iterable; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> lib.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `na::Iterable` [INFO] [stderr] --> shape/cuboid.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use na::Iterable; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> lib.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | #![warn(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `CSO` [INFO] [stderr] --> shape/minkowski_sum.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub type CSO<'a, M, G1, G2> = MinkowskiSum<'a, M, G1, Reflection<'a, G2>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `AnnotatedCSO` [INFO] [stderr] --> shape/minkowski_sum.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type AnnotatedCSO<'a, M, G1, G2> = AnnotatedMinkowskiSum<'a, M, G1, Reflection<'a, G2>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn point<'r>(&'r self) -> &'r P { [INFO] [stderr] 142 | | &self.point [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / fn as_vector<'a>(&'a self) -> &'a P::Vector { [INFO] [stderr] 182 | | self.point.as_vector() [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:256:29 [INFO] [stderr] | [INFO] [stderr] 256 | self.orig1 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:257:29 [INFO] [stderr] | [INFO] [stderr] 257 | self.orig2 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> shape/minkowski_sum.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | / fn ne(&self, other: &AnnotatedPoint

) -> bool { [INFO] [stderr] 340 | | self.point != other.point [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: item `shape::base_mesh::BaseMesh` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> shape/base_mesh.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl BaseMesh [INFO] [stderr] 89 | | where P: Point { [INFO] [stderr] 90 | | /// The vertices of this mesh. [INFO] [stderr] 91 | | #[inline] [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/trimesh.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/trimesh.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/polyline.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/polyline.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/ball.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/capsule.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/capsule.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cone.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cone.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cylinder.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cylinder.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: trait `CompositeShape` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> shape/composite_shape.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub trait CompositeShape { [INFO] [stderr] 14 | | /// The number of parts on this composite shapes. [INFO] [stderr] 15 | | fn len(&self) -> usize; [INFO] [stderr] 16 | | /// Applies a function to each sub-shape of this concave shape. [INFO] [stderr] ... | [INFO] [stderr] 26 | | fn bvt(&self) -> &BVT>; [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/utils_support_map.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | best_pt.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*best_pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/cone_support_map.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | let mut vres = local_dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> support_map/cone_support_map.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/cylinder_support_map.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | let mut vres = local_dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> support_map/cylinder_support_map.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.mins = self.mins + na::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += na::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | self.maxs = self.maxs + na::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += na::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | self.mins = self.mins + na::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += na::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.maxs = self.maxs + na::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += na::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | self.mins = self.mins + *dv; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | self.maxs = self.maxs + *dv; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_cuboid.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | AABB::new(center + -ws_half_extents.clone(), center + ws_half_extents) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ws_half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_utils.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let mut min: P = wp0.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `wp0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_utils.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | let mut max: P = wp0.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `wp0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.radius = self.radius + amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius += amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | BoundingSphere::new(self.center.clone(), self.radius + amount) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | self.radius = self.radius - amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius -= amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | BoundingSphere::new(self.center.clone(), self.radius - amount) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | self.center.as_vector().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.center.as_vector()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | self.center = self.center + *dv [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.center += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.a()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.b()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.c()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_segment.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.a()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_segment.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.b()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `partitioning::dbvt::DBVT` [INFO] [stderr] --> partitioning/dbvt.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> DBVT { [INFO] [stderr] 33 | | DBVT { [INFO] [stderr] 34 | | cache: OwnedAllocationCache::new(), [INFO] [stderr] 35 | | tree: None, [INFO] [stderr] 36 | | len: 0 [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for partitioning::dbvt::DBVT { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> partitioning/dbvt.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.len = self.len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> partitioning/dbvt.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | self.len = self.len + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/dbvt.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self.tree { [INFO] [stderr] 87 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 88 | | None => { } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> partitioning/dbvt.rs:361:21 [INFO] [stderr] | [INFO] [stderr] 361 | / let mut left; [INFO] [stderr] 362 | | [INFO] [stderr] 363 | | if (*parent).is_closest_to_left(&pto_insert.center) { [INFO] [stderr] 364 | | curr = &mut (*parent).left as *mut DBVTNode; [INFO] [stderr] ... | [INFO] [stderr] 369 | | left = false; [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let left = if (*parent).is_closest_to_left(&pto_insert.center) { ..; true } else { ..; false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self.tree { [INFO] [stderr] 62 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 63 | | None => { } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match (&self.tree, &other.tree) { [INFO] [stderr] 70 | | (&Some(ref ta), &Some(ref tb)) => ta.visit_bvtt(tb, visitor), [INFO] [stderr] 71 | | _ => { } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ help: try this: `if let (&Some(ref ta), &Some(ref tb)) = (&self.tree, &other.tree) { ta.visit_bvtt(tb, visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn root_bounding_volume<'r>(&'r self) -> Option<&'r BV> { [INFO] [stderr] 91 | | match self.tree { [INFO] [stderr] 92 | | Some(ref n) => { [INFO] [stderr] 93 | | match *n { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn bounding_volume<'a>(&'a self) -> &'a BV { [INFO] [stderr] 124 | | match *self { [INFO] [stderr] 125 | | BVTNode::Internal(ref bv, _, _) => bv, [INFO] [stderr] 126 | | BVTNode::Leaf(ref bv, _) => bv [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> partitioning/bvt.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / loop { [INFO] [stderr] 185 | | match queue.pop() { [INFO] [stderr] 186 | | Some(node) => { [INFO] [stderr] 187 | | if -node.cost >= best_cost { [INFO] [stderr] ... | [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(node) = queue.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:193:29 [INFO] [stderr] | [INFO] [stderr] 193 | / match algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 194 | | Some(lcost) => { [INFO] [stderr] 195 | | if lcost < best_cost { [INFO] [stderr] 196 | | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] ... | [INFO] [stderr] 199 | | None => { } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | if let Some(lcost) = algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 194 | if lcost < best_cost { [INFO] [stderr] 195 | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] 196 | } [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:202:29 [INFO] [stderr] | [INFO] [stderr] 202 | / match algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 203 | | Some(rcost) => { [INFO] [stderr] 204 | | if rcost < best_cost { [INFO] [stderr] 205 | | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] ... | [INFO] [stderr] 208 | | None => { } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 202 | if let Some(rcost) = algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 203 | if rcost < best_cost { [INFO] [stderr] 204 | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] 205 | } [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | / match algorithm.compute_b_cost(b) { [INFO] [stderr] 213 | | Some((candidate_cost, candidate_result)) => { [INFO] [stderr] 214 | | if candidate_cost < best_cost { [INFO] [stderr] 215 | | best_cost = candidate_cost; [INFO] [stderr] ... | [INFO] [stderr] 219 | | None => { } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let Some((candidate_cost, candidate_result)) = algorithm.compute_b_cost(b) { [INFO] [stderr] 213 | if candidate_cost < best_cost { [INFO] [stderr] 214 | best_cost = candidate_cost; [INFO] [stderr] 215 | result = Some((b, candidate_result)); [INFO] [stderr] 216 | } [INFO] [stderr] 217 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:244:8 [INFO] [stderr] | [INFO] [stderr] 244 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:287:12 [INFO] [stderr] | [INFO] [stderr] 287 | if left.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:290:17 [INFO] [stderr] | [INFO] [stderr] 290 | else if right.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> inspection/repr.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(unsafe { mem::transmute(self.repr.data) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.repr.data as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> inspection/repr.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | fn repr<'a>(&'a self) -> ReprDesc<'a, P, M>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_entities`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: type alias is never used: `CSO` [INFO] [stderr] --> shape/minkowski_sum.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | pub type CSO<'a, M, G1, G2> = MinkowskiSum<'a, M, G1, Reflection<'a, G2>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `AnnotatedCSO` [INFO] [stderr] --> shape/minkowski_sum.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub type AnnotatedCSO<'a, M, G1, G2> = AnnotatedMinkowskiSum<'a, M, G1, Reflection<'a, G2>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn point<'r>(&'r self) -> &'r P { [INFO] [stderr] 142 | | &self.point [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> shape/minkowski_sum.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / fn as_vector<'a>(&'a self) -> &'a P::Vector { [INFO] [stderr] 182 | | self.point.as_vector() [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:256:29 [INFO] [stderr] | [INFO] [stderr] 256 | self.orig1 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `AddAssign` impl [INFO] [stderr] --> shape/minkowski_sum.rs:257:29 [INFO] [stderr] | [INFO] [stderr] 257 | self.orig2 += other * _0_5; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> shape/minkowski_sum.rs:339:5 [INFO] [stderr] | [INFO] [stderr] 339 | / fn ne(&self, other: &AnnotatedPoint

) -> bool { [INFO] [stderr] 340 | | self.point != other.point [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: item `shape::base_mesh::BaseMesh` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> shape/base_mesh.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | / impl BaseMesh [INFO] [stderr] 89 | | where P: Point { [INFO] [stderr] 90 | | /// The vertices of this mesh. [INFO] [stderr] 91 | | #[inline] [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/base_mesh.rs:116:26 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/trimesh.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/trimesh.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/polyline.rs:30:26 [INFO] [stderr] | [INFO] [stderr] 30 | uvs: Option::Scalar>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> shape/polyline.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn uvs(&self) -> &Option::Scalar>>>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/ball.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/capsule.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/capsule.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cone.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cone.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cylinder.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | self.half_height.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.half_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> shape/cylinder.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: trait `CompositeShape` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> shape/composite_shape.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub trait CompositeShape { [INFO] [stderr] 14 | | /// The number of parts on this composite shapes. [INFO] [stderr] 15 | | fn len(&self) -> usize; [INFO] [stderr] 16 | | /// Applies a function to each sub-shape of this concave shape. [INFO] [stderr] ... | [INFO] [stderr] 26 | | fn bvt(&self) -> &BVT>; [INFO] [stderr] 27 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/utils_support_map.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | best_pt.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*best_pt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/cone_support_map.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | let mut vres = local_dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> support_map/cone_support_map.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> support_map/cylinder_support_map.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | let mut vres = local_dir.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `local_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> support_map/cylinder_support_map.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | vres = vres * self.radius(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vres *= self.radius()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | self.mins = self.mins + na::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += na::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | self.maxs = self.maxs + na::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += na::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | self.mins = self.mins + na::repeat(amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += na::repeat(amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | self.maxs = self.maxs + na::repeat(-amount); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += na::repeat(-amount)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | self.mins = self.mins + *dv; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.mins += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/aabb.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | self.maxs = self.maxs + *dv; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.maxs += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_cuboid.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | AABB::new(center + -ws_half_extents.clone(), center + ws_half_extents) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ws_half_extents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_utils.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | let mut min: P = wp0.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `wp0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/aabb_utils.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | let mut max: P = wp0.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `wp0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | self.radius.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.radius = self.radius + amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius += amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:129:29 [INFO] [stderr] | [INFO] [stderr] 129 | BoundingSphere::new(self.center.clone(), self.radius + amount) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | self.radius = self.radius - amount [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.radius -= amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:143:29 [INFO] [stderr] | [INFO] [stderr] 143 | BoundingSphere::new(self.center.clone(), self.radius - amount) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | self.center.as_vector().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.center.as_vector()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> bounding_volume/bounding_sphere.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | self.center = self.center + *dv [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.center += *dv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.a()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.b()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_triangle.rs:13:57 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone(), self.c().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.c()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_segment.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.a()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> bounding_volume/bounding_sphere_segment.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | let pts = [ self.a().clone(), self.b().clone() ]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.b()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `partitioning::dbvt::DBVT` [INFO] [stderr] --> partitioning/dbvt.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn new() -> DBVT { [INFO] [stderr] 33 | | DBVT { [INFO] [stderr] 34 | | cache: OwnedAllocationCache::new(), [INFO] [stderr] 35 | | tree: None, [INFO] [stderr] 36 | | len: 0 [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for partitioning::dbvt::DBVT { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> partitioning/dbvt.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | self.len = self.len - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> partitioning/dbvt.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | self.len = self.len + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.len += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/dbvt.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self.tree { [INFO] [stderr] 87 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 88 | | None => { } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> partitioning/dbvt.rs:361:21 [INFO] [stderr] | [INFO] [stderr] 361 | / let mut left; [INFO] [stderr] 362 | | [INFO] [stderr] 363 | | if (*parent).is_closest_to_left(&pto_insert.center) { [INFO] [stderr] 364 | | curr = &mut (*parent).left as *mut DBVTNode; [INFO] [stderr] ... | [INFO] [stderr] 369 | | left = false; [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let left = if (*parent).is_closest_to_left(&pto_insert.center) { ..; true } else { ..; false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self.tree { [INFO] [stderr] 62 | | Some(ref t) => t.visit(visitor), [INFO] [stderr] 63 | | None => { } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(ref t) = self.tree { t.visit(visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / match (&self.tree, &other.tree) { [INFO] [stderr] 70 | | (&Some(ref ta), &Some(ref tb)) => ta.visit_bvtt(tb, visitor), [INFO] [stderr] 71 | | _ => { } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ help: try this: `if let (&Some(ref ta), &Some(ref tb)) = (&self.tree, &other.tree) { ta.visit_bvtt(tb, visitor) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn root_bounding_volume<'r>(&'r self) -> Option<&'r BV> { [INFO] [stderr] 91 | | match self.tree { [INFO] [stderr] 92 | | Some(ref n) => { [INFO] [stderr] 93 | | match *n { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> partitioning/bvt.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn bounding_volume<'a>(&'a self) -> &'a BV { [INFO] [stderr] 124 | | match *self { [INFO] [stderr] 125 | | BVTNode::Internal(ref bv, _, _) => bv, [INFO] [stderr] 126 | | BVTNode::Leaf(ref bv, _) => bv [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> partitioning/bvt.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | / loop { [INFO] [stderr] 185 | | match queue.pop() { [INFO] [stderr] 186 | | Some(node) => { [INFO] [stderr] 187 | | if -node.cost >= best_cost { [INFO] [stderr] ... | [INFO] [stderr] 225 | | } [INFO] [stderr] 226 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(node) = queue.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:193:29 [INFO] [stderr] | [INFO] [stderr] 193 | / match algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 194 | | Some(lcost) => { [INFO] [stderr] 195 | | if lcost < best_cost { [INFO] [stderr] 196 | | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] ... | [INFO] [stderr] 199 | | None => { } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | if let Some(lcost) = algorithm.compute_bv_cost(left.bounding_volume()) { [INFO] [stderr] 194 | if lcost < best_cost { [INFO] [stderr] 195 | queue.push(RefWithCost::new(&**left, -lcost)) [INFO] [stderr] 196 | } [INFO] [stderr] 197 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:202:29 [INFO] [stderr] | [INFO] [stderr] 202 | / match algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 203 | | Some(rcost) => { [INFO] [stderr] 204 | | if rcost < best_cost { [INFO] [stderr] 205 | | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] ... | [INFO] [stderr] 208 | | None => { } [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 202 | if let Some(rcost) = algorithm.compute_bv_cost(right.bounding_volume()) { [INFO] [stderr] 203 | if rcost < best_cost { [INFO] [stderr] 204 | queue.push(RefWithCost::new(&**right, -rcost)) [INFO] [stderr] 205 | } [INFO] [stderr] 206 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> partitioning/bvt.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | / match algorithm.compute_b_cost(b) { [INFO] [stderr] 213 | | Some((candidate_cost, candidate_result)) => { [INFO] [stderr] 214 | | if candidate_cost < best_cost { [INFO] [stderr] 215 | | best_cost = candidate_cost; [INFO] [stderr] ... | [INFO] [stderr] 219 | | None => { } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 212 | if let Some((candidate_cost, candidate_result)) = algorithm.compute_b_cost(b) { [INFO] [stderr] 213 | if candidate_cost < best_cost { [INFO] [stderr] 214 | best_cost = candidate_cost; [INFO] [stderr] 215 | result = Some((b, candidate_result)); [INFO] [stderr] 216 | } [INFO] [stderr] 217 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:244:8 [INFO] [stderr] | [INFO] [stderr] 244 | if leaves.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `leaves.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:287:12 [INFO] [stderr] | [INFO] [stderr] 287 | if left.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `left.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> partitioning/bvt.rs:290:17 [INFO] [stderr] | [INFO] [stderr] 290 | else if right.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut ()`) to a reference type (`&T`) [INFO] [stderr] --> inspection/repr.rs:64:27 [INFO] [stderr] | [INFO] [stderr] 64 | Some(unsafe { mem::transmute(self.repr.data) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self.repr.data as *const T)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> inspection/repr.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | fn repr<'a>(&'a self) -> ReprDesc<'a, P, M>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ncollide_entities`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e897ced71a47316d7d2c2eb939bc14211b95df6bd7957f9bab412a07b89283b9"` [INFO] running `"docker" "rm" "-f" "e897ced71a47316d7d2c2eb939bc14211b95df6bd7957f9bab412a07b89283b9"` [INFO] [stdout] e897ced71a47316d7d2c2eb939bc14211b95df6bd7957f9bab412a07b89283b9