[INFO] crate nccl 0.4.3 is already in cache [INFO] extracting crate nccl 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/nccl/0.4.3 [INFO] extracting crate nccl 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nccl/0.4.3 [INFO] validating manifest of nccl-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nccl-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nccl-0.4.3 [INFO] finished frobbing nccl-0.4.3 [INFO] frobbed toml for nccl-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/nccl/0.4.3/Cargo.toml [INFO] started frobbing nccl-0.4.3 [INFO] finished frobbing nccl-0.4.3 [INFO] frobbed toml for nccl-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nccl/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nccl-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nccl/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ac3efebe94146d86b860af75ce1cbf42493582469bc285fd0d3091fa56ea682 [INFO] running `"docker" "start" "-a" "7ac3efebe94146d86b860af75ce1cbf42493582469bc285fd0d3091fa56ea682"` [INFO] [stderr] Checking nccl v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | pair: pair, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | lexeme: lexeme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lexeme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | pair: pair, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pair` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | lexeme: lexeme, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `lexeme` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pair.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 103 | | if self.has_key(path[0].clone()) { [INFO] [stderr] 104 | | self[path[0].clone()].has_path(path[1..path.len()].to_vec()) [INFO] [stderr] 105 | | } else { [INFO] [stderr] 106 | | false [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if self.has_key(path[0].clone()) { [INFO] [stderr] 103 | self[path[0].clone()].has_path(path[1..path.len()].to_vec()) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | false [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pair.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | Err(_) => return Err(Box::new(NcclError::new(ErrorKind::IntoError, "Could not convert to T", 0))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(NcclError::new(ErrorKind::IntoError, "Could not convert to T", 0)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pair.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | new.push(parse_into_value(self.tokens[i].lexeme.clone().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tokens[i].lexeme.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:57:57 [INFO] [stderr] | [INFO] [stderr] 57 | self.path.push(parse_into_value(self.tokens[i].lexeme.clone().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tokens[i].lexeme.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/pair.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 103 | | if self.has_key(path[0].clone()) { [INFO] [stderr] 104 | | self[path[0].clone()].has_path(path[1..path.len()].to_vec()) [INFO] [stderr] 105 | | } else { [INFO] [stderr] 106 | | false [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if self.has_key(path[0].clone()) { [INFO] [stderr] 103 | self[path[0].clone()].has_path(path[1..path.len()].to_vec()) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | false [INFO] [stderr] 106 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pair.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | Err(_) => return Err(Box::new(NcclError::new(ErrorKind::IntoError, "Could not convert to T", 0))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::new(NcclError::new(ErrorKind::IntoError, "Could not convert to T", 0)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match into.parse::() { [INFO] [stderr] 24 | | Ok(b) => return Value::Bool(b), [INFO] [stderr] 25 | | Err(_) => {}, [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(b) = into.parse::() { return Value::Bool(b) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match into.parse::() { [INFO] [stderr] 29 | | Ok(i) => return Value::Integer(i), [INFO] [stderr] 30 | | Err(_) => {}, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(i) = into.parse::() { return Value::Integer(i) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match into.parse::() { [INFO] [stderr] 34 | | Ok(f) => return Value::Float(f), [INFO] [stderr] 35 | | Err(_) => {}, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(f) = into.parse::() { return Value::Float(f) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | Value::Integer(i as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | Value::Integer(u as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | Value::Float(f as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / match self { [INFO] [stderr] 199 | | &Value::Bool(b) => write!(f, "{}", b), [INFO] [stderr] 200 | | &Value::String(ref s) => write!(f, "{}", s), [INFO] [stderr] 201 | | &Value::Float(fl) => write!(f, "{}", fl), [INFO] [stderr] 202 | | &Value::Integer(i) => write!(f, "{}", i), [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 198 | match *self { [INFO] [stderr] 199 | Value::Bool(b) => write!(f, "{}", b), [INFO] [stderr] 200 | Value::String(ref s) => write!(f, "{}", s), [INFO] [stderr] 201 | Value::Float(fl) => write!(f, "{}", fl), [INFO] [stderr] 202 | Value::Integer(i) => write!(f, "{}", i), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pair.rs:100:12 [INFO] [stderr] | [INFO] [stderr] 100 | if path.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | new.push(parse_into_value(self.tokens[i].lexeme.clone().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tokens[i].lexeme.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:57:57 [INFO] [stderr] | [INFO] [stderr] 57 | self.path.push(parse_into_value(self.tokens[i].lexeme.clone().into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.tokens[i].lexeme.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / match into.parse::() { [INFO] [stderr] 24 | | Ok(b) => return Value::Bool(b), [INFO] [stderr] 25 | | Err(_) => {}, [INFO] [stderr] 26 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(b) = into.parse::() { return Value::Bool(b) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / match into.parse::() { [INFO] [stderr] 29 | | Ok(i) => return Value::Integer(i), [INFO] [stderr] 30 | | Err(_) => {}, [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(i) = into.parse::() { return Value::Integer(i) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/value.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match into.parse::() { [INFO] [stderr] 34 | | Ok(f) => return Value::Float(f), [INFO] [stderr] 35 | | Err(_) => {}, [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ help: try this: `if let Ok(f) = into.parse::() { return Value::Float(f) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | Value::Integer(i as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | Value::Integer(u as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(u)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value.rs:192:22 [INFO] [stderr] | [INFO] [stderr] 192 | Value::Float(f as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/value.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / match self { [INFO] [stderr] 199 | | &Value::Bool(b) => write!(f, "{}", b), [INFO] [stderr] 200 | | &Value::String(ref s) => write!(f, "{}", s), [INFO] [stderr] 201 | | &Value::Float(fl) => write!(f, "{}", fl), [INFO] [stderr] 202 | | &Value::Integer(i) => write!(f, "{}", i), [INFO] [stderr] 203 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 198 | match *self { [INFO] [stderr] 199 | Value::Bool(b) => write!(f, "{}", b), [INFO] [stderr] 200 | Value::String(ref s) => write!(f, "{}", s), [INFO] [stderr] 201 | Value::Float(fl) => write!(f, "{}", fl), [INFO] [stderr] 202 | Value::Integer(i) => write!(f, "{}", i), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/nccl.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "7ac3efebe94146d86b860af75ce1cbf42493582469bc285fd0d3091fa56ea682"` [INFO] running `"docker" "rm" "-f" "7ac3efebe94146d86b860af75ce1cbf42493582469bc285fd0d3091fa56ea682"` [INFO] [stdout] 7ac3efebe94146d86b860af75ce1cbf42493582469bc285fd0d3091fa56ea682