[INFO] crate nbd 0.2.1 is already in cache
[INFO] extracting crate nbd 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/nbd/0.2.1
[INFO] extracting crate nbd 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nbd/0.2.1
[INFO] validating manifest of nbd-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nbd-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nbd-0.2.1
[INFO] finished frobbing nbd-0.2.1
[INFO] frobbed toml for nbd-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/nbd/0.2.1/Cargo.toml
[INFO] started frobbing nbd-0.2.1
[INFO] finished frobbing nbd-0.2.1
[INFO] frobbed toml for nbd-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nbd/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nbd-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nbd/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 772586ade36ada25a5d834c84baf4438c4d524e8835655260d3273e6647c073e
[INFO] running `"docker" "start" "-a" "772586ade36ada25a5d834c84baf4438c4d524e8835655260d3273e6647c073e"`
[INFO] [stderr]     Checking readwrite v0.1.1
[INFO] [stderr]     Checking pipe v0.0.3
[INFO] [stderr]     Checking rand v0.5.6
[INFO] [stderr]     Checking nbd v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:84:27
[INFO] [stderr]    |
[INFO] [stderr] 84 |         c.write_u64::<BE>(0x3e889045565a9)?;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^ help: consider: `0x0003_e889_0455_65a9`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:115:35
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if client_optmagic != 0x49484156454F5054 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^ help: consider: `0x4948_4156_454F_5054`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:123:25
[INFO] [stderr]     |
[INFO] [stderr] 123 |             if optlen > 100000 {
[INFO] [stderr]     |                         ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:182:27
[INFO] [stderr]     |
[INFO] [stderr] 182 |         c.write_u32::<BE>(0x67446698)?;
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0x6744_6698`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 |             if magic != 0x25609513 {
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider: `0x2560_9513`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:326:31
[INFO] [stderr]     |
[INFO] [stderr] 326 |             c.write_u64::<BE>(0x49484156454F5054)?;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: consider: `0x4948_4156_454F_5054`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:434:25
[INFO] [stderr]     |
[INFO] [stderr] 434 |         if signature != 0x67446698 {
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider: `0x6744_6698`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:445:27
[INFO] [stderr]     |
[INFO] [stderr] 445 |         c.write_u32::<BE>(0x25609513)?;
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0x2560_9513`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:605:16
[INFO] [stderr]     |
[INFO] [stderr] 605 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 606 | |             if let Some(x) = rhs.checked_neg() {
[INFO] [stderr] 607 | |                 self.checked_sub(x as u64)
[INFO] [stderr] 608 | |             } else {
[INFO] [stderr] 609 | |                 None
[INFO] [stderr] 610 | |             }
[INFO] [stderr] 611 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 605 |         } else if let Some(x) = rhs.checked_neg() {
[INFO] [stderr] 606 |     self.checked_sub(x as u64)
[INFO] [stderr] 607 | } else {
[INFO] [stderr] 608 |     None
[INFO] [stderr] 609 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:230:43
[INFO] [stderr]     |
[INFO] [stderr] 230 |                             Ok(x) if x == (length as u64) => {}
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:243:43
[INFO] [stderr]     |
[INFO] [stderr] 243 |                             Ok(x) if x == (length as u64) => {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:482:30
[INFO] [stderr]     |
[INFO] [stderr] 482 |             self.seek_pos += len as u64;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `u64::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:500:30
[INFO] [stderr]     |
[INFO] [stderr] 500 |             self.seek_pos += len as u64;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `u64::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/lib.rs:565:46
[INFO] [stderr]     |
[INFO] [stderr] 565 |     pub const NBD_FLAG_FIXED_NEWSTYLE: u16 = (1 << 0);
[INFO] [stderr]     |                                              ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/lib.rs:576:41
[INFO] [stderr]     |
[INFO] [stderr] 576 |     pub const NBD_FLAG_HAS_FLAGS: u16 = (1 << 0);
[INFO] [stderr]     |                                         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:631:19
[INFO] [stderr]     |
[INFO] [stderr] 631 |         if self > u32::max_value() as u64 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Checking proptest v0.8.7
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/lib.rs:84:27
[INFO] [stderr]    |
[INFO] [stderr] 84 |         c.write_u64::<BE>(0x3e889045565a9)?;
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^ help: consider: `0x0003_e889_0455_65a9`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:115:35
[INFO] [stderr]     |
[INFO] [stderr] 115 |             if client_optmagic != 0x49484156454F5054 {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^ help: consider: `0x4948_4156_454F_5054`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:123:25
[INFO] [stderr]     |
[INFO] [stderr] 123 |             if optlen > 100000 {
[INFO] [stderr]     |                         ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:182:27
[INFO] [stderr]     |
[INFO] [stderr] 182 |         c.write_u32::<BE>(0x67446698)?;
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0x6744_6698`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:212:25
[INFO] [stderr]     |
[INFO] [stderr] 212 |             if magic != 0x25609513 {
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider: `0x2560_9513`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:326:31
[INFO] [stderr]     |
[INFO] [stderr] 326 |             c.write_u64::<BE>(0x49484156454F5054)?;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^ help: consider: `0x4948_4156_454F_5054`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:434:25
[INFO] [stderr]     |
[INFO] [stderr] 434 |         if signature != 0x67446698 {
[INFO] [stderr]     |                         ^^^^^^^^^^ help: consider: `0x6744_6698`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:445:27
[INFO] [stderr]     |
[INFO] [stderr] 445 |         c.write_u32::<BE>(0x25609513)?;
[INFO] [stderr]     |                           ^^^^^^^^^^ help: consider: `0x2560_9513`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:605:16
[INFO] [stderr]     |
[INFO] [stderr] 605 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 606 | |             if let Some(x) = rhs.checked_neg() {
[INFO] [stderr] 607 | |                 self.checked_sub(x as u64)
[INFO] [stderr] 608 | |             } else {
[INFO] [stderr] 609 | |                 None
[INFO] [stderr] 610 | |             }
[INFO] [stderr] 611 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 605 |         } else if let Some(x) = rhs.checked_neg() {
[INFO] [stderr] 606 |     self.checked_sub(x as u64)
[INFO] [stderr] 607 | } else {
[INFO] [stderr] 608 |     None
[INFO] [stderr] 609 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:230:43
[INFO] [stderr]     |
[INFO] [stderr] 230 |                             Ok(x) if x == (length as u64) => {}
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:243:43
[INFO] [stderr]     |
[INFO] [stderr] 243 |                             Ok(x) if x == (length as u64) => {
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^ help: try: `u64::from(length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:482:30
[INFO] [stderr]     |
[INFO] [stderr] 482 |             self.seek_pos += len as u64;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `u64::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:500:30
[INFO] [stderr]     |
[INFO] [stderr] 500 |             self.seek_pos += len as u64;
[INFO] [stderr]     |                              ^^^^^^^^^^ help: try: `u64::from(len)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/lib.rs:565:46
[INFO] [stderr]     |
[INFO] [stderr] 565 |     pub const NBD_FLAG_FIXED_NEWSTYLE: u16 = (1 << 0);
[INFO] [stderr]     |                                              ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1`
[INFO] [stderr]    --> src/lib.rs:576:41
[INFO] [stderr]     |
[INFO] [stderr] 576 |     pub const NBD_FLAG_HAS_FLAGS: u16 = (1 << 0);
[INFO] [stderr]     |                                         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:631:19
[INFO] [stderr]     |
[INFO] [stderr] 631 |         if self > u32::max_value() as u64 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::max_value())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 19.09s
[INFO] running `"docker" "inspect" "772586ade36ada25a5d834c84baf4438c4d524e8835655260d3273e6647c073e"`
[INFO] running `"docker" "rm" "-f" "772586ade36ada25a5d834c84baf4438c4d524e8835655260d3273e6647c073e"`
[INFO] [stdout] 772586ade36ada25a5d834c84baf4438c4d524e8835655260d3273e6647c073e