[INFO] crate nanopow-rs 0.3.3 is already in cache [INFO] extracting crate nanopow-rs 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/nanopow-rs/0.3.3 [INFO] extracting crate nanopow-rs 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanopow-rs/0.3.3 [INFO] validating manifest of nanopow-rs-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanopow-rs-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanopow-rs-0.3.3 [INFO] finished frobbing nanopow-rs-0.3.3 [INFO] frobbed toml for nanopow-rs-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/nanopow-rs/0.3.3/Cargo.toml [INFO] started frobbing nanopow-rs-0.3.3 [INFO] finished frobbing nanopow-rs-0.3.3 [INFO] frobbed toml for nanopow-rs-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanopow-rs/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanopow-rs-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nanopow-rs/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 899abd8ae51592d773d9b40b6bd38199114580dcface18c19c8a175629fc1bcb [INFO] running `"docker" "start" "-a" "899abd8ae51592d773d9b40b6bd38199114580dcface18c19c8a175629fc1bcb"` [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Checking nanopow-rs v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | string [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | let string = HEXLOWER.encode(&work.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | string [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | let string = HEXUPPER.encode(&hash.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | string [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:74:22 [INFO] [stderr] | [INFO] [stderr] 74 | let string = HEXLOWER.encode(&work.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | string [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | let string = HEXUPPER.encode(&hash.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `buf[..8].clone_from_slice(&bytes[..8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `buf[..32].clone_from_slice(&bytes[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | let first = (&hash[5..8]).iter().fold(true, |acc, &byte| { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 131 | | acc && byte == 255 [INFO] [stderr] 132 | | }); [INFO] [stderr] | |______^ help: try: `.all(|byte| byte == 255)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `buf[..8].clone_from_slice(&bytes[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:109:18 [INFO] [stderr] | [INFO] [stderr] 109 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `buf[..32].clone_from_slice(&bytes[..32])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:130:37 [INFO] [stderr] | [INFO] [stderr] 130 | let first = (&hash[5..8]).iter().fold(true, |acc, &byte| { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 131 | | acc && byte == 255 [INFO] [stderr] 132 | | }); [INFO] [stderr] | |______^ help: try: `.all(|byte| byte == 255)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:270:17 [INFO] [stderr] | [INFO] [stderr] 270 | assert!(valid == false); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `!valid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.09s [INFO] running `"docker" "inspect" "899abd8ae51592d773d9b40b6bd38199114580dcface18c19c8a175629fc1bcb"` [INFO] running `"docker" "rm" "-f" "899abd8ae51592d773d9b40b6bd38199114580dcface18c19c8a175629fc1bcb"` [INFO] [stdout] 899abd8ae51592d773d9b40b6bd38199114580dcface18c19c8a175629fc1bcb