[INFO] crate nanocurrency-protocol 0.5.1 is already in cache [INFO] extracting crate nanocurrency-protocol 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/nanocurrency-protocol/0.5.1 [INFO] extracting crate nanocurrency-protocol 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanocurrency-protocol/0.5.1 [INFO] validating manifest of nanocurrency-protocol-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanocurrency-protocol-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanocurrency-protocol-0.5.1 [INFO] finished frobbing nanocurrency-protocol-0.5.1 [INFO] frobbed toml for nanocurrency-protocol-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/nanocurrency-protocol/0.5.1/Cargo.toml [INFO] started frobbing nanocurrency-protocol-0.5.1 [INFO] finished frobbing nanocurrency-protocol-0.5.1 [INFO] frobbed toml for nanocurrency-protocol-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanocurrency-protocol/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanocurrency-protocol-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nanocurrency-protocol/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 503876762f02a26b458925af93ea7951edd0b5be3b8bc00ac186f18c4c815586 [INFO] running `"docker" "start" "-a" "503876762f02a26b458925af93ea7951edd0b5be3b8bc00ac186f18c4c815586"` [INFO] [stderr] Compiling subtle v1.0.0 [INFO] [stderr] Compiling subtle v2.0.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling rand v0.5.6 [INFO] [stderr] Compiling digest v0.8.0 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Compiling curve25519-dalek v0.20.0 [INFO] [stderr] Compiling curve25519-dalek v1.0.3 [INFO] [stderr] Checking ed25519-dalek v0.8.1 [INFO] [stderr] Checking nanocurrency-types v0.3.16 [INFO] [stderr] Checking nanocurrency-protocol v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/tests/udp_encode_decode.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | balance: 1234567890_1234567890_u128, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `12_345_678_901_234_567_890_u128` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_digit_groups)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: digit groups should be smaller [INFO] [stderr] --> src/tests/udp_encode_decode.rs:57:26 [INFO] [stderr] | [INFO] [stderr] 57 | balance: 1234567890_1234567890_u128, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `12_345_678_901_234_567_890_u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/udp_encode_decode.rs:110:23 [INFO] [stderr] | [INFO] [stderr] 110 | sequence: 123456, [INFO] [stderr] | ^^^^^^ help: consider: `123_456` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / let work; [INFO] [stderr] 155 | | if block_ty >= 6 { [INFO] [stderr] 156 | | // New block types have work in big endian [INFO] [stderr] 157 | | work = cursor.read_u64::()?; [INFO] [stderr] 158 | | } else { [INFO] [stderr] 159 | | work = cursor.read_u64::()?; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let work = if block_ty >= 6 { cursor.read_u64::()? } else { cursor.read_u64::()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:32 [INFO] [stderr] | [INFO] [stderr] 378 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:384:32 [INFO] [stderr] | [INFO] [stderr] 384 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:395:32 [INFO] [stderr] | [INFO] [stderr] 395 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / let work; [INFO] [stderr] 155 | | if block_ty >= 6 { [INFO] [stderr] 156 | | // New block types have work in big endian [INFO] [stderr] 157 | | work = cursor.read_u64::()?; [INFO] [stderr] 158 | | } else { [INFO] [stderr] 159 | | work = cursor.read_u64::()?; [INFO] [stderr] 160 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let work = if block_ty >= 6 { cursor.read_u64::()? } else { cursor.read_u64::()? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:378:32 [INFO] [stderr] | [INFO] [stderr] 378 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:384:32 [INFO] [stderr] | [INFO] [stderr] 384 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:395:32 [INFO] [stderr] | [INFO] [stderr] 395 | let type_num = Self::block_type_num(&block) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(Self::block_type_num(&block))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.75s [INFO] running `"docker" "inspect" "503876762f02a26b458925af93ea7951edd0b5be3b8bc00ac186f18c4c815586"` [INFO] running `"docker" "rm" "-f" "503876762f02a26b458925af93ea7951edd0b5be3b8bc00ac186f18c4c815586"` [INFO] [stdout] 503876762f02a26b458925af93ea7951edd0b5be3b8bc00ac186f18c4c815586