[INFO] crate nanocurrency-peering 0.6.0 is already in cache [INFO] extracting crate nanocurrency-peering 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/nanocurrency-peering/0.6.0 [INFO] extracting crate nanocurrency-peering 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanocurrency-peering/0.6.0 [INFO] validating manifest of nanocurrency-peering-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanocurrency-peering-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanocurrency-peering-0.6.0 [INFO] finished frobbing nanocurrency-peering-0.6.0 [INFO] frobbed toml for nanocurrency-peering-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/nanocurrency-peering/0.6.0/Cargo.toml [INFO] started frobbing nanocurrency-peering-0.6.0 [INFO] finished frobbing nanocurrency-peering-0.6.0 [INFO] frobbed toml for nanocurrency-peering-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nanocurrency-peering/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanocurrency-peering-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nanocurrency-peering/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2ac123215e81a3f1ddf2fca4add607bfa0e7e1f7687194d1e1d879fd30acbe5 [INFO] running `"docker" "start" "-a" "f2ac123215e81a3f1ddf2fca4add607bfa0e7e1f7687194d1e1d879fd30acbe5"` [INFO] [stderr] Compiling subtle v1.0.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Compiling digest v0.8.0 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Compiling curve25519-dalek v1.0.3 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Compiling curve25519-dalek v0.20.0 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking ed25519-dalek v0.8.1 [INFO] [stderr] Checking nanocurrency-types v0.3.16 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking nanocurrency-protocol v0.5.1 [INFO] [stderr] Checking nanocurrency-peering v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp_framed.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp_framed.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp_framed.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp_framed.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | codec: codec, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `codec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/lib.rs:229:55 [INFO] [stderr] | [INFO] [stderr] 229 | socket = UdpSocket::from_std(std_socket, &Handle::current())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'tokio::reactor::Handle::current': semantics were sometimes surprising, use Handle::default() [INFO] [stderr] --> src/lib.rs:229:55 [INFO] [stderr] | [INFO] [stderr] 229 | socket = UdpSocket::from_std(std_socket, &Handle::current())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / let socket; [INFO] [stderr] 224 | | if cfg!(target_os = "windows") { [INFO] [stderr] 225 | | // TODO this is necessary on Windows but doesn't work well [INFO] [stderr] 226 | | let std_socket = UdpBuilder::new_v6()? [INFO] [stderr] ... | [INFO] [stderr] 231 | | socket = UdpSocket::bind(&self.listen_addr)?; [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let socket = if cfg!(target_os = "windows") { ..; UdpSocket::from_std(std_socket, &Handle::current())? } else { UdpSocket::bind(&self.listen_addr)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | / match msg { [INFO] [stderr] 248 | | Message::Keepalive(new_peers) => { [INFO] [stderr] 249 | | let state = &mut state; [INFO] [stderr] 250 | | output_messages.extend(new_peers.to_vec().into_iter().filter_map( [INFO] [stderr] ... | [INFO] [stderr] 288 | | _ => {} [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let Message::Keepalive(new_peers) = msg { [INFO] [stderr] 248 | let state = &mut state; [INFO] [stderr] 249 | output_messages.extend(new_peers.to_vec().into_iter().filter_map( [INFO] [stderr] 250 | move |new_peer| { [INFO] [stderr] 251 | match state.new_peer_backoff.entry(new_peer) { [INFO] [stderr] 252 | hash_map::Entry::Occupied(mut entry) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:269:38 [INFO] [stderr] | [INFO] [stderr] 269 | let ip = new_peer.ip().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*new_peer.ip()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | / let socket; [INFO] [stderr] 224 | | if cfg!(target_os = "windows") { [INFO] [stderr] 225 | | // TODO this is necessary on Windows but doesn't work well [INFO] [stderr] 226 | | let std_socket = UdpBuilder::new_v6()? [INFO] [stderr] ... | [INFO] [stderr] 231 | | socket = UdpSocket::bind(&self.listen_addr)?; [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let socket = if cfg!(target_os = "windows") { ..; UdpSocket::from_std(std_socket, &Handle::current())? } else { UdpSocket::bind(&self.listen_addr)? };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | / match msg { [INFO] [stderr] 248 | | Message::Keepalive(new_peers) => { [INFO] [stderr] 249 | | let state = &mut state; [INFO] [stderr] 250 | | output_messages.extend(new_peers.to_vec().into_iter().filter_map( [INFO] [stderr] ... | [INFO] [stderr] 288 | | _ => {} [INFO] [stderr] 289 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let Message::Keepalive(new_peers) = msg { [INFO] [stderr] 248 | let state = &mut state; [INFO] [stderr] 249 | output_messages.extend(new_peers.to_vec().into_iter().filter_map( [INFO] [stderr] 250 | move |new_peer| { [INFO] [stderr] 251 | match state.new_peer_backoff.entry(new_peer) { [INFO] [stderr] 252 | hash_map::Entry::Occupied(mut entry) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:269:38 [INFO] [stderr] | [INFO] [stderr] 269 | let ip = new_peer.ip().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*new_peer.ip()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.86s [INFO] running `"docker" "inspect" "f2ac123215e81a3f1ddf2fca4add607bfa0e7e1f7687194d1e1d879fd30acbe5"` [INFO] running `"docker" "rm" "-f" "f2ac123215e81a3f1ddf2fca4add607bfa0e7e1f7687194d1e1d879fd30acbe5"` [INFO] [stdout] f2ac123215e81a3f1ddf2fca4add607bfa0e7e1f7687194d1e1d879fd30acbe5