[INFO] crate nametable_codegen 0.1.3 is already in cache [INFO] extracting crate nametable_codegen 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/nametable_codegen/0.1.3 [INFO] extracting crate nametable_codegen 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nametable_codegen/0.1.3 [INFO] validating manifest of nametable_codegen-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nametable_codegen-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nametable_codegen-0.1.3 [INFO] finished frobbing nametable_codegen-0.1.3 [INFO] frobbed toml for nametable_codegen-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/nametable_codegen/0.1.3/Cargo.toml [INFO] started frobbing nametable_codegen-0.1.3 [INFO] finished frobbing nametable_codegen-0.1.3 [INFO] frobbed toml for nametable_codegen-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nametable_codegen/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nametable_codegen-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nametable_codegen/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e846d786f7e90071aec034c13c03807797d153f8fc9dfa632ebe52a1571567e7 [INFO] running `"docker" "start" "-a" "e846d786f7e90071aec034c13c03807797d153f8fc9dfa632ebe52a1571567e7"` [INFO] [stderr] Checking nametable v0.1.2 [INFO] [stderr] Compiling syntex_pos v0.57.0 [INFO] [stderr] Checking syntex_errors v0.57.0 [INFO] [stderr] Checking syntex_syntax v0.57.0 [INFO] [stderr] Checking syntex v0.57.0 [INFO] [stderr] Checking quasi v0.31.0 [INFO] [stderr] Compiling aster v0.40.0 [INFO] [stderr] Compiling quasi_codegen v0.31.0 [INFO] [stderr] Compiling nametable_codegen v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | if path.segments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:432:16 [INFO] [stderr] | [INFO] [stderr] 432 | if arr.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | let mut old_val = arr.get(0).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&arr[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if arr.get(i).unwrap().0 == old_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:436:34 [INFO] [stderr] | [INFO] [stderr] 436 | return Some((arr.get(i - 1).unwrap().1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | arr.get(i).unwrap().1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:439:27 [INFO] [stderr] | [INFO] [stderr] 439 | old_val = arr.get(i).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | / match detect_collision(&hash_data.0) { [INFO] [stderr] 445 | | Some((a, b)) => { [INFO] [stderr] 446 | | println!("nametable_macros: Hash collision happened between item index {:} and {:} for table `{:}'" [INFO] [stderr] 447 | | , a , b , & * artifact_name . as_str ( )); [INFO] [stderr] ... | [INFO] [stderr] 450 | | None => (), [INFO] [stderr] 451 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 444 | if let Some((a, b)) = detect_collision(&hash_data.0) { [INFO] [stderr] 445 | println!("nametable_macros: Hash collision happened between item index {:} and {:} for table `{:}'" [INFO] [stderr] 446 | , a , b , & * artifact_name . as_str ( )); [INFO] [stderr] 447 | hash_data.0 = vec!(); [INFO] [stderr] 448 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1108:11 [INFO] [stderr] | [INFO] [stderr] 1108 | while &parser.token != &Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1108 | while parser.token != Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1115:17 [INFO] [stderr] | [INFO] [stderr] 1115 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1124:17 [INFO] [stderr] | [INFO] [stderr] 1124 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1148:13 [INFO] [stderr] | [INFO] [stderr] 1148 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1151:21 [INFO] [stderr] | [INFO] [stderr] 1151 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1154:25 [INFO] [stderr] | [INFO] [stderr] 1154 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1176:8 [INFO] [stderr] | [INFO] [stderr] 1176 | if &parser.token != &Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1176 | if parser.token != Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:109:39 [INFO] [stderr] | [INFO] [stderr] 109 | if path.segments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:432:16 [INFO] [stderr] | [INFO] [stderr] 432 | if arr.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `arr.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | let mut old_val = arr.get(0).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `&arr[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:435:20 [INFO] [stderr] | [INFO] [stderr] 435 | if arr.get(i).unwrap().0 == old_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:436:34 [INFO] [stderr] | [INFO] [stderr] 436 | return Some((arr.get(i - 1).unwrap().1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:437:34 [INFO] [stderr] | [INFO] [stderr] 437 | arr.get(i).unwrap().1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:439:27 [INFO] [stderr] | [INFO] [stderr] 439 | old_val = arr.get(i).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `arr[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | / match detect_collision(&hash_data.0) { [INFO] [stderr] 445 | | Some((a, b)) => { [INFO] [stderr] 446 | | println!("nametable_macros: Hash collision happened between item index {:} and {:} for table `{:}'" [INFO] [stderr] 447 | | , a , b , & * artifact_name . as_str ( )); [INFO] [stderr] ... | [INFO] [stderr] 450 | | None => (), [INFO] [stderr] 451 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 444 | if let Some((a, b)) = detect_collision(&hash_data.0) { [INFO] [stderr] 445 | println!("nametable_macros: Hash collision happened between item index {:} and {:} for table `{:}'" [INFO] [stderr] 446 | , a , b , & * artifact_name . as_str ( )); [INFO] [stderr] 447 | hash_data.0 = vec!(); [INFO] [stderr] 448 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1108:11 [INFO] [stderr] | [INFO] [stderr] 1108 | while &parser.token != &Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1108 | while parser.token != Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1115:17 [INFO] [stderr] | [INFO] [stderr] 1115 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1124:17 [INFO] [stderr] | [INFO] [stderr] 1124 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1148:13 [INFO] [stderr] | [INFO] [stderr] 1148 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1151:21 [INFO] [stderr] | [INFO] [stderr] 1151 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1154:25 [INFO] [stderr] | [INFO] [stderr] 1154 | let _ = parser.bump(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> /opt/crater/target/debug/build/nametable_codegen-938c8e8effd355ab/out/nametable_codegen.rs:1176:8 [INFO] [stderr] | [INFO] [stderr] 1176 | if &parser.token != &Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1176 | if parser.token != Token::Eof { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 54.40s [INFO] running `"docker" "inspect" "e846d786f7e90071aec034c13c03807797d153f8fc9dfa632ebe52a1571567e7"` [INFO] running `"docker" "rm" "-f" "e846d786f7e90071aec034c13c03807797d153f8fc9dfa632ebe52a1571567e7"` [INFO] [stdout] e846d786f7e90071aec034c13c03807797d153f8fc9dfa632ebe52a1571567e7