[INFO] crate nametable 0.1.2 is already in cache
[INFO] extracting crate nametable 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/nametable/0.1.2
[INFO] extracting crate nametable 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nametable/0.1.2
[INFO] validating manifest of nametable-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nametable-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nametable-0.1.2
[INFO] removed 1 missing tests
[INFO] finished frobbing nametable-0.1.2
[INFO] frobbed toml for nametable-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/nametable/0.1.2/Cargo.toml
[INFO] started frobbing nametable-0.1.2
[INFO] removed 1 missing tests
[INFO] finished frobbing nametable-0.1.2
[INFO] frobbed toml for nametable-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nametable/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nametable-0.1.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nametable/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ac307f159c2f6d10d92dfd97ccc0191801ad610cbcff0936f8a8b19ca9ece348
[INFO] running `"docker" "start" "-a" "ac307f159c2f6d10d92dfd97ccc0191801ad610cbcff0936f8a8b19ca9ece348"`
[INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other test targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a test target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/tests/tests.rs
[INFO] [stderr] * /opt/crater/workdir/tests/hash_tests.rs
[INFO] [stderr] * /opt/crater/workdir/tests/dynamic_tests.rs
[INFO] [stderr] * /opt/crater/workdir/tests/static_tests.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autotests = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]     Checking nametable v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return self.len_local() + self.parent().map_or(0usize, |parent_table| parent_table.len());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.len_local() + self.parent().map_or(0usize, |parent_table| parent_table.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             return self.at_local(idx - initial);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.at_local(idx - initial)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             return None;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 | /         return StaticNameTable {
[INFO] [stderr] 86 | |             initial_idx: 0usize,
[INFO] [stderr] 87 | |             names: names_,
[INFO] [stderr] 88 | |             name_offsets: name_offsets_,
[INFO] [stderr] 89 | |             parent: None,
[INFO] [stderr] 90 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 85 |         StaticNameTable {
[INFO] [stderr] 86 |             initial_idx: 0usize,
[INFO] [stderr] 87 |             names: names_,
[INFO] [stderr] 88 |             name_offsets: name_offsets_,
[INFO] [stderr] 89 |             parent: None,
[INFO] [stderr] 90 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:97:9
[INFO] [stderr]     |
[INFO] [stderr] 97  | /         return StaticNameTable {
[INFO] [stderr] 98  | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 99  | |             names: names_,
[INFO] [stderr] 100 | |             name_offsets: name_offsets_,
[INFO] [stderr] 101 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 102 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 97  |         StaticNameTable {
[INFO] [stderr] 98  |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 99  |             names: names_,
[INFO] [stderr] 100 |             name_offsets: name_offsets_,
[INFO] [stderr] 101 |             parent: Some(Box::new(parent)),
[INFO] [stderr] 102 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return DynamicNameTable {
[INFO] [stderr] 131 | |             initial_idx: 0usize,
[INFO] [stderr] 132 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 | |             parent: None,
[INFO] [stderr] 134 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         DynamicNameTable {
[INFO] [stderr] 131 |             initial_idx: 0usize,
[INFO] [stderr] 132 |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 |             parent: None,
[INFO] [stderr] 134 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 | /         return DynamicNameTable {
[INFO] [stderr] 139 | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 140 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 141 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 142 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 138 |         DynamicNameTable {
[INFO] [stderr] 139 |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 140 |             names: Box::new(Vec::new()),
[INFO] [stderr] 141 |             parent: Some(Box::new(parent)),
[INFO] [stderr] 142 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         return StaticHashedNameTable {
[INFO] [stderr] 174 | |             initial_idx: 0usize,
[INFO] [stderr] 175 | |             names: names_,
[INFO] [stderr] 176 | |             name_offsets: name_offsets_,
[INFO] [stderr] 177 | |             hash_idxes: hash_idxes_,
[INFO] [stderr] 178 | |             parent: None,
[INFO] [stderr] 179 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 173 |         StaticHashedNameTable {
[INFO] [stderr] 174 |             initial_idx: 0usize,
[INFO] [stderr] 175 |             names: names_,
[INFO] [stderr] 176 |             name_offsets: name_offsets_,
[INFO] [stderr] 177 |             hash_idxes: hash_idxes_,
[INFO] [stderr] 178 |             parent: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         return StaticHashedNameTable {
[INFO] [stderr] 189 | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 190 | |             names: names_,
[INFO] [stderr] 191 | |             name_offsets: name_offsets_,
[INFO] [stderr] 192 | |             hash_idxes: hash_idxes_,
[INFO] [stderr] 193 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 194 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 188 |         StaticHashedNameTable {
[INFO] [stderr] 189 |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 190 |             names: names_,
[INFO] [stderr] 191 |             name_offsets: name_offsets_,
[INFO] [stderr] 192 |             hash_idxes: hash_idxes_,
[INFO] [stderr] 193 |             parent: Some(Box::new(parent)),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: trait `NameTable` has a `len` method but no (possibly inherited) `is_empty` method
[INFO] [stderr]   --> src/nametable.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | / pub trait NameTable {
[INFO] [stderr] 21 | |     fn parent<'a>(&'a self) -> Option<&'a NameTable>;
[INFO] [stderr] 22 | |
[INFO] [stderr] 23 | |     fn initial_local(&self) -> usize;
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |     }
[INFO] [stderr] 59 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn parent<'a>(&'a self) -> Option<&'a NameTable>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn at_local<'a>(&'a self, idx: usize) -> &'a str;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn at<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 40 | |         let initial = self.initial_local();
[INFO] [stderr] 41 | |         if idx >= initial {
[INFO] [stderr] 42 | |             return self.at_local(idx - initial);
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 76 | |         &self.names[self.name_offsets[idx]..self.name_offsets[idx + 1]]
[INFO] [stderr] 77 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 79 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/nametable.rs:109:12
[INFO] [stderr]     |
[INFO] [stderr] 109 |     names: Box<Vec<String>>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:120:5
[INFO] [stderr]     |
[INFO] [stderr] 120 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 121 | |         self.names[idx].as_str()
[INFO] [stderr] 122 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 124 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 125 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `nametable::DynamicNameTable`
[INFO] [stderr]    --> src/nametable.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 | /     pub fn new() -> Self {
[INFO] [stderr] 130 | |         return DynamicNameTable {
[INFO] [stderr] 131 | |             initial_idx: 0usize,
[INFO] [stderr] 132 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 | |             parent: None,
[INFO] [stderr] 134 | |         };
[INFO] [stderr] 135 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 107 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `index` on this type; consider implementing the `std::ops::Index` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/nametable.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 | /     pub fn index<'x, T: NameTableIdx>(&'x self, idx: T) -> &'x str {
[INFO] [stderr] 198 | |         &self.at(idx.to_index())
[INFO] [stderr] 199 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 | /     pub fn index<'x, T: NameTableIdx>(&'x self, idx: T) -> &'x str {
[INFO] [stderr] 198 | |         &self.at(idx.to_index())
[INFO] [stderr] 199 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/nametable.rs:202:9
[INFO] [stderr]     |
[INFO] [stderr] 202 |         self.hash_idxes.len() != 0
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.hash_idxes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:237:5
[INFO] [stderr]     |
[INFO] [stderr] 237 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 238 | |         &self.names[self.name_offsets[idx]..self.name_offsets[idx + 1]]
[INFO] [stderr] 239 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 241 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 242 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return self.len_local() + self.parent().map_or(0usize, |parent_table| parent_table.len());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.len_local() + self.parent().map_or(0usize, |parent_table| parent_table.len())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:42:13
[INFO] [stderr]    |
[INFO] [stderr] 42 |             return self.at_local(idx - initial);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.at_local(idx - initial)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             return None;
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:258:5
[INFO] [stderr]     |
[INFO] [stderr] 258 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 259 | |         self.at(_index.to_index())
[INFO] [stderr] 260 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/nametable.rs:85:9
[INFO] [stderr]    |
[INFO] [stderr] 85 | /         return StaticNameTable {
[INFO] [stderr] 86 | |             initial_idx: 0usize,
[INFO] [stderr] 87 | |             names: names_,
[INFO] [stderr] 88 | |             name_offsets: name_offsets_,
[INFO] [stderr] 89 | |             parent: None,
[INFO] [stderr] 90 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 85 |         StaticNameTable {
[INFO] [stderr] 86 |             initial_idx: 0usize,
[INFO] [stderr] 87 |             names: names_,
[INFO] [stderr] 88 |             name_offsets: name_offsets_,
[INFO] [stderr] 89 |             parent: None,
[INFO] [stderr] 90 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:97:9
[INFO] [stderr]     |
[INFO] [stderr] 97  | /         return StaticNameTable {
[INFO] [stderr] 98  | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 99  | |             names: names_,
[INFO] [stderr] 100 | |             name_offsets: name_offsets_,
[INFO] [stderr] 101 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 102 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 97  |         StaticNameTable {
[INFO] [stderr] 98  |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 99  |             names: names_,
[INFO] [stderr] 100 |             name_offsets: name_offsets_,
[INFO] [stderr] 101 |             parent: Some(Box::new(parent)),
[INFO] [stderr] 102 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:266:5
[INFO] [stderr]     |
[INFO] [stderr] 266 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 267 | |         self.at(_index.to_index())
[INFO] [stderr] 268 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 | /         return DynamicNameTable {
[INFO] [stderr] 131 | |             initial_idx: 0usize,
[INFO] [stderr] 132 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 | |             parent: None,
[INFO] [stderr] 134 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 130 |         DynamicNameTable {
[INFO] [stderr] 131 |             initial_idx: 0usize,
[INFO] [stderr] 132 |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 |             parent: None,
[INFO] [stderr] 134 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 | /         return DynamicNameTable {
[INFO] [stderr] 139 | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 140 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 141 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 142 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 138 |         DynamicNameTable {
[INFO] [stderr] 139 |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 140 |             names: Box::new(Vec::new()),
[INFO] [stderr] 141 |             parent: Some(Box::new(parent)),
[INFO] [stderr] 142 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:274:5
[INFO] [stderr]     |
[INFO] [stderr] 274 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 275 | |         self.at(_index.to_index())
[INFO] [stderr] 276 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 | /         return StaticHashedNameTable {
[INFO] [stderr] 174 | |             initial_idx: 0usize,
[INFO] [stderr] 175 | |             names: names_,
[INFO] [stderr] 176 | |             name_offsets: name_offsets_,
[INFO] [stderr] 177 | |             hash_idxes: hash_idxes_,
[INFO] [stderr] 178 | |             parent: None,
[INFO] [stderr] 179 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 173 |         StaticHashedNameTable {
[INFO] [stderr] 174 |             initial_idx: 0usize,
[INFO] [stderr] 175 |             names: names_,
[INFO] [stderr] 176 |             name_offsets: name_offsets_,
[INFO] [stderr] 177 |             hash_idxes: hash_idxes_,
[INFO] [stderr] 178 |             parent: None,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         return StaticHashedNameTable {
[INFO] [stderr] 189 | |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 190 | |             names: names_,
[INFO] [stderr] 191 | |             name_offsets: name_offsets_,
[INFO] [stderr] 192 | |             hash_idxes: hash_idxes_,
[INFO] [stderr] 193 | |             parent: Some(Box::new(parent)),
[INFO] [stderr] 194 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 188 |         StaticHashedNameTable {
[INFO] [stderr] 189 |             initial_idx: parent.initial_local() + parent.len_local(),
[INFO] [stderr] 190 |             names: names_,
[INFO] [stderr] 191 |             name_offsets: name_offsets_,
[INFO] [stderr] 192 |             hash_idxes: hash_idxes_,
[INFO] [stderr] 193 |             parent: Some(Box::new(parent)),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:282:5
[INFO] [stderr]     |
[INFO] [stderr] 282 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 283 | |         self.at(_index.to_index())
[INFO] [stderr] 284 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/nametable.rs:226:9
[INFO] [stderr]     |
[INFO] [stderr] 226 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: trait `NameTable` has a `len` method but no (possibly inherited) `is_empty` method
[INFO] [stderr]   --> src/nametable.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | / pub trait NameTable {
[INFO] [stderr] 21 | |     fn parent<'a>(&'a self) -> Option<&'a NameTable>;
[INFO] [stderr] 22 | |
[INFO] [stderr] 23 | |     fn initial_local(&self) -> usize;
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |     }
[INFO] [stderr] 59 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn parent<'a>(&'a self) -> Option<&'a NameTable>;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn at_local<'a>(&'a self, idx: usize) -> &'a str;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn at<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 40 | |         let initial = self.initial_local();
[INFO] [stderr] 41 | |         if idx >= initial {
[INFO] [stderr] 42 | |             return self.at_local(idx - initial);
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |         }
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:75:5
[INFO] [stderr]    |
[INFO] [stderr] 75 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 76 | |         &self.names[self.name_offsets[idx]..self.name_offsets[idx + 1]]
[INFO] [stderr] 77 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/nametable.rs:78:5
[INFO] [stderr]    |
[INFO] [stderr] 78 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 79 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 80 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`
[INFO] [stderr]    --> src/nametable.rs:109:12
[INFO] [stderr]     |
[INFO] [stderr] 109 |     names: Box<Vec<String>>,
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::box_vec)] on by default
[INFO] [stderr]     = help: `Vec<T>` is already on the heap, `Box<Vec<T>>` makes an extra allocation.
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:120:5
[INFO] [stderr]     |
[INFO] [stderr] 120 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 121 | |         self.names[idx].as_str()
[INFO] [stderr] 122 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 124 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 125 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `nametable::DynamicNameTable`
[INFO] [stderr]    --> src/nametable.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 | /     pub fn new() -> Self {
[INFO] [stderr] 130 | |         return DynamicNameTable {
[INFO] [stderr] 131 | |             initial_idx: 0usize,
[INFO] [stderr] 132 | |             names: Box::new(Vec::new()),
[INFO] [stderr] 133 | |             parent: None,
[INFO] [stderr] 134 | |         };
[INFO] [stderr] 135 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 107 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `index` on this type; consider implementing the `std::ops::Index` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/nametable.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 | /     pub fn index<'x, T: NameTableIdx>(&'x self, idx: T) -> &'x str {
[INFO] [stderr] 198 | |         &self.at(idx.to_index())
[INFO] [stderr] 199 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 | /     pub fn index<'x, T: NameTableIdx>(&'x self, idx: T) -> &'x str {
[INFO] [stderr] 198 | |         &self.at(idx.to_index())
[INFO] [stderr] 199 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/nametable.rs:202:9
[INFO] [stderr]     |
[INFO] [stderr] 202 |         self.hash_idxes.len() != 0
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.hash_idxes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:237:5
[INFO] [stderr]     |
[INFO] [stderr] 237 | /     fn at_local<'a>(&'a self, idx: usize) -> &'a str {
[INFO] [stderr] 238 | |         &self.names[self.name_offsets[idx]..self.name_offsets[idx + 1]]
[INFO] [stderr] 239 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:240:5
[INFO] [stderr]     |
[INFO] [stderr] 240 | /     fn parent<'a>(&'a self) -> Option<&'a NameTable> {
[INFO] [stderr] 241 | |         self.parent.as_ref().map(|boxed| boxed.as_ref())
[INFO] [stderr] 242 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:258:5
[INFO] [stderr]     |
[INFO] [stderr] 258 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 259 | |         self.at(_index.to_index())
[INFO] [stderr] 260 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:266:5
[INFO] [stderr]     |
[INFO] [stderr] 266 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 267 | |         self.at(_index.to_index())
[INFO] [stderr] 268 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:274:5
[INFO] [stderr]     |
[INFO] [stderr] 274 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 275 | |         self.at(_index.to_index())
[INFO] [stderr] 276 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/nametable.rs:282:5
[INFO] [stderr]     |
[INFO] [stderr] 282 | /     fn index<'a>(&'a self, _index: T) -> &'a str {
[INFO] [stderr] 283 | |         self.at(_index.to_index())
[INFO] [stderr] 284 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.38s
[INFO] running `"docker" "inspect" "ac307f159c2f6d10d92dfd97ccc0191801ad610cbcff0936f8a8b19ca9ece348"`
[INFO] running `"docker" "rm" "-f" "ac307f159c2f6d10d92dfd97ccc0191801ad610cbcff0936f8a8b19ca9ece348"`
[INFO] [stdout] ac307f159c2f6d10d92dfd97ccc0191801ad610cbcff0936f8a8b19ca9ece348