[INFO] crate namedlock 0.6.0 is already in cache [INFO] extracting crate namedlock 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/namedlock/0.6.0 [INFO] extracting crate namedlock 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/namedlock/0.6.0 [INFO] validating manifest of namedlock-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of namedlock-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing namedlock-0.6.0 [INFO] finished frobbing namedlock-0.6.0 [INFO] frobbed toml for namedlock-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/namedlock/0.6.0/Cargo.toml [INFO] started frobbing namedlock-0.6.0 [INFO] finished frobbing namedlock-0.6.0 [INFO] frobbed toml for namedlock-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/namedlock/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting namedlock-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/namedlock/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 958f443c2fb3124f34c7dc60c629bb3fcf5fb82b8387055d7dbc3e0325b00b07 [INFO] running `"docker" "start" "-a" "958f443c2fb3124f34c7dc60c629bb3fcf5fb82b8387055d7dbc3e0325b00b07"` [INFO] [stderr] Checking namedlock v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:56 [INFO] [stderr] | [INFO] [stderr] 283 | LockSpace{names:Arc::new(Mutex::new(HashMap::new())),cleanup:cleanup} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cleanup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:56 [INFO] [stderr] | [INFO] [stderr] 283 | LockSpace{names:Arc::new(Mutex::new(HashMap::new())),cleanup:cleanup} [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cleanup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ownedmutexguard.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(OwnedMutexGuard{owned_mutex:Some(self),guard:Some(guard)}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(OwnedMutexGuard{owned_mutex:Some(self),guard:Some(guard)})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | return LockSpaceRemoveResult::Success [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LockSpaceRemoveResult::Success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return LockSpaceRemoveResult::WouldBlock [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LockSpaceRemoveResult::WouldBlock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ownedmutexguard.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | fn deref<'b>(&'b self) -> &'b T { [INFO] [stderr] | _____^ [INFO] [stderr] 89 | | // This is always Some, because it's initialized as Some, and only drop() and into_inner() turn it into None [INFO] [stderr] 90 | | match self.guard { [INFO] [stderr] 91 | | Some(ref value) => &value, [INFO] [stderr] 92 | | None => unreachable!(), // to be replace with std::intrinsics::unreachable once stable [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:181:2 [INFO] [stderr] | [INFO] [stderr] 181 | fn deref<'b>(&'b self) -> &'b V { [INFO] [stderr] | _____^ [INFO] [stderr] 182 | | // This is always Some, because it's initialized as Some, and only drop() turns it into None [INFO] [stderr] 183 | | match self.guard { [INFO] [stderr] 184 | | Some(ref value) => &value, [INFO] [stderr] 185 | | None => unreachable!(), // to be replace with std::intrinsics::unreachable once stable [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:330:2 [INFO] [stderr] | [INFO] [stderr] 330 | fn try_remove_internal<'a>(mut entry: LockSpaceEntry<'a,K,V>) -> LockSpaceRemoveResult [INFO] [stderr] | _____^ [INFO] [stderr] 331 | | { [INFO] [stderr] 332 | | let arc=entry.get_mut().take().unwrap(); [INFO] [stderr] 333 | | match Arc::try_unwrap(arc) { [INFO] [stderr] ... | [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ownedmutexguard.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(OwnedMutexGuard{owned_mutex:Some(self),guard:Some(guard)}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(OwnedMutexGuard{owned_mutex:Some(self),guard:Some(guard)})` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | return LockSpaceRemoveResult::Success [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LockSpaceRemoveResult::Success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return LockSpaceRemoveResult::WouldBlock [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LockSpaceRemoveResult::WouldBlock` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ownedmutexguard.rs:88:2 [INFO] [stderr] | [INFO] [stderr] 88 | fn deref<'b>(&'b self) -> &'b T { [INFO] [stderr] | _____^ [INFO] [stderr] 89 | | // This is always Some, because it's initialized as Some, and only drop() and into_inner() turn it into None [INFO] [stderr] 90 | | match self.guard { [INFO] [stderr] 91 | | Some(ref value) => &value, [INFO] [stderr] 92 | | None => unreachable!(), // to be replace with std::intrinsics::unreachable once stable [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:181:2 [INFO] [stderr] | [INFO] [stderr] 181 | fn deref<'b>(&'b self) -> &'b V { [INFO] [stderr] | _____^ [INFO] [stderr] 182 | | // This is always Some, because it's initialized as Some, and only drop() turns it into None [INFO] [stderr] 183 | | match self.guard { [INFO] [stderr] 184 | | Some(ref value) => &value, [INFO] [stderr] 185 | | None => unreachable!(), // to be replace with std::intrinsics::unreachable once stable [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:330:2 [INFO] [stderr] | [INFO] [stderr] 330 | fn try_remove_internal<'a>(mut entry: LockSpaceEntry<'a,K,V>) -> LockSpaceRemoveResult [INFO] [stderr] | _____^ [INFO] [stderr] 331 | | { [INFO] [stderr] 332 | | let arc=entry.get_mut().take().unwrap(); [INFO] [stderr] 333 | | match Arc::try_unwrap(arc) { [INFO] [stderr] ... | [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "958f443c2fb3124f34c7dc60c629bb3fcf5fb82b8387055d7dbc3e0325b00b07"` [INFO] running `"docker" "rm" "-f" "958f443c2fb3124f34c7dc60c629bb3fcf5fb82b8387055d7dbc3e0325b00b07"` [INFO] [stdout] 958f443c2fb3124f34c7dc60c629bb3fcf5fb82b8387055d7dbc3e0325b00b07