[INFO] crate named_type_derive 0.1.6 is already in cache [INFO] extracting crate named_type_derive 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/named_type_derive/0.1.6 [INFO] extracting crate named_type_derive 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/named_type_derive/0.1.6 [INFO] validating manifest of named_type_derive-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of named_type_derive-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing named_type_derive-0.1.6 [INFO] finished frobbing named_type_derive-0.1.6 [INFO] frobbed toml for named_type_derive-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/named_type_derive/0.1.6/Cargo.toml [INFO] started frobbing named_type_derive-0.1.6 [INFO] finished frobbing named_type_derive-0.1.6 [INFO] frobbed toml for named_type_derive-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/named_type_derive/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting named_type_derive-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/named_type_derive/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6e0e0621ccb8d80f9c1ad4d08ebbaf83dec301db1ed90bd951450c79fc0d99d [INFO] running `"docker" "start" "-a" "e6e0e0621ccb8d80f9c1ad4d08ebbaf83dec301db1ed90bd951450c79fc0d99d"` [INFO] [stderr] Checking named_type v0.1.6 [INFO] [stderr] Checking named_type_derive v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | .expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | fn find_prefix_suffix(props: &Vec) -> Option<(&str, &str)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[NestedMetaItem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | .find(|item| match item { [INFO] [stderr] | ______________________^ [INFO] [stderr] 33 | | &&NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] 34 | | ident == "short_prefix" [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => false, [INFO] [stderr] 37 | | }).and_then(|item| match item { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | .find(|item| match *item { [INFO] [stderr] 33 | &NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | }).and_then(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 38 | | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] 39 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | }, [INFO] [stderr] 42 | | _ => None, [INFO] [stderr] 43 | | }).unwrap_or(""); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | }).and_then(|item| match *item { [INFO] [stderr] 38 | NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:38:77 [INFO] [stderr] | [INFO] [stderr] 38 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 39 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match *value { [INFO] [stderr] 39 | Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | .find(|item| match item { [INFO] [stderr] | ______________________^ [INFO] [stderr] 48 | | &&NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] 49 | | ident.to_string() == "short_suffix" [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | _ => false, [INFO] [stderr] 52 | | }).and_then(|item| match item { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | .find(|item| match *item { [INFO] [stderr] 48 | &NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | ident.to_string() == "short_suffix" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | }).and_then(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 53 | | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] 54 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 55 | | _ => None, [INFO] [stderr] 56 | | }, [INFO] [stderr] 57 | | _ => None, [INFO] [stderr] 58 | | }).unwrap_or(""); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | }).and_then(|item| match *item { [INFO] [stderr] 53 | NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:77 [INFO] [stderr] | [INFO] [stderr] 53 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 54 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 55 | | _ => None, [INFO] [stderr] 56 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match *value { [INFO] [stderr] 54 | Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | .find(|attr| match &attr.value { [INFO] [stderr] | __________________________^ [INFO] [stderr] 71 | | &MetaItem::List(ref ident, _) => ident == "named_type", [INFO] [stderr] 72 | | _ => false, [INFO] [stderr] 73 | | }).and_then(|attr| match &attr.value { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | .find(|attr| match attr.value { [INFO] [stderr] 71 | MetaItem::List(ref ident, _) => ident == "named_type", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | }).and_then(|attr| match &attr.value { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 74 | | &MetaItem::List(_, ref props) => find_prefix_suffix(props), [INFO] [stderr] 75 | | _ => None, [INFO] [stderr] 76 | | }).unwrap_or(("", "")) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | }).and_then(|attr| match attr.value { [INFO] [stderr] 74 | MetaItem::List(_, ref props) => find_prefix_suffix(props), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | .expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | fn find_prefix_suffix(props: &Vec) -> Option<(&str, &str)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[NestedMetaItem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | .find(|item| match item { [INFO] [stderr] | ______________________^ [INFO] [stderr] 33 | | &&NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] 34 | | ident == "short_prefix" [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => false, [INFO] [stderr] 37 | | }).and_then(|item| match item { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | .find(|item| match *item { [INFO] [stderr] 33 | &NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | }).and_then(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 38 | | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] 39 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | }, [INFO] [stderr] 42 | | _ => None, [INFO] [stderr] 43 | | }).unwrap_or(""); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | }).and_then(|item| match *item { [INFO] [stderr] 38 | NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:38:77 [INFO] [stderr] | [INFO] [stderr] 38 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 39 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 40 | | _ => None, [INFO] [stderr] 41 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match *value { [INFO] [stderr] 39 | Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | .find(|item| match item { [INFO] [stderr] | ______________________^ [INFO] [stderr] 48 | | &&NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] 49 | | ident.to_string() == "short_suffix" [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | _ => false, [INFO] [stderr] 52 | | }).and_then(|item| match item { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | .find(|item| match *item { [INFO] [stderr] 48 | &NestedMetaItem::MetaItem(MetaItem::NameValue(ref ident, _)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | ident.to_string() == "short_suffix" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:52:28 [INFO] [stderr] | [INFO] [stderr] 52 | }).and_then(|item| match item { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 53 | | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] 54 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 55 | | _ => None, [INFO] [stderr] 56 | | }, [INFO] [stderr] 57 | | _ => None, [INFO] [stderr] 58 | | }).unwrap_or(""); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | }).and_then(|item| match *item { [INFO] [stderr] 53 | NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:53:77 [INFO] [stderr] | [INFO] [stderr] 53 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match value { [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 54 | | &Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] 55 | | _ => None, [INFO] [stderr] 56 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | &NestedMetaItem::MetaItem(MetaItem::NameValue(_, ref value)) => match *value { [INFO] [stderr] 54 | Lit::Str(ref string, _) => Some(string.as_ref()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | .find(|attr| match &attr.value { [INFO] [stderr] | __________________________^ [INFO] [stderr] 71 | | &MetaItem::List(ref ident, _) => ident == "named_type", [INFO] [stderr] 72 | | _ => false, [INFO] [stderr] 73 | | }).and_then(|attr| match &attr.value { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | .find(|attr| match attr.value { [INFO] [stderr] 71 | MetaItem::List(ref ident, _) => ident == "named_type", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:73:32 [INFO] [stderr] | [INFO] [stderr] 73 | }).and_then(|attr| match &attr.value { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 74 | | &MetaItem::List(_, ref props) => find_prefix_suffix(props), [INFO] [stderr] 75 | | _ => None, [INFO] [stderr] 76 | | }).unwrap_or(("", "")) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 73 | }).and_then(|attr| match attr.value { [INFO] [stderr] 74 | MetaItem::List(_, ref props) => find_prefix_suffix(props), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "e6e0e0621ccb8d80f9c1ad4d08ebbaf83dec301db1ed90bd951450c79fc0d99d"` [INFO] running `"docker" "rm" "-f" "e6e0e0621ccb8d80f9c1ad4d08ebbaf83dec301db1ed90bd951450c79fc0d99d"` [INFO] [stdout] e6e0e0621ccb8d80f9c1ad4d08ebbaf83dec301db1ed90bd951450c79fc0d99d