[INFO] crate namable_closures 0.2.4 is already in cache [INFO] extracting crate namable_closures 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/namable_closures/0.2.4 [INFO] extracting crate namable_closures 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/namable_closures/0.2.4 [INFO] validating manifest of namable_closures-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of namable_closures-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing namable_closures-0.2.4 [INFO] finished frobbing namable_closures-0.2.4 [INFO] frobbed toml for namable_closures-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/namable_closures/0.2.4/Cargo.toml [INFO] started frobbing namable_closures-0.2.4 [INFO] finished frobbing namable_closures-0.2.4 [INFO] frobbed toml for namable_closures-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/namable_closures/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting namable_closures-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/namable_closures/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6db852c22ae0ec2ff13c8bc8ea50bc650e3ee204c2509f0ba5327f4f13ad6d6 [INFO] running `"docker" "start" "-a" "f6db852c22ae0ec2ff13c8bc8ea50bc650e3ee204c2509f0ba5327f4f13ad6d6"` [INFO] [stderr] Checking namable_closures v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/closure_rec.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | Self { func: func, state: s} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/closure_rec.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | state: &'a mut State [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `ClosureMutRec` [INFO] [stderr] --> src/closure_rec.rs:251:34 [INFO] [stderr] | [INFO] [stderr] 251 | use closure_rec::{ClosureRec,ClosureMutRec}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `StableFnMut` [INFO] [stderr] --> src/closure_rec.rs:252:30 [INFO] [stderr] | [INFO] [stderr] 252 | use stable_fn::{StableFn,StableFnMut}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/closure_rec.rs:259:43 [INFO] [stderr] | [INFO] [stderr] 259 | assert_eq!(fac.stable_call((10,)),3628800); [INFO] [stderr] | ^^^^^^^ help: consider: `3_628_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/closure_rec.rs:269:21 [INFO] [stderr] | [INFO] [stderr] 269 | n => me.call_with_state((i1,i0+i1), (i-1,)) [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `state` [INFO] [stderr] --> src/closure_rec.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | state: &'a mut State [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/closures.rs:628:22 [INFO] [stderr] | [INFO] [stderr] 628 | let cloned = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/closures.rs:640:26 [INFO] [stderr] | [INFO] [stderr] 640 | let cloned = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/closures.rs:649:22 [INFO] [stderr] | [INFO] [stderr] 649 | let cloned = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/closures.rs:659:26 [INFO] [stderr] | [INFO] [stderr] 659 | let mut cloned = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/closures.rs:680:22 [INFO] [stderr] | [INFO] [stderr] 680 | let cloned = c.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "f6db852c22ae0ec2ff13c8bc8ea50bc650e3ee204c2509f0ba5327f4f13ad6d6"` [INFO] running `"docker" "rm" "-f" "f6db852c22ae0ec2ff13c8bc8ea50bc650e3ee204c2509f0ba5327f4f13ad6d6"` [INFO] [stdout] f6db852c22ae0ec2ff13c8bc8ea50bc650e3ee204c2509f0ba5327f4f13ad6d6