[INFO] crate nagiosplugin 0.1.0 is already in cache [INFO] extracting crate nagiosplugin 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/nagiosplugin/0.1.0 [INFO] extracting crate nagiosplugin 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nagiosplugin/0.1.0 [INFO] validating manifest of nagiosplugin-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nagiosplugin-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nagiosplugin-0.1.0 [INFO] finished frobbing nagiosplugin-0.1.0 [INFO] frobbed toml for nagiosplugin-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/nagiosplugin/0.1.0/Cargo.toml [INFO] started frobbing nagiosplugin-0.1.0 [INFO] finished frobbing nagiosplugin-0.1.0 [INFO] frobbed toml for nagiosplugin-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/nagiosplugin/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nagiosplugin-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/nagiosplugin/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e55a66e3a4a00e4d1c1af0307816ea90448540dc68e645618ceae662ed9192b4 [INFO] running `"docker" "start" "-a" "e55a66e3a4a00e4d1c1af0307816ea90448540dc68e645618ceae662ed9192b4"` [INFO] [stderr] Checking nagiosplugin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:356:20 [INFO] [stderr] | [INFO] [stderr] 356 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 357 | | if &self.value >= critical { [INFO] [stderr] 358 | | return Some(State::Critical); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 356 | } else if &self.value >= critical { [INFO] [stderr] 357 | return Some(State::Critical); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:368:20 [INFO] [stderr] | [INFO] [stderr] 368 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 369 | | if &self.value >= warning { [INFO] [stderr] 370 | | return Some(State::Warning); [INFO] [stderr] 371 | | } [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | } else if &self.value >= warning { [INFO] [stderr] 369 | return Some(State::Warning); [INFO] [stderr] 370 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &State::Ok => 0, [INFO] [stderr] 169 | | &State::Warning => 1, [INFO] [stderr] 170 | | &State::Critical => 2, [INFO] [stderr] 171 | | &State::Unknown => 3, [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | State::Ok => 0, [INFO] [stderr] 169 | State::Warning => 1, [INFO] [stderr] 170 | State::Critical => 2, [INFO] [stderr] 171 | State::Unknown => 3, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | let f = |state| match state { [INFO] [stderr] | _________________________^ [INFO] [stderr] 190 | | &State::Unknown => 0, [INFO] [stderr] 191 | | &State::Ok => 1, [INFO] [stderr] 192 | | &State::Warning => 2, [INFO] [stderr] 193 | | &State::Critical => 3, [INFO] [stderr] 194 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | let f = |state| match *state { [INFO] [stderr] 190 | State::Unknown => 0, [INFO] [stderr] 191 | State::Ok => 1, [INFO] [stderr] 192 | State::Warning => 2, [INFO] [stderr] 193 | State::Critical => 3, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:331:22 [INFO] [stderr] | [INFO] [stderr] 331 | warning: warning.map(|w| w.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `warning.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:332:23 [INFO] [stderr] | [INFO] [stderr] 332 | critical: critical.map(|c| c.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `critical.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:333:18 [INFO] [stderr] | [INFO] [stderr] 333 | min: min.map(|m| m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `min.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:334:18 [INFO] [stderr] | [INFO] [stderr] 334 | max: max.map(|m| m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `max.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:356:20 [INFO] [stderr] | [INFO] [stderr] 356 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 357 | | if &self.value >= critical { [INFO] [stderr] 358 | | return Some(State::Critical); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 356 | } else if &self.value >= critical { [INFO] [stderr] 357 | return Some(State::Critical); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:368:20 [INFO] [stderr] | [INFO] [stderr] 368 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 369 | | if &self.value >= warning { [INFO] [stderr] 370 | | return Some(State::Warning); [INFO] [stderr] 371 | | } [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | } else if &self.value >= warning { [INFO] [stderr] 369 | return Some(State::Warning); [INFO] [stderr] 370 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &State::Ok => 0, [INFO] [stderr] 169 | | &State::Warning => 1, [INFO] [stderr] 170 | | &State::Critical => 2, [INFO] [stderr] 171 | | &State::Unknown => 3, [INFO] [stderr] 172 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | State::Ok => 0, [INFO] [stderr] 169 | State::Warning => 1, [INFO] [stderr] 170 | State::Critical => 2, [INFO] [stderr] 171 | State::Unknown => 3, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | let f = |state| match state { [INFO] [stderr] | _________________________^ [INFO] [stderr] 190 | | &State::Unknown => 0, [INFO] [stderr] 191 | | &State::Ok => 1, [INFO] [stderr] 192 | | &State::Warning => 2, [INFO] [stderr] 193 | | &State::Critical => 3, [INFO] [stderr] 194 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | let f = |state| match *state { [INFO] [stderr] 190 | State::Unknown => 0, [INFO] [stderr] 191 | State::Ok => 1, [INFO] [stderr] 192 | State::Warning => 2, [INFO] [stderr] 193 | State::Critical => 3, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:331:22 [INFO] [stderr] | [INFO] [stderr] 331 | warning: warning.map(|w| w.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `warning.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:332:23 [INFO] [stderr] | [INFO] [stderr] 332 | critical: critical.map(|c| c.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `critical.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:333:18 [INFO] [stderr] | [INFO] [stderr] 333 | min: min.map(|m| m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `min.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:334:18 [INFO] [stderr] | [INFO] [stderr] 334 | max: max.map(|m| m.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `max.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:480:5 [INFO] [stderr] | [INFO] [stderr] 480 | / fn test_partial_ord_metric() { [INFO] [stderr] 481 | | let metric = PartialOrdMetric::new("test", 12, None, None, None, None, false); [INFO] [stderr] 482 | | assert_eq!(metric.name(), "test"); [INFO] [stderr] 483 | | assert_eq!(metric.state(), Some(State::Ok)); [INFO] [stderr] ... | [INFO] [stderr] 534 | | assert_eq!(metric.value(), 10); [INFO] [stderr] 535 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `"docker" "inspect" "e55a66e3a4a00e4d1c1af0307816ea90448540dc68e645618ceae662ed9192b4"` [INFO] running `"docker" "rm" "-f" "e55a66e3a4a00e4d1c1af0307816ea90448540dc68e645618ceae662ed9192b4"` [INFO] [stdout] e55a66e3a4a00e4d1c1af0307816ea90448540dc68e645618ceae662ed9192b4