[INFO] crate n_array 0.1.3 is already in cache
[INFO] extracting crate n_array 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/n_array/0.1.3
[INFO] extracting crate n_array 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/n_array/0.1.3
[INFO] validating manifest of n_array-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of n_array-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing n_array-0.1.3
[INFO] finished frobbing n_array-0.1.3
[INFO] frobbed toml for n_array-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/n_array/0.1.3/Cargo.toml
[INFO] started frobbing n_array-0.1.3
[INFO] finished frobbing n_array-0.1.3
[INFO] frobbed toml for n_array-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/n_array/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting n_array-0.1.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/n_array/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 25dff87bb4e5f83a1281c61adde86b94cdb02ea1c81f5d5fc11063c84f2184d2
[INFO] running `"docker" "start" "-a" "25dff87bb4e5f83a1281c61adde86b94cdb02ea1c81f5d5fc11063c84f2184d2"`
[INFO] [stderr]     Checking n_array v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:45:13
[INFO] [stderr]    |
[INFO] [stderr] 45 |             data: data
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return &self.data[index_to_position(self.dimensions, &self.magnitudes, index)]
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.data[index_to_position(self.dimensions, &self.magnitudes, index)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return &mut self.data[index_to_position(self.dimensions, &self.magnitudes, index)];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.data[index_to_position(self.dimensions, &self.magnitudes, index)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/helpers.rs:1:57
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn index_to_position(dimensions: usize, magnitudes: &Vec<usize>, index: &[usize]) -> usize {
[INFO] [stderr]   |                                                         ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return &self.data[index_to_position(self.dimensions, &self.magnitudes, index)]
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.data[index_to_position(self.dimensions, &self.magnitudes, index)]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return &mut self.data[index_to_position(self.dimensions, &self.magnitudes, index)];
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.data[index_to_position(self.dimensions, &self.magnitudes, index)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]  --> src/helpers.rs:8:70
[INFO] [stderr]   |
[INFO] [stderr] 8 |     for ((i, max), index) in magnitudes.iter().enumerate().zip(index.into_iter()) {
[INFO] [stderr]   |                                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/helpers.rs:13:58
[INFO] [stderr]    |
[INFO] [stderr] 13 |         target_index += index * magnitudes.iter().take(i).fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/helpers.rs:23:58
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let sum_parts: usize = mag.clone().iter().take(x).fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/helpers.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     eval.iter().rev().map(|c| *c).collect::<Vec<usize>>()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `eval.iter().rev().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/lib.rs:34:47
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:34:36
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:34:24
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = &(*mag).clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = &[usize]::clone(mag).into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `n_array`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: statement with no effect
[INFO] [stderr]   --> src/tests.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     my_n_array[&[3, 1]];
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::no_effect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/helpers.rs:1:57
[INFO] [stderr]   |
[INFO] [stderr] 1 | pub fn index_to_position(dimensions: usize, magnitudes: &Vec<usize>, index: &[usize]) -> usize {
[INFO] [stderr]   |                                                         ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]  --> src/helpers.rs:8:70
[INFO] [stderr]   |
[INFO] [stderr] 8 |     for ((i, max), index) in magnitudes.iter().enumerate().zip(index.into_iter()) {
[INFO] [stderr]   |                                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/helpers.rs:13:58
[INFO] [stderr]    |
[INFO] [stderr] 13 |         target_index += index * magnitudes.iter().take(i).fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/helpers.rs:23:58
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let sum_parts: usize = mag.clone().iter().take(x).fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/helpers.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 |     eval.iter().rev().map(|c| *c).collect::<Vec<usize>>()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `eval.iter().rev().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/lib.rs:34:47
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/lib.rs:34:36
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                                    ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:34:24
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = mag.clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = &(*mag).clone().into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 34 |         let max_size = &[usize]::clone(mag).into_iter().fold(1, |acc, &item| acc*item);
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `n_array`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "25dff87bb4e5f83a1281c61adde86b94cdb02ea1c81f5d5fc11063c84f2184d2"`
[INFO] running `"docker" "rm" "-f" "25dff87bb4e5f83a1281c61adde86b94cdb02ea1c81f5d5fc11063c84f2184d2"`
[INFO] [stdout] 25dff87bb4e5f83a1281c61adde86b94cdb02ea1c81f5d5fc11063c84f2184d2