[INFO] crate n2k-base 0.2.1 is already in cache [INFO] extracting crate n2k-base 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/n2k-base/0.2.1 [INFO] extracting crate n2k-base 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/n2k-base/0.2.1 [INFO] validating manifest of n2k-base-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of n2k-base-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing n2k-base-0.2.1 [INFO] finished frobbing n2k-base-0.2.1 [INFO] frobbed toml for n2k-base-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/n2k-base/0.2.1/Cargo.toml [INFO] started frobbing n2k-base-0.2.1 [INFO] finished frobbing n2k-base-0.2.1 [INFO] frobbed toml for n2k-base-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/n2k-base/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting n2k-base-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/n2k-base/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c3fa02c0899bdd8aebca352fb5cf302fa9198800fc706a764c3c759299de7ba [INFO] running `"docker" "start" "-a" "0c3fa02c0899bdd8aebca352fb5cf302fa9198800fc706a764c3c759299de7ba"` [INFO] [stderr] Checking n2k-base v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/j1393/mod.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | N2kName { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/mod.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | N2kMessage { header: header, len: len, body: copy } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/mod.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | N2kMessage { header: header, len: len, body: copy } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/j1393/mod.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | N2kName { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/mod.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | N2kMessage { header: header, len: len, body: copy } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n2k/mod.rs:26:38 [INFO] [stderr] | [INFO] [stderr] 26 | N2kMessage { header: header, len: len, body: copy } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | let mut id = (priority as u32) << 26 | (pgn << 8) | source as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(priority)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:9:61 [INFO] [stderr] | [INFO] [stderr] 9 | let mut id = (priority as u32) << 26 | (pgn << 8) | source as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/n2k/header/mod.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | id = id | ((destination as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id |= ((destination as u32) << 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | id = id | ((destination as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(destination)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | (dp as u32) << 16 | (pf as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(dp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | (dp as u32) << 16 | (pf as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(pf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(dp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(pf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pdu_specific)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | fn get_pdu_specific(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | fn get_pdu_format(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | fn get_data_page(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `n2k::j1393::N2kName` [INFO] [stderr] --> src/n2k/j1393/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> N2kName { [INFO] [stderr] 36 | | N2kName { data: [0x21, 0x04, 0xb4, 0x2f, 0x00, 0x91, 0x79, 0xc0] } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/n2k/j1393/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new_from_parts( [INFO] [stderr] 15 | | _unique_number: u32, // 21 bits, 0..21 [INFO] [stderr] 16 | | _manufacturer: u8, // 11 bits, 21..32 [INFO] [stderr] 17 | | _dev_instance_lower: u8, // 3 bits, 32..35 [INFO] [stderr] ... | [INFO] [stderr] 32 | | N2kName { data: data } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/n2k/j1393/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | data[7] = data[7] | _industry_group; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[7] |= _industry_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/n2k/j1393/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn get_data<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 42 | | &self.data [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | let id = N2kHeader(0x18EEFF0A); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x18EE_FF0A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:101:28 [INFO] [stderr] | [INFO] [stderr] 101 | let id = N2kHeader(0x09FD020A); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x09FD_020A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:104:34 [INFO] [stderr] | [INFO] [stderr] 104 | assert_eq!(id.get_pgn(), 130306); [INFO] [stderr] | ^^^^^^ help: consider: `130_306` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:118:34 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(id, N2kHeader(0x18EEFF0A)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x18EE_FF0A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | 130306, [INFO] [stderr] | ^^^^^^ help: consider: `130_306` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:133:34 [INFO] [stderr] | [INFO] [stderr] 133 | assert_eq!(id, N2kHeader(0x09FD020A)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x09FD_020A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/header/mod.rs:135:34 [INFO] [stderr] | [INFO] [stderr] 135 | assert_eq!(id.get_pgn(), 130306); [INFO] [stderr] | ^^^^^^ help: consider: `130_306` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/n2k/j1393/mod.rs:64:23 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(h, 0x18EEFF0A); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x18EE_FF0A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | let mut id = (priority as u32) << 26 | (pgn << 8) | source as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(priority)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:9:61 [INFO] [stderr] | [INFO] [stderr] 9 | let mut id = (priority as u32) << 26 | (pgn << 8) | source as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/n2k/header/mod.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | id = id | ((destination as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id |= ((destination as u32) << 8)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | id = id | ((destination as u32) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(destination)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | (dp as u32) << 16 | (pf as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(dp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | (dp as u32) << 16 | (pf as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(pf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(dp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(pf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/n2k/header/mod.rs:50:52 [INFO] [stderr] | [INFO] [stderr] 50 | (dp as u32) << 16 | (pf as u32) << 8 | pdu_specific as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pdu_specific)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | fn get_pdu_specific(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | fn get_pdu_format(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/n2k/header/mod.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | fn get_data_page(id: &u32) -> u8 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `n2k::j1393::N2kName` [INFO] [stderr] --> src/n2k/j1393/mod.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> N2kName { [INFO] [stderr] 36 | | N2kName { data: [0x21, 0x04, 0xb4, 0x2f, 0x00, 0x91, 0x79, 0xc0] } [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/n2k/j1393/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new_from_parts( [INFO] [stderr] 15 | | _unique_number: u32, // 21 bits, 0..21 [INFO] [stderr] 16 | | _manufacturer: u8, // 11 bits, 21..32 [INFO] [stderr] 17 | | _dev_instance_lower: u8, // 3 bits, 32..35 [INFO] [stderr] ... | [INFO] [stderr] 32 | | N2kName { data: data } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/n2k/j1393/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | data[7] = data[7] | _industry_group; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data[7] |= _industry_group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/n2k/j1393/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn get_data<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 42 | | &self.data [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "0c3fa02c0899bdd8aebca352fb5cf302fa9198800fc706a764c3c759299de7ba"` [INFO] running `"docker" "rm" "-f" "0c3fa02c0899bdd8aebca352fb5cf302fa9198800fc706a764c3c759299de7ba"` [INFO] [stdout] 0c3fa02c0899bdd8aebca352fb5cf302fa9198800fc706a764c3c759299de7ba