[INFO] crate mysql_common 0.12.0 is already in cache [INFO] extracting crate mysql_common 0.12.0 into work/ex/clippy-test-run/sources/stable/reg/mysql_common/0.12.0 [INFO] extracting crate mysql_common 0.12.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mysql_common/0.12.0 [INFO] validating manifest of mysql_common-0.12.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mysql_common-0.12.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mysql_common-0.12.0 [INFO] finished frobbing mysql_common-0.12.0 [INFO] frobbed toml for mysql_common-0.12.0 written to work/ex/clippy-test-run/sources/stable/reg/mysql_common/0.12.0/Cargo.toml [INFO] started frobbing mysql_common-0.12.0 [INFO] finished frobbing mysql_common-0.12.0 [INFO] frobbed toml for mysql_common-0.12.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mysql_common/0.12.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mysql_common-0.12.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mysql_common/0.12.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00a2ebd190cde4311b19de80dcebca2e483765bed79b36524db4682814c8ed1e [INFO] running `"docker" "start" "-a" "00a2ebd190cde4311b19de80dcebca2e483765bed79b36524db4682814c8ed1e"` [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Checking checked v0.5.0 [INFO] [stderr] Checking atoi v0.2.4 [INFO] [stderr] Checking twox-hash v1.1.2 [INFO] [stderr] Checking mysql_common v0.12.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:282:40 [INFO] [stderr] | [INFO] [stderr] 282 | Ok(_) => Ok(StringIr { bytes: bytes }), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:467:49 [INFO] [stderr] | [INFO] [stderr] 467 | Value::Bytes(bytes) => Ok(BytesIr { bytes: bytes }), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:34 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:37 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:40 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:43 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:493:21 [INFO] [stderr] | [INFO] [stderr] 493 | tm_utcoff: tm_utcoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tm_utcoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:34 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:37 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:40 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:43 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:555:17 [INFO] [stderr] | [INFO] [stderr] 555 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:34 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:37 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:40 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:43 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:592:17 [INFO] [stderr] | [INFO] [stderr] 592 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:704:44 [INFO] [stderr] | [INFO] [stderr] 704 | Value::Time(false, 0, h, m, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:723:17 [INFO] [stderr] | [INFO] [stderr] 723 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:1136:21 [INFO] [stderr] | [INFO] [stderr] 1136 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:1137:21 [INFO] [stderr] | [INFO] [stderr] 1137 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:37 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:135:42 [INFO] [stderr] | [INFO] [stderr] 135 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:34 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:37 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:40 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:34 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:37 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:40 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:43 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:400:39 [INFO] [stderr] | [INFO] [stderr] 400 | Value::Time(neg, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:408:39 [INFO] [stderr] | [INFO] [stderr] 408 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:408:42 [INFO] [stderr] | [INFO] [stderr] 408 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packets.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:282:40 [INFO] [stderr] | [INFO] [stderr] 282 | Ok(_) => Ok(StringIr { bytes: bytes }), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:467:49 [INFO] [stderr] | [INFO] [stderr] 467 | Value::Bytes(bytes) => Ok(BytesIr { bytes: bytes }), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:34 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:37 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:40 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:483:43 [INFO] [stderr] | [INFO] [stderr] 483 | Value::Date(y, m, d, h, i, s, u) => Ok(ParseIr { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:493:21 [INFO] [stderr] | [INFO] [stderr] 493 | tm_utcoff: tm_utcoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tm_utcoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:34 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:37 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:40 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:534:43 [INFO] [stderr] | [INFO] [stderr] 534 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:555:17 [INFO] [stderr] | [INFO] [stderr] 555 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:34 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:37 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:40 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:573:43 [INFO] [stderr] | [INFO] [stderr] 573 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:592:17 [INFO] [stderr] | [INFO] [stderr] 592 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/convert.rs:704:44 [INFO] [stderr] | [INFO] [stderr] 704 | Value::Time(false, 0, h, m, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:723:17 [INFO] [stderr] | [INFO] [stderr] 723 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:1136:21 [INFO] [stderr] | [INFO] [stderr] 1136 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/convert.rs:1137:21 [INFO] [stderr] | [INFO] [stderr] 1137 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/value/json/serde_integration.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:121:37 [INFO] [stderr] | [INFO] [stderr] 121 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:37 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:124:43 [INFO] [stderr] | [INFO] [stderr] 124 | Value::Date(y, m, d, h, i, s, u) => format!( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:135:42 [INFO] [stderr] | [INFO] [stderr] 135 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:34 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:37 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:389:40 [INFO] [stderr] | [INFO] [stderr] 389 | Value::Date(y, m, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:34 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:37 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:40 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:393:43 [INFO] [stderr] | [INFO] [stderr] 393 | Value::Date(y, m, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:400:39 [INFO] [stderr] | [INFO] [stderr] 400 | Value::Time(neg, d, h, i, s, 0) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:408:39 [INFO] [stderr] | [INFO] [stderr] 408 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/value/mod.rs:408:42 [INFO] [stderr] | [INFO] [stderr] 408 | Value::Time(neg, d, h, i, s, u) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:72:55 [INFO] [stderr] | [INFO] [stderr] 72 | const CLIENT_LONG_PASSWORD = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:75:55 [INFO] [stderr] | [INFO] [stderr] 75 | const CLIENT_FOUND_ROWS = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | const CLIENT_LONG_FLAG = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:93:55 [INFO] [stderr] | [INFO] [stderr] 93 | const CLIENT_CONNECT_WITH_DB = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:96:55 [INFO] [stderr] | [INFO] [stderr] 96 | const CLIENT_NO_SCHEMA = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:105:55 [INFO] [stderr] | [INFO] [stderr] 105 | const CLIENT_COMPRESS = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:108:55 [INFO] [stderr] | [INFO] [stderr] 108 | const CLIENT_ODBC = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:117:55 [INFO] [stderr] | [INFO] [stderr] 117 | const CLIENT_LOCAL_FILES = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | const CLIENT_IGNORE_SPACE = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:128:55 [INFO] [stderr] | [INFO] [stderr] 128 | const CLIENT_PROTOCOL_41 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:138:55 [INFO] [stderr] | [INFO] [stderr] 138 | const CLIENT_INTERACTIVE = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:147:55 [INFO] [stderr] | [INFO] [stderr] 147 | const CLIENT_SSL = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:153:55 [INFO] [stderr] | [INFO] [stderr] 153 | const CLIENT_IGNORE_SIGPIPE = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:165:55 [INFO] [stderr] | [INFO] [stderr] 165 | const CLIENT_TRANSACTIONS = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | const CLIENT_RESERVED = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:169:55 [INFO] [stderr] | [INFO] [stderr] 169 | const CLIENT_SECURE_CONNECTION = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:179:55 [INFO] [stderr] | [INFO] [stderr] 179 | const CLIENT_MULTI_STATEMENTS = 0x00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:192:55 [INFO] [stderr] | [INFO] [stderr] 192 | const CLIENT_MULTI_RESULTS = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:204:55 [INFO] [stderr] | [INFO] [stderr] 204 | const CLIENT_PS_MULTI_RESULTS = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:217:55 [INFO] [stderr] | [INFO] [stderr] 217 | const CLIENT_PLUGIN_AUTH = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:226:55 [INFO] [stderr] | [INFO] [stderr] 226 | const CLIENT_CONNECT_ATTRS = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:246:55 [INFO] [stderr] | [INFO] [stderr] 246 | const CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | const CLIENT_CAN_HANDLE_EXPIRED_PASSWORDS = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:266:55 [INFO] [stderr] | [INFO] [stderr] 266 | const CLIENT_SESSION_TRACK = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:284:55 [INFO] [stderr] | [INFO] [stderr] 284 | const CLIENT_DEPRECATE_EOF = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:287:55 [INFO] [stderr] | [INFO] [stderr] 287 | const CLIENT_PROGRESS_OBSOLETE = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:292:55 [INFO] [stderr] | [INFO] [stderr] 292 | const CLIENT_SSL_VERIFY_SERVER_CERT = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:295:55 [INFO] [stderr] | [INFO] [stderr] 295 | const CLIENT_REMEMBER_OPTIONS = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/packets.rs:102:20 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 103 | | if last_packet_part == self.part_length as usize { [INFO] [stderr] 104 | | ParseResult::Done(RawPacket(self.data), self.last_seq_id) [INFO] [stderr] 105 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if last_packet_part == self.part_length as usize { [INFO] [stderr] 103 | ParseResult::Done(RawPacket(self.data), self.last_seq_id) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | let part_length = self.part_length; [INFO] [stderr] 106 | ParseResult::Incomplete(self, part_length as usize - last_packet_part) [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:153:50 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:154:54 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:155:49 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:156:53 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:299:19 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:319:28 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:320:29 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:327:30 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:374:36 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packets.rs:378:33 [INFO] [stderr] | [INFO] [stderr] 378 | session_state_info [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packets.rs:377:58 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:377:58 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:593:33 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/mod.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 162 | | if input[0] == 0xfb { [INFO] [stderr] 163 | | let _ = input.read_u8(); [INFO] [stderr] 164 | | Ok(Value::NULL) [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | } else if input[0] == 0xfb { [INFO] [stderr] 162 | let _ = input.read_u8(); [INFO] [stderr] 163 | Ok(Value::NULL) [INFO] [stderr] 164 | } else { [INFO] [stderr] 165 | Ok(Value::Bytes(read_lenenc_str!(input)?.into())) [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:72:55 [INFO] [stderr] | [INFO] [stderr] 72 | const CLIENT_LONG_PASSWORD = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:75:55 [INFO] [stderr] | [INFO] [stderr] 75 | const CLIENT_FOUND_ROWS = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | const CLIENT_LONG_FLAG = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:93:55 [INFO] [stderr] | [INFO] [stderr] 93 | const CLIENT_CONNECT_WITH_DB = 0x00000008; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:96:55 [INFO] [stderr] | [INFO] [stderr] 96 | const CLIENT_NO_SCHEMA = 0x00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:105:55 [INFO] [stderr] | [INFO] [stderr] 105 | const CLIENT_COMPRESS = 0x00000020; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:108:55 [INFO] [stderr] | [INFO] [stderr] 108 | const CLIENT_ODBC = 0x00000040; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0040` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:117:55 [INFO] [stderr] | [INFO] [stderr] 117 | const CLIENT_LOCAL_FILES = 0x00000080; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | const CLIENT_IGNORE_SPACE = 0x00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:128:55 [INFO] [stderr] | [INFO] [stderr] 128 | const CLIENT_PROTOCOL_41 = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:138:55 [INFO] [stderr] | [INFO] [stderr] 138 | const CLIENT_INTERACTIVE = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:147:55 [INFO] [stderr] | [INFO] [stderr] 147 | const CLIENT_SSL = 0x00000800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:153:55 [INFO] [stderr] | [INFO] [stderr] 153 | const CLIENT_IGNORE_SIGPIPE = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:165:55 [INFO] [stderr] | [INFO] [stderr] 165 | const CLIENT_TRANSACTIONS = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:167:55 [INFO] [stderr] | [INFO] [stderr] 167 | const CLIENT_RESERVED = 0x00004000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:169:55 [INFO] [stderr] | [INFO] [stderr] 169 | const CLIENT_SECURE_CONNECTION = 0x00008000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_8000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:179:55 [INFO] [stderr] | [INFO] [stderr] 179 | const CLIENT_MULTI_STATEMENTS = 0x00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:192:55 [INFO] [stderr] | [INFO] [stderr] 192 | const CLIENT_MULTI_RESULTS = 0x00020000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:204:55 [INFO] [stderr] | [INFO] [stderr] 204 | const CLIENT_PS_MULTI_RESULTS = 0x00040000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0004_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:217:55 [INFO] [stderr] | [INFO] [stderr] 217 | const CLIENT_PLUGIN_AUTH = 0x00080000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0008_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:226:55 [INFO] [stderr] | [INFO] [stderr] 226 | const CLIENT_CONNECT_ATTRS = 0x00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:246:55 [INFO] [stderr] | [INFO] [stderr] 246 | const CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA = 0x00200000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | const CLIENT_CAN_HANDLE_EXPIRED_PASSWORDS = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:266:55 [INFO] [stderr] | [INFO] [stderr] 266 | const CLIENT_SESSION_TRACK = 0x00800000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0080_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:284:55 [INFO] [stderr] | [INFO] [stderr] 284 | const CLIENT_DEPRECATE_EOF = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:287:55 [INFO] [stderr] | [INFO] [stderr] 287 | const CLIENT_PROGRESS_OBSOLETE = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:292:55 [INFO] [stderr] | [INFO] [stderr] 292 | const CLIENT_SSL_VERIFY_SERVER_CERT = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/constants.rs:295:55 [INFO] [stderr] | [INFO] [stderr] 295 | const CLIENT_REMEMBER_OPTIONS = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/packets.rs:102:20 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 103 | | if last_packet_part == self.part_length as usize { [INFO] [stderr] 104 | | ParseResult::Done(RawPacket(self.data), self.last_seq_id) [INFO] [stderr] 105 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if last_packet_part == self.part_length as usize { [INFO] [stderr] 103 | ParseResult::Done(RawPacket(self.data), self.last_seq_id) [INFO] [stderr] 104 | } else { [INFO] [stderr] 105 | let part_length = self.part_length; [INFO] [stderr] 106 | ParseResult::Incomplete(self, part_length as usize - last_packet_part) [INFO] [stderr] 107 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:152:51 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:153:50 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:154:54 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:155:49 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:156:53 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:299:19 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:319:28 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:320:29 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:327:30 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `reader` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:374:36 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/packets.rs:378:33 [INFO] [stderr] | [INFO] [stderr] 378 | session_state_info [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/packets.rs:377:58 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:377:58 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lib.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | *$reader = rest; [INFO] [stderr] | ^^^^^^^^ help: try this: `payload` [INFO] [stderr] | [INFO] [stderr] ::: src/packets.rs:593:33 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/packets.rs:1325:49 [INFO] [stderr] | [INFO] [stderr] 1325 | CapabilityFlags::from_bits_truncate(0xc00fffff) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc00f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/value/mod.rs:161:16 [INFO] [stderr] | [INFO] [stderr] 161 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 162 | | if input[0] == 0xfb { [INFO] [stderr] 163 | | let _ = input.read_u8(); [INFO] [stderr] 164 | | Ok(Value::NULL) [INFO] [stderr] ... | [INFO] [stderr] 167 | | } [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | } else if input[0] == 0xfb { [INFO] [stderr] 162 | let _ = input.read_u8(); [INFO] [stderr] 163 | Ok(Value::NULL) [INFO] [stderr] 164 | } else { [INFO] [stderr] 165 | Ok(Value::Bytes(read_lenenc_str!(input)?.into())) [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/crypto/der.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/crypto/der.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | (BigUint::from_bytes_be(&der[1..len + 1]), &der[len + 1..]) [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crypto/rsa.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | let output = (0..ceil_div(len, Self::HASH_LEN)) [INFO] [stderr] | ______________________^ [INFO] [stderr] 87 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..ceil_div(len, Self::HASH_LEN))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crypto/rsa.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let seed: Vec<_> = (0..Self::HASH_LEN) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 120 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..Self::HASH_LEN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | x if x < 0xfc => Ok(x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/named_params.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match state { [INFO] [stderr] 79 | | InNamedParam => params[cur_param].1 = query.len(), [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ help: try this: `if let InNamedParam = state { params[cur_param].1 = query.len() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/named_params.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:153:67 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:153:67 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:155:66 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:155:66 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:156:70 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:156:70 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:299:36 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:299:36 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:319:45 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:319:45 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:320:46 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:320:46 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:331:51 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:331:51 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:374:53 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:374:53 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:377:75 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:377:75 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packets.rs:415:22 [INFO] [stderr] | [INFO] [stderr] 415 | info: if info.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packets.rs:420:36 [INFO] [stderr] | [INFO] [stderr] 420 | session_state_info: if session_state_info.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!session_state_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packets.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn info_str<'x>(&'x self) -> Option> { [INFO] [stderr] 474 | | self.info [INFO] [stderr] 475 | | .as_ref() [INFO] [stderr] 476 | | .map(|x| String::from_utf8_lossy(x.as_ref())) [INFO] [stderr] 477 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packets.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | / fn new<'x>( [INFO] [stderr] 495 | | stage: u8, [INFO] [stderr] 496 | | max_stage: u8, [INFO] [stderr] 497 | | progress: u32, [INFO] [stderr] ... | [INFO] [stderr] 505 | | } [INFO] [stderr] 506 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:593:50 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:593:50 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packets.rs:946:13 [INFO] [stderr] | [INFO] [stderr] 946 | capabilities_1 as u32 | ((capabilities_2 as u32) << 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(capabilities_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packets.rs:946:38 [INFO] [stderr] | [INFO] [stderr] 946 | capabilities_1 as u32 | ((capabilities_2 as u32) << 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(capabilities_2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/packets.rs:1136:13 [INFO] [stderr] | [INFO] [stderr] 1136 | / let mut collation = UTF8_GENERAL_CI; [INFO] [stderr] 1137 | | if server_version >= (5, 5, 3) { [INFO] [stderr] 1138 | | collation = UTF8MB4_GENERAL_CI; [INFO] [stderr] 1139 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let collation = if server_version >= (5, 5, 3) { UTF8MB4_GENERAL_CI } else { UTF8_GENERAL_CI };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packets.rs:1165:5 [INFO] [stderr] | [INFO] [stderr] 1165 | / pub fn as_ref(&self) -> &[u8] { [INFO] [stderr] 1166 | | &self.data[..] [INFO] [stderr] 1167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packets.rs:1188:5 [INFO] [stderr] | [INFO] [stderr] 1188 | / pub fn as_ref(&self) -> &[u8] { [INFO] [stderr] 1189 | | &*self.data [INFO] [stderr] 1190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/params.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | Positional(SmallVec<[Value; 12]>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 40 | Positional(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/params.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | named_params: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/params.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if raw_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/params.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / if map.contains_key(&name) { [INFO] [stderr] 109 | | panic!("Redefinition of named parameter `{}'", name); [INFO] [stderr] 110 | | } else { [INFO] [stderr] 111 | | map.insert(name, Value::from(value)); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ help: consider using: `map.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/params.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | for v in x.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/params.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if raw_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:374:38 [INFO] [stderr] | [INFO] [stderr] 374 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:437:38 [INFO] [stderr] | [INFO] [stderr] 437 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:515:38 [INFO] [stderr] | [INFO] [stderr] 515 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:631:10 [INFO] [stderr] | [INFO] [stderr] 631 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:766:10 [INFO] [stderr] | [INFO] [stderr] 766 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:921:10 [INFO] [stderr] | [INFO] [stderr] 921 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/row/mod.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | values: values.into_iter().map(|value| Some(value)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: item `row::Row` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/row/mod.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl Row { [INFO] [stderr] 57 | | /// Returns length of a row. [INFO] [stderr] 58 | | pub fn len(&self) -> usize { [INFO] [stderr] 59 | | self.values.len() [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/row/mod.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / fn index<'a>(&'a self, index: usize) -> &'a Value { [INFO] [stderr] 152 | | self.values[index].as_ref().unwrap() [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/row/mod.rs:171:28 [INFO] [stderr] | [INFO] [stderr] 171 | fn idx(&self, columns: &Vec) -> Option; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Column]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scramble.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scramble.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/value/convert.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / Self::from_value_opt(v) [INFO] [stderr] 106 | | .ok() [INFO] [stderr] 107 | | .expect("Could not retrieve Self from Value") [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/value/convert.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / ::from_value_opt(v) [INFO] [stderr] 243 | | .ok() [INFO] [stderr] 244 | | .expect("Could not retrieve Option from Value") [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:364:37 [INFO] [stderr] | [INFO] [stderr] 364 | Value::Float(x) if x >= ::std::f32::MIN as f64 && x <= ::std::f32::MAX as f64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::f32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:364:68 [INFO] [stderr] | [INFO] [stderr] 364 | Value::Float(x) if x >= ::std::f32::MIN as f64 && x <= ::std::f32::MAX as f64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::f32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:486:30 [INFO] [stderr] | [INFO] [stderr] 486 | tm_year: y as i32 - 1_900, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:487:29 [INFO] [stderr] | [INFO] [stderr] 487 | tm_mon: m as i32 - 1, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:488:30 [INFO] [stderr] | [INFO] [stderr] 488 | tm_mday: d as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:489:30 [INFO] [stderr] | [INFO] [stderr] 489 | tm_hour: h as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:490:29 [INFO] [stderr] | [INFO] [stderr] 490 | tm_min: i as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:491:29 [INFO] [stderr] | [INFO] [stderr] 491 | tm_sec: s as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/value/convert.rs:504:30 [INFO] [stderr] | [INFO] [stderr] 504 | .or(strptime(s, "%Y-%m-%d")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| strptime(s, "%Y-%m-%d"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:52 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:62 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:72 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:58 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:68 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:78 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:52 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:62 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:72 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/convert.rs:609:8 [INFO] [stderr] | [INFO] [stderr] 609 | if bytes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/convert.rs:658:8 [INFO] [stderr] | [INFO] [stderr] 658 | if bytes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:58 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:68 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:78 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:743:28 [INFO] [stderr] | [INFO] [stderr] 743 | let secs = seconds as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:744:23 [INFO] [stderr] | [INFO] [stderr] 744 | + minutes as u64 * 60 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:745:23 [INFO] [stderr] | [INFO] [stderr] 745 | + hours as u64 * 60 * 60 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:746:23 [INFO] [stderr] | [INFO] [stderr] 746 | + days as u64 * 60 * 60 * 24; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:36 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:53 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:75 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:781:53 [INFO] [stderr] | [INFO] [stderr] 781 | let duration = time::Duration::days(days as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:782:45 [INFO] [stderr] | [INFO] [stderr] 782 | + time::Duration::hours(hours as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:783:47 [INFO] [stderr] | [INFO] [stderr] 783 | + time::Duration::minutes(minutes as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:784:47 [INFO] [stderr] | [INFO] [stderr] 784 | + time::Duration::seconds(seconds as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:785:52 [INFO] [stderr] | [INFO] [stderr] 785 | + time::Duration::microseconds(microseconds as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(microseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:794:62 [INFO] [stderr] | [INFO] [stderr] 794 | let duration = time::Duration::hours(hours as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:795:55 [INFO] [stderr] | [INFO] [stderr] 795 | + time::Duration::minutes(minutes as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:796:55 [INFO] [stderr] | [INFO] [stderr] 796 | + time::Duration::seconds(seconds as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:797:60 [INFO] [stderr] | [INFO] [stderr] 797 | + time::Duration::microseconds(microseconds as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(microseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 859 | impl_from_value_num!(i8, "Could not retrieve i8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 859 | impl_from_value_num!(i8, "Could not retrieve i8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 861 | impl_from_value_num!(i16, "Could not retrieve i16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 861 | impl_from_value_num!(i16, "Could not retrieve i16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 863 | impl_from_value_num!(i32, "Could not retrieve i32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 863 | impl_from_value_num!(i32, "Could not retrieve i32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 917 | into_value_impl!(i8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 918 | into_value_impl!(u8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 919 | into_value_impl!(i16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 920 | into_value_impl!(u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 921 | into_value_impl!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 922 | into_value_impl!(u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:939:22 [INFO] [stderr] | [INFO] [stderr] 939 | Value::Float(x as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1037:23 [INFO] [stderr] | [INFO] [stderr] 1037 | let micros = (x.subsec_nanos() as f64 / 1000_f64).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1039:23 [INFO] [stderr] | [INFO] [stderr] 1039 | secs_total -= seconds as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1041:23 [INFO] [stderr] | [INFO] [stderr] 1041 | secs_total -= (minutes as u64) * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1043:23 [INFO] [stderr] | [INFO] [stderr] 1043 | secs_total -= (hours as u64) * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/crypto/der.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/crypto/der.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | (BigUint::from_bytes_be(&der[1..len + 1]), &der[len + 1..]) [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crypto/rsa.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | let output = (0..ceil_div(len, Self::HASH_LEN)) [INFO] [stderr] | ______________________^ [INFO] [stderr] 87 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..ceil_div(len, Self::HASH_LEN))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crypto/rsa.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let seed: Vec<_> = (0..Self::HASH_LEN) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 120 | | .into_iter() [INFO] [stderr] | |________________________^ help: consider removing `.into_iter()`: `(0..Self::HASH_LEN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/io.rs:17:33 [INFO] [stderr] | [INFO] [stderr] 17 | x if x < 0xfc => Ok(x as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:130:62 [INFO] [stderr] | [INFO] [stderr] 130 | format!("'-{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:132:61 [INFO] [stderr] | [INFO] [stderr] 132 | format!("'{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:137:68 [INFO] [stderr] | [INFO] [stderr] 137 | format!("'-{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:139:67 [INFO] [stderr] | [INFO] [stderr] 139 | format!("'{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | Ok(Int(input.read_u8()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/named_params.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / match state { [INFO] [stderr] 79 | | InNamedParam => params[cur_param].1 = query.len(), [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ help: try this: `if let InNamedParam = state { params[cur_param].1 = query.len() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:210:28 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(Int(input.read_i8()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/named_params.rs:82:8 [INFO] [stderr] | [INFO] [stderr] 82 | if params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | Ok(Int(input.read_u16::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | Ok(Int(input.read_i16::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:222:28 [INFO] [stderr] | [INFO] [stderr] 222 | Ok(Int(input.read_u32::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:224:28 [INFO] [stderr] | [INFO] [stderr] 224 | Ok(Int(input.read_i32::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | ColumnType::MYSQL_TYPE_FLOAT => Ok(Float(input.read_f32::()? as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(input.read_f32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:347:44 [INFO] [stderr] | [INFO] [stderr] 347 | Value::Bytes(ref bytes) if bytes.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:402:62 [INFO] [stderr] | [INFO] [stderr] 402 | format!("'-{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:404:61 [INFO] [stderr] | [INFO] [stderr] 404 | format!("'{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:410:68 [INFO] [stderr] | [INFO] [stderr] 410 | format!("'-{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:412:67 [INFO] [stderr] | [INFO] [stderr] 412 | format!("'{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:152:68 [INFO] [stderr] | [INFO] [stderr] 152 | schema = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:153:67 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:153:67 [INFO] [stderr] | [INFO] [stderr] 153 | table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | org_table = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:155:66 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:155:66 [INFO] [stderr] | [INFO] [stderr] 155 | name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:156:70 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:156:70 [INFO] [stderr] | [INFO] [stderr] 156 | org_name = get_offset_and_len!(payload, read_lenenc_str!(&mut reader)?); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:299:36 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:299:36 [INFO] [stderr] | [INFO] [stderr] 299 | data: read_lenenc_str!(&mut payload)?.into(), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:319:45 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:319:45 [INFO] [stderr] | [INFO] [stderr] 319 | let name = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:320:46 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:320:46 [INFO] [stderr] | [INFO] [stderr] 320 | let value = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:327:47 [INFO] [stderr] | [INFO] [stderr] 327 | let schema = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:331:51 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:331:51 [INFO] [stderr] | [INFO] [stderr] 331 | let is_tracked = read_lenenc_str!(&mut reader)?; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:374:53 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:374:53 [INFO] [stderr] | [INFO] [stderr] 374 | let info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:377:75 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:377:75 [INFO] [stderr] | [INFO] [stderr] 377 | let session_state_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packets.rs:415:22 [INFO] [stderr] | [INFO] [stderr] 415 | info: if info.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/packets.rs:420:36 [INFO] [stderr] | [INFO] [stderr] 420 | session_state_info: if session_state_info.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!session_state_info.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packets.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn info_str<'x>(&'x self) -> Option> { [INFO] [stderr] 474 | | self.info [INFO] [stderr] 475 | | .as_ref() [INFO] [stderr] 476 | | .map(|x| String::from_utf8_lossy(x.as_ref())) [INFO] [stderr] 477 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packets.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | / fn new<'x>( [INFO] [stderr] 495 | | stage: u8, [INFO] [stderr] 496 | | max_stage: u8, [INFO] [stderr] 497 | | progress: u32, [INFO] [stderr] ... | [INFO] [stderr] 505 | | } [INFO] [stderr] 506 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `len` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:593:50 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `split_at` doesn't need a mutable reference [INFO] [stderr] --> src/packets.rs:593:50 [INFO] [stderr] | [INFO] [stderr] 593 | let progress_info = read_lenenc_str!(&mut payload)?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packets.rs:946:13 [INFO] [stderr] | [INFO] [stderr] 946 | capabilities_1 as u32 | ((capabilities_2 as u32) << 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(capabilities_1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/packets.rs:946:38 [INFO] [stderr] | [INFO] [stderr] 946 | capabilities_1 as u32 | ((capabilities_2 as u32) << 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(capabilities_2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/packets.rs:1136:13 [INFO] [stderr] | [INFO] [stderr] 1136 | / let mut collation = UTF8_GENERAL_CI; [INFO] [stderr] 1137 | | if server_version >= (5, 5, 3) { [INFO] [stderr] 1138 | | collation = UTF8MB4_GENERAL_CI; [INFO] [stderr] 1139 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let collation = if server_version >= (5, 5, 3) { UTF8MB4_GENERAL_CI } else { UTF8_GENERAL_CI };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packets.rs:1165:5 [INFO] [stderr] | [INFO] [stderr] 1165 | / pub fn as_ref(&self) -> &[u8] { [INFO] [stderr] 1166 | | &self.data[..] [INFO] [stderr] 1167 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: defining a method called `as_ref` on this type; consider implementing the `std::convert::AsRef` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packets.rs:1188:5 [INFO] [stderr] | [INFO] [stderr] 1188 | / pub fn as_ref(&self) -> &[u8] { [INFO] [stderr] 1189 | | &*self.data [INFO] [stderr] 1190 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/packets.rs:1411:5 [INFO] [stderr] | [INFO] [stderr] 1411 | / fn should_parse_ok_packet() { [INFO] [stderr] 1412 | | const PLAIN_OK: &[u8] = b"\x00\x00\x00\x02\x00\x00\x00"; [INFO] [stderr] 1413 | | const SESS_STATE_SYS_VAR_OK: &[u8] = [INFO] [stderr] 1414 | | (b"\x00\x00\x00\x02\x40\x00\x00\x00\x11\x00\x0f\x0a\x61\ [INFO] [stderr] ... | [INFO] [stderr] 1489 | | assert_eq!(ok_packet.session_state_info(), None); [INFO] [stderr] 1490 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/params.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | Positional(SmallVec<[Value; 12]>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 40 | Positional(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/params.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | named_params: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/params.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if raw_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/params.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | / if map.contains_key(&name) { [INFO] [stderr] 109 | | panic!("Redefinition of named parameter `{}'", name); [INFO] [stderr] 110 | | } else { [INFO] [stderr] 111 | | map.insert(name, Value::from(value)); [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ help: consider using: `map.entry(name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/params.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | for v in x.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/params.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if raw_params.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `raw_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:374:38 [INFO] [stderr] | [INFO] [stderr] 374 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:437:38 [INFO] [stderr] | [INFO] [stderr] 437 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:515:38 [INFO] [stderr] | [INFO] [stderr] 515 | fn from_row_opt(mut row: Row) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:631:10 [INFO] [stderr] | [INFO] [stderr] 631 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:766:10 [INFO] [stderr] | [INFO] [stderr] 766 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/row/convert.rs:921:10 [INFO] [stderr] | [INFO] [stderr] 921 | ) -> Result<(T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12), FromRowError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/row/mod.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | values: values.into_iter().map(|value| Some(value)).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: item `row::Row` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/row/mod.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / impl Row { [INFO] [stderr] 57 | | /// Returns length of a row. [INFO] [stderr] 58 | | pub fn len(&self) -> usize { [INFO] [stderr] 59 | | self.values.len() [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/row/mod.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / fn index<'a>(&'a self, index: usize) -> &'a Value { [INFO] [stderr] 152 | | self.values[index].as_ref().unwrap() [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/row/mod.rs:171:28 [INFO] [stderr] | [INFO] [stderr] 171 | fn idx(&self, columns: &Vec) -> Option; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Column]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scramble.rs:48:8 [INFO] [stderr] | [INFO] [stderr] 48 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scramble.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | if password.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `password.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/value/convert.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / Self::from_value_opt(v) [INFO] [stderr] 106 | | .ok() [INFO] [stderr] 107 | | .expect("Could not retrieve Self from Value") [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/value/convert.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / ::from_value_opt(v) [INFO] [stderr] 243 | | .ok() [INFO] [stderr] 244 | | .expect("Could not retrieve Option from Value") [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:364:37 [INFO] [stderr] | [INFO] [stderr] 364 | Value::Float(x) if x >= ::std::f32::MIN as f64 && x <= ::std::f32::MAX as f64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::f32::MIN)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:364:68 [INFO] [stderr] | [INFO] [stderr] 364 | Value::Float(x) if x >= ::std::f32::MIN as f64 && x <= ::std::f32::MAX as f64 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(::std::f32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:486:30 [INFO] [stderr] | [INFO] [stderr] 486 | tm_year: y as i32 - 1_900, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:487:29 [INFO] [stderr] | [INFO] [stderr] 487 | tm_mon: m as i32 - 1, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:488:30 [INFO] [stderr] | [INFO] [stderr] 488 | tm_mday: d as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:489:30 [INFO] [stderr] | [INFO] [stderr] 489 | tm_hour: h as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:490:29 [INFO] [stderr] | [INFO] [stderr] 490 | tm_min: i as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:491:29 [INFO] [stderr] | [INFO] [stderr] 491 | tm_sec: s as i32, [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/value/convert.rs:504:30 [INFO] [stderr] | [INFO] [stderr] 504 | .or(strptime(s, "%Y-%m-%d")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| strptime(s, "%Y-%m-%d"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:52 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:62 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:535:72 [INFO] [stderr] | [INFO] [stderr] 535 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:58 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:68 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:536:78 [INFO] [stderr] | [INFO] [stderr] 536 | let time = NaiveTime::from_hms_micro_opt(h as u32, i as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:52 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:62 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:574:72 [INFO] [stderr] | [INFO] [stderr] 574 | let date = NaiveDate::from_ymd_opt(y as i32, m as u32, d as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/convert.rs:609:8 [INFO] [stderr] | [INFO] [stderr] 609 | if bytes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/convert.rs:658:8 [INFO] [stderr] | [INFO] [stderr] 658 | if bytes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:58 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:68 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:705:78 [INFO] [stderr] | [INFO] [stderr] 705 | let time = NaiveTime::from_hms_micro_opt(h as u32, m as u32, s as u32, u); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:743:28 [INFO] [stderr] | [INFO] [stderr] 743 | let secs = seconds as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:744:23 [INFO] [stderr] | [INFO] [stderr] 744 | + minutes as u64 * 60 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:745:23 [INFO] [stderr] | [INFO] [stderr] 745 | + hours as u64 * 60 * 60 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:746:23 [INFO] [stderr] | [INFO] [stderr] 746 | + days as u64 * 60 * 60 * 24; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:36 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:53 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:756:75 [INFO] [stderr] | [INFO] [stderr] 756 | let secs = seconds as u64 + minutes as u64 * 60 + hours as u64 * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:781:53 [INFO] [stderr] | [INFO] [stderr] 781 | let duration = time::Duration::days(days as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(days)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:782:45 [INFO] [stderr] | [INFO] [stderr] 782 | + time::Duration::hours(hours as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:783:47 [INFO] [stderr] | [INFO] [stderr] 783 | + time::Duration::minutes(minutes as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:784:47 [INFO] [stderr] | [INFO] [stderr] 784 | + time::Duration::seconds(seconds as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:785:52 [INFO] [stderr] | [INFO] [stderr] 785 | + time::Duration::microseconds(microseconds as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(microseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:794:62 [INFO] [stderr] | [INFO] [stderr] 794 | let duration = time::Duration::hours(hours as i64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:795:55 [INFO] [stderr] | [INFO] [stderr] 795 | + time::Duration::minutes(minutes as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:796:55 [INFO] [stderr] | [INFO] [stderr] 796 | + time::Duration::seconds(seconds as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:797:60 [INFO] [stderr] | [INFO] [stderr] 797 | + time::Duration::microseconds(microseconds as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(microseconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 859 | impl_from_value_num!(i8, "Could not retrieve i8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 859 | impl_from_value_num!(i8, "Could not retrieve i8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 860 | impl_from_value_num!(u8, "Could not retrieve u8 from Value"); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 861 | impl_from_value_num!(i16, "Could not retrieve i16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 861 | impl_from_value_num!(i16, "Could not retrieve i16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 862 | impl_from_value_num!(u16, "Could not retrieve u16 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 863 | impl_from_value_num!(i32, "Could not retrieve i32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 863 | impl_from_value_num!(i32, "Could not retrieve i32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:151:35 [INFO] [stderr] | [INFO] [stderr] 151 | let min = ::std::$t::MIN as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MIN)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:152:39 [INFO] [stderr] | [INFO] [stderr] 152 | let mut max = ::std::$t::MAX as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:165:44 [INFO] [stderr] | [INFO] [stderr] 165 | Value::UInt(x) if x <= ::std::$t::MAX as u64 => Ok(ParseIr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(::std::$t::MAX)` [INFO] [stderr] ... [INFO] [stderr] 864 | impl_from_value_num!(u32, "Could not retrieve u32 from Value"); [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 917 | into_value_impl!(i8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 918 | into_value_impl!(u8); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 919 | into_value_impl!(i16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 920 | into_value_impl!(u16); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 921 | into_value_impl!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:911:28 [INFO] [stderr] | [INFO] [stderr] 911 | Value::Int(x as i64) [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] ... [INFO] [stderr] 922 | into_value_impl!(u32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:939:22 [INFO] [stderr] | [INFO] [stderr] 939 | Value::Float(x as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1037:23 [INFO] [stderr] | [INFO] [stderr] 1037 | let micros = (x.subsec_nanos() as f64 / 1000_f64).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(x.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1039:23 [INFO] [stderr] | [INFO] [stderr] 1039 | secs_total -= seconds as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1041:23 [INFO] [stderr] | [INFO] [stderr] 1041 | secs_total -= (minutes as u64) * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(minutes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/value/convert.rs:1043:23 [INFO] [stderr] | [INFO] [stderr] 1043 | secs_total -= (hours as u64) * 60 * 60; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:130:62 [INFO] [stderr] | [INFO] [stderr] 130 | format!("'-{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:132:61 [INFO] [stderr] | [INFO] [stderr] 132 | format!("'{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:137:68 [INFO] [stderr] | [INFO] [stderr] 137 | format!("'-{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:139:67 [INFO] [stderr] | [INFO] [stderr] 139 | format!("'{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:156:12 [INFO] [stderr] | [INFO] [stderr] 156 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | if input.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:208:28 [INFO] [stderr] | [INFO] [stderr] 208 | Ok(Int(input.read_u8()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:210:28 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(Int(input.read_i8()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i8()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:215:28 [INFO] [stderr] | [INFO] [stderr] 215 | Ok(Int(input.read_u16::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | Ok(Int(input.read_i16::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:222:28 [INFO] [stderr] | [INFO] [stderr] 222 | Ok(Int(input.read_u32::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:224:28 [INFO] [stderr] | [INFO] [stderr] 224 | Ok(Int(input.read_i32::()? as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(input.read_i32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | ColumnType::MYSQL_TYPE_FLOAT => Ok(Float(input.read_f32::()? as f64)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(input.read_f32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/value/mod.rs:347:44 [INFO] [stderr] | [INFO] [stderr] 347 | Value::Bytes(ref bytes) if bytes.len() > 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:402:62 [INFO] [stderr] | [INFO] [stderr] 402 | format!("'-{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:404:61 [INFO] [stderr] | [INFO] [stderr] 404 | format!("'{:03}:{:02}:{:02}'", d * 24 + h as u32, i, s) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:410:68 [INFO] [stderr] | [INFO] [stderr] 410 | format!("'-{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/value/mod.rs:412:67 [INFO] [stderr] | [INFO] [stderr] 412 | format!("'{:03}:{:02}:{:02}.{:06}'", d * 24 + h as u32, i, s, u) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.74s [INFO] running `"docker" "inspect" "00a2ebd190cde4311b19de80dcebca2e483765bed79b36524db4682814c8ed1e"` [INFO] running `"docker" "rm" "-f" "00a2ebd190cde4311b19de80dcebca2e483765bed79b36524db4682814c8ed1e"` [INFO] [stdout] 00a2ebd190cde4311b19de80dcebca2e483765bed79b36524db4682814c8ed1e