[INFO] crate mysql-proxy 0.2.1 is already in cache
[INFO] extracting crate mysql-proxy 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mysql-proxy/0.2.1
[INFO] extracting crate mysql-proxy 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mysql-proxy/0.2.1
[INFO] validating manifest of mysql-proxy-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mysql-proxy-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mysql-proxy-0.2.1
[INFO] finished frobbing mysql-proxy-0.2.1
[INFO] frobbed toml for mysql-proxy-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mysql-proxy/0.2.1/Cargo.toml
[INFO] started frobbing mysql-proxy-0.2.1
[INFO] finished frobbing mysql-proxy-0.2.1
[INFO] frobbed toml for mysql-proxy-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mysql-proxy/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mysql-proxy-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mysql-proxy/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a959fe39b04670253f5192e8559170d9b88fea0a788ae44b3c968a904a5d1173
[INFO] running `"docker" "start" "-a" "a959fe39b04670253f5192e8559170d9b88fea0a788ae44b3c968a904a5d1173"`
[INFO] [stderr]    Compiling curl-sys v0.2.5
[INFO] [stderr]     Checking mysql-proxy v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:263:13
[INFO] [stderr]     |
[INFO] [stderr] 263 |             handler: handler,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `handler`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 |         return Ok(Async::Ready(()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/lib.rs:56:35
[INFO] [stderr]    |
[INFO] [stderr] 56 |         payload.extend_from_slice("#".as_bytes()); // sql_state_marker
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:231:15
[INFO] [stderr]     |
[INFO] [stderr] 231 |         while self.write_buf.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.write_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 | /             match &server_read {
[INFO] [stderr] 323 | |                 &Err(ref e) => {
[INFO] [stderr] 324 | |                     debug!("Server closed connection: {}", e);
[INFO] [stderr] 325 | |                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 330 | |                 _ => {}
[INFO] [stderr] 331 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 322 |             if let &Err(ref e) = &server_read {
[INFO] [stderr] 323 |     debug!("Server closed connection: {}", e);
[INFO] [stderr] 324 |     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 325 |         Ok(_) => {},
[INFO] [stderr] 326 |         Err(_) => {}
[INFO] [stderr] 327 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 | /             match &server_read {
[INFO] [stderr] 323 | |                 &Err(ref e) => {
[INFO] [stderr] 324 | |                     debug!("Server closed connection: {}", e);
[INFO] [stderr] 325 | |                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 330 | |                 _ => {}
[INFO] [stderr] 331 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 322 |             match server_read {
[INFO] [stderr] 323 |                 Err(ref e) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:325:21
[INFO] [stderr]     |
[INFO] [stderr] 325 | /                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 326 | |                         Ok(_) => {},
[INFO] [stderr] 327 | |                         Err(_) => {}
[INFO] [stderr] 328 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Ok(_) = self.client_writer.stream.shutdown(Shutdown::Write) {}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 | /             match &client_read {
[INFO] [stderr] 338 | |                 &Err(ref e) => {
[INFO] [stderr] 339 | |                     debug!("Client closed connection: {}", e);
[INFO] [stderr] 340 | |                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 345 | |                 _ => {}
[INFO] [stderr] 346 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 337 |             if let &Err(ref e) = &client_read {
[INFO] [stderr] 338 |     debug!("Client closed connection: {}", e);
[INFO] [stderr] 339 |     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 340 |         Ok(_) => {},
[INFO] [stderr] 341 |         Err(_) => {}
[INFO] [stderr] 342 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 | /             match &client_read {
[INFO] [stderr] 338 | |                 &Err(ref e) => {
[INFO] [stderr] 339 | |                     debug!("Client closed connection: {}", e);
[INFO] [stderr] 340 | |                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 345 | |                 _ => {}
[INFO] [stderr] 346 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 337 |             match client_read {
[INFO] [stderr] 338 |                 Err(ref e) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:340:21
[INFO] [stderr]     |
[INFO] [stderr] 340 | /                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 341 | |                         Ok(_) => {},
[INFO] [stderr] 342 | |                         Err(_) => {}
[INFO] [stderr] 343 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Ok(_) = self.server_writer.stream.shutdown(Shutdown::Write) {}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:360:7
[INFO] [stderr]     |
[INFO] [stderr] 360 |     (((header[2] as u32) << 16) |
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:361:10
[INFO] [stderr]     |
[INFO] [stderr] 361 |         ((header[1] as u32) << 8) |
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:362:9
[INFO] [stderr]     |
[INFO] [stderr] 362 |         header[0] as u32) as usize
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: try: `u32::from(header[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Checking curl v0.3.11
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/passthrough.rs:95:21
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if i%8==0 { println!(""); }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> examples/proxy.rs:122:21
[INFO] [stderr]     |
[INFO] [stderr] 122 |         if i%8==0 { println!(""); }
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:168:13
[INFO] [stderr]     |
[INFO] [stderr] 168 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:214:13
[INFO] [stderr]     |
[INFO] [stderr] 214 |             stream: stream,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:263:13
[INFO] [stderr]     |
[INFO] [stderr] 263 |             handler: handler,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `handler`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:240:9
[INFO] [stderr]     |
[INFO] [stderr] 240 |         return Ok(Async::Ready(()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proxy.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/proxy.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> examples/proxy.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str`
[INFO] [stderr]   --> examples/proxy.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | use std::str;
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/passthrough.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> examples/passthrough.rs:8:1
[INFO] [stderr]   |
[INFO] [stderr] 8 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> examples/passthrough.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::str`
[INFO] [stderr]   --> examples/passthrough.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 | use std::str;
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `p`
[INFO] [stderr]   --> examples/passthrough.rs:71:34
[INFO] [stderr]    |
[INFO] [stderr] 71 |     fn handle_request(&mut self, p: &Packet) -> Action {
[INFO] [stderr]    |                                  ^ help: consider using `_p` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/passthrough.rs:28:40
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let bind_addr = env::args().nth(1).unwrap_or("127.0.0.1:3307".to_string());
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:3307".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/passthrough.rs:32:41
[INFO] [stderr]    |
[INFO] [stderr] 32 |     let mysql_addr = env::args().nth(2).unwrap_or("127.0.0.1:3306".to_string());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:3306".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/lib.rs:56:35
[INFO] [stderr]    |
[INFO] [stderr] 56 |         payload.extend_from_slice("#".as_bytes()); // sql_state_marker
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/proxy.rs:29:40
[INFO] [stderr]    |
[INFO] [stderr] 29 |     let bind_addr = env::args().nth(1).unwrap_or("127.0.0.1:3307".to_string());
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:3307".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> examples/proxy.rs:33:41
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let mysql_addr = env::args().nth(2).unwrap_or("127.0.0.1:3306".to_string());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:3306".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]    --> examples/proxy.rs:112:14
[INFO] [stderr]     |
[INFO] [stderr] 112 |     for i in 0..buf.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 112 |     for <item> in &buf {
[INFO] [stderr]     |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]    --> examples/proxy.rs:121:14
[INFO] [stderr]     |
[INFO] [stderr] 121 |     for i in 0..buf.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 121 |     for (i, <item>) in buf.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:231:15
[INFO] [stderr]     |
[INFO] [stderr] 231 |         while self.write_buf.len() > 0 {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.write_buf.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]   --> examples/passthrough.rs:85:14
[INFO] [stderr]    |
[INFO] [stderr] 85 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 85 |     for <item> in &buf {
[INFO] [stderr]    |         ^^^^^^    ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buf`
[INFO] [stderr]   --> examples/passthrough.rs:94:14
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for i in 0..buf.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 94 |     for (i, <item>) in buf.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 | /             match &server_read {
[INFO] [stderr] 323 | |                 &Err(ref e) => {
[INFO] [stderr] 324 | |                     debug!("Server closed connection: {}", e);
[INFO] [stderr] 325 | |                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 330 | |                 _ => {}
[INFO] [stderr] 331 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 322 |             if let &Err(ref e) = &server_read {
[INFO] [stderr] 323 |     debug!("Server closed connection: {}", e);
[INFO] [stderr] 324 |     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 325 |         Ok(_) => {},
[INFO] [stderr] 326 |         Err(_) => {}
[INFO] [stderr] 327 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 | /             match &server_read {
[INFO] [stderr] 323 | |                 &Err(ref e) => {
[INFO] [stderr] 324 | |                     debug!("Server closed connection: {}", e);
[INFO] [stderr] 325 | |                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 330 | |                 _ => {}
[INFO] [stderr] 331 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 322 |             match server_read {
[INFO] [stderr] 323 |                 Err(ref e) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:325:21
[INFO] [stderr]     |
[INFO] [stderr] 325 | /                     match self.client_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 326 | |                         Ok(_) => {},
[INFO] [stderr] 327 | |                         Err(_) => {}
[INFO] [stderr] 328 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Ok(_) = self.client_writer.stream.shutdown(Shutdown::Write) {}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 | /             match &client_read {
[INFO] [stderr] 338 | |                 &Err(ref e) => {
[INFO] [stderr] 339 | |                     debug!("Client closed connection: {}", e);
[INFO] [stderr] 340 | |                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 345 | |                 _ => {}
[INFO] [stderr] 346 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 337 |             if let &Err(ref e) = &client_read {
[INFO] [stderr] 338 |     debug!("Client closed connection: {}", e);
[INFO] [stderr] 339 |     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 340 |         Ok(_) => {},
[INFO] [stderr] 341 |         Err(_) => {}
[INFO] [stderr] 342 |     }
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/lib.rs:337:13
[INFO] [stderr]     |
[INFO] [stderr] 337 | /             match &client_read {
[INFO] [stderr] 338 | |                 &Err(ref e) => {
[INFO] [stderr] 339 | |                     debug!("Client closed connection: {}", e);
[INFO] [stderr] 340 | |                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] ...   |
[INFO] [stderr] 345 | |                 _ => {}
[INFO] [stderr] 346 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 337 |             match client_read {
[INFO] [stderr] 338 |                 Err(ref e) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:340:21
[INFO] [stderr]     |
[INFO] [stderr] 340 | /                     match self.server_writer.stream.shutdown(Shutdown::Write) {
[INFO] [stderr] 341 | |                         Ok(_) => {},
[INFO] [stderr] 342 | |                         Err(_) => {}
[INFO] [stderr] 343 | |                     }
[INFO] [stderr]     | |_____________________^ help: try this: `if let Ok(_) = self.server_writer.stream.shutdown(Shutdown::Write) {}`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:360:7
[INFO] [stderr]     |
[INFO] [stderr] 360 |     (((header[2] as u32) << 16) |
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:361:10
[INFO] [stderr]     |
[INFO] [stderr] 361 |         ((header[1] as u32) << 8) |
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(header[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:362:9
[INFO] [stderr]     |
[INFO] [stderr] 362 |         header[0] as u32) as usize
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: try: `u32::from(header[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 44s
[INFO] running `"docker" "inspect" "a959fe39b04670253f5192e8559170d9b88fea0a788ae44b3c968a904a5d1173"`
[INFO] running `"docker" "rm" "-f" "a959fe39b04670253f5192e8559170d9b88fea0a788ae44b3c968a904a5d1173"`
[INFO] [stdout] a959fe39b04670253f5192e8559170d9b88fea0a788ae44b3c968a904a5d1173