[INFO] crate myriad 0.1.1 is already in cache [INFO] extracting crate myriad 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/myriad/0.1.1 [INFO] extracting crate myriad 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/myriad/0.1.1 [INFO] validating manifest of myriad-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of myriad-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing myriad-0.1.1 [INFO] finished frobbing myriad-0.1.1 [INFO] frobbed toml for myriad-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/myriad/0.1.1/Cargo.toml [INFO] started frobbing myriad-0.1.1 [INFO] finished frobbing myriad-0.1.1 [INFO] frobbed toml for myriad-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/myriad/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting myriad-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/myriad/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b545ce204d959fedfc6a8b7cbe54b7a39bd36b8b011776579d350b0ea214f3fb [INFO] running `"docker" "start" "-a" "b545ce204d959fedfc6a8b7cbe54b7a39bd36b8b011776579d350b0ea214f3fb"` [INFO] [stderr] Checking myriad v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | guard: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | guard: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: trait `LockFree` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/mpmc/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub trait LockFree { [INFO] [stderr] 32 | | fn push(&self, item: T); [INFO] [stderr] 33 | | fn pop(&self) -> Option; [INFO] [stderr] 34 | | fn len(&self) -> usize; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | *self.inner.guard.lock().unwrap() = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | *self.inner.guard.lock().unwrap() = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | let mut guard = self.inner.guard.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: unused import: `Ordering::*` [INFO] [stderr] --> src/mpmc/stack.rs:97:42 [INFO] [stderr] | [INFO] [stderr] 97 | use std::sync::atomic::{AtomicUsize, Ordering::*}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | guard: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | guard: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: trait `LockFree` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/mpmc/mod.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / pub trait LockFree { [INFO] [stderr] 32 | | fn push(&self, item: T); [INFO] [stderr] 33 | | fn pop(&self) -> Option; [INFO] [stderr] 34 | | fn len(&self) -> usize; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | *self.inner.guard.lock().unwrap() = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:111:18 [INFO] [stderr] | [INFO] [stderr] 111 | *self.inner.guard.lock().unwrap() = true; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/mpmc/mod.rs:181:25 [INFO] [stderr] | [INFO] [stderr] 181 | let mut guard = self.inner.guard.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "b545ce204d959fedfc6a8b7cbe54b7a39bd36b8b011776579d350b0ea214f3fb"` [INFO] running `"docker" "rm" "-f" "b545ce204d959fedfc6a8b7cbe54b7a39bd36b8b011776579d350b0ea214f3fb"` [INFO] [stdout] b545ce204d959fedfc6a8b7cbe54b7a39bd36b8b011776579d350b0ea214f3fb