[INFO] crate my_internet_ip 0.1.1 is already in cache [INFO] extracting crate my_internet_ip 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/my_internet_ip/0.1.1 [INFO] extracting crate my_internet_ip 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/my_internet_ip/0.1.1 [INFO] validating manifest of my_internet_ip-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of my_internet_ip-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing my_internet_ip-0.1.1 [INFO] finished frobbing my_internet_ip-0.1.1 [INFO] frobbed toml for my_internet_ip-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/my_internet_ip/0.1.1/Cargo.toml [INFO] started frobbing my_internet_ip-0.1.1 [INFO] finished frobbing my_internet_ip-0.1.1 [INFO] frobbed toml for my_internet_ip-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/my_internet_ip/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting my_internet_ip-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/my_internet_ip/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11c1bf0739975e0cdca5ff03ba73aeb49649d4b5f57cb49d7cf736b2f918063e [INFO] running `"docker" "start" "-a" "11c1bf0739975e0cdca5ff03ba73aeb49649d4b5f57cb49d7cf736b2f918063e"` [INFO] [stderr] Checking my_internet_ip v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | easy.get(true).map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | easy.url("http://www.myip.ch").map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | easy.perform().map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:50:51 [INFO] [stderr] | [INFO] [stderr] 50 | let response_code = easy.response_code().map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:56:56 [INFO] [stderr] | [INFO] [stderr] 56 | let data_string: &str = str::from_utf8(&data).map_err(|e| MyIpError::Utf8Error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::Utf8Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | for line in data_string.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | ip.parse().map_err(|e| MyIpError::AddressParseError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::AddressParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | easy.get(true).map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | easy.url("http://www.myip.ch").map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | easy.perform().map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:50:51 [INFO] [stderr] | [INFO] [stderr] 50 | let response_code = easy.response_code().map_err(|e| MyIpError::CurlError(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::CurlError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:56:56 [INFO] [stderr] | [INFO] [stderr] 56 | let data_string: &str = str::from_utf8(&data).map_err(|e| MyIpError::Utf8Error(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::Utf8Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | for line in data_string.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | ip.parse().map_err(|e| MyIpError::AddressParseError(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MyIpError::AddressParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "11c1bf0739975e0cdca5ff03ba73aeb49649d4b5f57cb49d7cf736b2f918063e"` [INFO] running `"docker" "rm" "-f" "11c1bf0739975e0cdca5ff03ba73aeb49649d4b5f57cb49d7cf736b2f918063e"` [INFO] [stdout] 11c1bf0739975e0cdca5ff03ba73aeb49649d4b5f57cb49d7cf736b2f918063e