[INFO] crate my-pretty-failure 0.1.2 is already in cache [INFO] extracting crate my-pretty-failure 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/my-pretty-failure/0.1.2 [INFO] extracting crate my-pretty-failure 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/my-pretty-failure/0.1.2 [INFO] validating manifest of my-pretty-failure-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of my-pretty-failure-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing my-pretty-failure-0.1.2 [INFO] finished frobbing my-pretty-failure-0.1.2 [INFO] frobbed toml for my-pretty-failure-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/my-pretty-failure/0.1.2/Cargo.toml [INFO] started frobbing my-pretty-failure-0.1.2 [INFO] finished frobbing my-pretty-failure-0.1.2 [INFO] frobbed toml for my-pretty-failure-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/my-pretty-failure/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting my-pretty-failure-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/my-pretty-failure/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5185283e267bfc184b2a6e7feaf4c0bac4e2090cf0fa52a2d8e0cc4887656673 [INFO] running `"docker" "start" "-a" "5185283e267bfc184b2a6e7feaf4c0bac4e2090cf0fa52a2d8e0cc4887656673"` [INFO] [stderr] Checking my-pretty-failure v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | count_context = count_context + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_context += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | count_context = count_context + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_context += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/0001_myprettyfailure.rs:9:39 [INFO] [stderr] | [INFO] [stderr] 9 | fn err1() -> Result<(), MyError> { Ok(err2().context("a long err1".to_string())?) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 9 | fn err1() -> Result<(), MyError> { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/0001_myprettyfailure.rs:10:39 [INFO] [stderr] | [INFO] [stderr] 10 | fn err2() -> Result<(), MyError> { Ok(err3().context("a very long err2")?) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 10 | fn err2() -> Result<(), MyError> { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/0001_myprettyfailure.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | fn err3() -> Result<(), MyError> { Ok(Err(MyError::from("an another deep err3"))?) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 11 | fn err3() -> Result<(), MyError> { Ok(()) } [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.71s [INFO] running `"docker" "inspect" "5185283e267bfc184b2a6e7feaf4c0bac4e2090cf0fa52a2d8e0cc4887656673"` [INFO] running `"docker" "rm" "-f" "5185283e267bfc184b2a6e7feaf4c0bac4e2090cf0fa52a2d8e0cc4887656673"` [INFO] [stdout] 5185283e267bfc184b2a6e7feaf4c0bac4e2090cf0fa52a2d8e0cc4887656673