[INFO] crate mws 0.9.0 is already in cache [INFO] extracting crate mws 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/mws/0.9.0 [INFO] extracting crate mws 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mws/0.9.0 [INFO] validating manifest of mws-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mws-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mws-0.9.0 [INFO] finished frobbing mws-0.9.0 [INFO] frobbed toml for mws-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/mws/0.9.0/Cargo.toml [INFO] started frobbing mws-0.9.0 [INFO] finished frobbing mws-0.9.0 [INFO] frobbed toml for mws-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mws/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mws-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mws/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2d57b159e955feb8ba88a1e2db1ae8533eb85d61ce0848cce6092dbbf7133b01 [INFO] running `"docker" "start" "-a" "2d57b159e955feb8ba88a1e2db1ae8533eb85d61ce0848cce6092dbbf7133b01"` [INFO] [stderr] Checking base64 v0.2.1 [INFO] [stderr] Checking xml-rs v0.6.1 [INFO] [stderr] Compiling mws-derive v0.9.0 [INFO] [stderr] Checking dotenv v0.8.0 [INFO] [stderr] Checking mws v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xmlhelper/decode.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xmlhelper/decode.rs:185:7 [INFO] [stderr] | [INFO] [stderr] 185 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tdff.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:112:7 [INFO] [stderr] | [INFO] [stderr] 112 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign.rs:192:7 [INFO] [stderr] | [INFO] [stderr] 192 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign.rs:195:7 [INFO] [stderr] | [INFO] [stderr] 195 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feeds/mod.rs:86:7 [INFO] [stderr] | [INFO] [stderr] 86 | operation_type: operation_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xmlhelper/decode.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xmlhelper/decode.rs:185:7 [INFO] [stderr] | [INFO] [stderr] 185 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tdff.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:112:7 [INFO] [stderr] | [INFO] [stderr] 112 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | http_client: http_client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign.rs:192:7 [INFO] [stderr] | [INFO] [stderr] 192 | method: method, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sign.rs:195:7 [INFO] [stderr] | [INFO] [stderr] 195 | signature: signature, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `signature` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feeds/mod.rs:86:7 [INFO] [stderr] | [INFO] [stderr] 86 | operation_type: operation_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/fulfillment_outbound/types.rs:1105:48 [INFO] [stderr] | [INFO] [stderr] 1105 | EarliestShipDate: Some(Utc.ymd(2018, 05, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1105 | EarliestShipDate: Some(Utc.ymd(2018, 5, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1105 | EarliestShipDate: Some(Utc.ymd(2018, 0o5, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/fulfillment_outbound/types.rs:1106:46 [INFO] [stderr] | [INFO] [stderr] 1106 | LatestShipDate: Some(Utc.ymd(2018, 05, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1106 | LatestShipDate: Some(Utc.ymd(2018, 5, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1106 | LatestShipDate: Some(Utc.ymd(2018, 0o5, 18).and_hms(17, 8, 5)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/fulfillment_outbound/types.rs:1107:51 [INFO] [stderr] | [INFO] [stderr] 1107 | EarliestArrivalDate: Some(Utc.ymd(2018, 05, 23).and_hms(17, 8, 5)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1107 | EarliestArrivalDate: Some(Utc.ymd(2018, 5, 23).and_hms(17, 8, 5)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1107 | EarliestArrivalDate: Some(Utc.ymd(2018, 0o5, 23).and_hms(17, 8, 5)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/fulfillment_outbound/types.rs:1108:49 [INFO] [stderr] | [INFO] [stderr] 1108 | LatestArrivalDate: Some(Utc.ymd(2018, 05, 25).and_hms(17, 8, 5)), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1108 | LatestArrivalDate: Some(Utc.ymd(2018, 5, 25).and_hms(17, 8, 5)), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1108 | LatestArrivalDate: Some(Utc.ymd(2018, 0o5, 25).and_hms(17, 8, 5)), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:210:11 [INFO] [stderr] | [INFO] [stderr] 210 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | self.level = self.level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xmlhelper/decode.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 19 | | match $stream.next() { [INFO] [stderr] 20 | | Some(Ok($pattern)) => (), [INFO] [stderr] 21 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 285 | Ok(try_consume_event!(stream, XmlEvent::StartDocument { .. })) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 18 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xmlhelper/decode.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 19 | | match $stream.next() { [INFO] [stderr] 20 | | Some(Ok($pattern)) => (), [INFO] [stderr] 21 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 290 | Ok(try_consume_event!(stream, XmlEvent::EndDocument)) [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 18 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xmlhelper/decode.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | if let None = stream.peek() { [INFO] [stderr] | ___- ^^^^ [INFO] [stderr] 324 | | return "".parse().map_err(|err| MwsError::ParseString { [INFO] [stderr] 325 | | what: "".to_owned(), [INFO] [stderr] 326 | | message: format!("{}", err), [INFO] [stderr] 327 | | }); [INFO] [stderr] 328 | | } [INFO] [stderr] | |___- help: try this: `if stream.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:342:50 [INFO] [stderr] | [INFO] [stderr] 342 | Some(Ok(XmlEvent::StartElement { .. })) => depth = depth + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:343:48 [INFO] [stderr] | [INFO] [stderr] 343 | Some(Ok(XmlEvent::EndElement { .. })) => depth = depth - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / if let &Some(ref v) = self { [INFO] [stderr] 90 | | v.serialize_mws_params(&path, false, pairs); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(ref v) = *self { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tdff.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self.headers.get(i) { [INFO] [stderr] 38 | | Some(key) => { [INFO] [stderr] 39 | | row_container.push((key.as_ref() as &str, value)); [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(key) = self.headers.get(i) { [INFO] [stderr] 38 | row_container.push((key.as_ref() as &str, value)); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / element(s, "ErrorResponse", |s| { [INFO] [stderr] 42 | | fold_elements(s, ErrorResponseInfo::default(), |s, resp| { [INFO] [stderr] 43 | | match s.local_name() { [INFO] [stderr] 44 | | "Error" => { [INFO] [stderr] ... | [INFO] [stderr] 71 | | }) [INFO] [stderr] 72 | | }).into() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 41 | element(s, "ErrorResponse", |s| { [INFO] [stderr] 42 | fold_elements(s, ErrorResponseInfo::default(), |s, resp| { [INFO] [stderr] 43 | match s.local_name() { [INFO] [stderr] 44 | "Error" => { [INFO] [stderr] 45 | let err = fold_elements(s, ErrorResponseError::default(), |s, err| { [INFO] [stderr] 46 | match s.local_name() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:156:3 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn request_with_body( [INFO] [stderr] 157 | | &self, [INFO] [stderr] 158 | | method: Method, [INFO] [stderr] 159 | | path: &str, [INFO] [stderr] ... | [INFO] [stderr] 193 | | .map_err(Into::into) [INFO] [stderr] 194 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:226:19 [INFO] [stderr] | [INFO] [stderr] 226 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:234:3 [INFO] [stderr] | [INFO] [stderr] 234 | / pub fn request_xml_with_body( [INFO] [stderr] 235 | | &self, [INFO] [stderr] 236 | | method: Method, [INFO] [stderr] 237 | | path: &str, [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:309:19 [INFO] [stderr] | [INFO] [stderr] 309 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:314:19 [INFO] [stderr] | [INFO] [stderr] 314 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/sign.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | if qs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!qs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/feeds/mod.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/feeds/mod.rs:435:21 [INFO] [stderr] | [INFO] [stderr] 435 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inventory/mod.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inventory/mod.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:373:20 [INFO] [stderr] | [INFO] [stderr] 373 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:573:21 [INFO] [stderr] | [INFO] [stderr] 573 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:620:21 [INFO] [stderr] | [INFO] [stderr] 620 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:210:11 [INFO] [stderr] | [INFO] [stderr] 210 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | self.level = self.level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | self.level = self.level - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.level -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xmlhelper/decode.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 19 | | match $stream.next() { [INFO] [stderr] 20 | | Some(Ok($pattern)) => (), [INFO] [stderr] 21 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 285 | Ok(try_consume_event!(stream, XmlEvent::StartDocument { .. })) [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 18 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/xmlhelper/decode.rs:18:11 [INFO] [stderr] | [INFO] [stderr] 18 | ) => {{ [INFO] [stderr] | ___________^ [INFO] [stderr] 19 | | match $stream.next() { [INFO] [stderr] 20 | | Some(Ok($pattern)) => (), [INFO] [stderr] 21 | | Some(Ok(event)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }}; [INFO] [stderr] | |_____^ [INFO] [stderr] ... [INFO] [stderr] 290 | Ok(try_consume_event!(stream, XmlEvent::EndDocument)) [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 18 | ) => {()}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/xmlhelper/decode.rs:323:10 [INFO] [stderr] | [INFO] [stderr] 323 | if let None = stream.peek() { [INFO] [stderr] | ___- ^^^^ [INFO] [stderr] 324 | | return "".parse().map_err(|err| MwsError::ParseString { [INFO] [stderr] 325 | | what: "".to_owned(), [INFO] [stderr] 326 | | message: format!("{}", err), [INFO] [stderr] 327 | | }); [INFO] [stderr] 328 | | } [INFO] [stderr] | |___- help: try this: `if stream.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:342:50 [INFO] [stderr] | [INFO] [stderr] 342 | Some(Ok(XmlEvent::StartElement { .. })) => depth = depth + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/xmlhelper/decode.rs:343:48 [INFO] [stderr] | [INFO] [stderr] 343 | Some(Ok(XmlEvent::EndElement { .. })) => depth = depth - 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / if let &Some(ref v) = self { [INFO] [stderr] 90 | | v.serialize_mws_params(&path, false, pairs); [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(ref v) = *self { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tdff.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self.headers.get(i) { [INFO] [stderr] 38 | | Some(key) => { [INFO] [stderr] 39 | | row_container.push((key.as_ref() as &str, value)); [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(key) = self.headers.get(i) { [INFO] [stderr] 38 | row_container.push((key.as_ref() as &str, value)); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / element(s, "ErrorResponse", |s| { [INFO] [stderr] 42 | | fold_elements(s, ErrorResponseInfo::default(), |s, resp| { [INFO] [stderr] 43 | | match s.local_name() { [INFO] [stderr] 44 | | "Error" => { [INFO] [stderr] ... | [INFO] [stderr] 71 | | }) [INFO] [stderr] 72 | | }).into() [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 41 | element(s, "ErrorResponse", |s| { [INFO] [stderr] 42 | fold_elements(s, ErrorResponseInfo::default(), |s, resp| { [INFO] [stderr] 43 | match s.local_name() { [INFO] [stderr] 44 | "Error" => { [INFO] [stderr] 45 | let err = fold_elements(s, ErrorResponseError::default(), |s, err| { [INFO] [stderr] 46 | match s.local_name() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:156:3 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn request_with_body( [INFO] [stderr] 157 | | &self, [INFO] [stderr] 158 | | method: Method, [INFO] [stderr] 159 | | path: &str, [INFO] [stderr] ... | [INFO] [stderr] 193 | | .map_err(Into::into) [INFO] [stderr] 194 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:226:19 [INFO] [stderr] | [INFO] [stderr] 226 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/client.rs:234:3 [INFO] [stderr] | [INFO] [stderr] 234 | / pub fn request_xml_with_body( [INFO] [stderr] 235 | | &self, [INFO] [stderr] 236 | | method: Method, [INFO] [stderr] 237 | | path: &str, [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:309:19 [INFO] [stderr] | [INFO] [stderr] 309 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:314:19 [INFO] [stderr] | [INFO] [stderr] 314 | status: resp.status().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | Ok((resp.status().clone(), s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resp.status()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/sign.rs:72:20 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn to_string(self) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/sign.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | if qs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!qs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/feeds/mod.rs:419:21 [INFO] [stderr] | [INFO] [stderr] 419 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/feeds/mod.rs:435:21 [INFO] [stderr] | [INFO] [stderr] 435 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:310:21 [INFO] [stderr] | [INFO] [stderr] 310 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:230:21 [INFO] [stderr] | [INFO] [stderr] 230 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inbound_shipment/mod.rs:249:21 [INFO] [stderr] | [INFO] [stderr] 249 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:380:67 [INFO] [stderr] | [INFO] [stderr] 380 | result.push((format!("MarketplaceIdList.Type.{}", i + 1), ty.into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reports/mod.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / match s.local_name() { [INFO] [stderr] 403 | | "ReportRequestInfo" => { [INFO] [stderr] 404 | | let item = fold_elements(s, ReportRequestInfo::default(), |s, info| { [INFO] [stderr] 405 | | match s.local_name() { [INFO] [stderr] ... | [INFO] [stderr] 442 | | _ => {} [INFO] [stderr] 443 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | if let "ReportRequestInfo" = s.local_name() { [INFO] [stderr] 403 | let item = fold_elements(s, ReportRequestInfo::default(), |s, info| { [INFO] [stderr] 404 | match s.local_name() { [INFO] [stderr] 405 | "ReportType" => { [INFO] [stderr] 406 | info.report_type = characters(s)?; [INFO] [stderr] 407 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:464:20 [INFO] [stderr] | [INFO] [stderr] 464 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inventory/mod.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_inventory/mod.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:373:20 [INFO] [stderr] | [INFO] [stderr] 373 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:573:21 [INFO] [stderr] | [INFO] [stderr] 573 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/fulfillment_outbound/mod.rs:620:21 [INFO] [stderr] | [INFO] [stderr] 620 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:90:20 [INFO] [stderr] | [INFO] [stderr] 90 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/merchant_fulfillment/mod.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/orders/mod.rs:310:21 [INFO] [stderr] | [INFO] [stderr] 310 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:143:20 [INFO] [stderr] | [INFO] [stderr] 143 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:161:21 [INFO] [stderr] | [INFO] [stderr] 161 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:331:20 [INFO] [stderr] | [INFO] [stderr] 331 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | ).map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:380:67 [INFO] [stderr] | [INFO] [stderr] 380 | result.push((format!("MarketplaceIdList.Type.{}", i + 1), ty.into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reports/mod.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / match s.local_name() { [INFO] [stderr] 403 | | "ReportRequestInfo" => { [INFO] [stderr] 404 | | let item = fold_elements(s, ReportRequestInfo::default(), |s, info| { [INFO] [stderr] 405 | | match s.local_name() { [INFO] [stderr] ... | [INFO] [stderr] 442 | | _ => {} [INFO] [stderr] 443 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | if let "ReportRequestInfo" = s.local_name() { [INFO] [stderr] 403 | let item = fold_elements(s, ReportRequestInfo::default(), |s, info| { [INFO] [stderr] 404 | match s.local_name() { [INFO] [stderr] 405 | "ReportType" => { [INFO] [stderr] 406 | info.report_type = characters(s)?; [INFO] [stderr] 407 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:464:20 [INFO] [stderr] | [INFO] [stderr] 464 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reports/mod.rs:476:20 [INFO] [stderr] | [INFO] [stderr] 476 | .map_err(|err| err.into()) [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.80s [INFO] running `"docker" "inspect" "2d57b159e955feb8ba88a1e2db1ae8533eb85d61ce0848cce6092dbbf7133b01"` [INFO] running `"docker" "rm" "-f" "2d57b159e955feb8ba88a1e2db1ae8533eb85d61ce0848cce6092dbbf7133b01"` [INFO] [stdout] 2d57b159e955feb8ba88a1e2db1ae8533eb85d61ce0848cce6092dbbf7133b01