[INFO] crate mvr 0.2.1 is already in cache [INFO] extracting crate mvr 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/mvr/0.2.1 [INFO] extracting crate mvr 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mvr/0.2.1 [INFO] validating manifest of mvr-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mvr-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mvr-0.2.1 [INFO] finished frobbing mvr-0.2.1 [INFO] frobbed toml for mvr-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/mvr/0.2.1/Cargo.toml [INFO] started frobbing mvr-0.2.1 [INFO] finished frobbing mvr-0.2.1 [INFO] frobbed toml for mvr-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mvr/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mvr-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mvr/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c306e979f2fd86ce6cb2366a08b14ae791679b42269f6998134c15b4e6419a8e [INFO] running `"docker" "start" "-a" "c306e979f2fd86ce6cb2366a08b14ae791679b42269f6998134c15b4e6419a8e"` [INFO] [stderr] Compiling mvr v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] 161 | | bail!( [INFO] [stderr] 162 | | "could not rename file: {} -> {}", [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] 160 | bail!( [INFO] [stderr] 161 | "could not rename file: {} -> {}", [INFO] [stderr] 162 | path.display(), [INFO] [stderr] 163 | new_path.display() [INFO] [stderr] 164 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if let Err(_) = io::stdin().read_line(&mut s) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 108 | | bail!("could not read from stdin"); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____- help: try this: `if io::stdin().read_line(&mut s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | if let Err(_) = io::stdout().flush() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 136 | | bail!("could not flush stdout"); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________- help: try this: `if io::stdout().flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | if let Err(_) = fs::copy(&path, &new_path) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 153 | | bail!( [INFO] [stderr] 154 | | "could not copy file: {} -> {}", [INFO] [stderr] 155 | | path.display(), [INFO] [stderr] 156 | | new_path.display() [INFO] [stderr] 157 | | ); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________- help: try this: `if fs::copy(&path, &new_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 161 | | bail!( [INFO] [stderr] 162 | | "could not rename file: {} -> {}", [INFO] [stderr] 163 | | path.display(), [INFO] [stderr] 164 | | new_path.display() [INFO] [stderr] 165 | | ); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________- help: try this: `if fs::rename(&path, &new_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] 161 | | bail!( [INFO] [stderr] 162 | | "could not rename file: {} -> {}", [INFO] [stderr] ... | [INFO] [stderr] 166 | | } [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] 160 | bail!( [INFO] [stderr] 161 | "could not rename file: {} -> {}", [INFO] [stderr] 162 | path.display(), [INFO] [stderr] 163 | new_path.display() [INFO] [stderr] 164 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | if let Err(_) = io::stdin().read_line(&mut s) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 108 | | bail!("could not read from stdin"); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____- help: try this: `if io::stdin().read_line(&mut s).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | if let Err(_) = io::stdout().flush() { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 136 | | bail!("could not flush stdout"); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________- help: try this: `if io::stdout().flush().is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | if let Err(_) = fs::copy(&path, &new_path) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 153 | | bail!( [INFO] [stderr] 154 | | "could not copy file: {} -> {}", [INFO] [stderr] 155 | | path.display(), [INFO] [stderr] 156 | | new_path.display() [INFO] [stderr] 157 | | ); [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____________- help: try this: `if fs::copy(&path, &new_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | if let Err(_) = fs::rename(&path, &new_path) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 161 | | bail!( [INFO] [stderr] 162 | | "could not rename file: {} -> {}", [INFO] [stderr] 163 | | path.display(), [INFO] [stderr] 164 | | new_path.display() [INFO] [stderr] 165 | | ); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____________- help: try this: `if fs::rename(&path, &new_path).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.46s [INFO] running `"docker" "inspect" "c306e979f2fd86ce6cb2366a08b14ae791679b42269f6998134c15b4e6419a8e"` [INFO] running `"docker" "rm" "-f" "c306e979f2fd86ce6cb2366a08b14ae791679b42269f6998134c15b4e6419a8e"` [INFO] [stdout] c306e979f2fd86ce6cb2366a08b14ae791679b42269f6998134c15b4e6419a8e