[INFO] crate mvdb 0.3.0 is already in cache [INFO] extracting crate mvdb 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/mvdb/0.3.0 [INFO] extracting crate mvdb 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mvdb/0.3.0 [INFO] validating manifest of mvdb-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mvdb-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mvdb-0.3.0 [INFO] finished frobbing mvdb-0.3.0 [INFO] frobbed toml for mvdb-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/mvdb/0.3.0/Cargo.toml [INFO] started frobbing mvdb-0.3.0 [INFO] finished frobbing mvdb-0.3.0 [INFO] frobbed toml for mvdb-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mvdb/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mvdb-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mvdb/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5addf620b3a524a5f699e8897047e7edaf3a1905126673c7891c7593bf7ec45f [INFO] running `"docker" "start" "-a" "5addf620b3a524a5f699e8897047e7edaf3a1905126673c7891c7593bf7ec45f"` [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking mvdb v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mvdb.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | pretty: pretty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pretty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mvdb.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | pretty: pretty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pretty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/helpers.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let serializer = match pretty { [INFO] [stderr] | ______________________^ [INFO] [stderr] 46 | | true => serde_json::to_string_pretty, [INFO] [stderr] 47 | | false => serde_json::to_string, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pretty { serde_json::to_string_pretty } else { serde_json::to_string }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/helpers.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let serializer = match pretty { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => serde_json::to_string_pretty, [INFO] [stderr] 82 | | false => serde_json::to_string, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pretty { serde_json::to_string_pretty } else { serde_json::to_string }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/helpers.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / let _ = file.write_all(contents.as_bytes()) [INFO] [stderr] 98 | | .chain_err(|| "Failed to write to file")?; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/helpers.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | let serializer = match pretty { [INFO] [stderr] | ______________________^ [INFO] [stderr] 46 | | true => serde_json::to_string_pretty, [INFO] [stderr] 47 | | false => serde_json::to_string, [INFO] [stderr] 48 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pretty { serde_json::to_string_pretty } else { serde_json::to_string }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/helpers.rs:80:22 [INFO] [stderr] | [INFO] [stderr] 80 | let serializer = match pretty { [INFO] [stderr] | ______________________^ [INFO] [stderr] 81 | | true => serde_json::to_string_pretty, [INFO] [stderr] 82 | | false => serde_json::to_string, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pretty { serde_json::to_string_pretty } else { serde_json::to_string }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/helpers.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / let _ = file.write_all(contents.as_bytes()) [INFO] [stderr] 98 | | .chain_err(|| "Failed to write to file")?; [INFO] [stderr] | |__________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.59s [INFO] running `"docker" "inspect" "5addf620b3a524a5f699e8897047e7edaf3a1905126673c7891c7593bf7ec45f"` [INFO] running `"docker" "rm" "-f" "5addf620b3a524a5f699e8897047e7edaf3a1905126673c7891c7593bf7ec45f"` [INFO] [stdout] 5addf620b3a524a5f699e8897047e7edaf3a1905126673c7891c7593bf7ec45f