[INFO] crate mung 0.1.0 is already in cache
[INFO] extracting crate mung 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/mung/0.1.0
[INFO] extracting crate mung 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mung/0.1.0
[INFO] validating manifest of mung-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mung-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mung-0.1.0
[INFO] finished frobbing mung-0.1.0
[INFO] frobbed toml for mung-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/mung/0.1.0/Cargo.toml
[INFO] started frobbing mung-0.1.0
[INFO] finished frobbing mung-0.1.0
[INFO] frobbed toml for mung-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mung/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mung-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mung/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f2d8384686bc017754d99fc81c9c011e2d03ce4ad674055507f58367776efad8
[INFO] running `"docker" "start" "-a" "f2d8384686bc017754d99fc81c9c011e2d03ce4ad674055507f58367776efad8"`
[INFO] [stderr]     Checking mung v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/lib.rs:315:61
[INFO] [stderr]     |
[INFO] [stderr] 315 |         static ref NEED_TO_DECODE_UNDERSCORE: Regex = Regex::new( r"_" ).unwrap( );
[INFO] [stderr]     |                                                                   ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:347:66
[INFO] [stderr]     |
[INFO] [stderr] 347 |         let allo = charsetengine.decode( &allo, DecoderTrap::Replace ).unwrap_or( "�".to_string( ) );
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "�".to_string( ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:376:1
[INFO] [stderr]     |
[INFO] [stderr] 376 | / pub fn decode_rfc1738<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 377 | |
[INFO] [stderr] 378 | |     lazy_static! {
[INFO] [stderr] 379 | |         static ref HAS_TRIPLETS: Regex = Regex::new( r"%[a-zA-Z0-9][a-zA-Z0-9]" ).unwrap( );
[INFO] [stderr] ...   |
[INFO] [stderr] 402 | |     }
[INFO] [stderr] 403 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:396:66
[INFO] [stderr]     |
[INFO] [stderr] 396 |         let allo = charsetengine.decode( &allo, DecoderTrap::Replace ).unwrap_or( "�".to_string( ) );
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "�".to_string( ))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:431:1
[INFO] [stderr]     |
[INFO] [stderr] 431 | / pub fn decode_rfc2047<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 432 | |
[INFO] [stderr] 433 | |     lazy_static! {
[INFO] [stderr] 434 | |         static ref ENCODED_WORD: Regex = Regex::new( r"=\?(?P<charset>[^\?]*)\?(?P<encoding>[^\?]*)\?(?P<text>[^\?]*)\?=" ).unwrap( );
[INFO] [stderr] ...   |
[INFO] [stderr] 481 | |     }
[INFO] [stderr] 482 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:453:15
[INFO] [stderr]     |
[INFO] [stderr] 453 |                             return format!( "{}", encoded );
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `encoded.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:460:7
[INFO] [stderr]     |
[INFO] [stderr] 460 |                         format!( "{}", data )
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `data.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:464:7
[INFO] [stderr]     |
[INFO] [stderr] 464 |                         format!( "{}", replacement )
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `replacement.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:472:6
[INFO] [stderr]     |
[INFO] [stderr] 472 |                     format!( "{}", encoded )
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `encoded.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:505:1
[INFO] [stderr]     |
[INFO] [stderr] 505 | / pub fn decode_entities<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 506 | |
[INFO] [stderr] 507 | |     // &amp;amp; aren’t the only recursive escapes, we have &#38;#38; too
[INFO] [stderr] 508 | |     lazy_static! {
[INFO] [stderr] ...   |
[INFO] [stderr] 552 | |     }
[INFO] [stderr] 553 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:531:25
[INFO] [stderr]     |
[INFO] [stderr] 531 |                         Some( entity ) => format!( "{}", entity ),
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `entity.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]    --> src/lib.rs:315:61
[INFO] [stderr]     |
[INFO] [stderr] 315 |         static ref NEED_TO_DECODE_UNDERSCORE: Regex = Regex::new( r"_" ).unwrap( );
[INFO] [stderr]     |                                                                   ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]     = help: consider using `str::contains`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:347:66
[INFO] [stderr]     |
[INFO] [stderr] 347 |         let allo = charsetengine.decode( &allo, DecoderTrap::Replace ).unwrap_or( "�".to_string( ) );
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "�".to_string( ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:376:1
[INFO] [stderr]     |
[INFO] [stderr] 376 | / pub fn decode_rfc1738<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 377 | |
[INFO] [stderr] 378 | |     lazy_static! {
[INFO] [stderr] 379 | |         static ref HAS_TRIPLETS: Regex = Regex::new( r"%[a-zA-Z0-9][a-zA-Z0-9]" ).unwrap( );
[INFO] [stderr] ...   |
[INFO] [stderr] 402 | |     }
[INFO] [stderr] 403 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:396:66
[INFO] [stderr]     |
[INFO] [stderr] 396 |         let allo = charsetengine.decode( &allo, DecoderTrap::Replace ).unwrap_or( "�".to_string( ) );
[INFO] [stderr]     |                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "�".to_string( ))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:431:1
[INFO] [stderr]     |
[INFO] [stderr] 431 | / pub fn decode_rfc2047<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 432 | |
[INFO] [stderr] 433 | |     lazy_static! {
[INFO] [stderr] 434 | |         static ref ENCODED_WORD: Regex = Regex::new( r"=\?(?P<charset>[^\?]*)\?(?P<encoding>[^\?]*)\?(?P<text>[^\?]*)\?=" ).unwrap( );
[INFO] [stderr] ...   |
[INFO] [stderr] 481 | |     }
[INFO] [stderr] 482 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:453:15
[INFO] [stderr]     |
[INFO] [stderr] 453 |                             return format!( "{}", encoded );
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `encoded.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:460:7
[INFO] [stderr]     |
[INFO] [stderr] 460 |                         format!( "{}", data )
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `data.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:464:7
[INFO] [stderr]     |
[INFO] [stderr] 464 |                         format!( "{}", replacement )
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `replacement.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:472:6
[INFO] [stderr]     |
[INFO] [stderr] 472 |                     format!( "{}", encoded )
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `encoded.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:505:1
[INFO] [stderr]     |
[INFO] [stderr] 505 | / pub fn decode_entities<'a>( s: &'a str ) -> Cow<'a, str> {
[INFO] [stderr] 506 | |
[INFO] [stderr] 507 | |     // &amp;amp; aren’t the only recursive escapes, we have &#38;#38; too
[INFO] [stderr] 508 | |     lazy_static! {
[INFO] [stderr] ...   |
[INFO] [stderr] 552 | |     }
[INFO] [stderr] 553 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:531:25
[INFO] [stderr]     |
[INFO] [stderr] 531 |                         Some( entity ) => format!( "{}", entity ),
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `entity.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.38s
[INFO] running `"docker" "inspect" "f2d8384686bc017754d99fc81c9c011e2d03ce4ad674055507f58367776efad8"`
[INFO] running `"docker" "rm" "-f" "f2d8384686bc017754d99fc81c9c011e2d03ce4ad674055507f58367776efad8"`
[INFO] [stdout] f2d8384686bc017754d99fc81c9c011e2d03ce4ad674055507f58367776efad8