[INFO] crate multiwii_serial_protocol 0.1.1 is already in cache
[INFO] extracting crate multiwii_serial_protocol 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/multiwii_serial_protocol/0.1.1
[INFO] extracting crate multiwii_serial_protocol 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multiwii_serial_protocol/0.1.1
[INFO] validating manifest of multiwii_serial_protocol-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of multiwii_serial_protocol-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing multiwii_serial_protocol-0.1.1
[INFO] finished frobbing multiwii_serial_protocol-0.1.1
[INFO] frobbed toml for multiwii_serial_protocol-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/multiwii_serial_protocol/0.1.1/Cargo.toml
[INFO] started frobbing multiwii_serial_protocol-0.1.1
[INFO] finished frobbing multiwii_serial_protocol-0.1.1
[INFO] frobbed toml for multiwii_serial_protocol-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multiwii_serial_protocol/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting multiwii_serial_protocol-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/multiwii_serial_protocol/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 58a84476e2d3c4676afc2a60f3e80eb3ff65f4cc061486676c9c1d4508ee00f2
[INFO] running `"docker" "start" "-a" "58a84476e2d3c4676afc2a60f3e80eb3ff65f4cc061486676c9c1d4508ee00f2"`
[INFO] [stderr]    Compiling packed_struct v0.2.3
[INFO] [stderr]    Compiling packed_struct_codegen v0.2.4
[INFO] [stderr]     Checking multiwii_serial_protocol v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/packet.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn to_byte(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `packet::MspParser`
[INFO] [stderr]   --> src/packet.rs:70:2
[INFO] [stderr]    |
[INFO] [stderr] 70 |       pub fn new() -> MspParser {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 71 | |         MspParser {
[INFO] [stderr] 72 | |             state: MspParserState::Header1,
[INFO] [stderr] 73 | |             packet_direction: MspPacketDirection::ToFlightController,
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |         }
[INFO] [stderr] 79 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 68 | impl Default for packet::MspParser {
[INFO] [stderr] 69 |     fn default() -> Self {
[INFO] [stderr] 70 |         Self::new()
[INFO] [stderr] 71 |     }
[INFO] [stderr] 72 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/packet.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 if input == ('$' as u8) {
[INFO] [stderr]    |                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'$'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/packet.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 if input == ('M' as u8) {
[INFO] [stderr]    |                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'M'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:206:15
[INFO] [stderr]     |
[INFO] [stderr] 206 |         output[0] = '$' as u8;
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'$'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:207:15
[INFO] [stderr]     |
[INFO] [stderr] 207 |         output[1] = 'M' as u8;
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:239:18
[INFO] [stderr]     |
[INFO] [stderr] 239 |     let expected = ['$' as u8, 'M' as u8, '<' as u8, 2, 2, 0xbe, 0xef, 81];
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'$'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:239:29
[INFO] [stderr]     |
[INFO] [stderr] 239 |     let expected = ['$' as u8, 'M' as u8, '<' as u8, 2, 2, 0xbe, 0xef, 81];
[INFO] [stderr]     |                                ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:239:40
[INFO] [stderr]     |
[INFO] [stderr] 239 |     let expected = ['$' as u8, 'M' as u8, '<' as u8, 2, 2, 0xbe, 0xef, 81];
[INFO] [stderr]     |                                           ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'<'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `0xBE`
[INFO] [stderr]    --> src/packet.rs:242:12
[INFO] [stderr]     |
[INFO] [stderr] 242 |     let crc = 2 ^ 2 ^ 0xBE ^ 0xEF;
[INFO] [stderr]     |               ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `^`
[INFO] [stderr]    --> src/packet.rs:242:12
[INFO] [stderr]     |
[INFO] [stderr] 242 |     let crc = 2 ^ 2 ^ 0xBE ^ 0xEF;
[INFO] [stderr]     |               ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/packet.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn to_byte(&self) -> u8 {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `packet::MspParser`
[INFO] [stderr]   --> src/packet.rs:70:2
[INFO] [stderr]    |
[INFO] [stderr] 70 |       pub fn new() -> MspParser {
[INFO] [stderr]    |  _____^
[INFO] [stderr] 71 | |         MspParser {
[INFO] [stderr] 72 | |             state: MspParserState::Header1,
[INFO] [stderr] 73 | |             packet_direction: MspPacketDirection::ToFlightController,
[INFO] [stderr] ...  |
[INFO] [stderr] 78 | |         }
[INFO] [stderr] 79 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 68 | impl Default for packet::MspParser {
[INFO] [stderr] 69 |     fn default() -> Self {
[INFO] [stderr] 70 |         Self::new()
[INFO] [stderr] 71 |     }
[INFO] [stderr] 72 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/packet.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 if input == ('$' as u8) {
[INFO] [stderr]    |                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'$'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/packet.rs:99:17
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 if input == ('M' as u8) {
[INFO] [stderr]    |                             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'M'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:206:15
[INFO] [stderr]     |
[INFO] [stderr] 206 |         output[0] = '$' as u8;
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'$'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/packet.rs:207:15
[INFO] [stderr]     |
[INFO] [stderr] 207 |         output[1] = 'M' as u8;
[INFO] [stderr]     |                     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'M'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `multiwii_serial_protocol`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "58a84476e2d3c4676afc2a60f3e80eb3ff65f4cc061486676c9c1d4508ee00f2"`
[INFO] running `"docker" "rm" "-f" "58a84476e2d3c4676afc2a60f3e80eb3ff65f4cc061486676c9c1d4508ee00f2"`
[INFO] [stdout] 58a84476e2d3c4676afc2a60f3e80eb3ff65f4cc061486676c9c1d4508ee00f2