[INFO] crate multistr 0.5.4 is already in cache [INFO] extracting crate multistr 0.5.4 into work/ex/clippy-test-run/sources/stable/reg/multistr/0.5.4 [INFO] extracting crate multistr 0.5.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multistr/0.5.4 [INFO] validating manifest of multistr-0.5.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of multistr-0.5.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing multistr-0.5.4 [INFO] finished frobbing multistr-0.5.4 [INFO] frobbed toml for multistr-0.5.4 written to work/ex/clippy-test-run/sources/stable/reg/multistr/0.5.4/Cargo.toml [INFO] started frobbing multistr-0.5.4 [INFO] finished frobbing multistr-0.5.4 [INFO] frobbed toml for multistr-0.5.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multistr/0.5.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting multistr-0.5.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/multistr/0.5.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 306db308ed8b3c9b47e7f71bdd275263ae968bb3dcf5d93419cc2ac4dc6ee0a2 [INFO] running `"docker" "start" "-a" "306db308ed8b3c9b47e7f71bdd275263ae968bb3dcf5d93419cc2ac4dc6ee0a2"` [INFO] [stderr] Checking extra-default v0.2.0 [INFO] [stderr] Checking len-trait v0.6.1 [INFO] [stderr] Checking bow v1.0.3 [INFO] [stderr] Checking push-trait v0.6.0 [INFO] [stderr] Checking multistr v0.5.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | Split { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | Split { inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/split.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/strlike.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(self as *mut str as *mut [u8])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> src/strlike.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | Ok(unsafe { mem::transmute(data) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(data).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_bytes_to_str)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> src/strlike.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | mem::transmute(data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(data).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/vec.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | / if self.split.pop().is_none() { [INFO] [stderr] 237 | | return None; [INFO] [stderr] 238 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.split.pop()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `multistr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "306db308ed8b3c9b47e7f71bdd275263ae968bb3dcf5d93419cc2ac4dc6ee0a2"` [INFO] running `"docker" "rm" "-f" "306db308ed8b3c9b47e7f71bdd275263ae968bb3dcf5d93419cc2ac4dc6ee0a2"` [INFO] [stdout] 306db308ed8b3c9b47e7f71bdd275263ae968bb3dcf5d93419cc2ac4dc6ee0a2