[INFO] crate multipart-nickel 0.3.1 is already in cache [INFO] extracting crate multipart-nickel 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/multipart-nickel/0.3.1 [INFO] extracting crate multipart-nickel 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multipart-nickel/0.3.1 [INFO] validating manifest of multipart-nickel-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of multipart-nickel-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing multipart-nickel-0.3.1 [INFO] finished frobbing multipart-nickel-0.3.1 [INFO] frobbed toml for multipart-nickel-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/multipart-nickel/0.3.1/Cargo.toml [INFO] started frobbing multipart-nickel-0.3.1 [INFO] finished frobbing multipart-nickel-0.3.1 [INFO] frobbed toml for multipart-nickel-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multipart-nickel/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting multipart-nickel-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/multipart-nickel/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1119ea731b0d2490cdfe49ea886d2b395badfbc71775761e8f88db18005ed817 [INFO] running `"docker" "start" "-a" "1119ea731b0d2490cdfe49ea886d2b395badfbc71775761e8f88db18005ed817"` [INFO] [stderr] Checking nickel v0.10.2 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking multipart-nickel v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/nickel.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | return process_entries(res, entries.keep_partial()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `process_entries(res, entries.keep_partial())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/nickel.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | return res.send(format!("Server could not handle multipart POST! {:?}", e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.send(format!("Server could not handle multipart POST! {:?}", e))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/nickel.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | return res.send("Request seems not was a multipart request") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `res.send("Request seems not was a multipart request")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/nickel.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | / fn process_entries<'mw>(res: Response<'mw>, entries: Entries) -> MiddlewareResult<'mw> { [INFO] [stderr] 39 | | for (name, field) in entries.fields { [INFO] [stderr] 40 | | println!("Field {:?}: {:?}", name, field); [INFO] [stderr] 41 | | } [INFO] [stderr] ... | [INFO] [stderr] 67 | | res.send("Ok") [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.87s [INFO] running `"docker" "inspect" "1119ea731b0d2490cdfe49ea886d2b395badfbc71775761e8f88db18005ed817"` [INFO] running `"docker" "rm" "-f" "1119ea731b0d2490cdfe49ea886d2b395badfbc71775761e8f88db18005ed817"` [INFO] [stdout] 1119ea731b0d2490cdfe49ea886d2b395badfbc71775761e8f88db18005ed817