[INFO] crate multipart-async 0.0.2 is already in cache [INFO] extracting crate multipart-async 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/multipart-async/0.0.2 [INFO] extracting crate multipart-async 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multipart-async/0.0.2 [INFO] validating manifest of multipart-async-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of multipart-async-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing multipart-async-0.0.2 [INFO] finished frobbing multipart-async-0.0.2 [INFO] frobbed toml for multipart-async-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/multipart-async/0.0.2/Cargo.toml [INFO] started frobbing multipart-async-0.0.2 [INFO] finished frobbing multipart-async-0.0.2 [INFO] frobbed toml for multipart-async-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/multipart-async/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting multipart-async-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/multipart-async/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4d7d21687ddda884ea936b63bbc3b88ed58fa0b9e3de4b8b17c14d8a4baf21c3 [INFO] running `"docker" "start" "-a" "4d7d21687ddda884ea936b63bbc3b88ed58fa0b9e3de4b8b17c14d8a4baf21c3"` [INFO] [stderr] Checking display_bytes v0.1.0 [INFO] [stderr] Checking multipart-async v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:434:9 [INFO] [stderr] | [INFO] [stderr] 434 | incl_crlf: incl_crlf [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incl_crlf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:495:17 [INFO] [stderr] | [INFO] [stderr] 495 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | idx: idx, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:434:9 [INFO] [stderr] | [INFO] [stderr] 434 | incl_crlf: incl_crlf [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `incl_crlf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/boundary.rs:495:17 [INFO] [stderr] | [INFO] [stderr] 495 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mime::Mime` [INFO] [stderr] --> src/server/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use mime::Mime; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tempdir::TempDir` [INFO] [stderr] --> src/server/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use tempdir::TempDir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Borrow` [INFO] [stderr] --> src/server/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::borrow::Borrow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::VecDeque` [INFO] [stderr] --> src/server/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use std::collections::VecDeque; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `File`, `self` [INFO] [stderr] --> src/server/mod.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | use std::fs::{self, File}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/server/mod.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `fmt`, `mem`, `ptr` [INFO] [stderr] --> src/server/mod.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | use std::{fmt, io, mem, ptr}; [INFO] [stderr] | ^^^ ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/server/boundary.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Borrow`, `Cow` [INFO] [stderr] --> src/server/boundary.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | use std::borrow::{Borrow, Cow}; [INFO] [stderr] | ^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/server/boundary.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/server/boundary.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Async`, `Future` [INFO] [stderr] --> src/server/field/mod.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::{Future, Stream, Async, Poll}; [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Async::*` [INFO] [stderr] --> src/server/field/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use futures::Async::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Mime`, `self` [INFO] [stderr] --> src/server/field/mod.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | use mime::{self, Mime}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `io`, `mem`, `str` [INFO] [stderr] --> src/server/field/mod.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | use std::{io, mem, str}; [INFO] [stderr] | ^^ ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `helpers::*` [INFO] [stderr] --> src/server/field/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use helpers::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::httparse::EMPTY_HEADER` [INFO] [stderr] --> src/server/field/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use self::httparse::EMPTY_HEADER; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Async::*` [INFO] [stderr] --> src/server/field/collect.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::Async::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `server::boundary::BoundaryFinder` [INFO] [stderr] --> src/server/field/collect.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use server::boundary::BoundaryFinder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Internal` [INFO] [stderr] --> src/server/field/collect.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | use server::{Internal, BodyChunk, StreamError}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/field/collect.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Poll` [INFO] [stderr] --> src/server/field/headers.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use futures::{Poll, Stream}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `io` [INFO] [stderr] --> src/server/field/headers.rs:5:11 [INFO] [stderr] | [INFO] [stderr] 5 | use std::{io, str}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Multipart` [INFO] [stderr] --> src/server/field/headers.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use server::{Multipart, BodyChunk, StreamError, httparse, twoway}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stream` [INFO] [stderr] --> src/helpers.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::{Async, Stream}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/helpers.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/helpers.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::Arc` [INFO] [stderr] --> src/lib.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | use std::sync::Arc; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `mime::Mime` [INFO] [stderr] --> src/server/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | use mime::Mime; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `tempdir::TempDir` [INFO] [stderr] --> src/server/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | use tempdir::TempDir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::borrow::Borrow` [INFO] [stderr] --> src/server/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | use std::borrow::Borrow; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::VecDeque` [INFO] [stderr] --> src/server/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use std::collections::VecDeque; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `File`, `self` [INFO] [stderr] --> src/server/mod.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | use std::fs::{self, File}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `PathBuf`, `Path` [INFO] [stderr] --> src/server/mod.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | use std::path::{Path, PathBuf}; [INFO] [stderr] | ^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `fmt`, `mem`, `ptr` [INFO] [stderr] --> src/server/mod.rs:32:11 [INFO] [stderr] | [INFO] [stderr] 32 | use std::{fmt, io, mem, ptr}; [INFO] [stderr] | ^^^ ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/server/boundary.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Borrow`, `Cow` [INFO] [stderr] --> src/server/boundary.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | use std::borrow::{Borrow, Cow}; [INFO] [stderr] | ^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/server/boundary.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/server/boundary.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/server/boundary.rs:479:9 [INFO] [stderr] | [INFO] [stderr] 479 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/server/boundary.rs:481:9 [INFO] [stderr] | [INFO] [stderr] 481 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server/boundary.rs:483:22 [INFO] [stderr] | [INFO] [stderr] 483 | const BOUNDARY: &'static str = "--boundary"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Async`, `Future` [INFO] [stderr] --> src/server/field/mod.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::{Future, Stream, Async, Poll}; [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Async::*` [INFO] [stderr] --> src/server/field/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use futures::Async::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Mime`, `self` [INFO] [stderr] --> src/server/field/mod.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | use mime::{self, Mime}; [INFO] [stderr] | ^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `io`, `mem`, `str` [INFO] [stderr] --> src/server/field/mod.rs:13:11 [INFO] [stderr] | [INFO] [stderr] 13 | use std::{io, mem, str}; [INFO] [stderr] | ^^ ^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `helpers::*` [INFO] [stderr] --> src/server/field/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use helpers::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::httparse::EMPTY_HEADER` [INFO] [stderr] --> src/server/field/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | use self::httparse::EMPTY_HEADER; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::Async::*` [INFO] [stderr] --> src/server/field/collect.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use futures::Async::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `server::boundary::BoundaryFinder` [INFO] [stderr] --> src/server/field/collect.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use server::boundary::BoundaryFinder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Internal` [INFO] [stderr] --> src/server/field/collect.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | use server::{Internal, BodyChunk, StreamError}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server/field/collect.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | return UTF8_CHAR_WIDTH[b as usize] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTF8_CHAR_WIDTH[b as usize] as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Poll` [INFO] [stderr] --> src/server/field/headers.rs:1:15 [INFO] [stderr] | [INFO] [stderr] 1 | use futures::{Poll, Stream}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `io` [INFO] [stderr] --> src/server/field/headers.rs:5:11 [INFO] [stderr] | [INFO] [stderr] 5 | use std::{io, str}; [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Multipart` [INFO] [stderr] --> src/server/field/headers.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | use server::{Multipart, BodyChunk, StreamError, httparse, twoway}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Stream` [INFO] [stderr] --> src/helpers.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::{Async, Stream}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/helpers.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/helpers.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/server/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Write` [INFO] [stderr] --> src/server/boundary.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | use std::fmt::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/server/boundary.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | let len = boundary.len(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/server/mod.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Write` [INFO] [stderr] --> src/server/boundary.rs:395:13 [INFO] [stderr] | [INFO] [stderr] 395 | use std::fmt::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Future` [INFO] [stderr] --> src/server/boundary.rs:476:19 [INFO] [stderr] | [INFO] [stderr] 476 | use futures::{Future, Stream, Poll}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/server/boundary.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | let len = boundary.len(); [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server/field/collect.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | let mut stream = data.stream_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `maybe_boundary` [INFO] [stderr] --> src/server/boundary.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | fn maybe_boundary(&self, bytes: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `check_boundary` [INFO] [stderr] --> src/server/boundary.rs:266:5 [INFO] [stderr] | [INFO] [stderr] 266 | fn check_boundary(&self, bytes: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `consume_boundary` [INFO] [stderr] --> src/server/boundary.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | pub fn consume_boundary(&mut self) -> Poll { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `confirm_boundary` [INFO] [stderr] --> src/server/boundary.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | fn confirm_boundary(&mut self, boundary: S::Item) -> Poll { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `confirm_boundary_split` [INFO] [stderr] --> src/server/boundary.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | fn confirm_boundary_split(&mut self, first: S::Item, second: S::Item) -> Poll { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `End` [INFO] [stderr] --> src/server/boundary.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | End, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `check_last_two` [INFO] [stderr] --> src/server/boundary.rs:438:1 [INFO] [stderr] | [INFO] [stderr] 438 | fn check_last_two(boundary: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_alphanumeric` [INFO] [stderr] --> src/lib.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn random_alphanumeric(len: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/server/boundary.rs:245:31 [INFO] [stderr] | [INFO] [stderr] 245 | if len > 2 && &chunk[len - 2 ..] == &*b"\r\n" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 245 | if len > 2 && chunk[len - 2 ..] == *b"\r\n" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/server/field/collect.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | let mut stream = data.stream_mut(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `maybe_boundary` [INFO] [stderr] --> src/server/boundary.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | fn maybe_boundary(&self, bytes: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_alphanumeric` [INFO] [stderr] --> src/lib.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn random_alphanumeric(len: usize) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | self.waiting_task.take().map(|t| t.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.waiting_task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/server/boundary.rs:245:31 [INFO] [stderr] | [INFO] [stderr] 245 | if len > 2 && &chunk[len - 2 ..] == &*b"\r\n" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 245 | if len > 2 && chunk[len - 2 ..] == *b"\r\n" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/boundary.rs:547:17 [INFO] [stderr] | [INFO] [stderr] 547 | / match finder.poll().expect("Error from stream") { [INFO] [stderr] 548 | | Ready(item) => break item, [INFO] [stderr] 549 | | _ => (), [INFO] [stderr] 550 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Ready(item) = finder.poll().expect("Error from stream") { break item }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server/boundary.rs:578:13 [INFO] [stderr] | [INFO] [stderr] 578 | / match finder.consume_boundary().expect("Error from BoundaryFinder") { [INFO] [stderr] 579 | | Ready(val) => { [INFO] [stderr] 580 | | assert_eq!(val, is_end, "Found wrong kind of boundary"); [INFO] [stderr] 581 | | break; [INFO] [stderr] 582 | | }, [INFO] [stderr] 583 | | _ => (), [INFO] [stderr] 584 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 578 | if let Ready(val) = finder.consume_boundary().expect("Error from BoundaryFinder") { [INFO] [stderr] 579 | assert_eq!(val, is_end, "Found wrong kind of boundary"); [INFO] [stderr] 580 | break; [INFO] [stderr] 581 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/server/mod.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | self.waiting_task.take().map(|t| t.notify()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(t) = self.waiting_task.take() { t.notify() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.98s [INFO] running `"docker" "inspect" "4d7d21687ddda884ea936b63bbc3b88ed58fa0b9e3de4b8b17c14d8a4baf21c3"` [INFO] running `"docker" "rm" "-f" "4d7d21687ddda884ea936b63bbc3b88ed58fa0b9e3de4b8b17c14d8a4baf21c3"` [INFO] [stdout] 4d7d21687ddda884ea936b63bbc3b88ed58fa0b9e3de4b8b17c14d8a4baf21c3