[INFO] crate muff 0.1.4 is already in cache [INFO] extracting crate muff 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/muff/0.1.4 [INFO] extracting crate muff 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/muff/0.1.4 [INFO] validating manifest of muff-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of muff-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing muff-0.1.4 [INFO] finished frobbing muff-0.1.4 [INFO] frobbed toml for muff-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/muff/0.1.4/Cargo.toml [INFO] started frobbing muff-0.1.4 [INFO] finished frobbing muff-0.1.4 [INFO] frobbed toml for muff-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/muff/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting muff-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/muff/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6acbf6100d0efce7999eb2884cb3192a892554c0d9eb95eae9dffb449d76aa91 [INFO] running `"docker" "start" "-a" "6acbf6100d0efce7999eb2884cb3192a892554c0d9eb95eae9dffb449d76aa91"` [INFO] [stderr] Checking muff v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 127 | | if let Some(disks) = matches.values_of("DISKS") { [INFO] [stderr] 128 | | for arg in disks { [INFO] [stderr] 129 | | disk_args.push(arg.to_string()); [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 126 | } else if let Some(disks) = matches.values_of("DISKS") { [INFO] [stderr] 127 | for arg in disks { [INFO] [stderr] 128 | disk_args.push(arg.to_string()); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 127 | | if let Some(disks) = matches.values_of("DISKS") { [INFO] [stderr] 128 | | for arg in disks { [INFO] [stderr] 129 | | disk_args.push(arg.to_string()); [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 126 | } else if let Some(disks) = matches.values_of("DISKS") { [INFO] [stderr] 127 | for arg in disks { [INFO] [stderr] 128 | disk_args.push(arg.to_string()); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let source = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing source"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing source"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | let dest = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing dest"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing dest"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | let fs = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing fs"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing fs"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | let options = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing options"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing options"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | let dump = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing dump"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing dump"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let pass = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing pass"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing pass"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | return Err(format!( [INFO] [stderr] | ____________________^ [INFO] [stderr] 136 | | "no disks specified" [INFO] [stderr] 137 | | )); [INFO] [stderr] | |_________^ help: consider using .to_string(): `"no disks specified".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | for ref disk_tuple in disks.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ------------ help: try: `let disk_tuple = &disks.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | return Err(format!( [INFO] [stderr] | ________________________^ [INFO] [stderr] 270 | | "exiting without flashing" [INFO] [stderr] 271 | | )); [INFO] [stderr] | |_____________^ help: consider using .to_string(): `"exiting without flashing".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | writeln!(io::stderr(), "muff: {}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | let source = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing source"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing source"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | let dest = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing dest"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing dest"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:51:31 [INFO] [stderr] | [INFO] [stderr] 51 | let fs = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing fs"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing fs"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | let options = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing options"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing options"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | let dump = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing dump"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing dump"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/mount.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let pass = parts.next().ok_or(Error::new(ErrorKind::Other, "Missing pass"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new(ErrorKind::Other, "Missing pass"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | return Err(format!( [INFO] [stderr] | ____________________^ [INFO] [stderr] 136 | | "no disks specified" [INFO] [stderr] 137 | | )); [INFO] [stderr] | |_________^ help: consider using .to_string(): `"no disks specified".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:258:13 [INFO] [stderr] | [INFO] [stderr] 258 | for ref disk_tuple in disks.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ------------ help: try: `let disk_tuple = &disks.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:269:24 [INFO] [stderr] | [INFO] [stderr] 269 | return Err(format!( [INFO] [stderr] | ________________________^ [INFO] [stderr] 270 | | "exiting without flashing" [INFO] [stderr] 271 | | )); [INFO] [stderr] | |_____________^ help: consider using .to_string(): `"exiting without flashing".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | writeln!(io::stderr(), "muff: {}", err).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "6acbf6100d0efce7999eb2884cb3192a892554c0d9eb95eae9dffb449d76aa91"` [INFO] running `"docker" "rm" "-f" "6acbf6100d0efce7999eb2884cb3192a892554c0d9eb95eae9dffb449d76aa91"` [INFO] [stdout] 6acbf6100d0efce7999eb2884cb3192a892554c0d9eb95eae9dffb449d76aa91