[INFO] crate mtree 0.4.3 is already in cache [INFO] extracting crate mtree 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/mtree/0.4.3 [INFO] extracting crate mtree 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mtree/0.4.3 [INFO] validating manifest of mtree-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mtree-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mtree-0.4.3 [INFO] finished frobbing mtree-0.4.3 [INFO] frobbed toml for mtree-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/mtree/0.4.3/Cargo.toml [INFO] started frobbing mtree-0.4.3 [INFO] finished frobbing mtree-0.4.3 [INFO] frobbed toml for mtree-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mtree/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mtree-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mtree/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83e602eb9c7a78f3dc4985d2364d531081e85bea87374e9deee1c9ecb582e827 [INFO] running `"docker" "start" "-a" "83e602eb9c7a78f3dc4985d2364d531081e85bea87374e9deee1c9ecb582e827"` [INFO] [stderr] Checking newtype_array v0.1.6 [INFO] [stderr] Checking mtree v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:393:15 [INFO] [stderr] | [INFO] [stderr] 393 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u16::from(val)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_FromDec_uint!(u16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u32::from(val)` [INFO] [stderr] ... [INFO] [stderr] 49 | impl_FromDec_uint!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 50 | impl_FromDec_uint!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | acc = acc * 16 + val as u128; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/util.rs:209:1 [INFO] [stderr] | [INFO] [stderr] 209 | newtype_array!(pub struct Array48(48)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/util.rs:210:1 [INFO] [stderr] | [INFO] [stderr] 210 | newtype_array!(pub struct Array64(64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | cwd: env::current_dir().unwrap_or(PathBuf::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::current_dir().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser.rs:330:25 [INFO] [stderr] | [INFO] [stderr] 330 | for (input, res) in vec![ [INFO] [stderr] | _________________________^ [INFO] [stderr] 331 | | (&b"native"[..], Format::Native), [INFO] [stderr] 332 | | (&b"386bsd"[..], Format::Bsd386), [INFO] [stderr] 333 | | (&b"4bsd"[..], Format::Bsd4), [INFO] [stderr] ... | [INFO] [stderr] 346 | | (&b"ultrix"[..], Format::Ultrix), [INFO] [stderr] 347 | | ] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:393:15 [INFO] [stderr] | [INFO] [stderr] 393 | fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/parser.rs:414:25 [INFO] [stderr] | [INFO] [stderr] 414 | for (input, res) in vec![ [INFO] [stderr] | _________________________^ [INFO] [stderr] 415 | | (&b"block"[..], FileType::BlockDevice), [INFO] [stderr] 416 | | (&b"char"[..], FileType::CharacterDevice), [INFO] [stderr] 417 | | (&b"dir"[..], FileType::Directory), [INFO] [stderr] ... | [INFO] [stderr] 421 | | (&b"socket"[..], FileType::Socket), [INFO] [stderr] 422 | | ] { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/lib.rs:472:5 [INFO] [stderr] | [INFO] [stderr] 472 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 473 | | if let Some(v) = self.checksum { [INFO] [stderr] 474 | | writeln!(f, "checksum: {}", v)?; [INFO] [stderr] 475 | | } [INFO] [stderr] ... | [INFO] [stderr] 572 | | Ok(()) [INFO] [stderr] 573 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u16::from(val)` [INFO] [stderr] ... [INFO] [stderr] 48 | impl_FromDec_uint!(u16); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u32::from(val)` [INFO] [stderr] ... [INFO] [stderr] 49 | impl_FromDec_uint!(u32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | })?.checked_add(val as $from) [INFO] [stderr] | ^^^ help: try: `u64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 50 | impl_FromDec_uint!(u64); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | acc = acc * 16 + val as u128; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/util.rs:209:1 [INFO] [stderr] | [INFO] [stderr] 209 | newtype_array!(pub struct Array48(48)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/util.rs:210:1 [INFO] [stderr] | [INFO] [stderr] 210 | newtype_array!(pub struct Array64(64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | cwd: env::current_dir().unwrap_or(PathBuf::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::current_dir().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/lib.rs:472:5 [INFO] [stderr] | [INFO] [stderr] 472 | / fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 473 | | if let Some(v) = self.checksum { [INFO] [stderr] 474 | | writeln!(f, "checksum: {}", v)?; [INFO] [stderr] 475 | | } [INFO] [stderr] ... | [INFO] [stderr] 572 | | Ok(()) [INFO] [stderr] 573 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.60s [INFO] running `"docker" "inspect" "83e602eb9c7a78f3dc4985d2364d531081e85bea87374e9deee1c9ecb582e827"` [INFO] running `"docker" "rm" "-f" "83e602eb9c7a78f3dc4985d2364d531081e85bea87374e9deee1c9ecb582e827"` [INFO] [stdout] 83e602eb9c7a78f3dc4985d2364d531081e85bea87374e9deee1c9ecb582e827