[INFO] crate mss_saliency 1.0.3 is already in cache [INFO] extracting crate mss_saliency 1.0.3 into work/ex/clippy-test-run/sources/stable/reg/mss_saliency/1.0.3 [INFO] extracting crate mss_saliency 1.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mss_saliency/1.0.3 [INFO] validating manifest of mss_saliency-1.0.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mss_saliency-1.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mss_saliency-1.0.3 [INFO] finished frobbing mss_saliency-1.0.3 [INFO] frobbed toml for mss_saliency-1.0.3 written to work/ex/clippy-test-run/sources/stable/reg/mss_saliency/1.0.3/Cargo.toml [INFO] started frobbing mss_saliency-1.0.3 [INFO] finished frobbing mss_saliency-1.0.3 [INFO] frobbed toml for mss_saliency-1.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/mss_saliency/1.0.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mss_saliency-1.0.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/mss_saliency/1.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3cd166e1073dbc2783daaee815856151dd37e4c337012d459a3a86147e33da79 [INFO] running `"docker" "start" "-a" "3cd166e1073dbc2783daaee815856151dd37e4c337012d459a3a86147e33da79"` [INFO] [stderr] Checking rgb v0.8.12 [INFO] [stderr] Checking imgref v1.3.5 [INFO] [stderr] Checking mss_saliency v1.0.3 (/opt/crater/workdir) [INFO] [stderr] Checking lodepng v2.4.2 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return Img::new(sal_map, width as usize, height as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Img::new(sal_map, width as usize, height as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/integral.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | sum += image[(x - 1, y)] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image[(x - 1, y)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(avg as i16 - image[(x, y)] as i16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(avg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:38 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[(x, y)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return Img::new(sal_map, width as usize, height as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Img::new(sal_map, width as usize, height as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/integral.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | sum += image[(x - 1, y)] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(image[(x - 1, y)])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:24 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(avg as i16 - image[(x, y)] as i16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(avg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:38:38 [INFO] [stderr] | [INFO] [stderr] 38 | let diff = (avg as i16 - image[(x, y)] as i16) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(image[(x, y)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.37s [INFO] running `"docker" "inspect" "3cd166e1073dbc2783daaee815856151dd37e4c337012d459a3a86147e33da79"` [INFO] running `"docker" "rm" "-f" "3cd166e1073dbc2783daaee815856151dd37e4c337012d459a3a86147e33da79"` [INFO] [stdout] 3cd166e1073dbc2783daaee815856151dd37e4c337012d459a3a86147e33da79